* [PATCH v6 1/2] drm/xe: Decouple GuC RC code from xe_guc_pc
2026-01-23 23:50 [PATCH v6 0/2] drm/xe: Separate out GuC RC code Vinay Belgaumkar
@ 2026-01-23 23:50 ` Vinay Belgaumkar
2026-01-27 23:18 ` Michal Wajdeczko
2026-01-23 23:50 ` [PATCH v6 2/2] drm/xe: Add a wrapper for set/unset params Vinay Belgaumkar
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Vinay Belgaumkar @ 2026-01-23 23:50 UTC (permalink / raw)
To: intel-xe; +Cc: Vinay Belgaumkar, Riana Tauro
Move enable/disable GuC RC logic into the new file. This will
allow us to independently enable/disable GuC RC and not rely
on SLPC related functions. GuC already provides separate H2G
interfaces to setup GuC RC and SLPC.
v2: Comments (Michal W), remove duplicate c6_enable calls from
xe_guc_pc.
v3: Clarify crosss interactions between xe_guc_rc and xe_guc_pc
(Michal W)
v4: More comments (Michal W)
v5: Remove rc_init and use enable/disable (Riana)
v6: Link to kernel docs (Riana)
Cc: Riana Tauro <riana.tauro@intel.com>
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
---
Documentation/gpu/xe/xe_firmware.rst | 3 +
drivers/gpu/drm/xe/Makefile | 1 +
drivers/gpu/drm/xe/xe_gt.c | 1 -
drivers/gpu/drm/xe/xe_guc.c | 2 +
drivers/gpu/drm/xe/xe_guc_pc.c | 70 +++-------------
drivers/gpu/drm/xe/xe_guc_pc.h | 1 -
drivers/gpu/drm/xe/xe_guc_rc.c | 114 +++++++++++++++++++++++++++
drivers/gpu/drm/xe/xe_guc_rc.h | 14 ++++
drivers/gpu/drm/xe/xe_uc.c | 10 +--
drivers/gpu/drm/xe/xe_uc.h | 1 -
10 files changed, 152 insertions(+), 65 deletions(-)
create mode 100644 drivers/gpu/drm/xe/xe_guc_rc.c
create mode 100644 drivers/gpu/drm/xe/xe_guc_rc.h
diff --git a/Documentation/gpu/xe/xe_firmware.rst b/Documentation/gpu/xe/xe_firmware.rst
index 5d23e9f27391..9c15a300bc62 100644
--- a/Documentation/gpu/xe/xe_firmware.rst
+++ b/Documentation/gpu/xe/xe_firmware.rst
@@ -31,6 +31,9 @@ GuC Power Conservation (PC)
.. kernel-doc:: drivers/gpu/drm/xe/xe_guc_pc.c
:doc: GuC Power Conservation (PC)
+.. kernel-doc:: drivers/gpu/drm/xe/xe_guc_rc.c
+ :doc: GuC Render C-states (GuC RC)
+
PCIe Gen5 Limitations
=====================
diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
index b39cbb756232..2062602c1bf3 100644
--- a/drivers/gpu/drm/xe/Makefile
+++ b/drivers/gpu/drm/xe/Makefile
@@ -74,6 +74,7 @@ xe-y += xe_bb.o \
xe_guc_log.o \
xe_guc_pagefault.o \
xe_guc_pc.o \
+ xe_guc_rc.o \
xe_guc_submit.o \
xe_guc_tlb_inval.o \
xe_heci_gsc.o \
diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
index 9d090d0f2438..c8a1d44bbf3a 100644
--- a/drivers/gpu/drm/xe/xe_gt.c
+++ b/drivers/gpu/drm/xe/xe_gt.c
@@ -852,7 +852,6 @@ static void gt_reset_worker(struct work_struct *w)
if (IS_SRIOV_PF(gt_to_xe(gt)))
xe_gt_sriov_pf_stop_prepare(gt);
- xe_uc_gucrc_disable(>->uc);
xe_uc_stop_prepare(>->uc);
xe_pagefault_reset(gt_to_xe(gt), gt);
diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
index 44360437beeb..f66b0c987b09 100644
--- a/drivers/gpu/drm/xe/xe_guc.c
+++ b/drivers/gpu/drm/xe/xe_guc.c
@@ -35,6 +35,7 @@
#include "xe_guc_klv_helpers.h"
#include "xe_guc_log.h"
#include "xe_guc_pc.h"
+#include "xe_guc_rc.h"
#include "xe_guc_relay.h"
#include "xe_guc_submit.h"
#include "xe_memirq.h"
@@ -1609,6 +1610,7 @@ void xe_guc_stop_prepare(struct xe_guc *guc)
if (!IS_SRIOV_VF(guc_to_xe(guc))) {
int err;
+ xe_guc_rc_disable(guc);
err = xe_guc_pc_stop(&guc->pc);
xe_gt_WARN(guc_to_gt(guc), err, "Failed to stop GuC PC: %pe\n",
ERR_PTR(err));
diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c
index 54702a0fd05b..cf02c53ca3c5 100644
--- a/drivers/gpu/drm/xe/xe_guc_pc.c
+++ b/drivers/gpu/drm/xe/xe_guc_pc.c
@@ -92,6 +92,17 @@
* Render-C states is also a GuC PC feature that is now enabled in Xe for
* all platforms.
*
+ * Implementation details:
+ * -----------------------
+ * The implementation for GuC Power Management features is split as follows:
+ *
+ * xe_guc_rc: Logic for handling GuC RC
+ * xe_gt_idle: Host side logic for RC6 and Coarse Power gating (CPG)
+ * xe_guc_pc: Logic for all other SLPC related features
+ *
+ * There is some cross interaction between these where host C6 will need to be
+ * enabled when we plan to skip GuC RC. Also, the GuC RC mode is currently
+ * overridden through 0x3003 which is an SLPC H2G call.
*/
static struct xe_guc *pc_to_guc(struct xe_guc_pc *pc)
@@ -253,22 +264,6 @@ static int pc_action_unset_param(struct xe_guc_pc *pc, u8 id)
return ret;
}
-static int pc_action_setup_gucrc(struct xe_guc_pc *pc, u32 mode)
-{
- struct xe_guc_ct *ct = pc_to_ct(pc);
- u32 action[] = {
- GUC_ACTION_HOST2GUC_SETUP_PC_GUCRC,
- mode,
- };
- int ret;
-
- ret = xe_guc_ct_send(ct, action, ARRAY_SIZE(action), 0, 0);
- if (ret && !(xe_device_wedged(pc_to_xe(pc)) && ret == -ECANCELED))
- xe_gt_err(pc_to_gt(pc), "GuC RC enable mode=%u failed: %pe\n",
- mode, ERR_PTR(ret));
- return ret;
-}
-
static u32 decode_freq(u32 raw)
{
return DIV_ROUND_CLOSEST(raw * GT_FREQUENCY_MULTIPLIER,
@@ -1050,30 +1045,6 @@ int xe_guc_pc_restore_stashed_freq(struct xe_guc_pc *pc)
return ret;
}
-/**
- * xe_guc_pc_gucrc_disable - Disable GuC RC
- * @pc: Xe_GuC_PC instance
- *
- * Disables GuC RC by taking control of RC6 back from GuC.
- *
- * Return: 0 on success, negative error code on error.
- */
-int xe_guc_pc_gucrc_disable(struct xe_guc_pc *pc)
-{
- struct xe_device *xe = pc_to_xe(pc);
- struct xe_gt *gt = pc_to_gt(pc);
- int ret = 0;
-
- if (xe->info.skip_guc_pc)
- return 0;
-
- ret = pc_action_setup_gucrc(pc, GUCRC_HOST_CONTROL);
- if (ret)
- return ret;
-
- return xe_gt_idle_disable_c6(gt);
-}
-
/**
* xe_guc_pc_override_gucrc_mode - override GUCRC mode
* @pc: Xe_GuC_PC instance
@@ -1217,9 +1188,6 @@ int xe_guc_pc_start(struct xe_guc_pc *pc)
return -ETIMEDOUT;
if (xe->info.skip_guc_pc) {
- if (xe->info.platform != XE_PVC)
- xe_gt_idle_enable_c6(gt);
-
/* Request max possible since dynamic freq mgmt is not enabled */
pc_set_cur_freq(pc, UINT_MAX);
return 0;
@@ -1257,15 +1225,6 @@ int xe_guc_pc_start(struct xe_guc_pc *pc)
if (ret)
return ret;
- if (xe->info.platform == XE_PVC) {
- xe_guc_pc_gucrc_disable(pc);
- return 0;
- }
-
- ret = pc_action_setup_gucrc(pc, GUCRC_FIRMWARE_CONTROL);
- if (ret)
- return ret;
-
/* Enable SLPC Optimized Strategy for compute */
ret = pc_action_set_strategy(pc, SLPC_OPTIMIZED_STRATEGY_COMPUTE);
@@ -1285,10 +1244,8 @@ int xe_guc_pc_stop(struct xe_guc_pc *pc)
{
struct xe_device *xe = pc_to_xe(pc);
- if (xe->info.skip_guc_pc) {
- xe_gt_idle_disable_c6(pc_to_gt(pc));
+ if (xe->info.skip_guc_pc)
return 0;
- }
mutex_lock(&pc->freq_lock);
pc->freq_ready = false;
@@ -1309,8 +1266,7 @@ static void xe_guc_pc_fini_hw(void *arg)
if (xe_device_wedged(xe))
return;
- CLASS(xe_force_wake, fw_ref)(gt_to_fw(pc_to_gt(pc)), XE_FORCEWAKE_ALL);
- xe_guc_pc_gucrc_disable(pc);
+ CLASS(xe_force_wake, fw_ref)(gt_to_fw(pc_to_gt(pc)), XE_FW_GT);
XE_WARN_ON(xe_guc_pc_stop(pc));
/* Bind requested freq to mert_freq_cap before unload */
diff --git a/drivers/gpu/drm/xe/xe_guc_pc.h b/drivers/gpu/drm/xe/xe_guc_pc.h
index 0e31396f103c..1b95873b262e 100644
--- a/drivers/gpu/drm/xe/xe_guc_pc.h
+++ b/drivers/gpu/drm/xe/xe_guc_pc.h
@@ -15,7 +15,6 @@ struct drm_printer;
int xe_guc_pc_init(struct xe_guc_pc *pc);
int xe_guc_pc_start(struct xe_guc_pc *pc);
int xe_guc_pc_stop(struct xe_guc_pc *pc);
-int xe_guc_pc_gucrc_disable(struct xe_guc_pc *pc);
int xe_guc_pc_override_gucrc_mode(struct xe_guc_pc *pc, enum slpc_gucrc_mode mode);
int xe_guc_pc_unset_gucrc_mode(struct xe_guc_pc *pc);
void xe_guc_pc_print(struct xe_guc_pc *pc, struct drm_printer *p);
diff --git a/drivers/gpu/drm/xe/xe_guc_rc.c b/drivers/gpu/drm/xe/xe_guc_rc.c
new file mode 100644
index 000000000000..fc57e5290635
--- /dev/null
+++ b/drivers/gpu/drm/xe/xe_guc_rc.c
@@ -0,0 +1,114 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2026 Intel Corporation
+ */
+
+#include <linux/device/devres.h>
+#include <drm/drm_print.h>
+
+#include "abi/guc_actions_slpc_abi.h"
+#include "xe_device.h"
+#include "xe_force_wake.h"
+#include "xe_gt.h"
+#include "xe_gt_idle.h"
+#include "xe_gt_printk.h"
+#include "xe_guc.h"
+#include "xe_guc_ct.h"
+#include "xe_guc_rc.h"
+#include "xe_pm.h"
+
+/**
+ * DOC: GuC RC (Render C-states)
+ *
+ * GuC handles the GT transition to deeper C-states in conjunction with Pcode.
+ * GuC RC can be enabled independently of the frequency component in SLPC,
+ * which is also controlled by GuC.
+ *
+ * This file will contain all H2G related logic for handling Render C-states.
+ * There are some calls to xe_gt_idle, where we enable host C6 when GuC RC is
+ * skipped. GuC RC is mostly independent of xe_guc_pc with the exception of
+ * functions that override the mode for which we have to rely on the SLPC H2G
+ * calls.
+ */
+
+static int guc_action_setup_gucrc(struct xe_guc *guc, u32 control)
+{
+ u32 action[] = {
+ GUC_ACTION_HOST2GUC_SETUP_PC_GUCRC,
+ control,
+ };
+ int ret;
+
+ ret = xe_guc_ct_send(&guc->ct, action, ARRAY_SIZE(action), 0, 0);
+ if (ret && !(xe_device_wedged(guc_to_xe(guc)) && ret == -ECANCELED))
+ xe_gt_err(guc_to_gt(guc),
+ "GuC RC setup %s(%u) failed (%pe)\n",
+ control == GUCRC_HOST_CONTROL ? "HOST_CONTROL" :
+ control == GUCRC_FIRMWARE_CONTROL ? "FIRMWARE_CONTROL" :
+ "UNKNOWN", control, ERR_PTR(ret));
+ return ret;
+}
+
+/**
+ * xe_guc_rc_disable() - Disable GuC RC
+ * @guc: Xe GuC instance
+ *
+ * Disables GuC RC by taking control of RC6 back from GuC.
+ */
+void xe_guc_rc_disable(struct xe_guc *guc)
+{
+ struct xe_device *xe = guc_to_xe(guc);
+
+ if (!xe->info.skip_guc_pc && xe->info.platform != XE_PVC)
+ if (guc_action_setup_gucrc(guc, GUCRC_HOST_CONTROL))
+ return;
+
+ XE_WARN_ON(xe_gt_idle_disable_c6(guc_to_gt(guc)));
+}
+
+static void xe_guc_rc_fini_hw(void *arg)
+{
+ struct xe_guc *guc = arg;
+ struct xe_device *xe = guc_to_xe(guc);
+ struct xe_gt *gt = guc_to_gt(guc);
+
+ if (xe_device_wedged(xe))
+ return;
+
+ CLASS(xe_force_wake, fw_ref)(gt_to_fw(gt), XE_FW_GT);
+ xe_guc_rc_disable(guc);
+}
+
+/**
+ * xe_guc_rc_enable() - Enable GuC RC feature if applicable
+ * @guc: Xe GuC instance
+ *
+ * Enables GuC RC feature.
+ *
+ * Return: 0 on success, negative error code on error.
+ */
+int xe_guc_rc_enable(struct xe_guc *guc)
+{
+ struct xe_device *xe = guc_to_xe(guc);
+ struct xe_gt *gt = guc_to_gt(guc);
+
+ xe_gt_assert(gt, xe_device_uc_enabled(xe));
+
+ CLASS(xe_force_wake, fw_ref)(gt_to_fw(gt), XE_FW_GT);
+ if (!xe_force_wake_ref_has_domain(fw_ref.domains, XE_FW_GT))
+ return -ETIMEDOUT;
+
+ if (xe->info.platform == XE_PVC) {
+ xe_guc_rc_disable(guc);
+ return 0;
+ }
+
+ if (xe->info.skip_guc_pc) {
+ xe_gt_idle_enable_c6(gt);
+ return 0;
+ }
+
+ devm_add_action_or_reset(xe->drm.dev, xe_guc_rc_fini_hw, guc);
+
+ return guc_action_setup_gucrc(guc, GUCRC_FIRMWARE_CONTROL);
+}
diff --git a/drivers/gpu/drm/xe/xe_guc_rc.h b/drivers/gpu/drm/xe/xe_guc_rc.h
new file mode 100644
index 000000000000..c980b0fce472
--- /dev/null
+++ b/drivers/gpu/drm/xe/xe_guc_rc.h
@@ -0,0 +1,14 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2026 Intel Corporation
+ */
+
+#ifndef _XE_GUC_RC_H_
+#define _XE_GUC_RC_H_
+
+struct xe_guc;
+
+void xe_guc_rc_disable(struct xe_guc *guc);
+int xe_guc_rc_enable(struct xe_guc *guc);
+
+#endif
diff --git a/drivers/gpu/drm/xe/xe_uc.c b/drivers/gpu/drm/xe/xe_uc.c
index 3f63c2a7e86d..d9aa845a308d 100644
--- a/drivers/gpu/drm/xe/xe_uc.c
+++ b/drivers/gpu/drm/xe/xe_uc.c
@@ -13,6 +13,7 @@
#include "xe_gt_sriov_vf.h"
#include "xe_guc.h"
#include "xe_guc_pc.h"
+#include "xe_guc_rc.h"
#include "xe_guc_engine_activity.h"
#include "xe_huc.h"
#include "xe_sriov.h"
@@ -214,6 +215,10 @@ int xe_uc_load_hw(struct xe_uc *uc)
if (ret)
goto err_out;
+ ret = xe_guc_rc_enable(&uc->guc);
+ if (ret)
+ goto err_out;
+
xe_guc_engine_activity_enable_stats(&uc->guc);
/* We don't fail the driver load if HuC fails to auth */
@@ -242,11 +247,6 @@ int xe_uc_reset_prepare(struct xe_uc *uc)
return xe_guc_reset_prepare(&uc->guc);
}
-void xe_uc_gucrc_disable(struct xe_uc *uc)
-{
- XE_WARN_ON(xe_guc_pc_gucrc_disable(&uc->guc.pc));
-}
-
void xe_uc_stop_prepare(struct xe_uc *uc)
{
xe_gsc_stop_prepare(&uc->gsc);
diff --git a/drivers/gpu/drm/xe/xe_uc.h b/drivers/gpu/drm/xe/xe_uc.h
index 5398da1a8097..255a54a8f876 100644
--- a/drivers/gpu/drm/xe/xe_uc.h
+++ b/drivers/gpu/drm/xe/xe_uc.h
@@ -12,7 +12,6 @@ int xe_uc_init_noalloc(struct xe_uc *uc);
int xe_uc_init(struct xe_uc *uc);
int xe_uc_init_post_hwconfig(struct xe_uc *uc);
int xe_uc_load_hw(struct xe_uc *uc);
-void xe_uc_gucrc_disable(struct xe_uc *uc);
int xe_uc_reset_prepare(struct xe_uc *uc);
void xe_uc_runtime_resume(struct xe_uc *uc);
void xe_uc_runtime_suspend(struct xe_uc *uc);
--
2.38.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v6 1/2] drm/xe: Decouple GuC RC code from xe_guc_pc
2026-01-23 23:50 ` [PATCH v6 1/2] drm/xe: Decouple GuC RC code from xe_guc_pc Vinay Belgaumkar
@ 2026-01-27 23:18 ` Michal Wajdeczko
0 siblings, 0 replies; 11+ messages in thread
From: Michal Wajdeczko @ 2026-01-27 23:18 UTC (permalink / raw)
To: Vinay Belgaumkar, intel-xe; +Cc: Riana Tauro
On 1/24/2026 12:50 AM, Vinay Belgaumkar wrote:
> Move enable/disable GuC RC logic into the new file. This will
> allow us to independently enable/disable GuC RC and not rely
> on SLPC related functions. GuC already provides separate H2G
> interfaces to setup GuC RC and SLPC.
>
> v2: Comments (Michal W), remove duplicate c6_enable calls from
> xe_guc_pc.
>
> v3: Clarify crosss interactions between xe_guc_rc and xe_guc_pc
> (Michal W)
>
> v4: More comments (Michal W)
>
> v5: Remove rc_init and use enable/disable (Riana)
>
> v6: Link to kernel docs (Riana)
nit: you may keep change-log under ---
>
> Cc: Riana Tauro <riana.tauro@intel.com>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> ---
> Documentation/gpu/xe/xe_firmware.rst | 3 +
> drivers/gpu/drm/xe/Makefile | 1 +
> drivers/gpu/drm/xe/xe_gt.c | 1 -
> drivers/gpu/drm/xe/xe_guc.c | 2 +
> drivers/gpu/drm/xe/xe_guc_pc.c | 70 +++-------------
> drivers/gpu/drm/xe/xe_guc_pc.h | 1 -
> drivers/gpu/drm/xe/xe_guc_rc.c | 114 +++++++++++++++++++++++++++
> drivers/gpu/drm/xe/xe_guc_rc.h | 14 ++++
> drivers/gpu/drm/xe/xe_uc.c | 10 +--
> drivers/gpu/drm/xe/xe_uc.h | 1 -
> 10 files changed, 152 insertions(+), 65 deletions(-)
> create mode 100644 drivers/gpu/drm/xe/xe_guc_rc.c
> create mode 100644 drivers/gpu/drm/xe/xe_guc_rc.h
>
> diff --git a/Documentation/gpu/xe/xe_firmware.rst b/Documentation/gpu/xe/xe_firmware.rst
> index 5d23e9f27391..9c15a300bc62 100644
> --- a/Documentation/gpu/xe/xe_firmware.rst
> +++ b/Documentation/gpu/xe/xe_firmware.rst
> @@ -31,6 +31,9 @@ GuC Power Conservation (PC)
> .. kernel-doc:: drivers/gpu/drm/xe/xe_guc_pc.c
> :doc: GuC Power Conservation (PC)
>
> +.. kernel-doc:: drivers/gpu/drm/xe/xe_guc_rc.c
> + :doc: GuC Render C-states (GuC RC)
> +
> PCIe Gen5 Limitations
> =====================
>
> diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
> index b39cbb756232..2062602c1bf3 100644
> --- a/drivers/gpu/drm/xe/Makefile
> +++ b/drivers/gpu/drm/xe/Makefile
> @@ -74,6 +74,7 @@ xe-y += xe_bb.o \
> xe_guc_log.o \
> xe_guc_pagefault.o \
> xe_guc_pc.o \
> + xe_guc_rc.o \
> xe_guc_submit.o \
> xe_guc_tlb_inval.o \
> xe_heci_gsc.o \
> diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
> index 9d090d0f2438..c8a1d44bbf3a 100644
> --- a/drivers/gpu/drm/xe/xe_gt.c
> +++ b/drivers/gpu/drm/xe/xe_gt.c
> @@ -852,7 +852,6 @@ static void gt_reset_worker(struct work_struct *w)
> if (IS_SRIOV_PF(gt_to_xe(gt)))
> xe_gt_sriov_pf_stop_prepare(gt);
>
> - xe_uc_gucrc_disable(>->uc);
> xe_uc_stop_prepare(>->uc);
> xe_pagefault_reset(gt_to_xe(gt), gt);
>
> diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
> index 44360437beeb..f66b0c987b09 100644
> --- a/drivers/gpu/drm/xe/xe_guc.c
> +++ b/drivers/gpu/drm/xe/xe_guc.c
> @@ -35,6 +35,7 @@
> #include "xe_guc_klv_helpers.h"
> #include "xe_guc_log.h"
> #include "xe_guc_pc.h"
> +#include "xe_guc_rc.h"
> #include "xe_guc_relay.h"
> #include "xe_guc_submit.h"
> #include "xe_memirq.h"
> @@ -1609,6 +1610,7 @@ void xe_guc_stop_prepare(struct xe_guc *guc)
> if (!IS_SRIOV_VF(guc_to_xe(guc))) {
> int err;
>
> + xe_guc_rc_disable(guc);
> err = xe_guc_pc_stop(&guc->pc);
> xe_gt_WARN(guc_to_gt(guc), err, "Failed to stop GuC PC: %pe\n",
> ERR_PTR(err));
> diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c
> index 54702a0fd05b..cf02c53ca3c5 100644
> --- a/drivers/gpu/drm/xe/xe_guc_pc.c
> +++ b/drivers/gpu/drm/xe/xe_guc_pc.c
> @@ -92,6 +92,17 @@
> * Render-C states is also a GuC PC feature that is now enabled in Xe for
> * all platforms.
> *
> + * Implementation details:
> + * -----------------------
> + * The implementation for GuC Power Management features is split as follows:
> + *
> + * xe_guc_rc: Logic for handling GuC RC
> + * xe_gt_idle: Host side logic for RC6 and Coarse Power gating (CPG)
> + * xe_guc_pc: Logic for all other SLPC related features
> + *
> + * There is some cross interaction between these where host C6 will need to be
> + * enabled when we plan to skip GuC RC. Also, the GuC RC mode is currently
> + * overridden through 0x3003 which is an SLPC H2G call.
> */
>
> static struct xe_guc *pc_to_guc(struct xe_guc_pc *pc)
> @@ -253,22 +264,6 @@ static int pc_action_unset_param(struct xe_guc_pc *pc, u8 id)
> return ret;
> }
>
> -static int pc_action_setup_gucrc(struct xe_guc_pc *pc, u32 mode)
> -{
> - struct xe_guc_ct *ct = pc_to_ct(pc);
> - u32 action[] = {
> - GUC_ACTION_HOST2GUC_SETUP_PC_GUCRC,
> - mode,
> - };
> - int ret;
> -
> - ret = xe_guc_ct_send(ct, action, ARRAY_SIZE(action), 0, 0);
> - if (ret && !(xe_device_wedged(pc_to_xe(pc)) && ret == -ECANCELED))
> - xe_gt_err(pc_to_gt(pc), "GuC RC enable mode=%u failed: %pe\n",
> - mode, ERR_PTR(ret));
> - return ret;
> -}
> -
> static u32 decode_freq(u32 raw)
> {
> return DIV_ROUND_CLOSEST(raw * GT_FREQUENCY_MULTIPLIER,
> @@ -1050,30 +1045,6 @@ int xe_guc_pc_restore_stashed_freq(struct xe_guc_pc *pc)
> return ret;
> }
>
> -/**
> - * xe_guc_pc_gucrc_disable - Disable GuC RC
> - * @pc: Xe_GuC_PC instance
> - *
> - * Disables GuC RC by taking control of RC6 back from GuC.
> - *
> - * Return: 0 on success, negative error code on error.
> - */
> -int xe_guc_pc_gucrc_disable(struct xe_guc_pc *pc)
> -{
> - struct xe_device *xe = pc_to_xe(pc);
> - struct xe_gt *gt = pc_to_gt(pc);
> - int ret = 0;
> -
> - if (xe->info.skip_guc_pc)
> - return 0;
> -
> - ret = pc_action_setup_gucrc(pc, GUCRC_HOST_CONTROL);
> - if (ret)
> - return ret;
> -
> - return xe_gt_idle_disable_c6(gt);
> -}
> -
> /**
> * xe_guc_pc_override_gucrc_mode - override GUCRC mode
> * @pc: Xe_GuC_PC instance
> @@ -1217,9 +1188,6 @@ int xe_guc_pc_start(struct xe_guc_pc *pc)
> return -ETIMEDOUT;
>
> if (xe->info.skip_guc_pc) {
> - if (xe->info.platform != XE_PVC)
> - xe_gt_idle_enable_c6(gt);
> -
> /* Request max possible since dynamic freq mgmt is not enabled */
> pc_set_cur_freq(pc, UINT_MAX);
> return 0;
> @@ -1257,15 +1225,6 @@ int xe_guc_pc_start(struct xe_guc_pc *pc)
> if (ret)
> return ret;
>
> - if (xe->info.platform == XE_PVC) {
> - xe_guc_pc_gucrc_disable(pc);
> - return 0;
> - }
> -
> - ret = pc_action_setup_gucrc(pc, GUCRC_FIRMWARE_CONTROL);
> - if (ret)
> - return ret;
> -
> /* Enable SLPC Optimized Strategy for compute */
> ret = pc_action_set_strategy(pc, SLPC_OPTIMIZED_STRATEGY_COMPUTE);
>
> @@ -1285,10 +1244,8 @@ int xe_guc_pc_stop(struct xe_guc_pc *pc)
> {
> struct xe_device *xe = pc_to_xe(pc);
>
> - if (xe->info.skip_guc_pc) {
> - xe_gt_idle_disable_c6(pc_to_gt(pc));
> + if (xe->info.skip_guc_pc)
> return 0;
> - }
>
> mutex_lock(&pc->freq_lock);
> pc->freq_ready = false;
> @@ -1309,8 +1266,7 @@ static void xe_guc_pc_fini_hw(void *arg)
> if (xe_device_wedged(xe))
> return;
>
> - CLASS(xe_force_wake, fw_ref)(gt_to_fw(pc_to_gt(pc)), XE_FORCEWAKE_ALL);
> - xe_guc_pc_gucrc_disable(pc);
> + CLASS(xe_force_wake, fw_ref)(gt_to_fw(pc_to_gt(pc)), XE_FW_GT);
> XE_WARN_ON(xe_guc_pc_stop(pc));
>
> /* Bind requested freq to mert_freq_cap before unload */
> diff --git a/drivers/gpu/drm/xe/xe_guc_pc.h b/drivers/gpu/drm/xe/xe_guc_pc.h
> index 0e31396f103c..1b95873b262e 100644
> --- a/drivers/gpu/drm/xe/xe_guc_pc.h
> +++ b/drivers/gpu/drm/xe/xe_guc_pc.h
> @@ -15,7 +15,6 @@ struct drm_printer;
> int xe_guc_pc_init(struct xe_guc_pc *pc);
> int xe_guc_pc_start(struct xe_guc_pc *pc);
> int xe_guc_pc_stop(struct xe_guc_pc *pc);
> -int xe_guc_pc_gucrc_disable(struct xe_guc_pc *pc);
> int xe_guc_pc_override_gucrc_mode(struct xe_guc_pc *pc, enum slpc_gucrc_mode mode);
> int xe_guc_pc_unset_gucrc_mode(struct xe_guc_pc *pc);
> void xe_guc_pc_print(struct xe_guc_pc *pc, struct drm_printer *p);
> diff --git a/drivers/gpu/drm/xe/xe_guc_rc.c b/drivers/gpu/drm/xe/xe_guc_rc.c
> new file mode 100644
> index 000000000000..fc57e5290635
> --- /dev/null
> +++ b/drivers/gpu/drm/xe/xe_guc_rc.c
> @@ -0,0 +1,114 @@
> +// SPDX-License-Identifier: MIT
> +/*
> + * Copyright © 2026 Intel Corporation
> + */
> +
> +#include <linux/device/devres.h>
nit: quite unusual to include devres.h directly
> +#include <drm/drm_print.h>
> +
> +#include "abi/guc_actions_slpc_abi.h"
> +#include "xe_device.h"
> +#include "xe_force_wake.h"
> +#include "xe_gt.h"
> +#include "xe_gt_idle.h"
> +#include "xe_gt_printk.h"
> +#include "xe_guc.h"
> +#include "xe_guc_ct.h"
> +#include "xe_guc_rc.h"
> +#include "xe_pm.h"
> +
> +/**
> + * DOC: GuC RC (Render C-states)
> + *
> + * GuC handles the GT transition to deeper C-states in conjunction with Pcode.
> + * GuC RC can be enabled independently of the frequency component in SLPC,
> + * which is also controlled by GuC.
> + *
> + * This file will contain all H2G related logic for handling Render C-states.
> + * There are some calls to xe_gt_idle, where we enable host C6 when GuC RC is
> + * skipped. GuC RC is mostly independent of xe_guc_pc with the exception of
> + * functions that override the mode for which we have to rely on the SLPC H2G
> + * calls.
> + */
> +
> +static int guc_action_setup_gucrc(struct xe_guc *guc, u32 control)
> +{
> + u32 action[] = {
> + GUC_ACTION_HOST2GUC_SETUP_PC_GUCRC,
> + control,
> + };
> + int ret;
> +
> + ret = xe_guc_ct_send(&guc->ct, action, ARRAY_SIZE(action), 0, 0);
> + if (ret && !(xe_device_wedged(guc_to_xe(guc)) && ret == -ECANCELED))
> + xe_gt_err(guc_to_gt(guc),
> + "GuC RC setup %s(%u) failed (%pe)\n",
> + control == GUCRC_HOST_CONTROL ? "HOST_CONTROL" :
> + control == GUCRC_FIRMWARE_CONTROL ? "FIRMWARE_CONTROL" :
> + "UNKNOWN", control, ERR_PTR(ret));
> + return ret;
> +}
> +
> +/**
> + * xe_guc_rc_disable() - Disable GuC RC
> + * @guc: Xe GuC instance
> + *
> + * Disables GuC RC by taking control of RC6 back from GuC.
> + */
> +void xe_guc_rc_disable(struct xe_guc *guc)
> +{
> + struct xe_device *xe = guc_to_xe(guc);
> +
> + if (!xe->info.skip_guc_pc && xe->info.platform != XE_PVC)
> + if (guc_action_setup_gucrc(guc, GUCRC_HOST_CONTROL))
> + return;
> +
> + XE_WARN_ON(xe_gt_idle_disable_c6(guc_to_gt(guc)));
use xe_gt_WARN_ON()
> +}
> +
> +static void xe_guc_rc_fini_hw(void *arg)
> +{
> + struct xe_guc *guc = arg;
> + struct xe_device *xe = guc_to_xe(guc);
> + struct xe_gt *gt = guc_to_gt(guc);
> +
> + if (xe_device_wedged(xe))
> + return;
> +
> + CLASS(xe_force_wake, fw_ref)(gt_to_fw(gt), XE_FW_GT);
> + xe_guc_rc_disable(guc);
> +}
> +
> +/**
> + * xe_guc_rc_enable() - Enable GuC RC feature if applicable
> + * @guc: Xe GuC instance
> + *
> + * Enables GuC RC feature.
> + *
> + * Return: 0 on success, negative error code on error.
> + */
> +int xe_guc_rc_enable(struct xe_guc *guc)
> +{
> + struct xe_device *xe = guc_to_xe(guc);
> + struct xe_gt *gt = guc_to_gt(guc);
> +
> + xe_gt_assert(gt, xe_device_uc_enabled(xe));
> +
> + CLASS(xe_force_wake, fw_ref)(gt_to_fw(gt), XE_FW_GT);
> + if (!xe_force_wake_ref_has_domain(fw_ref.domains, XE_FW_GT))
> + return -ETIMEDOUT;
> +
> + if (xe->info.platform == XE_PVC) {
> + xe_guc_rc_disable(guc);
> + return 0;
> + }
> +
> + if (xe->info.skip_guc_pc) {
> + xe_gt_idle_enable_c6(gt);
> + return 0;
> + }
> +
> + devm_add_action_or_reset(xe->drm.dev, xe_guc_rc_fini_hw, guc);
you should check for error here ...
but since this function can be called many times, is this something you really want?
maybe there should be xe_guc_rc_init() function which would register this fini() action just once?
otherwise you should remove that action during explicit disable() call
> +
> + return guc_action_setup_gucrc(guc, GUCRC_FIRMWARE_CONTROL);
> +}
> diff --git a/drivers/gpu/drm/xe/xe_guc_rc.h b/drivers/gpu/drm/xe/xe_guc_rc.h
> new file mode 100644
> index 000000000000..c980b0fce472
> --- /dev/null
> +++ b/drivers/gpu/drm/xe/xe_guc_rc.h
> @@ -0,0 +1,14 @@
> +/* SPDX-License-Identifier: MIT */
> +/*
> + * Copyright © 2026 Intel Corporation
> + */
> +
> +#ifndef _XE_GUC_RC_H_
> +#define _XE_GUC_RC_H_
> +
> +struct xe_guc;
> +
> +void xe_guc_rc_disable(struct xe_guc *guc);
> +int xe_guc_rc_enable(struct xe_guc *guc);
> +
> +#endif
> diff --git a/drivers/gpu/drm/xe/xe_uc.c b/drivers/gpu/drm/xe/xe_uc.c
> index 3f63c2a7e86d..d9aa845a308d 100644
> --- a/drivers/gpu/drm/xe/xe_uc.c
> +++ b/drivers/gpu/drm/xe/xe_uc.c
> @@ -13,6 +13,7 @@
> #include "xe_gt_sriov_vf.h"
> #include "xe_guc.h"
> #include "xe_guc_pc.h"
> +#include "xe_guc_rc.h"
> #include "xe_guc_engine_activity.h"
> #include "xe_huc.h"
> #include "xe_sriov.h"
> @@ -214,6 +215,10 @@ int xe_uc_load_hw(struct xe_uc *uc)
> if (ret)
> goto err_out;
>
> + ret = xe_guc_rc_enable(&uc->guc);
> + if (ret)
> + goto err_out;
> +
> xe_guc_engine_activity_enable_stats(&uc->guc);
>
> /* We don't fail the driver load if HuC fails to auth */
> @@ -242,11 +247,6 @@ int xe_uc_reset_prepare(struct xe_uc *uc)
> return xe_guc_reset_prepare(&uc->guc);
> }
>
> -void xe_uc_gucrc_disable(struct xe_uc *uc)
> -{
> - XE_WARN_ON(xe_guc_pc_gucrc_disable(&uc->guc.pc));
> -}
> -
> void xe_uc_stop_prepare(struct xe_uc *uc)
> {
> xe_gsc_stop_prepare(&uc->gsc);
> diff --git a/drivers/gpu/drm/xe/xe_uc.h b/drivers/gpu/drm/xe/xe_uc.h
> index 5398da1a8097..255a54a8f876 100644
> --- a/drivers/gpu/drm/xe/xe_uc.h
> +++ b/drivers/gpu/drm/xe/xe_uc.h
> @@ -12,7 +12,6 @@ int xe_uc_init_noalloc(struct xe_uc *uc);
> int xe_uc_init(struct xe_uc *uc);
> int xe_uc_init_post_hwconfig(struct xe_uc *uc);
> int xe_uc_load_hw(struct xe_uc *uc);
> -void xe_uc_gucrc_disable(struct xe_uc *uc);
> int xe_uc_reset_prepare(struct xe_uc *uc);
> void xe_uc_runtime_resume(struct xe_uc *uc);
> void xe_uc_runtime_suspend(struct xe_uc *uc);
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v6 2/2] drm/xe: Add a wrapper for set/unset params
2026-01-23 23:50 [PATCH v6 0/2] drm/xe: Separate out GuC RC code Vinay Belgaumkar
2026-01-23 23:50 ` [PATCH v6 1/2] drm/xe: Decouple GuC RC code from xe_guc_pc Vinay Belgaumkar
@ 2026-01-23 23:50 ` Vinay Belgaumkar
2026-01-27 3:15 ` Riana Tauro
2026-01-27 23:32 ` Michal Wajdeczko
2026-01-24 0:20 ` ✗ CI.checkpatch: warning for drm/xe: Separate out GuC RC code (rev3) Patchwork
` (2 subsequent siblings)
4 siblings, 2 replies; 11+ messages in thread
From: Vinay Belgaumkar @ 2026-01-23 23:50 UTC (permalink / raw)
To: intel-xe; +Cc: Vinay Belgaumkar, Riana Tauro
Also, extract out the GuC RC related set/unset param functions
into xe_guc_rc file. GuC still allows us to override GuC RC mode
using an SLPC H2G interface. Continue to use that interface, but
move the related code to the newly created xe_guc_rc file.
v2: xe_guc_rc functions to use guc pointer instead of gt (Michal W)
v3: Assert if runtime pm ref is not held (Michal W)
v4: Review comments (Riana)
Cc: Riana Tauro <riana.tauro@intel.com>
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
---
drivers/gpu/drm/xe/xe_guc_pc.c | 56 +++++++++++++++++++---------------
drivers/gpu/drm/xe/xe_guc_pc.h | 5 ++-
drivers/gpu/drm/xe/xe_guc_rc.c | 30 ++++++++++++++++++
drivers/gpu/drm/xe/xe_guc_rc.h | 3 ++
drivers/gpu/drm/xe/xe_oa.c | 9 +++---
5 files changed, 70 insertions(+), 33 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c
index cf02c53ca3c5..31c6cb111916 100644
--- a/drivers/gpu/drm/xe/xe_guc_pc.c
+++ b/drivers/gpu/drm/xe/xe_guc_pc.c
@@ -264,6 +264,37 @@ static int pc_action_unset_param(struct xe_guc_pc *pc, u8 id)
return ret;
}
+/**
+ * xe_guc_pc_action_set_param() - Set value of SLPC param
+ * @pc: Xe_GuC_PC instance
+ * @id: Param id
+ * @value: Value to set
+ *
+ * This function can be used to set any SLPC param.
+ *
+ * Returns: 0 on Success
+ */
+int xe_guc_pc_action_set_param(struct xe_guc_pc *pc, u8 id, u32 value)
+{
+ xe_device_assert_mem_access(pc_to_xe(pc));
+ return pc_action_set_param(pc, id, value);
+}
+
+/**
+ * xe_guc_pc_action_unset_param() - Revert to default value
+ * @pc: Xe_GuC_PC instance
+ * @id: Param id
+ *
+ * This function can be used revert any SLPC param to its default value.
+ *
+ * Returns: 0 on Success
+ */
+int xe_guc_pc_action_unset_param(struct xe_guc_pc *pc, u8 id)
+{
+ xe_device_assert_mem_access(pc_to_xe(pc));
+ return pc_action_unset_param(pc, id);
+}
+
static u32 decode_freq(u32 raw)
{
return DIV_ROUND_CLOSEST(raw * GT_FREQUENCY_MULTIPLIER,
@@ -1045,31 +1076,6 @@ int xe_guc_pc_restore_stashed_freq(struct xe_guc_pc *pc)
return ret;
}
-/**
- * xe_guc_pc_override_gucrc_mode - override GUCRC mode
- * @pc: Xe_GuC_PC instance
- * @mode: new value of the mode.
- *
- * Return: 0 on success, negative error code on error
- */
-int xe_guc_pc_override_gucrc_mode(struct xe_guc_pc *pc, enum slpc_gucrc_mode mode)
-{
- guard(xe_pm_runtime)(pc_to_xe(pc));
- return pc_action_set_param(pc, SLPC_PARAM_PWRGATE_RC_MODE, mode);
-}
-
-/**
- * xe_guc_pc_unset_gucrc_mode - unset GUCRC mode override
- * @pc: Xe_GuC_PC instance
- *
- * Return: 0 on success, negative error code on error
- */
-int xe_guc_pc_unset_gucrc_mode(struct xe_guc_pc *pc)
-{
- guard(xe_pm_runtime)(pc_to_xe(pc));
- return pc_action_unset_param(pc, SLPC_PARAM_PWRGATE_RC_MODE);
-}
-
static void pc_init_pcode_freq(struct xe_guc_pc *pc)
{
u32 min = DIV_ROUND_CLOSEST(pc->rpn_freq, GT_FREQUENCY_MULTIPLIER);
diff --git a/drivers/gpu/drm/xe/xe_guc_pc.h b/drivers/gpu/drm/xe/xe_guc_pc.h
index 1b95873b262e..0678a4e787b3 100644
--- a/drivers/gpu/drm/xe/xe_guc_pc.h
+++ b/drivers/gpu/drm/xe/xe_guc_pc.h
@@ -9,15 +9,14 @@
#include <linux/types.h>
struct xe_guc_pc;
-enum slpc_gucrc_mode;
struct drm_printer;
int xe_guc_pc_init(struct xe_guc_pc *pc);
int xe_guc_pc_start(struct xe_guc_pc *pc);
int xe_guc_pc_stop(struct xe_guc_pc *pc);
-int xe_guc_pc_override_gucrc_mode(struct xe_guc_pc *pc, enum slpc_gucrc_mode mode);
-int xe_guc_pc_unset_gucrc_mode(struct xe_guc_pc *pc);
void xe_guc_pc_print(struct xe_guc_pc *pc, struct drm_printer *p);
+int xe_guc_pc_action_set_param(struct xe_guc_pc *pc, u8 id, u32 value);
+int xe_guc_pc_action_unset_param(struct xe_guc_pc *pc, u8 id);
u32 xe_guc_pc_get_act_freq(struct xe_guc_pc *pc);
int xe_guc_pc_get_cur_freq(struct xe_guc_pc *pc, u32 *freq);
diff --git a/drivers/gpu/drm/xe/xe_guc_rc.c b/drivers/gpu/drm/xe/xe_guc_rc.c
index fc57e5290635..0a900c309ecf 100644
--- a/drivers/gpu/drm/xe/xe_guc_rc.c
+++ b/drivers/gpu/drm/xe/xe_guc_rc.c
@@ -14,6 +14,7 @@
#include "xe_gt_printk.h"
#include "xe_guc.h"
#include "xe_guc_ct.h"
+#include "xe_guc_pc.h"
#include "xe_guc_rc.h"
#include "xe_pm.h"
@@ -112,3 +113,32 @@ int xe_guc_rc_enable(struct xe_guc *guc)
return guc_action_setup_gucrc(guc, GUCRC_FIRMWARE_CONTROL);
}
+
+/**
+ * xe_guc_rc_set_mode() - set GUCRC mode
+ * @guc: Xe GuC instance
+ * @mode: new value of the mode.
+ *
+ * Function to set GuC RC mode to one of the enum values.
+ *
+ * Returns: 0 on success, negative error code on error
+ */
+int xe_guc_rc_set_mode(struct xe_guc *guc, enum slpc_gucrc_mode mode)
+{
+ guard(xe_pm_runtime)(guc_to_xe(guc));
+ return xe_guc_pc_action_set_param(&guc->pc, SLPC_PARAM_PWRGATE_RC_MODE, mode);
+}
+
+/**
+ * xe_guc_rc_unset_mode() - revert to default mode
+ * @guc: Xe GuC instance
+ *
+ * Function to revert GuC RC mode to platform defaults.
+ *
+ * Returns: 0 on success, negative error code on error
+ */
+int xe_guc_rc_unset_mode(struct xe_guc *guc)
+{
+ guard(xe_pm_runtime)(guc_to_xe(guc));
+ return xe_guc_pc_action_unset_param(&guc->pc, SLPC_PARAM_PWRGATE_RC_MODE);
+}
diff --git a/drivers/gpu/drm/xe/xe_guc_rc.h b/drivers/gpu/drm/xe/xe_guc_rc.h
index c980b0fce472..d76dfad8e26c 100644
--- a/drivers/gpu/drm/xe/xe_guc_rc.h
+++ b/drivers/gpu/drm/xe/xe_guc_rc.h
@@ -7,8 +7,11 @@
#define _XE_GUC_RC_H_
struct xe_guc;
+enum slpc_gucrc_mode;
void xe_guc_rc_disable(struct xe_guc *guc);
int xe_guc_rc_enable(struct xe_guc *guc);
+int xe_guc_rc_set_mode(struct xe_guc *guc, enum slpc_gucrc_mode mode);
+int xe_guc_rc_unset_mode(struct xe_guc *guc);
#endif
diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
index abf87fe0b345..f7752719b74f 100644
--- a/drivers/gpu/drm/xe/xe_oa.c
+++ b/drivers/gpu/drm/xe/xe_oa.c
@@ -29,7 +29,7 @@
#include "xe_gt.h"
#include "xe_gt_mcr.h"
#include "xe_gt_printk.h"
-#include "xe_guc_pc.h"
+#include "xe_guc_rc.h"
#include "xe_macros.h"
#include "xe_mmio.h"
#include "xe_oa.h"
@@ -875,7 +875,7 @@ static void xe_oa_stream_destroy(struct xe_oa_stream *stream)
/* Wa_1509372804:pvc: Unset the override of GUCRC mode to enable rc6 */
if (stream->override_gucrc)
- xe_gt_WARN_ON(gt, xe_guc_pc_unset_gucrc_mode(>->uc.guc.pc));
+ xe_gt_WARN_ON(gt, xe_guc_rc_unset_mode(>->uc.guc));
xe_oa_free_configs(stream);
xe_file_put(stream->xef);
@@ -1765,8 +1765,7 @@ static int xe_oa_stream_init(struct xe_oa_stream *stream,
* state. Prevent this by overriding GUCRC mode.
*/
if (XE_GT_WA(stream->gt, 1509372804)) {
- ret = xe_guc_pc_override_gucrc_mode(>->uc.guc.pc,
- SLPC_GUCRC_MODE_GUCRC_NO_RC6);
+ ret = xe_guc_rc_set_mode(>->uc.guc, SLPC_GUCRC_MODE_GUCRC_NO_RC6);
if (ret)
goto err_free_configs;
@@ -1824,7 +1823,7 @@ static int xe_oa_stream_init(struct xe_oa_stream *stream,
xe_force_wake_put(gt_to_fw(gt), stream->fw_ref);
xe_pm_runtime_put(stream->oa->xe);
if (stream->override_gucrc)
- xe_gt_WARN_ON(gt, xe_guc_pc_unset_gucrc_mode(>->uc.guc.pc));
+ xe_gt_WARN_ON(gt, xe_guc_rc_unset_mode(>->uc.guc));
err_free_configs:
xe_oa_free_configs(stream);
exit:
--
2.38.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v6 2/2] drm/xe: Add a wrapper for set/unset params
2026-01-23 23:50 ` [PATCH v6 2/2] drm/xe: Add a wrapper for set/unset params Vinay Belgaumkar
@ 2026-01-27 3:15 ` Riana Tauro
2026-01-27 23:32 ` Michal Wajdeczko
1 sibling, 0 replies; 11+ messages in thread
From: Riana Tauro @ 2026-01-27 3:15 UTC (permalink / raw)
To: Vinay Belgaumkar, intel-xe
On 1/24/2026 5:20 AM, Vinay Belgaumkar wrote:
> Also, extract out the GuC RC related set/unset param functions
> into xe_guc_rc file. GuC still allows us to override GuC RC mode
> using an SLPC H2G interface. Continue to use that interface, but
> move the related code to the newly created xe_guc_rc file.
>
> v2: xe_guc_rc functions to use guc pointer instead of gt (Michal W)
> v3: Assert if runtime pm ref is not held (Michal W)
> v4: Review comments (Riana)
>
> Cc: Riana Tauro <riana.tauro@intel.com>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Looks good to me.
Reviewed-by: Riana Tauro <riana.tauro@intel.com>
> ---
> drivers/gpu/drm/xe/xe_guc_pc.c | 56 +++++++++++++++++++---------------
> drivers/gpu/drm/xe/xe_guc_pc.h | 5 ++-
> drivers/gpu/drm/xe/xe_guc_rc.c | 30 ++++++++++++++++++
> drivers/gpu/drm/xe/xe_guc_rc.h | 3 ++
> drivers/gpu/drm/xe/xe_oa.c | 9 +++---
> 5 files changed, 70 insertions(+), 33 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c
> index cf02c53ca3c5..31c6cb111916 100644
> --- a/drivers/gpu/drm/xe/xe_guc_pc.c
> +++ b/drivers/gpu/drm/xe/xe_guc_pc.c
> @@ -264,6 +264,37 @@ static int pc_action_unset_param(struct xe_guc_pc *pc, u8 id)
> return ret;
> }
>
> +/**
> + * xe_guc_pc_action_set_param() - Set value of SLPC param
> + * @pc: Xe_GuC_PC instance
> + * @id: Param id
> + * @value: Value to set
> + *
> + * This function can be used to set any SLPC param.
> + *
> + * Returns: 0 on Success
> + */
> +int xe_guc_pc_action_set_param(struct xe_guc_pc *pc, u8 id, u32 value)
> +{
> + xe_device_assert_mem_access(pc_to_xe(pc));
> + return pc_action_set_param(pc, id, value);
> +}
> +
> +/**
> + * xe_guc_pc_action_unset_param() - Revert to default value
> + * @pc: Xe_GuC_PC instance
> + * @id: Param id
> + *
> + * This function can be used revert any SLPC param to its default value.
> + *
> + * Returns: 0 on Success
> + */
> +int xe_guc_pc_action_unset_param(struct xe_guc_pc *pc, u8 id)
> +{
> + xe_device_assert_mem_access(pc_to_xe(pc));
> + return pc_action_unset_param(pc, id);
> +}
> +
> static u32 decode_freq(u32 raw)
> {
> return DIV_ROUND_CLOSEST(raw * GT_FREQUENCY_MULTIPLIER,
> @@ -1045,31 +1076,6 @@ int xe_guc_pc_restore_stashed_freq(struct xe_guc_pc *pc)
> return ret;
> }
>
> -/**
> - * xe_guc_pc_override_gucrc_mode - override GUCRC mode
> - * @pc: Xe_GuC_PC instance
> - * @mode: new value of the mode.
> - *
> - * Return: 0 on success, negative error code on error
> - */
> -int xe_guc_pc_override_gucrc_mode(struct xe_guc_pc *pc, enum slpc_gucrc_mode mode)
> -{
> - guard(xe_pm_runtime)(pc_to_xe(pc));
> - return pc_action_set_param(pc, SLPC_PARAM_PWRGATE_RC_MODE, mode);
> -}
> -
> -/**
> - * xe_guc_pc_unset_gucrc_mode - unset GUCRC mode override
> - * @pc: Xe_GuC_PC instance
> - *
> - * Return: 0 on success, negative error code on error
> - */
> -int xe_guc_pc_unset_gucrc_mode(struct xe_guc_pc *pc)
> -{
> - guard(xe_pm_runtime)(pc_to_xe(pc));
> - return pc_action_unset_param(pc, SLPC_PARAM_PWRGATE_RC_MODE);
> -}
> -
> static void pc_init_pcode_freq(struct xe_guc_pc *pc)
> {
> u32 min = DIV_ROUND_CLOSEST(pc->rpn_freq, GT_FREQUENCY_MULTIPLIER);
> diff --git a/drivers/gpu/drm/xe/xe_guc_pc.h b/drivers/gpu/drm/xe/xe_guc_pc.h
> index 1b95873b262e..0678a4e787b3 100644
> --- a/drivers/gpu/drm/xe/xe_guc_pc.h
> +++ b/drivers/gpu/drm/xe/xe_guc_pc.h
> @@ -9,15 +9,14 @@
> #include <linux/types.h>
>
> struct xe_guc_pc;
> -enum slpc_gucrc_mode;
> struct drm_printer;
>
> int xe_guc_pc_init(struct xe_guc_pc *pc);
> int xe_guc_pc_start(struct xe_guc_pc *pc);
> int xe_guc_pc_stop(struct xe_guc_pc *pc);
> -int xe_guc_pc_override_gucrc_mode(struct xe_guc_pc *pc, enum slpc_gucrc_mode mode);
> -int xe_guc_pc_unset_gucrc_mode(struct xe_guc_pc *pc);
> void xe_guc_pc_print(struct xe_guc_pc *pc, struct drm_printer *p);
> +int xe_guc_pc_action_set_param(struct xe_guc_pc *pc, u8 id, u32 value);
> +int xe_guc_pc_action_unset_param(struct xe_guc_pc *pc, u8 id);
>
> u32 xe_guc_pc_get_act_freq(struct xe_guc_pc *pc);
> int xe_guc_pc_get_cur_freq(struct xe_guc_pc *pc, u32 *freq);
> diff --git a/drivers/gpu/drm/xe/xe_guc_rc.c b/drivers/gpu/drm/xe/xe_guc_rc.c
> index fc57e5290635..0a900c309ecf 100644
> --- a/drivers/gpu/drm/xe/xe_guc_rc.c
> +++ b/drivers/gpu/drm/xe/xe_guc_rc.c
> @@ -14,6 +14,7 @@
> #include "xe_gt_printk.h"
> #include "xe_guc.h"
> #include "xe_guc_ct.h"
> +#include "xe_guc_pc.h"
> #include "xe_guc_rc.h"
> #include "xe_pm.h"
>
> @@ -112,3 +113,32 @@ int xe_guc_rc_enable(struct xe_guc *guc)
>
> return guc_action_setup_gucrc(guc, GUCRC_FIRMWARE_CONTROL);
> }
> +
> +/**
> + * xe_guc_rc_set_mode() - set GUCRC mode
> + * @guc: Xe GuC instance
> + * @mode: new value of the mode.
> + *
> + * Function to set GuC RC mode to one of the enum values.
> + *
> + * Returns: 0 on success, negative error code on error
> + */
> +int xe_guc_rc_set_mode(struct xe_guc *guc, enum slpc_gucrc_mode mode)
> +{
> + guard(xe_pm_runtime)(guc_to_xe(guc));
> + return xe_guc_pc_action_set_param(&guc->pc, SLPC_PARAM_PWRGATE_RC_MODE, mode);
> +}
> +
> +/**
> + * xe_guc_rc_unset_mode() - revert to default mode
> + * @guc: Xe GuC instance
> + *
> + * Function to revert GuC RC mode to platform defaults.
> + *
> + * Returns: 0 on success, negative error code on error
> + */
> +int xe_guc_rc_unset_mode(struct xe_guc *guc)
> +{
> + guard(xe_pm_runtime)(guc_to_xe(guc));
> + return xe_guc_pc_action_unset_param(&guc->pc, SLPC_PARAM_PWRGATE_RC_MODE);
> +}
> diff --git a/drivers/gpu/drm/xe/xe_guc_rc.h b/drivers/gpu/drm/xe/xe_guc_rc.h
> index c980b0fce472..d76dfad8e26c 100644
> --- a/drivers/gpu/drm/xe/xe_guc_rc.h
> +++ b/drivers/gpu/drm/xe/xe_guc_rc.h
> @@ -7,8 +7,11 @@
> #define _XE_GUC_RC_H_
>
> struct xe_guc;
> +enum slpc_gucrc_mode;
>
> void xe_guc_rc_disable(struct xe_guc *guc);
> int xe_guc_rc_enable(struct xe_guc *guc);
> +int xe_guc_rc_set_mode(struct xe_guc *guc, enum slpc_gucrc_mode mode);
> +int xe_guc_rc_unset_mode(struct xe_guc *guc);
>
> #endif
> diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
> index abf87fe0b345..f7752719b74f 100644
> --- a/drivers/gpu/drm/xe/xe_oa.c
> +++ b/drivers/gpu/drm/xe/xe_oa.c
> @@ -29,7 +29,7 @@
> #include "xe_gt.h"
> #include "xe_gt_mcr.h"
> #include "xe_gt_printk.h"
> -#include "xe_guc_pc.h"
> +#include "xe_guc_rc.h"
> #include "xe_macros.h"
> #include "xe_mmio.h"
> #include "xe_oa.h"
> @@ -875,7 +875,7 @@ static void xe_oa_stream_destroy(struct xe_oa_stream *stream)
>
> /* Wa_1509372804:pvc: Unset the override of GUCRC mode to enable rc6 */
> if (stream->override_gucrc)
> - xe_gt_WARN_ON(gt, xe_guc_pc_unset_gucrc_mode(>->uc.guc.pc));
> + xe_gt_WARN_ON(gt, xe_guc_rc_unset_mode(>->uc.guc));
>
> xe_oa_free_configs(stream);
> xe_file_put(stream->xef);
> @@ -1765,8 +1765,7 @@ static int xe_oa_stream_init(struct xe_oa_stream *stream,
> * state. Prevent this by overriding GUCRC mode.
> */
> if (XE_GT_WA(stream->gt, 1509372804)) {
> - ret = xe_guc_pc_override_gucrc_mode(>->uc.guc.pc,
> - SLPC_GUCRC_MODE_GUCRC_NO_RC6);
> + ret = xe_guc_rc_set_mode(>->uc.guc, SLPC_GUCRC_MODE_GUCRC_NO_RC6);
> if (ret)
> goto err_free_configs;
>
> @@ -1824,7 +1823,7 @@ static int xe_oa_stream_init(struct xe_oa_stream *stream,
> xe_force_wake_put(gt_to_fw(gt), stream->fw_ref);
> xe_pm_runtime_put(stream->oa->xe);
> if (stream->override_gucrc)
> - xe_gt_WARN_ON(gt, xe_guc_pc_unset_gucrc_mode(>->uc.guc.pc));
> + xe_gt_WARN_ON(gt, xe_guc_rc_unset_mode(>->uc.guc));
> err_free_configs:
> xe_oa_free_configs(stream);
> exit:
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v6 2/2] drm/xe: Add a wrapper for set/unset params
2026-01-23 23:50 ` [PATCH v6 2/2] drm/xe: Add a wrapper for set/unset params Vinay Belgaumkar
2026-01-27 3:15 ` Riana Tauro
@ 2026-01-27 23:32 ` Michal Wajdeczko
2026-01-28 0:13 ` Belgaumkar, Vinay
1 sibling, 1 reply; 11+ messages in thread
From: Michal Wajdeczko @ 2026-01-27 23:32 UTC (permalink / raw)
To: Vinay Belgaumkar, intel-xe; +Cc: Riana Tauro
subject is too generic, maybe mention GuC/PC/RC ?
"drm/xe/guc: Add wrappers for set/unset SLPC params"
On 1/24/2026 12:50 AM, Vinay Belgaumkar wrote:
> Also, extract out the GuC RC related set/unset param functions
> into xe_guc_rc file. GuC still allows us to override GuC RC mode
> using an SLPC H2G interface. Continue to use that interface, but
> move the related code to the newly created xe_guc_rc file.
>
> v2: xe_guc_rc functions to use guc pointer instead of gt (Michal W)
> v3: Assert if runtime pm ref is not held (Michal W)
> v4: Review comments (Riana)
>
> Cc: Riana Tauro <riana.tauro@intel.com>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> ---
> drivers/gpu/drm/xe/xe_guc_pc.c | 56 +++++++++++++++++++---------------
> drivers/gpu/drm/xe/xe_guc_pc.h | 5 ++-
> drivers/gpu/drm/xe/xe_guc_rc.c | 30 ++++++++++++++++++
> drivers/gpu/drm/xe/xe_guc_rc.h | 3 ++
> drivers/gpu/drm/xe/xe_oa.c | 9 +++---
> 5 files changed, 70 insertions(+), 33 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c
> index cf02c53ca3c5..31c6cb111916 100644
> --- a/drivers/gpu/drm/xe/xe_guc_pc.c
> +++ b/drivers/gpu/drm/xe/xe_guc_pc.c
> @@ -264,6 +264,37 @@ static int pc_action_unset_param(struct xe_guc_pc *pc, u8 id)
> return ret;
> }
>
> +/**
> + * xe_guc_pc_action_set_param() - Set value of SLPC param
> + * @pc: Xe_GuC_PC instance
> + * @id: Param id
> + * @value: Value to set
> + *
> + * This function can be used to set any SLPC param.
> + *
> + * Returns: 0 on Success
* Return: 0 on success or a negative error code on failure.
> + */
> +int xe_guc_pc_action_set_param(struct xe_guc_pc *pc, u8 id, u32 value)
> +{
> + xe_device_assert_mem_access(pc_to_xe(pc));
> + return pc_action_set_param(pc, id, value);
> +}
> +
> +/**
> + * xe_guc_pc_action_unset_param() - Revert to default value
> + * @pc: Xe_GuC_PC instance
> + * @id: Param id
> + *
> + * This function can be used revert any SLPC param to its default value.
> + *
> + * Returns: 0 on Success
ditto
> + */
> +int xe_guc_pc_action_unset_param(struct xe_guc_pc *pc, u8 id)
> +{
> + xe_device_assert_mem_access(pc_to_xe(pc));
> + return pc_action_unset_param(pc, id);
> +}
> +
> static u32 decode_freq(u32 raw)
> {
> return DIV_ROUND_CLOSEST(raw * GT_FREQUENCY_MULTIPLIER,
> @@ -1045,31 +1076,6 @@ int xe_guc_pc_restore_stashed_freq(struct xe_guc_pc *pc)
> return ret;
> }
>
> -/**
> - * xe_guc_pc_override_gucrc_mode - override GUCRC mode
> - * @pc: Xe_GuC_PC instance
> - * @mode: new value of the mode.
> - *
> - * Return: 0 on success, negative error code on error
> - */
> -int xe_guc_pc_override_gucrc_mode(struct xe_guc_pc *pc, enum slpc_gucrc_mode mode)
> -{
> - guard(xe_pm_runtime)(pc_to_xe(pc));
> - return pc_action_set_param(pc, SLPC_PARAM_PWRGATE_RC_MODE, mode);
> -}
> -
> -/**
> - * xe_guc_pc_unset_gucrc_mode - unset GUCRC mode override
> - * @pc: Xe_GuC_PC instance
> - *
> - * Return: 0 on success, negative error code on error
> - */
> -int xe_guc_pc_unset_gucrc_mode(struct xe_guc_pc *pc)
> -{
> - guard(xe_pm_runtime)(pc_to_xe(pc));
> - return pc_action_unset_param(pc, SLPC_PARAM_PWRGATE_RC_MODE);
> -}
> -
> static void pc_init_pcode_freq(struct xe_guc_pc *pc)
> {
> u32 min = DIV_ROUND_CLOSEST(pc->rpn_freq, GT_FREQUENCY_MULTIPLIER);
> diff --git a/drivers/gpu/drm/xe/xe_guc_pc.h b/drivers/gpu/drm/xe/xe_guc_pc.h
> index 1b95873b262e..0678a4e787b3 100644
> --- a/drivers/gpu/drm/xe/xe_guc_pc.h
> +++ b/drivers/gpu/drm/xe/xe_guc_pc.h
> @@ -9,15 +9,14 @@
> #include <linux/types.h>
>
> struct xe_guc_pc;
> -enum slpc_gucrc_mode;
> struct drm_printer;
>
> int xe_guc_pc_init(struct xe_guc_pc *pc);
> int xe_guc_pc_start(struct xe_guc_pc *pc);
> int xe_guc_pc_stop(struct xe_guc_pc *pc);
> -int xe_guc_pc_override_gucrc_mode(struct xe_guc_pc *pc, enum slpc_gucrc_mode mode);
> -int xe_guc_pc_unset_gucrc_mode(struct xe_guc_pc *pc);
> void xe_guc_pc_print(struct xe_guc_pc *pc, struct drm_printer *p);
> +int xe_guc_pc_action_set_param(struct xe_guc_pc *pc, u8 id, u32 value);
> +int xe_guc_pc_action_unset_param(struct xe_guc_pc *pc, u8 id);
>
> u32 xe_guc_pc_get_act_freq(struct xe_guc_pc *pc);
> int xe_guc_pc_get_cur_freq(struct xe_guc_pc *pc, u32 *freq);
> diff --git a/drivers/gpu/drm/xe/xe_guc_rc.c b/drivers/gpu/drm/xe/xe_guc_rc.c
> index fc57e5290635..0a900c309ecf 100644
> --- a/drivers/gpu/drm/xe/xe_guc_rc.c
> +++ b/drivers/gpu/drm/xe/xe_guc_rc.c
> @@ -14,6 +14,7 @@
> #include "xe_gt_printk.h"
> #include "xe_guc.h"
> #include "xe_guc_ct.h"
> +#include "xe_guc_pc.h"
> #include "xe_guc_rc.h"
> #include "xe_pm.h"
>
> @@ -112,3 +113,32 @@ int xe_guc_rc_enable(struct xe_guc *guc)
>
> return guc_action_setup_gucrc(guc, GUCRC_FIRMWARE_CONTROL);
> }
> +
> +/**
> + * xe_guc_rc_set_mode() - set GUCRC mode
> + * @guc: Xe GuC instance
> + * @mode: new value of the mode.
> + *
> + * Function to set GuC RC mode to one of the enum values.
> + *
> + * Returns: 0 on success, negative error code on error
> + */
> +int xe_guc_rc_set_mode(struct xe_guc *guc, enum slpc_gucrc_mode mode)
> +{
> + guard(xe_pm_runtime)(guc_to_xe(guc));
are we sure we want to do full resume here?
maybe it should be:
guard(xe_pm_runtime_noresume)
> + return xe_guc_pc_action_set_param(&guc->pc, SLPC_PARAM_PWRGATE_RC_MODE, mode);
> +}
> +
> +/**
> + * xe_guc_rc_unset_mode() - revert to default mode
> + * @guc: Xe GuC instance
> + *
> + * Function to revert GuC RC mode to platform defaults.
> + *
> + * Returns: 0 on success, negative error code on error
> + */
> +int xe_guc_rc_unset_mode(struct xe_guc *guc)
> +{
> + guard(xe_pm_runtime)(guc_to_xe(guc));
ditto
> + return xe_guc_pc_action_unset_param(&guc->pc, SLPC_PARAM_PWRGATE_RC_MODE);
> +}
> diff --git a/drivers/gpu/drm/xe/xe_guc_rc.h b/drivers/gpu/drm/xe/xe_guc_rc.h
> index c980b0fce472..d76dfad8e26c 100644
> --- a/drivers/gpu/drm/xe/xe_guc_rc.h
> +++ b/drivers/gpu/drm/xe/xe_guc_rc.h
> @@ -7,8 +7,11 @@
> #define _XE_GUC_RC_H_
>
> struct xe_guc;
> +enum slpc_gucrc_mode;
>
> void xe_guc_rc_disable(struct xe_guc *guc);
> int xe_guc_rc_enable(struct xe_guc *guc);
> +int xe_guc_rc_set_mode(struct xe_guc *guc, enum slpc_gucrc_mode mode);
> +int xe_guc_rc_unset_mode(struct xe_guc *guc);
>
> #endif
> diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
> index abf87fe0b345..f7752719b74f 100644
> --- a/drivers/gpu/drm/xe/xe_oa.c
> +++ b/drivers/gpu/drm/xe/xe_oa.c
> @@ -29,7 +29,7 @@
> #include "xe_gt.h"
> #include "xe_gt_mcr.h"
> #include "xe_gt_printk.h"
> -#include "xe_guc_pc.h"
> +#include "xe_guc_rc.h"
> #include "xe_macros.h"
> #include "xe_mmio.h"
> #include "xe_oa.h"
> @@ -875,7 +875,7 @@ static void xe_oa_stream_destroy(struct xe_oa_stream *stream)
>
> /* Wa_1509372804:pvc: Unset the override of GUCRC mode to enable rc6 */
> if (stream->override_gucrc)
> - xe_gt_WARN_ON(gt, xe_guc_pc_unset_gucrc_mode(>->uc.guc.pc));
> + xe_gt_WARN_ON(gt, xe_guc_rc_unset_mode(>->uc.guc));
as return real error code, not bool, maybe we should also print it?
>
> xe_oa_free_configs(stream);
> xe_file_put(stream->xef);
> @@ -1765,8 +1765,7 @@ static int xe_oa_stream_init(struct xe_oa_stream *stream,
> * state. Prevent this by overriding GUCRC mode.
> */
> if (XE_GT_WA(stream->gt, 1509372804)) {
> - ret = xe_guc_pc_override_gucrc_mode(>->uc.guc.pc,
> - SLPC_GUCRC_MODE_GUCRC_NO_RC6);
> + ret = xe_guc_rc_set_mode(>->uc.guc, SLPC_GUCRC_MODE_GUCRC_NO_RC6);
> if (ret)
> goto err_free_configs;
>
> @@ -1824,7 +1823,7 @@ static int xe_oa_stream_init(struct xe_oa_stream *stream,
> xe_force_wake_put(gt_to_fw(gt), stream->fw_ref);
> xe_pm_runtime_put(stream->oa->xe);
we should just place guc_rc calls when we still are holding rpm
> if (stream->override_gucrc)
> - xe_gt_WARN_ON(gt, xe_guc_pc_unset_gucrc_mode(>->uc.guc.pc));
> + xe_gt_WARN_ON(gt, xe_guc_rc_unset_mode(>->uc.guc));
> err_free_configs:
> xe_oa_free_configs(stream);
> exit:
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v6 2/2] drm/xe: Add a wrapper for set/unset params
2026-01-27 23:32 ` Michal Wajdeczko
@ 2026-01-28 0:13 ` Belgaumkar, Vinay
0 siblings, 0 replies; 11+ messages in thread
From: Belgaumkar, Vinay @ 2026-01-28 0:13 UTC (permalink / raw)
To: Michal Wajdeczko, intel-xe; +Cc: Riana Tauro
On 1/27/2026 3:32 PM, Michal Wajdeczko wrote:
> subject is too generic, maybe mention GuC/PC/RC ?
>
> "drm/xe/guc: Add wrappers for set/unset SLPC params"
ok.
>
>
> On 1/24/2026 12:50 AM, Vinay Belgaumkar wrote:
>> Also, extract out the GuC RC related set/unset param functions
>> into xe_guc_rc file. GuC still allows us to override GuC RC mode
>> using an SLPC H2G interface. Continue to use that interface, but
>> move the related code to the newly created xe_guc_rc file.
>>
>> v2: xe_guc_rc functions to use guc pointer instead of gt (Michal W)
>> v3: Assert if runtime pm ref is not held (Michal W)
>> v4: Review comments (Riana)
>>
>> Cc: Riana Tauro <riana.tauro@intel.com>
>> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
>> ---
>> drivers/gpu/drm/xe/xe_guc_pc.c | 56 +++++++++++++++++++---------------
>> drivers/gpu/drm/xe/xe_guc_pc.h | 5 ++-
>> drivers/gpu/drm/xe/xe_guc_rc.c | 30 ++++++++++++++++++
>> drivers/gpu/drm/xe/xe_guc_rc.h | 3 ++
>> drivers/gpu/drm/xe/xe_oa.c | 9 +++---
>> 5 files changed, 70 insertions(+), 33 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c
>> index cf02c53ca3c5..31c6cb111916 100644
>> --- a/drivers/gpu/drm/xe/xe_guc_pc.c
>> +++ b/drivers/gpu/drm/xe/xe_guc_pc.c
>> @@ -264,6 +264,37 @@ static int pc_action_unset_param(struct xe_guc_pc *pc, u8 id)
>> return ret;
>> }
>>
>> +/**
>> + * xe_guc_pc_action_set_param() - Set value of SLPC param
>> + * @pc: Xe_GuC_PC instance
>> + * @id: Param id
>> + * @value: Value to set
>> + *
>> + * This function can be used to set any SLPC param.
>> + *
>> + * Returns: 0 on Success
> * Return: 0 on success or a negative error code on failure.
ok.
>
>> + */
>> +int xe_guc_pc_action_set_param(struct xe_guc_pc *pc, u8 id, u32 value)
>> +{
>> + xe_device_assert_mem_access(pc_to_xe(pc));
>> + return pc_action_set_param(pc, id, value);
>> +}
>> +
>> +/**
>> + * xe_guc_pc_action_unset_param() - Revert to default value
>> + * @pc: Xe_GuC_PC instance
>> + * @id: Param id
>> + *
>> + * This function can be used revert any SLPC param to its default value.
>> + *
>> + * Returns: 0 on Success
> ditto
ok.
>
>> + */
>> +int xe_guc_pc_action_unset_param(struct xe_guc_pc *pc, u8 id)
>> +{
>> + xe_device_assert_mem_access(pc_to_xe(pc));
>> + return pc_action_unset_param(pc, id);
>> +}
>> +
>> static u32 decode_freq(u32 raw)
>> {
>> return DIV_ROUND_CLOSEST(raw * GT_FREQUENCY_MULTIPLIER,
>> @@ -1045,31 +1076,6 @@ int xe_guc_pc_restore_stashed_freq(struct xe_guc_pc *pc)
>> return ret;
>> }
>>
>> -/**
>> - * xe_guc_pc_override_gucrc_mode - override GUCRC mode
>> - * @pc: Xe_GuC_PC instance
>> - * @mode: new value of the mode.
>> - *
>> - * Return: 0 on success, negative error code on error
>> - */
>> -int xe_guc_pc_override_gucrc_mode(struct xe_guc_pc *pc, enum slpc_gucrc_mode mode)
>> -{
>> - guard(xe_pm_runtime)(pc_to_xe(pc));
>> - return pc_action_set_param(pc, SLPC_PARAM_PWRGATE_RC_MODE, mode);
>> -}
>> -
>> -/**
>> - * xe_guc_pc_unset_gucrc_mode - unset GUCRC mode override
>> - * @pc: Xe_GuC_PC instance
>> - *
>> - * Return: 0 on success, negative error code on error
>> - */
>> -int xe_guc_pc_unset_gucrc_mode(struct xe_guc_pc *pc)
>> -{
>> - guard(xe_pm_runtime)(pc_to_xe(pc));
>> - return pc_action_unset_param(pc, SLPC_PARAM_PWRGATE_RC_MODE);
>> -}
>> -
>> static void pc_init_pcode_freq(struct xe_guc_pc *pc)
>> {
>> u32 min = DIV_ROUND_CLOSEST(pc->rpn_freq, GT_FREQUENCY_MULTIPLIER);
>> diff --git a/drivers/gpu/drm/xe/xe_guc_pc.h b/drivers/gpu/drm/xe/xe_guc_pc.h
>> index 1b95873b262e..0678a4e787b3 100644
>> --- a/drivers/gpu/drm/xe/xe_guc_pc.h
>> +++ b/drivers/gpu/drm/xe/xe_guc_pc.h
>> @@ -9,15 +9,14 @@
>> #include <linux/types.h>
>>
>> struct xe_guc_pc;
>> -enum slpc_gucrc_mode;
>> struct drm_printer;
>>
>> int xe_guc_pc_init(struct xe_guc_pc *pc);
>> int xe_guc_pc_start(struct xe_guc_pc *pc);
>> int xe_guc_pc_stop(struct xe_guc_pc *pc);
>> -int xe_guc_pc_override_gucrc_mode(struct xe_guc_pc *pc, enum slpc_gucrc_mode mode);
>> -int xe_guc_pc_unset_gucrc_mode(struct xe_guc_pc *pc);
>> void xe_guc_pc_print(struct xe_guc_pc *pc, struct drm_printer *p);
>> +int xe_guc_pc_action_set_param(struct xe_guc_pc *pc, u8 id, u32 value);
>> +int xe_guc_pc_action_unset_param(struct xe_guc_pc *pc, u8 id);
>>
>> u32 xe_guc_pc_get_act_freq(struct xe_guc_pc *pc);
>> int xe_guc_pc_get_cur_freq(struct xe_guc_pc *pc, u32 *freq);
>> diff --git a/drivers/gpu/drm/xe/xe_guc_rc.c b/drivers/gpu/drm/xe/xe_guc_rc.c
>> index fc57e5290635..0a900c309ecf 100644
>> --- a/drivers/gpu/drm/xe/xe_guc_rc.c
>> +++ b/drivers/gpu/drm/xe/xe_guc_rc.c
>> @@ -14,6 +14,7 @@
>> #include "xe_gt_printk.h"
>> #include "xe_guc.h"
>> #include "xe_guc_ct.h"
>> +#include "xe_guc_pc.h"
>> #include "xe_guc_rc.h"
>> #include "xe_pm.h"
>>
>> @@ -112,3 +113,32 @@ int xe_guc_rc_enable(struct xe_guc *guc)
>>
>> return guc_action_setup_gucrc(guc, GUCRC_FIRMWARE_CONTROL);
>> }
>> +
>> +/**
>> + * xe_guc_rc_set_mode() - set GUCRC mode
>> + * @guc: Xe GuC instance
>> + * @mode: new value of the mode.
>> + *
>> + * Function to set GuC RC mode to one of the enum values.
>> + *
>> + * Returns: 0 on success, negative error code on error
>> + */
>> +int xe_guc_rc_set_mode(struct xe_guc *guc, enum slpc_gucrc_mode mode)
>> +{
>> + guard(xe_pm_runtime)(guc_to_xe(guc));
> are we sure we want to do full resume here?
> maybe it should be:
>
> guard(xe_pm_runtime_noresume)
>
>> + return xe_guc_pc_action_set_param(&guc->pc, SLPC_PARAM_PWRGATE_RC_MODE, mode);
>> +}
>> +
>> +/**
>> + * xe_guc_rc_unset_mode() - revert to default mode
>> + * @guc: Xe GuC instance
>> + *
>> + * Function to revert GuC RC mode to platform defaults.
>> + *
>> + * Returns: 0 on success, negative error code on error
>> + */
>> +int xe_guc_rc_unset_mode(struct xe_guc *guc)
>> +{
>> + guard(xe_pm_runtime)(guc_to_xe(guc));
> ditto
ok.
>
>> + return xe_guc_pc_action_unset_param(&guc->pc, SLPC_PARAM_PWRGATE_RC_MODE);
>> +}
>> diff --git a/drivers/gpu/drm/xe/xe_guc_rc.h b/drivers/gpu/drm/xe/xe_guc_rc.h
>> index c980b0fce472..d76dfad8e26c 100644
>> --- a/drivers/gpu/drm/xe/xe_guc_rc.h
>> +++ b/drivers/gpu/drm/xe/xe_guc_rc.h
>> @@ -7,8 +7,11 @@
>> #define _XE_GUC_RC_H_
>>
>> struct xe_guc;
>> +enum slpc_gucrc_mode;
>>
>> void xe_guc_rc_disable(struct xe_guc *guc);
>> int xe_guc_rc_enable(struct xe_guc *guc);
>> +int xe_guc_rc_set_mode(struct xe_guc *guc, enum slpc_gucrc_mode mode);
>> +int xe_guc_rc_unset_mode(struct xe_guc *guc);
>>
>> #endif
>> diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
>> index abf87fe0b345..f7752719b74f 100644
>> --- a/drivers/gpu/drm/xe/xe_oa.c
>> +++ b/drivers/gpu/drm/xe/xe_oa.c
>> @@ -29,7 +29,7 @@
>> #include "xe_gt.h"
>> #include "xe_gt_mcr.h"
>> #include "xe_gt_printk.h"
>> -#include "xe_guc_pc.h"
>> +#include "xe_guc_rc.h"
>> #include "xe_macros.h"
>> #include "xe_mmio.h"
>> #include "xe_oa.h"
>> @@ -875,7 +875,7 @@ static void xe_oa_stream_destroy(struct xe_oa_stream *stream)
>>
>> /* Wa_1509372804:pvc: Unset the override of GUCRC mode to enable rc6 */
>> if (stream->override_gucrc)
>> - xe_gt_WARN_ON(gt, xe_guc_pc_unset_gucrc_mode(>->uc.guc.pc));
>> + xe_gt_WARN_ON(gt, xe_guc_rc_unset_mode(>->uc.guc));
> as return real error code, not bool, maybe we should also print it?
We already print it in the lower level function pc_action_unset_param().
>
>>
>> xe_oa_free_configs(stream);
>> xe_file_put(stream->xef);
>> @@ -1765,8 +1765,7 @@ static int xe_oa_stream_init(struct xe_oa_stream *stream,
>> * state. Prevent this by overriding GUCRC mode.
>> */
>> if (XE_GT_WA(stream->gt, 1509372804)) {
>> - ret = xe_guc_pc_override_gucrc_mode(>->uc.guc.pc,
>> - SLPC_GUCRC_MODE_GUCRC_NO_RC6);
>> + ret = xe_guc_rc_set_mode(>->uc.guc, SLPC_GUCRC_MODE_GUCRC_NO_RC6);
>> if (ret)
>> goto err_free_configs;
>>
>> @@ -1824,7 +1823,7 @@ static int xe_oa_stream_init(struct xe_oa_stream *stream,
>> xe_force_wake_put(gt_to_fw(gt), stream->fw_ref);
>> xe_pm_runtime_put(stream->oa->xe);
> we should just place guc_rc calls when we still are holding rpm
For now, that seems to be true. But if someone introduces a sysfs
interface later on and forgets to add a runtime_get(), it's better to
have it in the guc_rc function as well?
Thanks,
Vinay.
>
>> if (stream->override_gucrc)
>> - xe_gt_WARN_ON(gt, xe_guc_pc_unset_gucrc_mode(>->uc.guc.pc));
>> + xe_gt_WARN_ON(gt, xe_guc_rc_unset_mode(>->uc.guc));
>> err_free_configs:
>> xe_oa_free_configs(stream);
>> exit:
^ permalink raw reply [flat|nested] 11+ messages in thread
* ✗ CI.checkpatch: warning for drm/xe: Separate out GuC RC code (rev3)
2026-01-23 23:50 [PATCH v6 0/2] drm/xe: Separate out GuC RC code Vinay Belgaumkar
2026-01-23 23:50 ` [PATCH v6 1/2] drm/xe: Decouple GuC RC code from xe_guc_pc Vinay Belgaumkar
2026-01-23 23:50 ` [PATCH v6 2/2] drm/xe: Add a wrapper for set/unset params Vinay Belgaumkar
@ 2026-01-24 0:20 ` Patchwork
2026-01-24 0:21 ` ✓ CI.KUnit: success " Patchwork
2026-01-24 8:22 ` ✗ Xe.CI.Full: failure " Patchwork
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2026-01-24 0:20 UTC (permalink / raw)
To: Vinay Belgaumkar; +Cc: intel-xe
== Series Details ==
Series: drm/xe: Separate out GuC RC code (rev3)
URL : https://patchwork.freedesktop.org/series/158581/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
1f57ba1afceae32108bd24770069f764d940a0e4
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit af4b7dc9e2bb5271e8cbf90583598206363a371b
Author: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Date: Fri Jan 23 15:50:27 2026 -0800
drm/xe: Add a wrapper for set/unset params
Also, extract out the GuC RC related set/unset param functions
into xe_guc_rc file. GuC still allows us to override GuC RC mode
using an SLPC H2G interface. Continue to use that interface, but
move the related code to the newly created xe_guc_rc file.
v2: xe_guc_rc functions to use guc pointer instead of gt (Michal W)
v3: Assert if runtime pm ref is not held (Michal W)
v4: Review comments (Riana)
Cc: Riana Tauro <riana.tauro@intel.com>
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
+ /mt/dim checkpatch 314da883f703c9a9f908648c3acc6c05a6c6730e drm-intel
65149893246b drm/xe: Decouple GuC RC code from xe_guc_pc
-:221: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#221:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 320 lines checked
af4b7dc9e2bb drm/xe: Add a wrapper for set/unset params
^ permalink raw reply [flat|nested] 11+ messages in thread* ✓ CI.KUnit: success for drm/xe: Separate out GuC RC code (rev3)
2026-01-23 23:50 [PATCH v6 0/2] drm/xe: Separate out GuC RC code Vinay Belgaumkar
` (2 preceding siblings ...)
2026-01-24 0:20 ` ✗ CI.checkpatch: warning for drm/xe: Separate out GuC RC code (rev3) Patchwork
@ 2026-01-24 0:21 ` Patchwork
2026-01-24 8:22 ` ✗ Xe.CI.Full: failure " Patchwork
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2026-01-24 0:21 UTC (permalink / raw)
To: Vinay Belgaumkar; +Cc: intel-xe
== Series Details ==
Series: drm/xe: Separate out GuC RC code (rev3)
URL : https://patchwork.freedesktop.org/series/158581/
State : success
== Summary ==
+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig
[00:20:29] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[00:20:33] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[00:21:05] Starting KUnit Kernel (1/1)...
[00:21:05] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[00:21:05] ================== guc_buf (11 subtests) ===================
[00:21:05] [PASSED] test_smallest
[00:21:05] [PASSED] test_largest
[00:21:05] [PASSED] test_granular
[00:21:05] [PASSED] test_unique
[00:21:05] [PASSED] test_overlap
[00:21:05] [PASSED] test_reusable
[00:21:05] [PASSED] test_too_big
[00:21:05] [PASSED] test_flush
[00:21:05] [PASSED] test_lookup
[00:21:05] [PASSED] test_data
[00:21:05] [PASSED] test_class
[00:21:05] ===================== [PASSED] guc_buf =====================
[00:21:05] =================== guc_dbm (7 subtests) ===================
[00:21:05] [PASSED] test_empty
[00:21:05] [PASSED] test_default
[00:21:05] ======================== test_size ========================
[00:21:05] [PASSED] 4
[00:21:05] [PASSED] 8
[00:21:05] [PASSED] 32
[00:21:05] [PASSED] 256
[00:21:05] ==================== [PASSED] test_size ====================
[00:21:05] ======================= test_reuse ========================
[00:21:05] [PASSED] 4
[00:21:05] [PASSED] 8
[00:21:05] [PASSED] 32
[00:21:05] [PASSED] 256
[00:21:05] =================== [PASSED] test_reuse ====================
[00:21:05] =================== test_range_overlap ====================
[00:21:05] [PASSED] 4
[00:21:05] [PASSED] 8
[00:21:05] [PASSED] 32
[00:21:05] [PASSED] 256
[00:21:05] =============== [PASSED] test_range_overlap ================
[00:21:05] =================== test_range_compact ====================
[00:21:05] [PASSED] 4
[00:21:05] [PASSED] 8
[00:21:05] [PASSED] 32
[00:21:05] [PASSED] 256
[00:21:05] =============== [PASSED] test_range_compact ================
[00:21:05] ==================== test_range_spare =====================
[00:21:05] [PASSED] 4
[00:21:05] [PASSED] 8
[00:21:05] [PASSED] 32
[00:21:05] [PASSED] 256
[00:21:05] ================ [PASSED] test_range_spare =================
[00:21:05] ===================== [PASSED] guc_dbm =====================
[00:21:05] =================== guc_idm (6 subtests) ===================
[00:21:05] [PASSED] bad_init
[00:21:05] [PASSED] no_init
[00:21:05] [PASSED] init_fini
[00:21:05] [PASSED] check_used
[00:21:05] [PASSED] check_quota
[00:21:05] [PASSED] check_all
[00:21:05] ===================== [PASSED] guc_idm =====================
[00:21:05] ================== no_relay (3 subtests) ===================
[00:21:05] [PASSED] xe_drops_guc2pf_if_not_ready
[00:21:05] [PASSED] xe_drops_guc2vf_if_not_ready
[00:21:05] [PASSED] xe_rejects_send_if_not_ready
[00:21:05] ==================== [PASSED] no_relay =====================
[00:21:05] ================== pf_relay (14 subtests) ==================
[00:21:05] [PASSED] pf_rejects_guc2pf_too_short
[00:21:05] [PASSED] pf_rejects_guc2pf_too_long
[00:21:05] [PASSED] pf_rejects_guc2pf_no_payload
[00:21:05] [PASSED] pf_fails_no_payload
[00:21:05] [PASSED] pf_fails_bad_origin
[00:21:05] [PASSED] pf_fails_bad_type
[00:21:05] [PASSED] pf_txn_reports_error
[00:21:05] [PASSED] pf_txn_sends_pf2guc
[00:21:05] [PASSED] pf_sends_pf2guc
[00:21:05] [SKIPPED] pf_loopback_nop
[00:21:05] [SKIPPED] pf_loopback_echo
[00:21:05] [SKIPPED] pf_loopback_fail
[00:21:05] [SKIPPED] pf_loopback_busy
[00:21:05] [SKIPPED] pf_loopback_retry
[00:21:05] ==================== [PASSED] pf_relay =====================
[00:21:05] ================== vf_relay (3 subtests) ===================
[00:21:05] [PASSED] vf_rejects_guc2vf_too_short
[00:21:05] [PASSED] vf_rejects_guc2vf_too_long
[00:21:05] [PASSED] vf_rejects_guc2vf_no_payload
[00:21:05] ==================== [PASSED] vf_relay =====================
[00:21:05] ================ pf_gt_config (6 subtests) =================
[00:21:05] [PASSED] fair_contexts_1vf
[00:21:05] [PASSED] fair_doorbells_1vf
[00:21:05] [PASSED] fair_ggtt_1vf
[00:21:05] ====================== fair_contexts ======================
[00:21:05] [PASSED] 1 VF
[00:21:05] [PASSED] 2 VFs
[00:21:05] [PASSED] 3 VFs
[00:21:05] [PASSED] 4 VFs
[00:21:05] [PASSED] 5 VFs
[00:21:05] [PASSED] 6 VFs
[00:21:05] [PASSED] 7 VFs
[00:21:05] [PASSED] 8 VFs
[00:21:05] [PASSED] 9 VFs
[00:21:05] [PASSED] 10 VFs
[00:21:05] [PASSED] 11 VFs
[00:21:05] [PASSED] 12 VFs
[00:21:05] [PASSED] 13 VFs
[00:21:05] [PASSED] 14 VFs
[00:21:05] [PASSED] 15 VFs
[00:21:05] [PASSED] 16 VFs
[00:21:05] [PASSED] 17 VFs
[00:21:05] [PASSED] 18 VFs
[00:21:05] [PASSED] 19 VFs
[00:21:05] [PASSED] 20 VFs
[00:21:05] [PASSED] 21 VFs
[00:21:05] [PASSED] 22 VFs
[00:21:05] [PASSED] 23 VFs
[00:21:05] [PASSED] 24 VFs
[00:21:05] [PASSED] 25 VFs
[00:21:05] [PASSED] 26 VFs
[00:21:05] [PASSED] 27 VFs
[00:21:05] [PASSED] 28 VFs
[00:21:05] [PASSED] 29 VFs
[00:21:05] [PASSED] 30 VFs
[00:21:05] [PASSED] 31 VFs
[00:21:05] [PASSED] 32 VFs
[00:21:05] [PASSED] 33 VFs
[00:21:05] [PASSED] 34 VFs
[00:21:05] [PASSED] 35 VFs
[00:21:05] [PASSED] 36 VFs
[00:21:05] [PASSED] 37 VFs
[00:21:05] [PASSED] 38 VFs
[00:21:05] [PASSED] 39 VFs
[00:21:05] [PASSED] 40 VFs
[00:21:05] [PASSED] 41 VFs
[00:21:05] [PASSED] 42 VFs
[00:21:05] [PASSED] 43 VFs
[00:21:05] [PASSED] 44 VFs
[00:21:05] [PASSED] 45 VFs
[00:21:05] [PASSED] 46 VFs
[00:21:05] [PASSED] 47 VFs
[00:21:05] [PASSED] 48 VFs
[00:21:05] [PASSED] 49 VFs
[00:21:05] [PASSED] 50 VFs
[00:21:05] [PASSED] 51 VFs
[00:21:05] [PASSED] 52 VFs
[00:21:05] [PASSED] 53 VFs
[00:21:05] [PASSED] 54 VFs
[00:21:05] [PASSED] 55 VFs
[00:21:05] [PASSED] 56 VFs
[00:21:05] [PASSED] 57 VFs
[00:21:05] [PASSED] 58 VFs
[00:21:05] [PASSED] 59 VFs
[00:21:05] [PASSED] 60 VFs
[00:21:05] [PASSED] 61 VFs
[00:21:05] [PASSED] 62 VFs
[00:21:05] [PASSED] 63 VFs
[00:21:05] ================== [PASSED] fair_contexts ==================
[00:21:05] ===================== fair_doorbells ======================
[00:21:05] [PASSED] 1 VF
[00:21:05] [PASSED] 2 VFs
[00:21:05] [PASSED] 3 VFs
[00:21:05] [PASSED] 4 VFs
[00:21:05] [PASSED] 5 VFs
[00:21:05] [PASSED] 6 VFs
[00:21:05] [PASSED] 7 VFs
[00:21:05] [PASSED] 8 VFs
[00:21:05] [PASSED] 9 VFs
[00:21:05] [PASSED] 10 VFs
[00:21:05] [PASSED] 11 VFs
[00:21:05] [PASSED] 12 VFs
[00:21:05] [PASSED] 13 VFs
[00:21:05] [PASSED] 14 VFs
[00:21:05] [PASSED] 15 VFs
[00:21:05] [PASSED] 16 VFs
[00:21:05] [PASSED] 17 VFs
[00:21:05] [PASSED] 18 VFs
[00:21:05] [PASSED] 19 VFs
[00:21:05] [PASSED] 20 VFs
[00:21:05] [PASSED] 21 VFs
[00:21:05] [PASSED] 22 VFs
[00:21:05] [PASSED] 23 VFs
[00:21:05] [PASSED] 24 VFs
[00:21:05] [PASSED] 25 VFs
[00:21:05] [PASSED] 26 VFs
[00:21:05] [PASSED] 27 VFs
[00:21:05] [PASSED] 28 VFs
[00:21:05] [PASSED] 29 VFs
[00:21:05] [PASSED] 30 VFs
[00:21:05] [PASSED] 31 VFs
[00:21:05] [PASSED] 32 VFs
[00:21:05] [PASSED] 33 VFs
[00:21:05] [PASSED] 34 VFs
[00:21:05] [PASSED] 35 VFs
[00:21:05] [PASSED] 36 VFs
[00:21:05] [PASSED] 37 VFs
[00:21:05] [PASSED] 38 VFs
[00:21:05] [PASSED] 39 VFs
[00:21:05] [PASSED] 40 VFs
[00:21:05] [PASSED] 41 VFs
[00:21:05] [PASSED] 42 VFs
[00:21:05] [PASSED] 43 VFs
[00:21:05] [PASSED] 44 VFs
[00:21:05] [PASSED] 45 VFs
[00:21:05] [PASSED] 46 VFs
[00:21:05] [PASSED] 47 VFs
[00:21:05] [PASSED] 48 VFs
[00:21:05] [PASSED] 49 VFs
[00:21:05] [PASSED] 50 VFs
[00:21:05] [PASSED] 51 VFs
[00:21:05] [PASSED] 52 VFs
[00:21:05] [PASSED] 53 VFs
[00:21:05] [PASSED] 54 VFs
[00:21:05] [PASSED] 55 VFs
[00:21:05] [PASSED] 56 VFs
[00:21:05] [PASSED] 57 VFs
[00:21:05] [PASSED] 58 VFs
[00:21:05] [PASSED] 59 VFs
[00:21:05] [PASSED] 60 VFs
[00:21:05] [PASSED] 61 VFs
[00:21:05] [PASSED] 62 VFs
[00:21:05] [PASSED] 63 VFs
[00:21:05] ================= [PASSED] fair_doorbells ==================
[00:21:05] ======================== fair_ggtt ========================
[00:21:05] [PASSED] 1 VF
[00:21:05] [PASSED] 2 VFs
[00:21:05] [PASSED] 3 VFs
[00:21:05] [PASSED] 4 VFs
[00:21:05] [PASSED] 5 VFs
[00:21:05] [PASSED] 6 VFs
[00:21:05] [PASSED] 7 VFs
[00:21:05] [PASSED] 8 VFs
[00:21:05] [PASSED] 9 VFs
[00:21:05] [PASSED] 10 VFs
[00:21:05] [PASSED] 11 VFs
[00:21:05] [PASSED] 12 VFs
[00:21:05] [PASSED] 13 VFs
[00:21:05] [PASSED] 14 VFs
[00:21:05] [PASSED] 15 VFs
[00:21:05] [PASSED] 16 VFs
[00:21:05] [PASSED] 17 VFs
[00:21:05] [PASSED] 18 VFs
[00:21:05] [PASSED] 19 VFs
[00:21:05] [PASSED] 20 VFs
[00:21:05] [PASSED] 21 VFs
[00:21:05] [PASSED] 22 VFs
[00:21:05] [PASSED] 23 VFs
[00:21:05] [PASSED] 24 VFs
[00:21:05] [PASSED] 25 VFs
[00:21:05] [PASSED] 26 VFs
[00:21:05] [PASSED] 27 VFs
[00:21:05] [PASSED] 28 VFs
[00:21:05] [PASSED] 29 VFs
[00:21:05] [PASSED] 30 VFs
[00:21:05] [PASSED] 31 VFs
[00:21:05] [PASSED] 32 VFs
[00:21:05] [PASSED] 33 VFs
[00:21:05] [PASSED] 34 VFs
[00:21:05] [PASSED] 35 VFs
[00:21:05] [PASSED] 36 VFs
[00:21:05] [PASSED] 37 VFs
[00:21:05] [PASSED] 38 VFs
[00:21:05] [PASSED] 39 VFs
[00:21:05] [PASSED] 40 VFs
[00:21:05] [PASSED] 41 VFs
[00:21:05] [PASSED] 42 VFs
[00:21:05] [PASSED] 43 VFs
[00:21:05] [PASSED] 44 VFs
[00:21:05] [PASSED] 45 VFs
[00:21:05] [PASSED] 46 VFs
[00:21:05] [PASSED] 47 VFs
[00:21:05] [PASSED] 48 VFs
[00:21:05] [PASSED] 49 VFs
[00:21:05] [PASSED] 50 VFs
[00:21:05] [PASSED] 51 VFs
[00:21:05] [PASSED] 52 VFs
[00:21:05] [PASSED] 53 VFs
[00:21:05] [PASSED] 54 VFs
[00:21:05] [PASSED] 55 VFs
[00:21:05] [PASSED] 56 VFs
[00:21:05] [PASSED] 57 VFs
[00:21:05] [PASSED] 58 VFs
[00:21:05] [PASSED] 59 VFs
[00:21:05] [PASSED] 60 VFs
[00:21:05] [PASSED] 61 VFs
[00:21:05] [PASSED] 62 VFs
[00:21:05] [PASSED] 63 VFs
[00:21:05] ==================== [PASSED] fair_ggtt ====================
[00:21:05] ================== [PASSED] pf_gt_config ===================
[00:21:05] ===================== lmtt (1 subtest) =====================
[00:21:05] ======================== test_ops =========================
[00:21:05] [PASSED] 2-level
[00:21:05] [PASSED] multi-level
[00:21:05] ==================== [PASSED] test_ops =====================
[00:21:05] ====================== [PASSED] lmtt =======================
[00:21:05] ================= pf_service (11 subtests) =================
[00:21:05] [PASSED] pf_negotiate_any
[00:21:05] [PASSED] pf_negotiate_base_match
[00:21:05] [PASSED] pf_negotiate_base_newer
[00:21:05] [PASSED] pf_negotiate_base_next
[00:21:05] [SKIPPED] pf_negotiate_base_older
[00:21:05] [PASSED] pf_negotiate_base_prev
[00:21:05] [PASSED] pf_negotiate_latest_match
[00:21:05] [PASSED] pf_negotiate_latest_newer
[00:21:05] [PASSED] pf_negotiate_latest_next
[00:21:05] [SKIPPED] pf_negotiate_latest_older
[00:21:05] [SKIPPED] pf_negotiate_latest_prev
[00:21:05] =================== [PASSED] pf_service ====================
[00:21:05] ================= xe_guc_g2g (2 subtests) ==================
[00:21:05] ============== xe_live_guc_g2g_kunit_default ==============
[00:21:05] ========= [SKIPPED] xe_live_guc_g2g_kunit_default ==========
[00:21:05] ============== xe_live_guc_g2g_kunit_allmem ===============
[00:21:05] ========== [SKIPPED] xe_live_guc_g2g_kunit_allmem ==========
[00:21:05] =================== [SKIPPED] xe_guc_g2g ===================
[00:21:05] =================== xe_mocs (2 subtests) ===================
[00:21:05] ================ xe_live_mocs_kernel_kunit ================
[00:21:05] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============
[00:21:05] ================ xe_live_mocs_reset_kunit =================
[00:21:05] ============ [SKIPPED] xe_live_mocs_reset_kunit ============
[00:21:05] ==================== [SKIPPED] xe_mocs =====================
[00:21:05] ================= xe_migrate (2 subtests) ==================
[00:21:05] ================= xe_migrate_sanity_kunit =================
[00:21:05] ============ [SKIPPED] xe_migrate_sanity_kunit =============
[00:21:05] ================== xe_validate_ccs_kunit ==================
[00:21:05] ============= [SKIPPED] xe_validate_ccs_kunit ==============
[00:21:05] =================== [SKIPPED] xe_migrate ===================
[00:21:05] ================== xe_dma_buf (1 subtest) ==================
[00:21:05] ==================== xe_dma_buf_kunit =====================
[00:21:05] ================ [SKIPPED] xe_dma_buf_kunit ================
[00:21:05] =================== [SKIPPED] xe_dma_buf ===================
[00:21:05] ================= xe_bo_shrink (1 subtest) =================
[00:21:05] =================== xe_bo_shrink_kunit ====================
[00:21:05] =============== [SKIPPED] xe_bo_shrink_kunit ===============
[00:21:05] ================== [SKIPPED] xe_bo_shrink ==================
[00:21:05] ==================== xe_bo (2 subtests) ====================
[00:21:05] ================== xe_ccs_migrate_kunit ===================
[00:21:05] ============== [SKIPPED] xe_ccs_migrate_kunit ==============
[00:21:05] ==================== xe_bo_evict_kunit ====================
[00:21:05] =============== [SKIPPED] xe_bo_evict_kunit ================
[00:21:05] ===================== [SKIPPED] xe_bo ======================
[00:21:05] ==================== args (13 subtests) ====================
[00:21:05] [PASSED] count_args_test
[00:21:05] [PASSED] call_args_example
[00:21:05] [PASSED] call_args_test
[00:21:05] [PASSED] drop_first_arg_example
[00:21:05] [PASSED] drop_first_arg_test
[00:21:05] [PASSED] first_arg_example
[00:21:05] [PASSED] first_arg_test
[00:21:05] [PASSED] last_arg_example
[00:21:05] [PASSED] last_arg_test
[00:21:05] [PASSED] pick_arg_example
[00:21:05] [PASSED] if_args_example
[00:21:05] [PASSED] if_args_test
[00:21:05] [PASSED] sep_comma_example
[00:21:05] ====================== [PASSED] args =======================
[00:21:05] =================== xe_pci (3 subtests) ====================
[00:21:05] ==================== check_graphics_ip ====================
[00:21:05] [PASSED] 12.00 Xe_LP
[00:21:05] [PASSED] 12.10 Xe_LP+
[00:21:05] [PASSED] 12.55 Xe_HPG
[00:21:05] [PASSED] 12.60 Xe_HPC
[00:21:05] [PASSED] 12.70 Xe_LPG
[00:21:05] [PASSED] 12.71 Xe_LPG
[00:21:05] [PASSED] 12.74 Xe_LPG+
[00:21:05] [PASSED] 20.01 Xe2_HPG
[00:21:05] [PASSED] 20.02 Xe2_HPG
[00:21:05] [PASSED] 20.04 Xe2_LPG
[00:21:05] [PASSED] 30.00 Xe3_LPG
[00:21:05] [PASSED] 30.01 Xe3_LPG
[00:21:05] [PASSED] 30.03 Xe3_LPG
[00:21:05] [PASSED] 30.04 Xe3_LPG
[00:21:05] [PASSED] 30.05 Xe3_LPG
[00:21:05] [PASSED] 35.11 Xe3p_XPC
[00:21:05] ================ [PASSED] check_graphics_ip ================
[00:21:05] ===================== check_media_ip ======================
[00:21:05] [PASSED] 12.00 Xe_M
[00:21:05] [PASSED] 12.55 Xe_HPM
[00:21:05] [PASSED] 13.00 Xe_LPM+
[00:21:05] [PASSED] 13.01 Xe2_HPM
[00:21:05] [PASSED] 20.00 Xe2_LPM
[00:21:05] [PASSED] 30.00 Xe3_LPM
[00:21:05] [PASSED] 30.02 Xe3_LPM
[00:21:05] [PASSED] 35.00 Xe3p_LPM
[00:21:05] [PASSED] 35.03 Xe3p_HPM
[00:21:05] ================= [PASSED] check_media_ip ==================
[00:21:05] =================== check_platform_desc ===================
[00:21:05] [PASSED] 0x9A60 (TIGERLAKE)
[00:21:05] [PASSED] 0x9A68 (TIGERLAKE)
[00:21:05] [PASSED] 0x9A70 (TIGERLAKE)
[00:21:05] [PASSED] 0x9A40 (TIGERLAKE)
[00:21:05] [PASSED] 0x9A49 (TIGERLAKE)
[00:21:05] [PASSED] 0x9A59 (TIGERLAKE)
[00:21:05] [PASSED] 0x9A78 (TIGERLAKE)
[00:21:05] [PASSED] 0x9AC0 (TIGERLAKE)
[00:21:05] [PASSED] 0x9AC9 (TIGERLAKE)
[00:21:05] [PASSED] 0x9AD9 (TIGERLAKE)
[00:21:05] [PASSED] 0x9AF8 (TIGERLAKE)
[00:21:05] [PASSED] 0x4C80 (ROCKETLAKE)
[00:21:05] [PASSED] 0x4C8A (ROCKETLAKE)
[00:21:05] [PASSED] 0x4C8B (ROCKETLAKE)
[00:21:05] [PASSED] 0x4C8C (ROCKETLAKE)
[00:21:05] [PASSED] 0x4C90 (ROCKETLAKE)
[00:21:05] [PASSED] 0x4C9A (ROCKETLAKE)
[00:21:05] [PASSED] 0x4680 (ALDERLAKE_S)
[00:21:05] [PASSED] 0x4682 (ALDERLAKE_S)
[00:21:05] [PASSED] 0x4688 (ALDERLAKE_S)
[00:21:05] [PASSED] 0x468A (ALDERLAKE_S)
[00:21:05] [PASSED] 0x468B (ALDERLAKE_S)
[00:21:05] [PASSED] 0x4690 (ALDERLAKE_S)
[00:21:05] [PASSED] 0x4692 (ALDERLAKE_S)
[00:21:05] [PASSED] 0x4693 (ALDERLAKE_S)
[00:21:05] [PASSED] 0x46A0 (ALDERLAKE_P)
[00:21:05] [PASSED] 0x46A1 (ALDERLAKE_P)
[00:21:05] [PASSED] 0x46A2 (ALDERLAKE_P)
[00:21:05] [PASSED] 0x46A3 (ALDERLAKE_P)
[00:21:05] [PASSED] 0x46A6 (ALDERLAKE_P)
[00:21:05] [PASSED] 0x46A8 (ALDERLAKE_P)
[00:21:05] [PASSED] 0x46AA (ALDERLAKE_P)
[00:21:05] [PASSED] 0x462A (ALDERLAKE_P)
[00:21:05] [PASSED] 0x4626 (ALDERLAKE_P)
[00:21:05] [PASSED] 0x4628 (ALDERLAKE_P)
stty: 'standard input': Inappropriate ioctl for device
[00:21:05] [PASSED] 0x46B0 (ALDERLAKE_P)
[00:21:05] [PASSED] 0x46B1 (ALDERLAKE_P)
[00:21:05] [PASSED] 0x46B2 (ALDERLAKE_P)
[00:21:05] [PASSED] 0x46B3 (ALDERLAKE_P)
[00:21:05] [PASSED] 0x46C0 (ALDERLAKE_P)
[00:21:05] [PASSED] 0x46C1 (ALDERLAKE_P)
[00:21:05] [PASSED] 0x46C2 (ALDERLAKE_P)
[00:21:05] [PASSED] 0x46C3 (ALDERLAKE_P)
[00:21:05] [PASSED] 0x46D0 (ALDERLAKE_N)
[00:21:05] [PASSED] 0x46D1 (ALDERLAKE_N)
[00:21:05] [PASSED] 0x46D2 (ALDERLAKE_N)
[00:21:05] [PASSED] 0x46D3 (ALDERLAKE_N)
[00:21:05] [PASSED] 0x46D4 (ALDERLAKE_N)
[00:21:05] [PASSED] 0xA721 (ALDERLAKE_P)
[00:21:05] [PASSED] 0xA7A1 (ALDERLAKE_P)
[00:21:05] [PASSED] 0xA7A9 (ALDERLAKE_P)
[00:21:05] [PASSED] 0xA7AC (ALDERLAKE_P)
[00:21:05] [PASSED] 0xA7AD (ALDERLAKE_P)
[00:21:05] [PASSED] 0xA720 (ALDERLAKE_P)
[00:21:05] [PASSED] 0xA7A0 (ALDERLAKE_P)
[00:21:05] [PASSED] 0xA7A8 (ALDERLAKE_P)
[00:21:05] [PASSED] 0xA7AA (ALDERLAKE_P)
[00:21:05] [PASSED] 0xA7AB (ALDERLAKE_P)
[00:21:05] [PASSED] 0xA780 (ALDERLAKE_S)
[00:21:05] [PASSED] 0xA781 (ALDERLAKE_S)
[00:21:05] [PASSED] 0xA782 (ALDERLAKE_S)
[00:21:05] [PASSED] 0xA783 (ALDERLAKE_S)
[00:21:05] [PASSED] 0xA788 (ALDERLAKE_S)
[00:21:05] [PASSED] 0xA789 (ALDERLAKE_S)
[00:21:05] [PASSED] 0xA78A (ALDERLAKE_S)
[00:21:05] [PASSED] 0xA78B (ALDERLAKE_S)
[00:21:05] [PASSED] 0x4905 (DG1)
[00:21:05] [PASSED] 0x4906 (DG1)
[00:21:05] [PASSED] 0x4907 (DG1)
[00:21:05] [PASSED] 0x4908 (DG1)
[00:21:05] [PASSED] 0x4909 (DG1)
[00:21:05] [PASSED] 0x56C0 (DG2)
[00:21:05] [PASSED] 0x56C2 (DG2)
[00:21:05] [PASSED] 0x56C1 (DG2)
[00:21:05] [PASSED] 0x7D51 (METEORLAKE)
[00:21:05] [PASSED] 0x7DD1 (METEORLAKE)
[00:21:05] [PASSED] 0x7D41 (METEORLAKE)
[00:21:05] [PASSED] 0x7D67 (METEORLAKE)
[00:21:05] [PASSED] 0xB640 (METEORLAKE)
[00:21:05] [PASSED] 0x56A0 (DG2)
[00:21:05] [PASSED] 0x56A1 (DG2)
[00:21:05] [PASSED] 0x56A2 (DG2)
[00:21:05] [PASSED] 0x56BE (DG2)
[00:21:05] [PASSED] 0x56BF (DG2)
[00:21:05] [PASSED] 0x5690 (DG2)
[00:21:05] [PASSED] 0x5691 (DG2)
[00:21:05] [PASSED] 0x5692 (DG2)
[00:21:05] [PASSED] 0x56A5 (DG2)
[00:21:05] [PASSED] 0x56A6 (DG2)
[00:21:05] [PASSED] 0x56B0 (DG2)
[00:21:05] [PASSED] 0x56B1 (DG2)
[00:21:05] [PASSED] 0x56BA (DG2)
[00:21:05] [PASSED] 0x56BB (DG2)
[00:21:05] [PASSED] 0x56BC (DG2)
[00:21:05] [PASSED] 0x56BD (DG2)
[00:21:05] [PASSED] 0x5693 (DG2)
[00:21:05] [PASSED] 0x5694 (DG2)
[00:21:05] [PASSED] 0x5695 (DG2)
[00:21:05] [PASSED] 0x56A3 (DG2)
[00:21:05] [PASSED] 0x56A4 (DG2)
[00:21:05] [PASSED] 0x56B2 (DG2)
[00:21:05] [PASSED] 0x56B3 (DG2)
[00:21:05] [PASSED] 0x5696 (DG2)
[00:21:05] [PASSED] 0x5697 (DG2)
[00:21:05] [PASSED] 0xB69 (PVC)
[00:21:05] [PASSED] 0xB6E (PVC)
[00:21:05] [PASSED] 0xBD4 (PVC)
[00:21:05] [PASSED] 0xBD5 (PVC)
[00:21:05] [PASSED] 0xBD6 (PVC)
[00:21:05] [PASSED] 0xBD7 (PVC)
[00:21:05] [PASSED] 0xBD8 (PVC)
[00:21:05] [PASSED] 0xBD9 (PVC)
[00:21:05] [PASSED] 0xBDA (PVC)
[00:21:05] [PASSED] 0xBDB (PVC)
[00:21:05] [PASSED] 0xBE0 (PVC)
[00:21:05] [PASSED] 0xBE1 (PVC)
[00:21:05] [PASSED] 0xBE5 (PVC)
[00:21:05] [PASSED] 0x7D40 (METEORLAKE)
[00:21:05] [PASSED] 0x7D45 (METEORLAKE)
[00:21:05] [PASSED] 0x7D55 (METEORLAKE)
[00:21:05] [PASSED] 0x7D60 (METEORLAKE)
[00:21:05] [PASSED] 0x7DD5 (METEORLAKE)
[00:21:05] [PASSED] 0x6420 (LUNARLAKE)
[00:21:05] [PASSED] 0x64A0 (LUNARLAKE)
[00:21:05] [PASSED] 0x64B0 (LUNARLAKE)
[00:21:05] [PASSED] 0xE202 (BATTLEMAGE)
[00:21:05] [PASSED] 0xE209 (BATTLEMAGE)
[00:21:05] [PASSED] 0xE20B (BATTLEMAGE)
[00:21:05] [PASSED] 0xE20C (BATTLEMAGE)
[00:21:05] [PASSED] 0xE20D (BATTLEMAGE)
[00:21:05] [PASSED] 0xE210 (BATTLEMAGE)
[00:21:05] [PASSED] 0xE211 (BATTLEMAGE)
[00:21:05] [PASSED] 0xE212 (BATTLEMAGE)
[00:21:05] [PASSED] 0xE216 (BATTLEMAGE)
[00:21:05] [PASSED] 0xE220 (BATTLEMAGE)
[00:21:05] [PASSED] 0xE221 (BATTLEMAGE)
[00:21:05] [PASSED] 0xE222 (BATTLEMAGE)
[00:21:05] [PASSED] 0xE223 (BATTLEMAGE)
[00:21:05] [PASSED] 0xB080 (PANTHERLAKE)
[00:21:05] [PASSED] 0xB081 (PANTHERLAKE)
[00:21:05] [PASSED] 0xB082 (PANTHERLAKE)
[00:21:05] [PASSED] 0xB083 (PANTHERLAKE)
[00:21:05] [PASSED] 0xB084 (PANTHERLAKE)
[00:21:05] [PASSED] 0xB085 (PANTHERLAKE)
[00:21:05] [PASSED] 0xB086 (PANTHERLAKE)
[00:21:05] [PASSED] 0xB087 (PANTHERLAKE)
[00:21:05] [PASSED] 0xB08F (PANTHERLAKE)
[00:21:05] [PASSED] 0xB090 (PANTHERLAKE)
[00:21:05] [PASSED] 0xB0A0 (PANTHERLAKE)
[00:21:05] [PASSED] 0xB0B0 (PANTHERLAKE)
[00:21:05] [PASSED] 0xFD80 (PANTHERLAKE)
[00:21:05] [PASSED] 0xFD81 (PANTHERLAKE)
[00:21:05] [PASSED] 0xD740 (NOVALAKE_S)
[00:21:05] [PASSED] 0xD741 (NOVALAKE_S)
[00:21:05] [PASSED] 0xD742 (NOVALAKE_S)
[00:21:05] [PASSED] 0xD743 (NOVALAKE_S)
[00:21:05] [PASSED] 0xD744 (NOVALAKE_S)
[00:21:05] [PASSED] 0xD745 (NOVALAKE_S)
[00:21:05] [PASSED] 0x674C (CRESCENTISLAND)
[00:21:05] =============== [PASSED] check_platform_desc ===============
[00:21:05] ===================== [PASSED] xe_pci ======================
[00:21:05] =================== xe_rtp (2 subtests) ====================
[00:21:05] =============== xe_rtp_process_to_sr_tests ================
[00:21:05] [PASSED] coalesce-same-reg
[00:21:05] [PASSED] no-match-no-add
[00:21:05] [PASSED] match-or
[00:21:05] [PASSED] match-or-xfail
[00:21:05] [PASSED] no-match-no-add-multiple-rules
[00:21:05] [PASSED] two-regs-two-entries
[00:21:05] [PASSED] clr-one-set-other
[00:21:05] [PASSED] set-field
[00:21:05] [PASSED] conflict-duplicate
[00:21:05] [PASSED] conflict-not-disjoint
[00:21:05] [PASSED] conflict-reg-type
[00:21:05] =========== [PASSED] xe_rtp_process_to_sr_tests ============
[00:21:05] ================== xe_rtp_process_tests ===================
[00:21:05] [PASSED] active1
[00:21:05] [PASSED] active2
[00:21:05] [PASSED] active-inactive
[00:21:05] [PASSED] inactive-active
[00:21:05] [PASSED] inactive-1st_or_active-inactive
[00:21:05] [PASSED] inactive-2nd_or_active-inactive
[00:21:05] [PASSED] inactive-last_or_active-inactive
[00:21:05] [PASSED] inactive-no_or_active-inactive
[00:21:05] ============== [PASSED] xe_rtp_process_tests ===============
[00:21:05] ===================== [PASSED] xe_rtp ======================
[00:21:05] ==================== xe_wa (1 subtest) =====================
[00:21:05] ======================== xe_wa_gt =========================
[00:21:05] [PASSED] TIGERLAKE B0
[00:21:05] [PASSED] DG1 A0
[00:21:05] [PASSED] DG1 B0
[00:21:05] [PASSED] ALDERLAKE_S A0
[00:21:05] [PASSED] ALDERLAKE_S B0
[00:21:05] [PASSED] ALDERLAKE_S C0
[00:21:05] [PASSED] ALDERLAKE_S D0
[00:21:05] [PASSED] ALDERLAKE_P A0
[00:21:05] [PASSED] ALDERLAKE_P B0
[00:21:05] [PASSED] ALDERLAKE_P C0
[00:21:05] [PASSED] ALDERLAKE_S RPLS D0
[00:21:05] [PASSED] ALDERLAKE_P RPLU E0
[00:21:05] [PASSED] DG2 G10 C0
[00:21:05] [PASSED] DG2 G11 B1
[00:21:05] [PASSED] DG2 G12 A1
[00:21:05] [PASSED] METEORLAKE 12.70(Xe_LPG) A0 13.00(Xe_LPM+) A0
[00:21:05] [PASSED] METEORLAKE 12.71(Xe_LPG) A0 13.00(Xe_LPM+) A0
[00:21:05] [PASSED] METEORLAKE 12.74(Xe_LPG+) A0 13.00(Xe_LPM+) A0
[00:21:05] [PASSED] LUNARLAKE 20.04(Xe2_LPG) A0 20.00(Xe2_LPM) A0
[00:21:05] [PASSED] LUNARLAKE 20.04(Xe2_LPG) B0 20.00(Xe2_LPM) A0
[00:21:05] [PASSED] BATTLEMAGE 20.01(Xe2_HPG) A0 13.01(Xe2_HPM) A1
[00:21:05] [PASSED] PANTHERLAKE 30.00(Xe3_LPG) A0 30.00(Xe3_LPM) A0
[00:21:05] ==================== [PASSED] xe_wa_gt =====================
[00:21:05] ====================== [PASSED] xe_wa ======================
[00:21:05] ============================================================
[00:21:05] Testing complete. Ran 512 tests: passed: 494, skipped: 18
[00:21:05] Elapsed time: 36.395s total, 4.212s configuring, 31.666s building, 0.465s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig
[00:21:06] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[00:21:07] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[00:21:32] Starting KUnit Kernel (1/1)...
[00:21:32] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[00:21:33] ============ drm_test_pick_cmdline (2 subtests) ============
[00:21:33] [PASSED] drm_test_pick_cmdline_res_1920_1080_60
[00:21:33] =============== drm_test_pick_cmdline_named ===============
[00:21:33] [PASSED] NTSC
[00:21:33] [PASSED] NTSC-J
[00:21:33] [PASSED] PAL
[00:21:33] [PASSED] PAL-M
[00:21:33] =========== [PASSED] drm_test_pick_cmdline_named ===========
[00:21:33] ============== [PASSED] drm_test_pick_cmdline ==============
[00:21:33] == drm_test_atomic_get_connector_for_encoder (1 subtest) ===
[00:21:33] [PASSED] drm_test_drm_atomic_get_connector_for_encoder
[00:21:33] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ====
[00:21:33] =========== drm_validate_clone_mode (2 subtests) ===========
[00:21:33] ============== drm_test_check_in_clone_mode ===============
[00:21:33] [PASSED] in_clone_mode
[00:21:33] [PASSED] not_in_clone_mode
[00:21:33] ========== [PASSED] drm_test_check_in_clone_mode ===========
[00:21:33] =============== drm_test_check_valid_clones ===============
[00:21:33] [PASSED] not_in_clone_mode
[00:21:33] [PASSED] valid_clone
[00:21:33] [PASSED] invalid_clone
[00:21:33] =========== [PASSED] drm_test_check_valid_clones ===========
[00:21:33] ============= [PASSED] drm_validate_clone_mode =============
[00:21:33] ============= drm_validate_modeset (1 subtest) =============
[00:21:33] [PASSED] drm_test_check_connector_changed_modeset
[00:21:33] ============== [PASSED] drm_validate_modeset ===============
[00:21:33] ====== drm_test_bridge_get_current_state (2 subtests) ======
[00:21:33] [PASSED] drm_test_drm_bridge_get_current_state_atomic
[00:21:33] [PASSED] drm_test_drm_bridge_get_current_state_legacy
[00:21:33] ======== [PASSED] drm_test_bridge_get_current_state ========
[00:21:33] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ======
[00:21:33] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic
[00:21:33] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled
[00:21:33] [PASSED] drm_test_drm_bridge_helper_reset_crtc_legacy
[00:21:33] ======== [PASSED] drm_test_bridge_helper_reset_crtc ========
[00:21:33] ============== drm_bridge_alloc (2 subtests) ===============
[00:21:33] [PASSED] drm_test_drm_bridge_alloc_basic
[00:21:33] [PASSED] drm_test_drm_bridge_alloc_get_put
[00:21:33] ================ [PASSED] drm_bridge_alloc =================
[00:21:33] ================== drm_buddy (9 subtests) ==================
[00:21:33] [PASSED] drm_test_buddy_alloc_limit
[00:21:33] [PASSED] drm_test_buddy_alloc_optimistic
[00:21:33] [PASSED] drm_test_buddy_alloc_pessimistic
[00:21:33] [PASSED] drm_test_buddy_alloc_pathological
[00:21:33] [PASSED] drm_test_buddy_alloc_contiguous
[00:21:33] [PASSED] drm_test_buddy_alloc_clear
[00:21:33] [PASSED] drm_test_buddy_alloc_range_bias
[00:21:33] [PASSED] drm_test_buddy_fragmentation_performance
[00:21:33] [PASSED] drm_test_buddy_alloc_exceeds_max_order
[00:21:33] ==================== [PASSED] drm_buddy ====================
[00:21:33] ============= drm_cmdline_parser (40 subtests) =============
[00:21:33] [PASSED] drm_test_cmdline_force_d_only
[00:21:33] [PASSED] drm_test_cmdline_force_D_only_dvi
[00:21:33] [PASSED] drm_test_cmdline_force_D_only_hdmi
[00:21:33] [PASSED] drm_test_cmdline_force_D_only_not_digital
[00:21:33] [PASSED] drm_test_cmdline_force_e_only
[00:21:33] [PASSED] drm_test_cmdline_res
[00:21:33] [PASSED] drm_test_cmdline_res_vesa
[00:21:33] [PASSED] drm_test_cmdline_res_vesa_rblank
[00:21:33] [PASSED] drm_test_cmdline_res_rblank
[00:21:33] [PASSED] drm_test_cmdline_res_bpp
[00:21:33] [PASSED] drm_test_cmdline_res_refresh
[00:21:33] [PASSED] drm_test_cmdline_res_bpp_refresh
[00:21:33] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced
[00:21:33] [PASSED] drm_test_cmdline_res_bpp_refresh_margins
[00:21:33] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off
[00:21:33] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on
[00:21:33] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog
[00:21:33] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital
[00:21:33] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on
[00:21:33] [PASSED] drm_test_cmdline_res_margins_force_on
[00:21:33] [PASSED] drm_test_cmdline_res_vesa_margins
[00:21:33] [PASSED] drm_test_cmdline_name
[00:21:33] [PASSED] drm_test_cmdline_name_bpp
[00:21:33] [PASSED] drm_test_cmdline_name_option
[00:21:33] [PASSED] drm_test_cmdline_name_bpp_option
[00:21:33] [PASSED] drm_test_cmdline_rotate_0
[00:21:33] [PASSED] drm_test_cmdline_rotate_90
[00:21:33] [PASSED] drm_test_cmdline_rotate_180
[00:21:33] [PASSED] drm_test_cmdline_rotate_270
[00:21:33] [PASSED] drm_test_cmdline_hmirror
[00:21:33] [PASSED] drm_test_cmdline_vmirror
[00:21:33] [PASSED] drm_test_cmdline_margin_options
[00:21:33] [PASSED] drm_test_cmdline_multiple_options
[00:21:33] [PASSED] drm_test_cmdline_bpp_extra_and_option
[00:21:33] [PASSED] drm_test_cmdline_extra_and_option
[00:21:33] [PASSED] drm_test_cmdline_freestanding_options
[00:21:33] [PASSED] drm_test_cmdline_freestanding_force_e_and_options
[00:21:33] [PASSED] drm_test_cmdline_panel_orientation
[00:21:33] ================ drm_test_cmdline_invalid =================
[00:21:33] [PASSED] margin_only
[00:21:33] [PASSED] interlace_only
[00:21:33] [PASSED] res_missing_x
[00:21:33] [PASSED] res_missing_y
[00:21:33] [PASSED] res_bad_y
[00:21:33] [PASSED] res_missing_y_bpp
[00:21:33] [PASSED] res_bad_bpp
[00:21:33] [PASSED] res_bad_refresh
[00:21:33] [PASSED] res_bpp_refresh_force_on_off
[00:21:33] [PASSED] res_invalid_mode
[00:21:33] [PASSED] res_bpp_wrong_place_mode
[00:21:33] [PASSED] name_bpp_refresh
[00:21:33] [PASSED] name_refresh
[00:21:33] [PASSED] name_refresh_wrong_mode
[00:21:33] [PASSED] name_refresh_invalid_mode
[00:21:33] [PASSED] rotate_multiple
[00:21:33] [PASSED] rotate_invalid_val
[00:21:33] [PASSED] rotate_truncated
[00:21:33] [PASSED] invalid_option
[00:21:33] [PASSED] invalid_tv_option
[00:21:33] [PASSED] truncated_tv_option
[00:21:33] ============ [PASSED] drm_test_cmdline_invalid =============
[00:21:33] =============== drm_test_cmdline_tv_options ===============
[00:21:33] [PASSED] NTSC
[00:21:33] [PASSED] NTSC_443
[00:21:33] [PASSED] NTSC_J
[00:21:33] [PASSED] PAL
[00:21:33] [PASSED] PAL_M
[00:21:33] [PASSED] PAL_N
[00:21:33] [PASSED] SECAM
[00:21:33] [PASSED] MONO_525
[00:21:33] [PASSED] MONO_625
[00:21:33] =========== [PASSED] drm_test_cmdline_tv_options ===========
[00:21:33] =============== [PASSED] drm_cmdline_parser ================
[00:21:33] ========== drmm_connector_hdmi_init (20 subtests) ==========
[00:21:33] [PASSED] drm_test_connector_hdmi_init_valid
[00:21:33] [PASSED] drm_test_connector_hdmi_init_bpc_8
[00:21:33] [PASSED] drm_test_connector_hdmi_init_bpc_10
[00:21:33] [PASSED] drm_test_connector_hdmi_init_bpc_12
[00:21:33] [PASSED] drm_test_connector_hdmi_init_bpc_invalid
[00:21:33] [PASSED] drm_test_connector_hdmi_init_bpc_null
[00:21:33] [PASSED] drm_test_connector_hdmi_init_formats_empty
[00:21:33] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb
[00:21:33] === drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[00:21:33] [PASSED] supported_formats=0x9 yuv420_allowed=1
[00:21:33] [PASSED] supported_formats=0x9 yuv420_allowed=0
[00:21:33] [PASSED] supported_formats=0x3 yuv420_allowed=1
[00:21:33] [PASSED] supported_formats=0x3 yuv420_allowed=0
[00:21:33] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[00:21:33] [PASSED] drm_test_connector_hdmi_init_null_ddc
[00:21:33] [PASSED] drm_test_connector_hdmi_init_null_product
[00:21:33] [PASSED] drm_test_connector_hdmi_init_null_vendor
[00:21:33] [PASSED] drm_test_connector_hdmi_init_product_length_exact
[00:21:33] [PASSED] drm_test_connector_hdmi_init_product_length_too_long
[00:21:33] [PASSED] drm_test_connector_hdmi_init_product_valid
[00:21:33] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact
[00:21:33] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long
[00:21:33] [PASSED] drm_test_connector_hdmi_init_vendor_valid
[00:21:33] ========= drm_test_connector_hdmi_init_type_valid =========
[00:21:33] [PASSED] HDMI-A
[00:21:33] [PASSED] HDMI-B
[00:21:33] ===== [PASSED] drm_test_connector_hdmi_init_type_valid =====
[00:21:33] ======== drm_test_connector_hdmi_init_type_invalid ========
[00:21:33] [PASSED] Unknown
[00:21:33] [PASSED] VGA
[00:21:33] [PASSED] DVI-I
[00:21:33] [PASSED] DVI-D
[00:21:33] [PASSED] DVI-A
[00:21:33] [PASSED] Composite
[00:21:33] [PASSED] SVIDEO
[00:21:33] [PASSED] LVDS
[00:21:33] [PASSED] Component
[00:21:33] [PASSED] DIN
[00:21:33] [PASSED] DP
[00:21:33] [PASSED] TV
[00:21:33] [PASSED] eDP
[00:21:33] [PASSED] Virtual
[00:21:33] [PASSED] DSI
[00:21:33] [PASSED] DPI
[00:21:33] [PASSED] Writeback
[00:21:33] [PASSED] SPI
[00:21:33] [PASSED] USB
[00:21:33] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ====
[00:21:33] ============ [PASSED] drmm_connector_hdmi_init =============
[00:21:33] ============= drmm_connector_init (3 subtests) =============
[00:21:33] [PASSED] drm_test_drmm_connector_init
[00:21:33] [PASSED] drm_test_drmm_connector_init_null_ddc
[00:21:33] ========= drm_test_drmm_connector_init_type_valid =========
[00:21:33] [PASSED] Unknown
[00:21:33] [PASSED] VGA
[00:21:33] [PASSED] DVI-I
[00:21:33] [PASSED] DVI-D
[00:21:33] [PASSED] DVI-A
[00:21:33] [PASSED] Composite
[00:21:33] [PASSED] SVIDEO
[00:21:33] [PASSED] LVDS
[00:21:33] [PASSED] Component
[00:21:33] [PASSED] DIN
[00:21:33] [PASSED] DP
[00:21:33] [PASSED] HDMI-A
[00:21:33] [PASSED] HDMI-B
[00:21:33] [PASSED] TV
[00:21:33] [PASSED] eDP
[00:21:33] [PASSED] Virtual
[00:21:33] [PASSED] DSI
[00:21:33] [PASSED] DPI
[00:21:33] [PASSED] Writeback
[00:21:33] [PASSED] SPI
[00:21:33] [PASSED] USB
[00:21:33] ===== [PASSED] drm_test_drmm_connector_init_type_valid =====
[00:21:33] =============== [PASSED] drmm_connector_init ===============
[00:21:33] ========= drm_connector_dynamic_init (6 subtests) ==========
[00:21:33] [PASSED] drm_test_drm_connector_dynamic_init
[00:21:33] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc
[00:21:33] [PASSED] drm_test_drm_connector_dynamic_init_not_added
[00:21:33] [PASSED] drm_test_drm_connector_dynamic_init_properties
[00:21:33] ===== drm_test_drm_connector_dynamic_init_type_valid ======
[00:21:33] [PASSED] Unknown
[00:21:33] [PASSED] VGA
[00:21:33] [PASSED] DVI-I
[00:21:33] [PASSED] DVI-D
[00:21:33] [PASSED] DVI-A
[00:21:33] [PASSED] Composite
[00:21:33] [PASSED] SVIDEO
[00:21:33] [PASSED] LVDS
[00:21:33] [PASSED] Component
[00:21:33] [PASSED] DIN
[00:21:33] [PASSED] DP
[00:21:33] [PASSED] HDMI-A
[00:21:33] [PASSED] HDMI-B
[00:21:33] [PASSED] TV
[00:21:33] [PASSED] eDP
[00:21:33] [PASSED] Virtual
[00:21:33] [PASSED] DSI
[00:21:33] [PASSED] DPI
[00:21:33] [PASSED] Writeback
[00:21:33] [PASSED] SPI
[00:21:33] [PASSED] USB
[00:21:33] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid ==
[00:21:33] ======== drm_test_drm_connector_dynamic_init_name =========
[00:21:33] [PASSED] Unknown
[00:21:33] [PASSED] VGA
[00:21:33] [PASSED] DVI-I
[00:21:33] [PASSED] DVI-D
[00:21:33] [PASSED] DVI-A
[00:21:33] [PASSED] Composite
[00:21:33] [PASSED] SVIDEO
[00:21:33] [PASSED] LVDS
[00:21:33] [PASSED] Component
[00:21:33] [PASSED] DIN
[00:21:33] [PASSED] DP
[00:21:33] [PASSED] HDMI-A
[00:21:33] [PASSED] HDMI-B
[00:21:33] [PASSED] TV
[00:21:33] [PASSED] eDP
[00:21:33] [PASSED] Virtual
[00:21:33] [PASSED] DSI
[00:21:33] [PASSED] DPI
[00:21:33] [PASSED] Writeback
[00:21:33] [PASSED] SPI
[00:21:33] [PASSED] USB
[00:21:33] ==== [PASSED] drm_test_drm_connector_dynamic_init_name =====
[00:21:33] =========== [PASSED] drm_connector_dynamic_init ============
[00:21:33] ==== drm_connector_dynamic_register_early (4 subtests) =====
[00:21:33] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list
[00:21:33] [PASSED] drm_test_drm_connector_dynamic_register_early_defer
[00:21:33] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init
[00:21:33] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object
[00:21:33] ====== [PASSED] drm_connector_dynamic_register_early =======
[00:21:33] ======= drm_connector_dynamic_register (7 subtests) ========
[00:21:33] [PASSED] drm_test_drm_connector_dynamic_register_on_list
[00:21:33] [PASSED] drm_test_drm_connector_dynamic_register_no_defer
[00:21:33] [PASSED] drm_test_drm_connector_dynamic_register_no_init
[00:21:33] [PASSED] drm_test_drm_connector_dynamic_register_mode_object
[00:21:33] [PASSED] drm_test_drm_connector_dynamic_register_sysfs
[00:21:33] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name
[00:21:33] [PASSED] drm_test_drm_connector_dynamic_register_debugfs
[00:21:33] ========= [PASSED] drm_connector_dynamic_register ==========
[00:21:33] = drm_connector_attach_broadcast_rgb_property (2 subtests) =
[00:21:33] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property
[00:21:33] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector
[00:21:33] === [PASSED] drm_connector_attach_broadcast_rgb_property ===
[00:21:33] ========== drm_get_tv_mode_from_name (2 subtests) ==========
[00:21:33] ========== drm_test_get_tv_mode_from_name_valid ===========
[00:21:33] [PASSED] NTSC
[00:21:33] [PASSED] NTSC-443
[00:21:33] [PASSED] NTSC-J
[00:21:33] [PASSED] PAL
[00:21:33] [PASSED] PAL-M
[00:21:33] [PASSED] PAL-N
[00:21:33] [PASSED] SECAM
[00:21:33] [PASSED] Mono
[00:21:33] ====== [PASSED] drm_test_get_tv_mode_from_name_valid =======
[00:21:33] [PASSED] drm_test_get_tv_mode_from_name_truncated
[00:21:33] ============ [PASSED] drm_get_tv_mode_from_name ============
[00:21:33] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) =
[00:21:33] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb
[00:21:33] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc
[00:21:33] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1
[00:21:33] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc
[00:21:33] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1
[00:21:33] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double
[00:21:33] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid =
[00:21:33] [PASSED] VIC 96
[00:21:33] [PASSED] VIC 97
[00:21:33] [PASSED] VIC 101
[00:21:33] [PASSED] VIC 102
[00:21:33] [PASSED] VIC 106
[00:21:33] [PASSED] VIC 107
[00:21:33] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid ===
[00:21:33] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc
[00:21:33] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc
[00:21:33] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc
[00:21:33] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc
[00:21:33] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc
[00:21:33] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ====
[00:21:33] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) ==
[00:21:33] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name ====
[00:21:33] [PASSED] Automatic
[00:21:33] [PASSED] Full
[00:21:33] [PASSED] Limited 16:235
[00:21:33] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name ===
[00:21:33] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid
[00:21:33] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ====
[00:21:33] == drm_hdmi_connector_get_output_format_name (2 subtests) ==
[00:21:33] === drm_test_drm_hdmi_connector_get_output_format_name ====
[00:21:33] [PASSED] RGB
[00:21:33] [PASSED] YUV 4:2:0
[00:21:33] [PASSED] YUV 4:2:2
[00:21:33] [PASSED] YUV 4:4:4
[00:21:33] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name ===
[00:21:33] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid
[00:21:33] ==== [PASSED] drm_hdmi_connector_get_output_format_name ====
[00:21:33] ============= drm_damage_helper (21 subtests) ==============
[00:21:33] [PASSED] drm_test_damage_iter_no_damage
[00:21:33] [PASSED] drm_test_damage_iter_no_damage_fractional_src
[00:21:33] [PASSED] drm_test_damage_iter_no_damage_src_moved
[00:21:33] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved
[00:21:33] [PASSED] drm_test_damage_iter_no_damage_not_visible
[00:21:33] [PASSED] drm_test_damage_iter_no_damage_no_crtc
[00:21:33] [PASSED] drm_test_damage_iter_no_damage_no_fb
[00:21:33] [PASSED] drm_test_damage_iter_simple_damage
[00:21:33] [PASSED] drm_test_damage_iter_single_damage
[00:21:33] [PASSED] drm_test_damage_iter_single_damage_intersect_src
[00:21:33] [PASSED] drm_test_damage_iter_single_damage_outside_src
[00:21:33] [PASSED] drm_test_damage_iter_single_damage_fractional_src
[00:21:33] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src
[00:21:33] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src
[00:21:33] [PASSED] drm_test_damage_iter_single_damage_src_moved
[00:21:33] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved
[00:21:33] [PASSED] drm_test_damage_iter_damage
[00:21:33] [PASSED] drm_test_damage_iter_damage_one_intersect
[00:21:33] [PASSED] drm_test_damage_iter_damage_one_outside
[00:21:33] [PASSED] drm_test_damage_iter_damage_src_moved
[00:21:33] [PASSED] drm_test_damage_iter_damage_not_visible
[00:21:33] ================ [PASSED] drm_damage_helper ================
[00:21:33] ============== drm_dp_mst_helper (3 subtests) ==============
[00:21:33] ============== drm_test_dp_mst_calc_pbn_mode ==============
[00:21:33] [PASSED] Clock 154000 BPP 30 DSC disabled
[00:21:33] [PASSED] Clock 234000 BPP 30 DSC disabled
[00:21:33] [PASSED] Clock 297000 BPP 24 DSC disabled
[00:21:33] [PASSED] Clock 332880 BPP 24 DSC enabled
[00:21:33] [PASSED] Clock 324540 BPP 24 DSC enabled
[00:21:33] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ==========
[00:21:33] ============== drm_test_dp_mst_calc_pbn_div ===============
[00:21:33] [PASSED] Link rate 2000000 lane count 4
[00:21:33] [PASSED] Link rate 2000000 lane count 2
[00:21:33] [PASSED] Link rate 2000000 lane count 1
[00:21:33] [PASSED] Link rate 1350000 lane count 4
[00:21:33] [PASSED] Link rate 1350000 lane count 2
[00:21:33] [PASSED] Link rate 1350000 lane count 1
[00:21:33] [PASSED] Link rate 1000000 lane count 4
[00:21:33] [PASSED] Link rate 1000000 lane count 2
[00:21:33] [PASSED] Link rate 1000000 lane count 1
[00:21:33] [PASSED] Link rate 810000 lane count 4
[00:21:33] [PASSED] Link rate 810000 lane count 2
[00:21:33] [PASSED] Link rate 810000 lane count 1
[00:21:33] [PASSED] Link rate 540000 lane count 4
[00:21:33] [PASSED] Link rate 540000 lane count 2
[00:21:33] [PASSED] Link rate 540000 lane count 1
[00:21:33] [PASSED] Link rate 270000 lane count 4
[00:21:33] [PASSED] Link rate 270000 lane count 2
[00:21:33] [PASSED] Link rate 270000 lane count 1
[00:21:33] [PASSED] Link rate 162000 lane count 4
[00:21:33] [PASSED] Link rate 162000 lane count 2
[00:21:33] [PASSED] Link rate 162000 lane count 1
[00:21:33] ========== [PASSED] drm_test_dp_mst_calc_pbn_div ===========
[00:21:33] ========= drm_test_dp_mst_sideband_msg_req_decode =========
[00:21:33] [PASSED] DP_ENUM_PATH_RESOURCES with port number
[00:21:33] [PASSED] DP_POWER_UP_PHY with port number
[00:21:33] [PASSED] DP_POWER_DOWN_PHY with port number
[00:21:33] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks
[00:21:33] [PASSED] DP_ALLOCATE_PAYLOAD with port number
[00:21:33] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI
[00:21:33] [PASSED] DP_ALLOCATE_PAYLOAD with PBN
[00:21:33] [PASSED] DP_QUERY_PAYLOAD with port number
[00:21:33] [PASSED] DP_QUERY_PAYLOAD with VCPI
[00:21:33] [PASSED] DP_REMOTE_DPCD_READ with port number
[00:21:33] [PASSED] DP_REMOTE_DPCD_READ with DPCD address
[00:21:33] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes
[00:21:33] [PASSED] DP_REMOTE_DPCD_WRITE with port number
[00:21:33] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address
[00:21:33] [PASSED] DP_REMOTE_DPCD_WRITE with data array
[00:21:33] [PASSED] DP_REMOTE_I2C_READ with port number
[00:21:33] [PASSED] DP_REMOTE_I2C_READ with I2C device ID
[00:21:33] [PASSED] DP_REMOTE_I2C_READ with transactions array
[00:21:33] [PASSED] DP_REMOTE_I2C_WRITE with port number
[00:21:33] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID
[00:21:33] [PASSED] DP_REMOTE_I2C_WRITE with data array
[00:21:33] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID
[00:21:33] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID
[00:21:33] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event
[00:21:33] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event
[00:21:33] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior
[00:21:33] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior
[00:21:33] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode =====
[00:21:33] ================ [PASSED] drm_dp_mst_helper ================
[00:21:33] ================== drm_exec (7 subtests) ===================
[00:21:33] [PASSED] sanitycheck
[00:21:33] [PASSED] test_lock
[00:21:33] [PASSED] test_lock_unlock
[00:21:33] [PASSED] test_duplicates
[00:21:33] [PASSED] test_prepare
[00:21:33] [PASSED] test_prepare_array
[00:21:33] [PASSED] test_multiple_loops
[00:21:33] ==================== [PASSED] drm_exec =====================
[00:21:33] =========== drm_format_helper_test (17 subtests) ===========
[00:21:33] ============== drm_test_fb_xrgb8888_to_gray8 ==============
[00:21:33] [PASSED] single_pixel_source_buffer
[00:21:33] [PASSED] single_pixel_clip_rectangle
[00:21:33] [PASSED] well_known_colors
[00:21:33] [PASSED] destination_pitch
[00:21:33] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ==========
[00:21:33] ============= drm_test_fb_xrgb8888_to_rgb332 ==============
[00:21:33] [PASSED] single_pixel_source_buffer
[00:21:33] [PASSED] single_pixel_clip_rectangle
[00:21:33] [PASSED] well_known_colors
[00:21:33] [PASSED] destination_pitch
[00:21:33] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ==========
[00:21:33] ============= drm_test_fb_xrgb8888_to_rgb565 ==============
[00:21:33] [PASSED] single_pixel_source_buffer
[00:21:33] [PASSED] single_pixel_clip_rectangle
[00:21:33] [PASSED] well_known_colors
[00:21:33] [PASSED] destination_pitch
[00:21:33] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ==========
[00:21:33] ============ drm_test_fb_xrgb8888_to_xrgb1555 =============
[00:21:33] [PASSED] single_pixel_source_buffer
[00:21:33] [PASSED] single_pixel_clip_rectangle
[00:21:33] [PASSED] well_known_colors
[00:21:33] [PASSED] destination_pitch
[00:21:33] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 =========
[00:21:33] ============ drm_test_fb_xrgb8888_to_argb1555 =============
[00:21:33] [PASSED] single_pixel_source_buffer
[00:21:33] [PASSED] single_pixel_clip_rectangle
[00:21:33] [PASSED] well_known_colors
[00:21:33] [PASSED] destination_pitch
[00:21:33] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 =========
[00:21:33] ============ drm_test_fb_xrgb8888_to_rgba5551 =============
[00:21:33] [PASSED] single_pixel_source_buffer
[00:21:33] [PASSED] single_pixel_clip_rectangle
[00:21:33] [PASSED] well_known_colors
[00:21:33] [PASSED] destination_pitch
[00:21:33] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 =========
[00:21:33] ============= drm_test_fb_xrgb8888_to_rgb888 ==============
[00:21:33] [PASSED] single_pixel_source_buffer
[00:21:33] [PASSED] single_pixel_clip_rectangle
[00:21:33] [PASSED] well_known_colors
[00:21:33] [PASSED] destination_pitch
[00:21:33] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ==========
[00:21:33] ============= drm_test_fb_xrgb8888_to_bgr888 ==============
[00:21:33] [PASSED] single_pixel_source_buffer
[00:21:33] [PASSED] single_pixel_clip_rectangle
[00:21:33] [PASSED] well_known_colors
[00:21:33] [PASSED] destination_pitch
[00:21:33] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ==========
[00:21:33] ============ drm_test_fb_xrgb8888_to_argb8888 =============
[00:21:33] [PASSED] single_pixel_source_buffer
[00:21:33] [PASSED] single_pixel_clip_rectangle
[00:21:33] [PASSED] well_known_colors
[00:21:33] [PASSED] destination_pitch
[00:21:33] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 =========
[00:21:33] =========== drm_test_fb_xrgb8888_to_xrgb2101010 ===========
[00:21:33] [PASSED] single_pixel_source_buffer
[00:21:33] [PASSED] single_pixel_clip_rectangle
[00:21:33] [PASSED] well_known_colors
[00:21:33] [PASSED] destination_pitch
[00:21:33] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 =======
[00:21:33] =========== drm_test_fb_xrgb8888_to_argb2101010 ===========
[00:21:33] [PASSED] single_pixel_source_buffer
[00:21:33] [PASSED] single_pixel_clip_rectangle
[00:21:33] [PASSED] well_known_colors
[00:21:33] [PASSED] destination_pitch
[00:21:33] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 =======
[00:21:33] ============== drm_test_fb_xrgb8888_to_mono ===============
[00:21:33] [PASSED] single_pixel_source_buffer
[00:21:33] [PASSED] single_pixel_clip_rectangle
[00:21:33] [PASSED] well_known_colors
[00:21:33] [PASSED] destination_pitch
[00:21:33] ========== [PASSED] drm_test_fb_xrgb8888_to_mono ===========
[00:21:33] ==================== drm_test_fb_swab =====================
[00:21:33] [PASSED] single_pixel_source_buffer
[00:21:33] [PASSED] single_pixel_clip_rectangle
[00:21:33] [PASSED] well_known_colors
[00:21:33] [PASSED] destination_pitch
[00:21:33] ================ [PASSED] drm_test_fb_swab =================
[00:21:33] ============ drm_test_fb_xrgb8888_to_xbgr8888 =============
[00:21:33] [PASSED] single_pixel_source_buffer
[00:21:33] [PASSED] single_pixel_clip_rectangle
[00:21:33] [PASSED] well_known_colors
[00:21:33] [PASSED] destination_pitch
[00:21:33] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 =========
[00:21:33] ============ drm_test_fb_xrgb8888_to_abgr8888 =============
[00:21:33] [PASSED] single_pixel_source_buffer
[00:21:33] [PASSED] single_pixel_clip_rectangle
[00:21:33] [PASSED] well_known_colors
[00:21:33] [PASSED] destination_pitch
[00:21:33] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 =========
[00:21:33] ================= drm_test_fb_clip_offset =================
[00:21:33] [PASSED] pass through
[00:21:33] [PASSED] horizontal offset
[00:21:33] [PASSED] vertical offset
[00:21:33] [PASSED] horizontal and vertical offset
[00:21:33] [PASSED] horizontal offset (custom pitch)
[00:21:33] [PASSED] vertical offset (custom pitch)
[00:21:33] [PASSED] horizontal and vertical offset (custom pitch)
[00:21:33] ============= [PASSED] drm_test_fb_clip_offset =============
[00:21:33] =================== drm_test_fb_memcpy ====================
[00:21:33] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258)
[00:21:33] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258)
[00:21:33] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559)
[00:21:33] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258)
[00:21:33] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258)
[00:21:33] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559)
[00:21:33] [PASSED] well_known_colors: XB24 little-endian (0x34324258)
[00:21:33] [PASSED] well_known_colors: XRA8 little-endian (0x38415258)
[00:21:33] [PASSED] well_known_colors: YU24 little-endian (0x34325559)
[00:21:33] [PASSED] destination_pitch: XB24 little-endian (0x34324258)
[00:21:33] [PASSED] destination_pitch: XRA8 little-endian (0x38415258)
[00:21:33] [PASSED] destination_pitch: YU24 little-endian (0x34325559)
[00:21:33] =============== [PASSED] drm_test_fb_memcpy ================
[00:21:33] ============= [PASSED] drm_format_helper_test ==============
[00:21:33] ================= drm_format (18 subtests) =================
[00:21:33] [PASSED] drm_test_format_block_width_invalid
[00:21:33] [PASSED] drm_test_format_block_width_one_plane
[00:21:33] [PASSED] drm_test_format_block_width_two_plane
[00:21:33] [PASSED] drm_test_format_block_width_three_plane
[00:21:33] [PASSED] drm_test_format_block_width_tiled
[00:21:33] [PASSED] drm_test_format_block_height_invalid
[00:21:33] [PASSED] drm_test_format_block_height_one_plane
[00:21:33] [PASSED] drm_test_format_block_height_two_plane
[00:21:33] [PASSED] drm_test_format_block_height_three_plane
[00:21:33] [PASSED] drm_test_format_block_height_tiled
[00:21:33] [PASSED] drm_test_format_min_pitch_invalid
[00:21:33] [PASSED] drm_test_format_min_pitch_one_plane_8bpp
[00:21:33] [PASSED] drm_test_format_min_pitch_one_plane_16bpp
[00:21:33] [PASSED] drm_test_format_min_pitch_one_plane_24bpp
[00:21:33] [PASSED] drm_test_format_min_pitch_one_plane_32bpp
[00:21:33] [PASSED] drm_test_format_min_pitch_two_plane
[00:21:33] [PASSED] drm_test_format_min_pitch_three_plane_8bpp
[00:21:33] [PASSED] drm_test_format_min_pitch_tiled
[00:21:33] =================== [PASSED] drm_format ====================
[00:21:33] ============== drm_framebuffer (10 subtests) ===============
[00:21:33] ========== drm_test_framebuffer_check_src_coords ==========
[00:21:33] [PASSED] Success: source fits into fb
[00:21:33] [PASSED] Fail: overflowing fb with x-axis coordinate
[00:21:33] [PASSED] Fail: overflowing fb with y-axis coordinate
[00:21:33] [PASSED] Fail: overflowing fb with source width
[00:21:33] [PASSED] Fail: overflowing fb with source height
[00:21:33] ====== [PASSED] drm_test_framebuffer_check_src_coords ======
[00:21:33] [PASSED] drm_test_framebuffer_cleanup
[00:21:33] =============== drm_test_framebuffer_create ===============
[00:21:33] [PASSED] ABGR8888 normal sizes
[00:21:33] [PASSED] ABGR8888 max sizes
[00:21:33] [PASSED] ABGR8888 pitch greater than min required
[00:21:33] [PASSED] ABGR8888 pitch less than min required
[00:21:33] [PASSED] ABGR8888 Invalid width
[00:21:33] [PASSED] ABGR8888 Invalid buffer handle
[00:21:33] [PASSED] No pixel format
[00:21:33] [PASSED] ABGR8888 Width 0
[00:21:33] [PASSED] ABGR8888 Height 0
[00:21:33] [PASSED] ABGR8888 Out of bound height * pitch combination
[00:21:33] [PASSED] ABGR8888 Large buffer offset
[00:21:33] [PASSED] ABGR8888 Buffer offset for inexistent plane
[00:21:33] [PASSED] ABGR8888 Invalid flag
[00:21:33] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers
[00:21:33] [PASSED] ABGR8888 Valid buffer modifier
[00:21:33] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE)
[00:21:33] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS
[00:21:33] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS
[00:21:33] [PASSED] NV12 Normal sizes
[00:21:33] [PASSED] NV12 Max sizes
[00:21:33] [PASSED] NV12 Invalid pitch
[00:21:33] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag
[00:21:33] [PASSED] NV12 different modifier per-plane
[00:21:33] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE
[00:21:33] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS
[00:21:33] [PASSED] NV12 Modifier for inexistent plane
[00:21:33] [PASSED] NV12 Handle for inexistent plane
[00:21:33] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS
[00:21:33] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier
[00:21:33] [PASSED] YVU420 Normal sizes
[00:21:33] [PASSED] YVU420 Max sizes
[00:21:33] [PASSED] YVU420 Invalid pitch
[00:21:33] [PASSED] YVU420 Different pitches
[00:21:33] [PASSED] YVU420 Different buffer offsets/pitches
[00:21:33] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS
[00:21:33] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS
[00:21:33] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS
[00:21:33] [PASSED] YVU420 Valid modifier
[00:21:33] [PASSED] YVU420 Different modifiers per plane
[00:21:33] [PASSED] YVU420 Modifier for inexistent plane
[00:21:33] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR)
[00:21:33] [PASSED] X0L2 Normal sizes
[00:21:33] [PASSED] X0L2 Max sizes
[00:21:33] [PASSED] X0L2 Invalid pitch
[00:21:33] [PASSED] X0L2 Pitch greater than minimum required
[00:21:33] [PASSED] X0L2 Handle for inexistent plane
[00:21:33] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set
[00:21:33] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set
[00:21:33] [PASSED] X0L2 Valid modifier
[00:21:33] [PASSED] X0L2 Modifier for inexistent plane
[00:21:33] =========== [PASSED] drm_test_framebuffer_create ===========
[00:21:33] [PASSED] drm_test_framebuffer_free
[00:21:33] [PASSED] drm_test_framebuffer_init
[00:21:33] [PASSED] drm_test_framebuffer_init_bad_format
[00:21:33] [PASSED] drm_test_framebuffer_init_dev_mismatch
[00:21:33] [PASSED] drm_test_framebuffer_lookup
[00:21:33] [PASSED] drm_test_framebuffer_lookup_inexistent
[00:21:33] [PASSED] drm_test_framebuffer_modifiers_not_supported
[00:21:33] ================= [PASSED] drm_framebuffer =================
[00:21:33] ================ drm_gem_shmem (8 subtests) ================
[00:21:33] [PASSED] drm_gem_shmem_test_obj_create
[00:21:33] [PASSED] drm_gem_shmem_test_obj_create_private
[00:21:33] [PASSED] drm_gem_shmem_test_pin_pages
[00:21:33] [PASSED] drm_gem_shmem_test_vmap
[00:21:33] [PASSED] drm_gem_shmem_test_get_sg_table
[00:21:33] [PASSED] drm_gem_shmem_test_get_pages_sgt
[00:21:33] [PASSED] drm_gem_shmem_test_madvise
[00:21:33] [PASSED] drm_gem_shmem_test_purge
[00:21:33] ================== [PASSED] drm_gem_shmem ==================
[00:21:33] === drm_atomic_helper_connector_hdmi_check (27 subtests) ===
[00:21:33] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode
[00:21:33] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1
[00:21:33] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode
[00:21:33] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1
[00:21:33] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode
[00:21:33] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1
[00:21:33] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420 =======
[00:21:33] [PASSED] Automatic
[00:21:33] [PASSED] Full
[00:21:33] [PASSED] Limited 16:235
[00:21:33] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 ===
[00:21:33] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed
[00:21:33] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed
[00:21:33] [PASSED] drm_test_check_disable_connector
[00:21:33] [PASSED] drm_test_check_hdmi_funcs_reject_rate
[00:21:33] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb
[00:21:33] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420
[00:21:33] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422
[00:21:33] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420
[00:21:33] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420
[00:21:33] [PASSED] drm_test_check_output_bpc_crtc_mode_changed
[00:21:33] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed
[00:21:33] [PASSED] drm_test_check_output_bpc_dvi
[00:21:33] [PASSED] drm_test_check_output_bpc_format_vic_1
[00:21:33] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only
[00:21:33] [PASSED] drm_test_check_output_bpc_format_display_rgb_only
[00:21:33] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only
[00:21:33] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only
[00:21:33] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc
[00:21:33] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc
[00:21:33] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc
[00:21:33] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ======
[00:21:33] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ====
[00:21:33] [PASSED] drm_test_check_broadcast_rgb_value
[00:21:33] [PASSED] drm_test_check_bpc_8_value
[00:21:33] [PASSED] drm_test_check_bpc_10_value
[00:21:33] [PASSED] drm_test_check_bpc_12_value
[00:21:33] [PASSED] drm_test_check_format_value
[00:21:33] [PASSED] drm_test_check_tmds_char_value
[00:21:33] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ======
[00:21:33] = drm_atomic_helper_connector_hdmi_mode_valid (4 subtests) =
[00:21:33] [PASSED] drm_test_check_mode_valid
[00:21:33] [PASSED] drm_test_check_mode_valid_reject
[00:21:33] [PASSED] drm_test_check_mode_valid_reject_rate
[00:21:33] [PASSED] drm_test_check_mode_valid_reject_max_clock
[00:21:33] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid ===
[00:21:33] = drm_atomic_helper_connector_hdmi_infoframes (5 subtests) =
[00:21:33] [PASSED] drm_test_check_infoframes
[00:21:33] [PASSED] drm_test_check_reject_avi_infoframe
[00:21:33] [PASSED] drm_test_check_reject_hdr_infoframe_bpc_8
[00:21:33] [PASSED] drm_test_check_reject_hdr_infoframe_bpc_10
[00:21:33] [PASSED] drm_test_check_reject_audio_infoframe
[00:21:33] === [PASSED] drm_atomic_helper_connector_hdmi_infoframes ===
[00:21:33] ================= drm_managed (2 subtests) =================
[00:21:33] [PASSED] drm_test_managed_release_action
[00:21:33] [PASSED] drm_test_managed_run_action
[00:21:33] =================== [PASSED] drm_managed ===================
[00:21:33] =================== drm_mm (6 subtests) ====================
[00:21:33] [PASSED] drm_test_mm_init
[00:21:33] [PASSED] drm_test_mm_debug
[00:21:33] [PASSED] drm_test_mm_align32
[00:21:33] [PASSED] drm_test_mm_align64
[00:21:33] [PASSED] drm_test_mm_lowest
[00:21:33] [PASSED] drm_test_mm_highest
[00:21:33] ===================== [PASSED] drm_mm ======================
[00:21:33] ============= drm_modes_analog_tv (5 subtests) =============
[00:21:33] [PASSED] drm_test_modes_analog_tv_mono_576i
[00:21:33] [PASSED] drm_test_modes_analog_tv_ntsc_480i
[00:21:33] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined
[00:21:33] [PASSED] drm_test_modes_analog_tv_pal_576i
[00:21:33] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined
[00:21:33] =============== [PASSED] drm_modes_analog_tv ===============
[00:21:33] ============== drm_plane_helper (2 subtests) ===============
[00:21:33] =============== drm_test_check_plane_state ================
[00:21:33] [PASSED] clipping_simple
[00:21:33] [PASSED] clipping_rotate_reflect
[00:21:33] [PASSED] positioning_simple
[00:21:33] [PASSED] upscaling
[00:21:33] [PASSED] downscaling
[00:21:33] [PASSED] rounding1
[00:21:33] [PASSED] rounding2
[00:21:33] [PASSED] rounding3
[00:21:33] [PASSED] rounding4
[00:21:33] =========== [PASSED] drm_test_check_plane_state ============
[00:21:33] =========== drm_test_check_invalid_plane_state ============
[00:21:33] [PASSED] positioning_invalid
[00:21:33] [PASSED] upscaling_invalid
[00:21:33] [PASSED] downscaling_invalid
[00:21:33] ======= [PASSED] drm_test_check_invalid_plane_state ========
[00:21:33] ================ [PASSED] drm_plane_helper =================
[00:21:33] ====== drm_connector_helper_tv_get_modes (1 subtest) =======
[00:21:33] ====== drm_test_connector_helper_tv_get_modes_check =======
[00:21:33] [PASSED] None
[00:21:33] [PASSED] PAL
[00:21:33] [PASSED] NTSC
[00:21:33] [PASSED] Both, NTSC Default
[00:21:33] [PASSED] Both, PAL Default
[00:21:33] [PASSED] Both, NTSC Default, with PAL on command-line
[00:21:33] [PASSED] Both, PAL Default, with NTSC on command-line
[00:21:33] == [PASSED] drm_test_connector_helper_tv_get_modes_check ===
[00:21:33] ======== [PASSED] drm_connector_helper_tv_get_modes ========
[00:21:33] ================== drm_rect (9 subtests) ===================
[00:21:33] [PASSED] drm_test_rect_clip_scaled_div_by_zero
[00:21:33] [PASSED] drm_test_rect_clip_scaled_not_clipped
[00:21:33] [PASSED] drm_test_rect_clip_scaled_clipped
[00:21:33] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned
[00:21:33] ================= drm_test_rect_intersect =================
[00:21:33] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0
[00:21:33] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1
[00:21:33] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0
[00:21:33] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1
[00:21:33] [PASSED] right x left: 2x1+0+0 x 3x1+1+0
[00:21:33] [PASSED] left x right: 3x1+1+0 x 2x1+0+0
[00:21:33] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1
[00:21:33] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0
[00:21:33] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1
[00:21:33] [PASSED] touching side: 1x1+0+0 x 1x1+1+0
[00:21:33] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0
[00:21:33] [PASSED] inside another: 2x2+0+0 x 1x1+1+1
[00:21:33] [PASSED] far away: 1x1+0+0 x 1x1+3+6
[00:21:33] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10
[00:21:33] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10
stty: 'standard input': Inappropriate ioctl for device
[00:21:33] ============= [PASSED] drm_test_rect_intersect =============
[00:21:33] ================ drm_test_rect_calc_hscale ================
[00:21:33] [PASSED] normal use
[00:21:33] [PASSED] out of max range
[00:21:33] [PASSED] out of min range
[00:21:33] [PASSED] zero dst
[00:21:33] [PASSED] negative src
[00:21:33] [PASSED] negative dst
[00:21:33] ============ [PASSED] drm_test_rect_calc_hscale ============
[00:21:33] ================ drm_test_rect_calc_vscale ================
[00:21:33] [PASSED] normal use
[00:21:33] [PASSED] out of max range
[00:21:33] [PASSED] out of min range
[00:21:33] [PASSED] zero dst
[00:21:33] [PASSED] negative src
[00:21:33] [PASSED] negative dst
[00:21:33] ============ [PASSED] drm_test_rect_calc_vscale ============
[00:21:33] ================== drm_test_rect_rotate ===================
[00:21:33] [PASSED] reflect-x
[00:21:33] [PASSED] reflect-y
[00:21:33] [PASSED] rotate-0
[00:21:33] [PASSED] rotate-90
[00:21:33] [PASSED] rotate-180
[00:21:33] [PASSED] rotate-270
[00:21:33] ============== [PASSED] drm_test_rect_rotate ===============
[00:21:33] ================ drm_test_rect_rotate_inv =================
[00:21:33] [PASSED] reflect-x
[00:21:33] [PASSED] reflect-y
[00:21:33] [PASSED] rotate-0
[00:21:33] [PASSED] rotate-90
[00:21:33] [PASSED] rotate-180
[00:21:33] [PASSED] rotate-270
[00:21:33] ============ [PASSED] drm_test_rect_rotate_inv =============
[00:21:33] ==================== [PASSED] drm_rect =====================
[00:21:33] ============ drm_sysfb_modeset_test (1 subtest) ============
[00:21:33] ============ drm_test_sysfb_build_fourcc_list =============
[00:21:33] [PASSED] no native formats
[00:21:33] [PASSED] XRGB8888 as native format
[00:21:33] [PASSED] remove duplicates
[00:21:33] [PASSED] convert alpha formats
[00:21:33] [PASSED] random formats
[00:21:33] ======== [PASSED] drm_test_sysfb_build_fourcc_list =========
[00:21:33] ============= [PASSED] drm_sysfb_modeset_test ==============
[00:21:33] ================== drm_fixp (2 subtests) ===================
[00:21:33] [PASSED] drm_test_int2fixp
[00:21:33] [PASSED] drm_test_sm2fixp
[00:21:33] ==================== [PASSED] drm_fixp =====================
[00:21:33] ============================================================
[00:21:33] Testing complete. Ran 630 tests: passed: 630
[00:21:33] Elapsed time: 27.322s total, 1.665s configuring, 25.239s building, 0.376s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig
[00:21:33] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[00:21:35] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[00:21:44] Starting KUnit Kernel (1/1)...
[00:21:44] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[00:21:44] ================= ttm_device (5 subtests) ==================
[00:21:44] [PASSED] ttm_device_init_basic
[00:21:44] [PASSED] ttm_device_init_multiple
[00:21:44] [PASSED] ttm_device_fini_basic
[00:21:44] [PASSED] ttm_device_init_no_vma_man
[00:21:44] ================== ttm_device_init_pools ==================
[00:21:44] [PASSED] No DMA allocations, no DMA32 required
[00:21:44] [PASSED] DMA allocations, DMA32 required
[00:21:44] [PASSED] No DMA allocations, DMA32 required
[00:21:44] [PASSED] DMA allocations, no DMA32 required
[00:21:44] ============== [PASSED] ttm_device_init_pools ==============
[00:21:44] =================== [PASSED] ttm_device ====================
[00:21:44] ================== ttm_pool (8 subtests) ===================
[00:21:44] ================== ttm_pool_alloc_basic ===================
[00:21:44] [PASSED] One page
[00:21:44] [PASSED] More than one page
[00:21:44] [PASSED] Above the allocation limit
[00:21:44] [PASSED] One page, with coherent DMA mappings enabled
[00:21:44] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[00:21:44] ============== [PASSED] ttm_pool_alloc_basic ===============
[00:21:44] ============== ttm_pool_alloc_basic_dma_addr ==============
[00:21:44] [PASSED] One page
[00:21:44] [PASSED] More than one page
[00:21:44] [PASSED] Above the allocation limit
[00:21:44] [PASSED] One page, with coherent DMA mappings enabled
[00:21:44] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[00:21:44] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ==========
[00:21:44] [PASSED] ttm_pool_alloc_order_caching_match
[00:21:44] [PASSED] ttm_pool_alloc_caching_mismatch
[00:21:44] [PASSED] ttm_pool_alloc_order_mismatch
[00:21:44] [PASSED] ttm_pool_free_dma_alloc
[00:21:44] [PASSED] ttm_pool_free_no_dma_alloc
[00:21:44] [PASSED] ttm_pool_fini_basic
[00:21:44] ==================== [PASSED] ttm_pool =====================
[00:21:44] ================ ttm_resource (8 subtests) =================
[00:21:44] ================= ttm_resource_init_basic =================
[00:21:44] [PASSED] Init resource in TTM_PL_SYSTEM
[00:21:44] [PASSED] Init resource in TTM_PL_VRAM
[00:21:44] [PASSED] Init resource in a private placement
[00:21:44] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags
[00:21:44] ============= [PASSED] ttm_resource_init_basic =============
[00:21:44] [PASSED] ttm_resource_init_pinned
[00:21:44] [PASSED] ttm_resource_fini_basic
[00:21:44] [PASSED] ttm_resource_manager_init_basic
[00:21:44] [PASSED] ttm_resource_manager_usage_basic
[00:21:44] [PASSED] ttm_resource_manager_set_used_basic
[00:21:44] [PASSED] ttm_sys_man_alloc_basic
[00:21:44] [PASSED] ttm_sys_man_free_basic
[00:21:44] ================== [PASSED] ttm_resource ===================
[00:21:44] =================== ttm_tt (15 subtests) ===================
[00:21:44] ==================== ttm_tt_init_basic ====================
[00:21:44] [PASSED] Page-aligned size
[00:21:44] [PASSED] Extra pages requested
[00:21:44] ================ [PASSED] ttm_tt_init_basic ================
[00:21:44] [PASSED] ttm_tt_init_misaligned
[00:21:44] [PASSED] ttm_tt_fini_basic
[00:21:44] [PASSED] ttm_tt_fini_sg
[00:21:44] [PASSED] ttm_tt_fini_shmem
[00:21:44] [PASSED] ttm_tt_create_basic
[00:21:44] [PASSED] ttm_tt_create_invalid_bo_type
[00:21:44] [PASSED] ttm_tt_create_ttm_exists
[00:21:44] [PASSED] ttm_tt_create_failed
[00:21:44] [PASSED] ttm_tt_destroy_basic
[00:21:44] [PASSED] ttm_tt_populate_null_ttm
[00:21:44] [PASSED] ttm_tt_populate_populated_ttm
[00:21:44] [PASSED] ttm_tt_unpopulate_basic
[00:21:44] [PASSED] ttm_tt_unpopulate_empty_ttm
[00:21:44] [PASSED] ttm_tt_swapin_basic
[00:21:44] ===================== [PASSED] ttm_tt ======================
[00:21:44] =================== ttm_bo (14 subtests) ===================
[00:21:44] =========== ttm_bo_reserve_optimistic_no_ticket ===========
[00:21:44] [PASSED] Cannot be interrupted and sleeps
[00:21:44] [PASSED] Cannot be interrupted, locks straight away
[00:21:44] [PASSED] Can be interrupted, sleeps
[00:21:44] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket =======
[00:21:44] [PASSED] ttm_bo_reserve_locked_no_sleep
[00:21:44] [PASSED] ttm_bo_reserve_no_wait_ticket
[00:21:44] [PASSED] ttm_bo_reserve_double_resv
[00:21:44] [PASSED] ttm_bo_reserve_interrupted
[00:21:44] [PASSED] ttm_bo_reserve_deadlock
[00:21:44] [PASSED] ttm_bo_unreserve_basic
[00:21:44] [PASSED] ttm_bo_unreserve_pinned
[00:21:44] [PASSED] ttm_bo_unreserve_bulk
[00:21:44] [PASSED] ttm_bo_fini_basic
[00:21:44] [PASSED] ttm_bo_fini_shared_resv
[00:21:44] [PASSED] ttm_bo_pin_basic
[00:21:44] [PASSED] ttm_bo_pin_unpin_resource
[00:21:44] [PASSED] ttm_bo_multiple_pin_one_unpin
[00:21:44] ===================== [PASSED] ttm_bo ======================
[00:21:44] ============== ttm_bo_validate (21 subtests) ===============
[00:21:44] ============== ttm_bo_init_reserved_sys_man ===============
[00:21:44] [PASSED] Buffer object for userspace
[00:21:44] [PASSED] Kernel buffer object
[00:21:44] [PASSED] Shared buffer object
[00:21:44] ========== [PASSED] ttm_bo_init_reserved_sys_man ===========
[00:21:44] ============== ttm_bo_init_reserved_mock_man ==============
[00:21:44] [PASSED] Buffer object for userspace
[00:21:44] [PASSED] Kernel buffer object
[00:21:44] [PASSED] Shared buffer object
[00:21:44] ========== [PASSED] ttm_bo_init_reserved_mock_man ==========
[00:21:44] [PASSED] ttm_bo_init_reserved_resv
[00:21:44] ================== ttm_bo_validate_basic ==================
[00:21:44] [PASSED] Buffer object for userspace
[00:21:44] [PASSED] Kernel buffer object
[00:21:44] [PASSED] Shared buffer object
[00:21:44] ============== [PASSED] ttm_bo_validate_basic ==============
[00:21:44] [PASSED] ttm_bo_validate_invalid_placement
[00:21:44] ============= ttm_bo_validate_same_placement ==============
[00:21:44] [PASSED] System manager
[00:21:44] [PASSED] VRAM manager
[00:21:44] ========= [PASSED] ttm_bo_validate_same_placement ==========
[00:21:44] [PASSED] ttm_bo_validate_failed_alloc
[00:21:44] [PASSED] ttm_bo_validate_pinned
[00:21:44] [PASSED] ttm_bo_validate_busy_placement
[00:21:44] ================ ttm_bo_validate_multihop =================
[00:21:44] [PASSED] Buffer object for userspace
[00:21:44] [PASSED] Kernel buffer object
[00:21:44] [PASSED] Shared buffer object
[00:21:44] ============ [PASSED] ttm_bo_validate_multihop =============
[00:21:44] ========== ttm_bo_validate_no_placement_signaled ==========
[00:21:44] [PASSED] Buffer object in system domain, no page vector
[00:21:44] [PASSED] Buffer object in system domain with an existing page vector
[00:21:44] ====== [PASSED] ttm_bo_validate_no_placement_signaled ======
[00:21:44] ======== ttm_bo_validate_no_placement_not_signaled ========
[00:21:44] [PASSED] Buffer object for userspace
[00:21:44] [PASSED] Kernel buffer object
[00:21:44] [PASSED] Shared buffer object
[00:21:44] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ====
[00:21:44] [PASSED] ttm_bo_validate_move_fence_signaled
[00:21:44] ========= ttm_bo_validate_move_fence_not_signaled =========
[00:21:44] [PASSED] Waits for GPU
[00:21:44] [PASSED] Tries to lock straight away
[00:21:44] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled =====
[00:21:44] [PASSED] ttm_bo_validate_happy_evict
[00:21:44] [PASSED] ttm_bo_validate_all_pinned_evict
[00:21:44] [PASSED] ttm_bo_validate_allowed_only_evict
[00:21:44] [PASSED] ttm_bo_validate_deleted_evict
[00:21:44] [PASSED] ttm_bo_validate_busy_domain_evict
[00:21:44] [PASSED] ttm_bo_validate_evict_gutting
[00:21:44] [PASSED] ttm_bo_validate_recrusive_evict
stty: 'standard input': Inappropriate ioctl for device
[00:21:44] ================= [PASSED] ttm_bo_validate =================
[00:21:44] ============================================================
[00:21:44] Testing complete. Ran 101 tests: passed: 101
[00:21:44] Elapsed time: 11.344s total, 1.700s configuring, 9.428s building, 0.184s running
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
^ permalink raw reply [flat|nested] 11+ messages in thread* ✗ Xe.CI.Full: failure for drm/xe: Separate out GuC RC code (rev3)
2026-01-23 23:50 [PATCH v6 0/2] drm/xe: Separate out GuC RC code Vinay Belgaumkar
` (3 preceding siblings ...)
2026-01-24 0:21 ` ✓ CI.KUnit: success " Patchwork
@ 2026-01-24 8:22 ` Patchwork
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2026-01-24 8:22 UTC (permalink / raw)
To: Vinay Belgaumkar; +Cc: intel-xe
[-- Attachment #1: Type: text/plain, Size: 370 bytes --]
== Series Details ==
Series: drm/xe: Separate out GuC RC code (rev3)
URL : https://patchwork.freedesktop.org/series/158581/
State : failure
== Summary ==
ERROR: The runconfig 'xe-4443-a47173257e3d0aeae02f59baad97046bee0b7ce9_FULL' does not exist in the database
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-158581v3/index.html
[-- Attachment #2: Type: text/html, Size: 935 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v6 2/2] drm/xe: Add a wrapper for set/unset params
2026-01-22 23:20 [PATCH v6 0/2] drm/xe: Separate out GuC RC code Vinay Belgaumkar
@ 2026-01-22 23:20 ` Vinay Belgaumkar
0 siblings, 0 replies; 11+ messages in thread
From: Vinay Belgaumkar @ 2026-01-22 23:20 UTC (permalink / raw)
To: intel-xe; +Cc: Vinay Belgaumkar
Also, extract out the GuC RC related set/unset param functions
into xe_guc_rc file. GuC still allows us to override GuC RC mode
using an SLPC H2G interface. Continue to use that interface, but
move the related code to the newly created xe_guc_rc file.
v2: xe_guc_rc functions to use guc pointer instead of gt (Michal W)
v3: Assert if runtime pm ref is not held (Michal W)
v4: Review comments (Riana)
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
---
drivers/gpu/drm/xe/xe_guc_pc.c | 56 +++++++++++++++++++---------------
drivers/gpu/drm/xe/xe_guc_pc.h | 5 ++-
drivers/gpu/drm/xe/xe_guc_rc.c | 30 ++++++++++++++++++
drivers/gpu/drm/xe/xe_guc_rc.h | 3 ++
drivers/gpu/drm/xe/xe_oa.c | 9 +++---
5 files changed, 70 insertions(+), 33 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c
index cf02c53ca3c5..31c6cb111916 100644
--- a/drivers/gpu/drm/xe/xe_guc_pc.c
+++ b/drivers/gpu/drm/xe/xe_guc_pc.c
@@ -264,6 +264,37 @@ static int pc_action_unset_param(struct xe_guc_pc *pc, u8 id)
return ret;
}
+/**
+ * xe_guc_pc_action_set_param() - Set value of SLPC param
+ * @pc: Xe_GuC_PC instance
+ * @id: Param id
+ * @value: Value to set
+ *
+ * This function can be used to set any SLPC param.
+ *
+ * Returns: 0 on Success
+ */
+int xe_guc_pc_action_set_param(struct xe_guc_pc *pc, u8 id, u32 value)
+{
+ xe_device_assert_mem_access(pc_to_xe(pc));
+ return pc_action_set_param(pc, id, value);
+}
+
+/**
+ * xe_guc_pc_action_unset_param() - Revert to default value
+ * @pc: Xe_GuC_PC instance
+ * @id: Param id
+ *
+ * This function can be used revert any SLPC param to its default value.
+ *
+ * Returns: 0 on Success
+ */
+int xe_guc_pc_action_unset_param(struct xe_guc_pc *pc, u8 id)
+{
+ xe_device_assert_mem_access(pc_to_xe(pc));
+ return pc_action_unset_param(pc, id);
+}
+
static u32 decode_freq(u32 raw)
{
return DIV_ROUND_CLOSEST(raw * GT_FREQUENCY_MULTIPLIER,
@@ -1045,31 +1076,6 @@ int xe_guc_pc_restore_stashed_freq(struct xe_guc_pc *pc)
return ret;
}
-/**
- * xe_guc_pc_override_gucrc_mode - override GUCRC mode
- * @pc: Xe_GuC_PC instance
- * @mode: new value of the mode.
- *
- * Return: 0 on success, negative error code on error
- */
-int xe_guc_pc_override_gucrc_mode(struct xe_guc_pc *pc, enum slpc_gucrc_mode mode)
-{
- guard(xe_pm_runtime)(pc_to_xe(pc));
- return pc_action_set_param(pc, SLPC_PARAM_PWRGATE_RC_MODE, mode);
-}
-
-/**
- * xe_guc_pc_unset_gucrc_mode - unset GUCRC mode override
- * @pc: Xe_GuC_PC instance
- *
- * Return: 0 on success, negative error code on error
- */
-int xe_guc_pc_unset_gucrc_mode(struct xe_guc_pc *pc)
-{
- guard(xe_pm_runtime)(pc_to_xe(pc));
- return pc_action_unset_param(pc, SLPC_PARAM_PWRGATE_RC_MODE);
-}
-
static void pc_init_pcode_freq(struct xe_guc_pc *pc)
{
u32 min = DIV_ROUND_CLOSEST(pc->rpn_freq, GT_FREQUENCY_MULTIPLIER);
diff --git a/drivers/gpu/drm/xe/xe_guc_pc.h b/drivers/gpu/drm/xe/xe_guc_pc.h
index 1b95873b262e..0678a4e787b3 100644
--- a/drivers/gpu/drm/xe/xe_guc_pc.h
+++ b/drivers/gpu/drm/xe/xe_guc_pc.h
@@ -9,15 +9,14 @@
#include <linux/types.h>
struct xe_guc_pc;
-enum slpc_gucrc_mode;
struct drm_printer;
int xe_guc_pc_init(struct xe_guc_pc *pc);
int xe_guc_pc_start(struct xe_guc_pc *pc);
int xe_guc_pc_stop(struct xe_guc_pc *pc);
-int xe_guc_pc_override_gucrc_mode(struct xe_guc_pc *pc, enum slpc_gucrc_mode mode);
-int xe_guc_pc_unset_gucrc_mode(struct xe_guc_pc *pc);
void xe_guc_pc_print(struct xe_guc_pc *pc, struct drm_printer *p);
+int xe_guc_pc_action_set_param(struct xe_guc_pc *pc, u8 id, u32 value);
+int xe_guc_pc_action_unset_param(struct xe_guc_pc *pc, u8 id);
u32 xe_guc_pc_get_act_freq(struct xe_guc_pc *pc);
int xe_guc_pc_get_cur_freq(struct xe_guc_pc *pc, u32 *freq);
diff --git a/drivers/gpu/drm/xe/xe_guc_rc.c b/drivers/gpu/drm/xe/xe_guc_rc.c
index fc57e5290635..0a900c309ecf 100644
--- a/drivers/gpu/drm/xe/xe_guc_rc.c
+++ b/drivers/gpu/drm/xe/xe_guc_rc.c
@@ -14,6 +14,7 @@
#include "xe_gt_printk.h"
#include "xe_guc.h"
#include "xe_guc_ct.h"
+#include "xe_guc_pc.h"
#include "xe_guc_rc.h"
#include "xe_pm.h"
@@ -112,3 +113,32 @@ int xe_guc_rc_enable(struct xe_guc *guc)
return guc_action_setup_gucrc(guc, GUCRC_FIRMWARE_CONTROL);
}
+
+/**
+ * xe_guc_rc_set_mode() - set GUCRC mode
+ * @guc: Xe GuC instance
+ * @mode: new value of the mode.
+ *
+ * Function to set GuC RC mode to one of the enum values.
+ *
+ * Returns: 0 on success, negative error code on error
+ */
+int xe_guc_rc_set_mode(struct xe_guc *guc, enum slpc_gucrc_mode mode)
+{
+ guard(xe_pm_runtime)(guc_to_xe(guc));
+ return xe_guc_pc_action_set_param(&guc->pc, SLPC_PARAM_PWRGATE_RC_MODE, mode);
+}
+
+/**
+ * xe_guc_rc_unset_mode() - revert to default mode
+ * @guc: Xe GuC instance
+ *
+ * Function to revert GuC RC mode to platform defaults.
+ *
+ * Returns: 0 on success, negative error code on error
+ */
+int xe_guc_rc_unset_mode(struct xe_guc *guc)
+{
+ guard(xe_pm_runtime)(guc_to_xe(guc));
+ return xe_guc_pc_action_unset_param(&guc->pc, SLPC_PARAM_PWRGATE_RC_MODE);
+}
diff --git a/drivers/gpu/drm/xe/xe_guc_rc.h b/drivers/gpu/drm/xe/xe_guc_rc.h
index c980b0fce472..d76dfad8e26c 100644
--- a/drivers/gpu/drm/xe/xe_guc_rc.h
+++ b/drivers/gpu/drm/xe/xe_guc_rc.h
@@ -7,8 +7,11 @@
#define _XE_GUC_RC_H_
struct xe_guc;
+enum slpc_gucrc_mode;
void xe_guc_rc_disable(struct xe_guc *guc);
int xe_guc_rc_enable(struct xe_guc *guc);
+int xe_guc_rc_set_mode(struct xe_guc *guc, enum slpc_gucrc_mode mode);
+int xe_guc_rc_unset_mode(struct xe_guc *guc);
#endif
diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
index abf87fe0b345..f7752719b74f 100644
--- a/drivers/gpu/drm/xe/xe_oa.c
+++ b/drivers/gpu/drm/xe/xe_oa.c
@@ -29,7 +29,7 @@
#include "xe_gt.h"
#include "xe_gt_mcr.h"
#include "xe_gt_printk.h"
-#include "xe_guc_pc.h"
+#include "xe_guc_rc.h"
#include "xe_macros.h"
#include "xe_mmio.h"
#include "xe_oa.h"
@@ -875,7 +875,7 @@ static void xe_oa_stream_destroy(struct xe_oa_stream *stream)
/* Wa_1509372804:pvc: Unset the override of GUCRC mode to enable rc6 */
if (stream->override_gucrc)
- xe_gt_WARN_ON(gt, xe_guc_pc_unset_gucrc_mode(>->uc.guc.pc));
+ xe_gt_WARN_ON(gt, xe_guc_rc_unset_mode(>->uc.guc));
xe_oa_free_configs(stream);
xe_file_put(stream->xef);
@@ -1765,8 +1765,7 @@ static int xe_oa_stream_init(struct xe_oa_stream *stream,
* state. Prevent this by overriding GUCRC mode.
*/
if (XE_GT_WA(stream->gt, 1509372804)) {
- ret = xe_guc_pc_override_gucrc_mode(>->uc.guc.pc,
- SLPC_GUCRC_MODE_GUCRC_NO_RC6);
+ ret = xe_guc_rc_set_mode(>->uc.guc, SLPC_GUCRC_MODE_GUCRC_NO_RC6);
if (ret)
goto err_free_configs;
@@ -1824,7 +1823,7 @@ static int xe_oa_stream_init(struct xe_oa_stream *stream,
xe_force_wake_put(gt_to_fw(gt), stream->fw_ref);
xe_pm_runtime_put(stream->oa->xe);
if (stream->override_gucrc)
- xe_gt_WARN_ON(gt, xe_guc_pc_unset_gucrc_mode(>->uc.guc.pc));
+ xe_gt_WARN_ON(gt, xe_guc_rc_unset_mode(>->uc.guc));
err_free_configs:
xe_oa_free_configs(stream);
exit:
--
2.38.1
^ permalink raw reply related [flat|nested] 11+ messages in thread