Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/sched: Re-queue run job worker when drm_sched_entity_pop_job() returns NULL
@ 2024-01-30  3:04 Matthew Brost
  2024-01-30  3:07 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 15+ messages in thread
From: Matthew Brost @ 2024-01-30  3:04 UTC (permalink / raw)
  To: intel-xe, dri-devel; +Cc: airlied, christian.koenig, ltuikov89

Rather then loop over entities until one with a ready job is found,
re-queue the run job worker when drm_sched_entity_pop_job() returns NULL.

Fixes: 6dbd9004a55 ("drm/sched: Drain all entities in DRM sched run job worker")
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/scheduler/sched_main.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
index 8acbef7ae53d..7e90c9f95611 100644
--- a/drivers/gpu/drm/scheduler/sched_main.c
+++ b/drivers/gpu/drm/scheduler/sched_main.c
@@ -1178,21 +1178,24 @@ static void drm_sched_run_job_work(struct work_struct *w)
 	struct drm_sched_entity *entity;
 	struct dma_fence *fence;
 	struct drm_sched_fence *s_fence;
-	struct drm_sched_job *sched_job = NULL;
+	struct drm_sched_job *sched_job;
 	int r;
 
 	if (READ_ONCE(sched->pause_submit))
 		return;
 
 	/* Find entity with a ready job */
-	while (!sched_job && (entity = drm_sched_select_entity(sched))) {
-		sched_job = drm_sched_entity_pop_job(entity);
-		if (!sched_job)
-			complete_all(&entity->entity_idle);
-	}
+	entity = drm_sched_select_entity(sched);
 	if (!entity)
 		return;	/* No more work */
 
+	sched_job = drm_sched_entity_pop_job(entity);
+	if (!sched_job) {
+		complete_all(&entity->entity_idle);
+		drm_sched_run_job_queue(sched);
+		return;
+	}
+
 	s_fence = sched_job->s_fence;
 
 	atomic_add(sched_job->credits, &sched->credit_count);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2024-02-06  2:06 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-30  3:04 [PATCH] drm/sched: Re-queue run job worker when drm_sched_entity_pop_job() returns NULL Matthew Brost
2024-01-30  3:07 ` ✓ CI.Patch_applied: success for " Patchwork
2024-01-30  3:07 ` ✗ CI.checkpatch: warning " Patchwork
2024-01-30  3:08 ` ✓ CI.KUnit: success " Patchwork
2024-01-30  3:15 ` ✓ CI.Build: " Patchwork
2024-01-30  3:15 ` ✓ CI.Hooks: " Patchwork
2024-01-30  3:17 ` ✓ CI.checksparse: " Patchwork
2024-01-30  3:39 ` ✓ CI.BAT: " Patchwork
2024-01-30  7:05 ` [PATCH] " Christian König
2024-02-02 21:58   ` Rodrigo Vivi
2024-02-05  8:44     ` Christian König
2024-02-05 13:33       ` Rodrigo Vivi
2024-02-06  0:56         ` Luben Tuikov
2024-02-06  2:05           ` Dave Airlie
2024-02-06  0:45 ` Luben Tuikov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox