Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/dp: Wait more before rearming FIFO underrun during retrain
@ 2024-06-26  8:36 Ankit Nautiyal
  2024-06-26  8:40 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 13+ messages in thread
From: Ankit Nautiyal @ 2024-06-26  8:36 UTC (permalink / raw)
  To: intel-gfx, intel-xe

During Link re-training reporting underrun is disabled and then
renabled after re-training is completed. For BMG its seen that we get
FIFO underrun just after the retraining is completed and the underrun
reporting is re-enabled.
Add one more intel_crtc_wait_for_next_vblank before re-arming the
underruns.

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 3903f6ead6e6..25af51499383 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -5325,7 +5325,12 @@ static int intel_dp_retrain_link(struct intel_encoder *encoder,
 		const struct intel_crtc_state *crtc_state =
 			to_intel_crtc_state(crtc->base.state);
 
-		/* Keep underrun reporting disabled until things are stable */
+		/*
+		 * Keep underrun reporting disabled until things are stable.
+		 * Wait for some more time, as we see (at least on BMG) that
+		 * underrun gets reported just after the reporting is enabled.
+		 */
+		intel_crtc_wait_for_next_vblank(crtc);
 		intel_crtc_wait_for_next_vblank(crtc);
 
 		intel_set_cpu_fifo_underrun_reporting(dev_priv, crtc->pipe, true);
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2024-07-03  6:28 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-26  8:36 [PATCH] drm/i915/dp: Wait more before rearming FIFO underrun during retrain Ankit Nautiyal
2024-06-26  8:40 ` ✓ CI.Patch_applied: success for " Patchwork
2024-06-26  8:40 ` ✗ CI.checkpatch: warning " Patchwork
2024-06-26  8:41 ` ✓ CI.KUnit: success " Patchwork
2024-06-26  8:53 ` ✓ CI.Build: " Patchwork
2024-06-26  8:56 ` ✓ CI.Hooks: " Patchwork
2024-06-26  8:58 ` ✗ CI.checksparse: warning " Patchwork
2024-06-26  9:21 ` ✓ CI.BAT: success " Patchwork
2024-06-26 10:35 ` ✗ CI.FULL: failure " Patchwork
2024-06-26 15:13 ` [PATCH] " Rodrigo Vivi
2024-06-26 15:18   ` Runyan, Arthur J
2024-06-26 15:43     ` Imre Deak
2024-07-03  6:27       ` Nautiyal, Ankit K

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox