From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/i915/de: Move intel_de_wait*() into intel_de.c
Date: Fri, 13 Mar 2026 16:21:28 +0200 [thread overview]
Message-ID: <5c029eac8bab1466ff942cd71ee9d33bd0370da4@intel.com> (raw)
In-Reply-To: <20260313111028.25159-3-ville.syrjala@linux.intel.com>
On Fri, 13 Mar 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> intel_de_wait*() end up doing quite a bit of stuff, so the one
> function call overhead from them seems insignificant. Move the
> implementation intel_de.c.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_de.c | 72 ++++++++++++++++++
> drivers/gpu/drm/i915/display/intel_de.h | 99 +++++--------------------
> 2 files changed, 92 insertions(+), 79 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_de.c b/drivers/gpu/drm/i915/display/intel_de.c
> index 5348c1d51eb8..fce92535bd6a 100644
> --- a/drivers/gpu/drm/i915/display/intel_de.c
> +++ b/drivers/gpu/drm/i915/display/intel_de.c
> @@ -7,6 +7,78 @@
>
> #include "intel_de.h"
>
> +int intel_de_wait_us(struct intel_display *display, i915_reg_t reg,
> + u32 mask, u32 value, unsigned int timeout_us,
> + u32 *out_value)
> +{
> + int ret;
> +
> + intel_dmc_wl_get(display, reg);
> +
> + ret = __intel_wait_for_register(__to_uncore(display), reg, mask,
> + value, timeout_us, 0, out_value);
> +
> + intel_dmc_wl_put(display, reg);
> +
> + return ret;
> +}
> +
> +int intel_de_wait_ms(struct intel_display *display, i915_reg_t reg,
> + u32 mask, u32 value, unsigned int timeout_ms,
> + u32 *out_value)
> +{
> + int ret;
> +
> + intel_dmc_wl_get(display, reg);
> +
> + ret = __intel_wait_for_register(__to_uncore(display), reg, mask,
> + value, 2, timeout_ms, out_value);
> +
> + intel_dmc_wl_put(display, reg);
> +
> + return ret;
> +}
> +
> +int intel_de_wait_fw_ms(struct intel_display *display, i915_reg_t reg,
> + u32 mask, u32 value, unsigned int timeout_ms,
> + u32 *out_value)
> +{
> + return __intel_wait_for_register_fw(__to_uncore(display), reg, mask,
> + value, 2, timeout_ms, out_value);
> +}
> +
> +int intel_de_wait_fw_us_atomic(struct intel_display *display, i915_reg_t reg,
> + u32 mask, u32 value, unsigned int timeout_us,
> + u32 *out_value)
> +{
> + return __intel_wait_for_register_fw(__to_uncore(display), reg, mask,
> + value, timeout_us, 0, out_value);
> +}
> +
> +int intel_de_wait_for_set_us(struct intel_display *display, i915_reg_t reg,
> + u32 mask, unsigned int timeout_us)
> +{
> + return intel_de_wait_us(display, reg, mask, mask, timeout_us, NULL);
> +}
> +
> +int intel_de_wait_for_clear_us(struct intel_display *display, i915_reg_t reg,
> + u32 mask, unsigned int timeout_us)
> +{
> + return intel_de_wait_us(display, reg, mask, 0, timeout_us, NULL);
> +}
> +
> +int intel_de_wait_for_set_ms(struct intel_display *display, i915_reg_t reg,
> + u32 mask, unsigned int timeout_ms)
> +{
> + return intel_de_wait_ms(display, reg, mask, mask, timeout_ms, NULL);
> +}
> +
> +int intel_de_wait_for_clear_ms(struct intel_display *display, i915_reg_t reg,
> + u32 mask, unsigned int timeout_ms)
> +{
> + return intel_de_wait_ms(display, reg, mask, 0, timeout_ms, NULL);
> +}
> +
> u8 intel_de_read8(struct intel_display *display, i915_reg_t reg)
> {
> /* this is only used on VGA registers (possible on pre-g4x) */
> diff --git a/drivers/gpu/drm/i915/display/intel_de.h b/drivers/gpu/drm/i915/display/intel_de.h
> index 8ca5904ba84e..f87b84ab9d6d 100644
> --- a/drivers/gpu/drm/i915/display/intel_de.h
> +++ b/drivers/gpu/drm/i915/display/intel_de.h
> @@ -86,85 +86,26 @@ intel_de_rmw(struct intel_display *display, i915_reg_t reg, u32 clear, u32 set)
> return val;
> }
>
> -static inline int
> -intel_de_wait_us(struct intel_display *display, i915_reg_t reg,
> - u32 mask, u32 value, unsigned int timeout_us,
> - u32 *out_value)
> -{
> - int ret;
> -
> - intel_dmc_wl_get(display, reg);
> -
> - ret = __intel_wait_for_register(__to_uncore(display), reg, mask,
> - value, timeout_us, 0, out_value);
> -
> - intel_dmc_wl_put(display, reg);
> -
> - return ret;
> -}
> -
> -static inline int
> -intel_de_wait_ms(struct intel_display *display, i915_reg_t reg,
> - u32 mask, u32 value, unsigned int timeout_ms,
> - u32 *out_value)
> -{
> - int ret;
> -
> - intel_dmc_wl_get(display, reg);
> -
> - ret = __intel_wait_for_register(__to_uncore(display), reg, mask,
> - value, 2, timeout_ms, out_value);
> -
> - intel_dmc_wl_put(display, reg);
> -
> - return ret;
> -}
> -
> -static inline int
> -intel_de_wait_fw_ms(struct intel_display *display, i915_reg_t reg,
> - u32 mask, u32 value, unsigned int timeout_ms,
> - u32 *out_value)
> -{
> - return __intel_wait_for_register_fw(__to_uncore(display), reg, mask,
> - value, 2, timeout_ms, out_value);
> -}
> -
> -static inline int
> -intel_de_wait_fw_us_atomic(struct intel_display *display, i915_reg_t reg,
> - u32 mask, u32 value, unsigned int timeout_us,
> - u32 *out_value)
> -{
> - return __intel_wait_for_register_fw(__to_uncore(display), reg, mask,
> - value, timeout_us, 0, out_value);
> -}
> -
> -static inline int
> -intel_de_wait_for_set_us(struct intel_display *display, i915_reg_t reg,
> - u32 mask, unsigned int timeout_us)
> -{
> - return intel_de_wait_us(display, reg, mask, mask, timeout_us, NULL);
> -}
> -
> -static inline int
> -intel_de_wait_for_clear_us(struct intel_display *display, i915_reg_t reg,
> - u32 mask, unsigned int timeout_us)
> -{
> - return intel_de_wait_us(display, reg, mask, 0, timeout_us, NULL);
> -}
> -
> -static inline int
> -intel_de_wait_for_set_ms(struct intel_display *display, i915_reg_t reg,
> - u32 mask, unsigned int timeout_ms)
> -{
> - return intel_de_wait_ms(display, reg, mask, mask, timeout_ms, NULL);
> -}
> -
> -static inline int
> -intel_de_wait_for_clear_ms(struct intel_display *display, i915_reg_t reg,
> - u32 mask, unsigned int timeout_ms)
> -{
> - return intel_de_wait_ms(display, reg, mask, 0, timeout_ms, NULL);
> -}
> +int intel_de_wait_us(struct intel_display *display, i915_reg_t reg,
> + u32 mask, u32 value, unsigned int timeout_us,
> + u32 *out_value);
> +int intel_de_wait_ms(struct intel_display *display, i915_reg_t reg,
> + u32 mask, u32 value, unsigned int timeout_ms,
> + u32 *out_value);
> +int intel_de_wait_fw_ms(struct intel_display *display, i915_reg_t reg,
> + u32 mask, u32 value, unsigned int timeout_ms,
> + u32 *out_value);
> +int intel_de_wait_fw_us_atomic(struct intel_display *display, i915_reg_t reg,
> + u32 mask, u32 value, unsigned int timeout_us,
> + u32 *out_value);
> +int intel_de_wait_for_set_us(struct intel_display *display, i915_reg_t reg,
> + u32 mask, unsigned int timeout_us);
> +int intel_de_wait_for_clear_us(struct intel_display *display, i915_reg_t reg,
> + u32 mask, unsigned int timeout_us);
> +int intel_de_wait_for_set_ms(struct intel_display *display, i915_reg_t reg,
> + u32 mask, unsigned int timeout_ms);
> +int intel_de_wait_for_clear_ms(struct intel_display *display, i915_reg_t reg,
> + u32 mask, unsigned int timeout_ms);
>
> /*
> * Unlocked mmio-accessors, think carefully before using these.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2026-03-13 14:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 11:10 [PATCH 0/3] drm/i915/de: Move register polling into display code Ville Syrjala
2026-03-13 11:10 ` [PATCH 1/3] drm/i915/de: Introduce intel_de.c and move intel_de_{read, write}8() there Ville Syrjala
2026-03-13 14:21 ` Jani Nikula
2026-03-13 11:10 ` [PATCH 2/3] drm/i915/de: Move intel_de_wait*() into intel_de.c Ville Syrjala
2026-03-13 14:21 ` Jani Nikula [this message]
2026-03-13 11:10 ` [PATCH 3/3] drm/i915/de: Implement register polling in the display code Ville Syrjala
2026-03-13 15:03 ` Jani Nikula
2026-03-17 7:52 ` Ville Syrjälä
2026-03-23 9:50 ` Ville Syrjälä
2026-03-14 8:09 ` kernel test robot
2026-03-23 9:43 ` [PATCH v2 " Ville Syrjala
2026-03-13 11:15 ` ✗ CI.checkpatch: warning for drm/i915/de: Move register polling into " Patchwork
2026-03-13 11:17 ` ✓ CI.KUnit: success " Patchwork
2026-03-13 11:51 ` ✓ Xe.CI.BAT: " Patchwork
2026-03-14 14:29 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-03-23 10:43 ` ✗ CI.checkpatch: warning for drm/i915/de: Move register polling into display code (rev2) Patchwork
2026-03-23 10:45 ` ✓ CI.KUnit: success " Patchwork
2026-03-23 11:26 ` ✓ Xe.CI.BAT: " Patchwork
2026-03-23 13:56 ` ✓ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c029eac8bab1466ff942cd71ee9d33bd0370da4@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox