Re: [PATCH v5 10/11] drm/xe: Add exec queue active vfunc

["Summers, Stuart" <stuart.summers@intel.com>]

On Fri, 2026-01-16 at 14:17 -0800, Matthew Brost wrote:
> If an exec queue is inactive (e.g., not registered or scheduling is
> disabled), TLB invalidations are not issued for that queue. Add a
> virtual function to determine the active state, which TLB
> invalidation
> logic can hook into.
> 
> v5:
>  - Operate on primary in active function
> 
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Stuart Summers <stuart.summers@intel.com>

> Tested-by: Stuart Summers <stuart.summers@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_exec_queue_types.h | 2 ++
>  drivers/gpu/drm/xe/xe_execlist.c         | 7 +++++++
>  drivers/gpu/drm/xe/xe_guc_submit.c       | 9 +++++++++
>  3 files changed, 18 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_exec_queue_types.h
> b/drivers/gpu/drm/xe/xe_exec_queue_types.h
> index d3e2789cf5bc..9cca558c5809 100644
> --- a/drivers/gpu/drm/xe/xe_exec_queue_types.h
> +++ b/drivers/gpu/drm/xe/xe_exec_queue_types.h
> @@ -298,6 +298,8 @@ struct xe_exec_queue_ops {
>         void (*resume)(struct xe_exec_queue *q);
>         /** @reset_status: check exec queue reset status */
>         bool (*reset_status)(struct xe_exec_queue *q);
> +       /** @active: check exec queue is active */
> +       bool (*active)(struct xe_exec_queue *q);
>  };
>  
>  #endif
> diff --git a/drivers/gpu/drm/xe/xe_execlist.c
> b/drivers/gpu/drm/xe/xe_execlist.c
> index 8bf330aeaec0..005a5b2c36fe 100644
> --- a/drivers/gpu/drm/xe/xe_execlist.c
> +++ b/drivers/gpu/drm/xe/xe_execlist.c
> @@ -468,6 +468,12 @@ static bool
> execlist_exec_queue_reset_status(struct xe_exec_queue *q)
>         return false;
>  }
>  
> +static bool execlist_exec_queue_active(struct xe_exec_queue *q)
> +{
> +       /* NIY */
> +       return false;
> +}
> +
>  static const struct xe_exec_queue_ops execlist_exec_queue_ops = {
>         .init = execlist_exec_queue_init,
>         .kill = execlist_exec_queue_kill,
> @@ -480,6 +486,7 @@ static const struct xe_exec_queue_ops
> execlist_exec_queue_ops = {
>         .suspend_wait = execlist_exec_queue_suspend_wait,
>         .resume = execlist_exec_queue_resume,
>         .reset_status = execlist_exec_queue_reset_status,
> +       .active = execlist_exec_queue_active,
>  };
>  
>  int xe_execlist_init(struct xe_gt *gt)
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c
> b/drivers/gpu/drm/xe/xe_guc_submit.c
> index 1b2f66f4425b..e9f9f844d50e 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -2206,6 +2206,14 @@ static bool guc_exec_queue_reset_status(struct
> xe_exec_queue *q)
>         return exec_queue_reset(q) ||
> exec_queue_killed_or_banned_or_wedged(q);
>  }
>  
> +static bool guc_exec_queue_active(struct xe_exec_queue *q)
> +{
> +       struct xe_exec_queue *primary =
> xe_exec_queue_multi_queue_primary(q);
> +
> +       return exec_queue_enabled(primary) &&
> +               !exec_queue_pending_disable(primary);
> +}
> +
>  /*
>   * All of these functions are an abstraction layer which other parts
> of Xe can
>   * use to trap into the GuC backend. All of these functions, aside
> from init,
> @@ -2225,6 +2233,7 @@ static const struct xe_exec_queue_ops
> guc_exec_queue_ops = {
>         .suspend_wait = guc_exec_queue_suspend_wait,
>         .resume = guc_exec_queue_resume,
>         .reset_status = guc_exec_queue_reset_status,
> +       .active = guc_exec_queue_active,
>  };
>  
>  static void guc_exec_queue_stop(struct xe_guc *guc, struct
> xe_exec_queue *q)