Re: [PATCH 04/16] drm/i915/display: Move intel_psr_post_plane_update() at the later

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 3/24/2025 7:02 PM, Ankit Nautiyal wrote:
> In intel_post_plane_update() there are things which might need to do
> vblank waits, so enabling PSR as early as we do now is simply
> counter-productive. Therefore move intel_psr_post_plane_update() at the
> last of intel_post_plane_update().
>
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Hi Jouni,

Missed to carry forward your Rb tag while sending the new version.

Thanks for looking into the patch and the review.

Regards,

Ankit

> ---
>   drivers/gpu/drm/i915/display/intel_display.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 53675a92bbf5..b68b86923dca 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -1049,8 +1049,6 @@ static void intel_post_plane_update(struct intel_atomic_state *state,
>   		intel_atomic_get_new_crtc_state(state, crtc);
>   	enum pipe pipe = crtc->pipe;
>   
> -	intel_psr_post_plane_update(state, crtc);
> -
>   	intel_frontbuffer_flip(dev_priv, new_crtc_state->fb_bits);
>   
>   	if (new_crtc_state->update_wm_post && new_crtc_state->hw.active)
> @@ -1079,6 +1077,8 @@ static void intel_post_plane_update(struct intel_atomic_state *state,
>   
>   	if (audio_enabling(old_crtc_state, new_crtc_state))
>   		intel_encoders_audio_enable(state, crtc);
> +
> +	intel_psr_post_plane_update(state, crtc);
>   }
>   
>   static void intel_post_plane_update_after_readout(struct intel_atomic_state *state,