Re: [PATCH v4 0/8] drm/i915: move more display dependencies from i915

[Jani Nikula <jani.nikula@linux.intel.com>]

On Mon, 20 Apr 2026, Luca Coelho <luciano.coelho@intel.com> wrote:
> This series continues my work of refactoring the clock gating
> initialization, so that i915 doesn't do display-specific stuff.
>
> With this, all register dependencies should be gone.
>
> Changes in v4:
> 	* Explain why HAS_LLC() is not needed anymore (Jani);
> 	* Replace intel_display_core.h include with intel_pch.h (Jani);
>
> Please review.

There's the one omission in patch 5 that I pointed out that needs to be
fixed.

Other than that, this is

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

I do have a nagging feeling that further refactoring will be needed, as
this introduces a plethora of new display interfaces i915 core needs to
call, and we should work to minimize that surface. However, this is good
stuff for moving the display stuff out of i915 core, so let's roll with
this.

A minor nit for further reference. If you can, please try to avoid
combining code movement and other changes. Reviewing pure code movement
with 'git show --color-moved' is quick. Reviewing other mechanical
changes with 'git show --color-words' is also quick. Unfortunately,
having code movement and other inline changes in one breaks both
approaches, and you have to fall back to more manual review.

BR,
Jani.


>
> Cheers,
> Luca.
>
>
> Luca Coelho (8):
>   drm/i915: move SKL clock gating init to display
>   drm/i915: move KBL clock gating init to display
>   drm/i915/display: move CFL clock gating init to display
>   drm/i915/display: move BXT clock gating init to display
>   drm/i915/display: move GLK clock gating init to display
>   drm/i915/display: move HSW and BDW clock gating init to display
>   drm/i915/display: move pre-HSW clock gating init to display
>   drm/i915: remove HAS_PCH_NOP() dependency from clock gating
>
>  drivers/gpu/drm/i915/Makefile                 |   1 +
>  .../i915/display/intel_display_clock_gating.c | 255 ++++++++++++++++++
>  .../i915/display/intel_display_clock_gating.h |  27 ++
>  .../gpu/drm/i915/display/intel_display_regs.h |  31 +++
>  drivers/gpu/drm/i915/i915_reg.h               |  31 ---
>  drivers/gpu/drm/i915/intel_clock_gating.c     | 226 ++--------------
>  6 files changed, 331 insertions(+), 240 deletions(-)
>  create mode 100644 drivers/gpu/drm/i915/display/intel_display_clock_gating.c
>  create mode 100644 drivers/gpu/drm/i915/display/intel_display_clock_gating.h

-- 
Jani Nikula, Intel