Re: [PATCH] drm/xe/pmu: Remove PMU from Xe till uapi is finalized

[Aravind Iddamsetty <aravind.iddamsetty@linux.intel.com>]

On 12/11/23 12:05, Dixit, Ashutosh wrote:

Hi Ashutosh,
> On Sun, 10 Dec 2023 22:04:25 -0800, Aravind Iddamsetty wrote:
> Hi Aravind,
>
>> On 12/10/23 04:22, Dixit, Ashutosh wrote:
>>> On Sat, 09 Dec 2023 14:43:52 -0800, Ashutosh Dixit wrote:
>>>> PMU uapi is likely to change in the future. Till the uapi is finalized,
>>>> remove PMU from Xe. PMU can be re-added after uapi is finalized.
>> Hi Ashutosh,
>>
>> Is it possible to have the infra as it is and just remove the events
>> part.
> If you want to send a patch which can do this cleanly please go ahead. I
> was trying it but it was looking odd that the infra is there but no events
> were exposed.

Ya agree with you it won't look nice without any events, a piece of unused code.

so acking your patch to remove it.

Acked-by: Aravind Iddamsetty <aravind.iddamsetty@linux.intel.com>

I believe we should also drop the corresponding IGT test xe_perf_pmu.

Thanks,
Aravind.
>
>> As there is follow on series from Riana which uses the infra
>> https://patchwork.freedesktop.org/series/126919/.  or the other
>> alternative would be for Riana to bring in the infra as part of her
>> series.
> So that is why I thought it would be easier if deleted the whole thing now
> and later Riana or Umesh could add an initial patch, authored by you, which
> adds the PMU infrastructure and then add their part in separate patches.
>
> Thanks.
> --
> Ashutosh
>
>>> Complete removal of PMU for now is probably preferable than what was done
>>> in:
>>>
>>> https://patchwork.freedesktop.org/series/127590/
>>>
>>> Also, it is probably preferable to remove PMU code via a rebase, but if
>>> that is time consuming, adding this patch will remove PMU code.
>>>
>>> I was trying to send a series of 'fixup' patches, but that seemed difficult
>>> because a large number of patches have touched non-PMU files, so all those
>>> patches will need to be fixed up.
>>>
>>> Thanks.
>>> --
>>> Ashutosh