Re: [PATCH] drm/xe/pmu: Remove PMU from Xe till uapi is finalized

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Mon, 11 Dec 2023 13:30:02 -0800, Francois Dugast wrote:

Hi Francois,

>
> On Mon, Dec 11, 2023 at 10:25:09AM -0800, Umesh Nerlige Ramappa wrote:
> > On Sat, Dec 09, 2023 at 02:43:52PM -0800, Ashutosh Dixit wrote:
> > > PMU uapi is likely to change in the future. Till the uapi is finalized,
> > > remove PMU from Xe. PMU can be re-added after uapi is finalized.
> > >
> > > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> >
> > I guess partial removal was messy. This is fine.
> >
> > Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
>
> It seems this patch cannot be used as it is, I am getting the same error
> as the one reported by CI:
>
>     ../drivers/gpu/drm/xe/tests/xe_dma_buf.c:125:47: error: \
>     ‘DRM_XE_GEM_CPU_CACHING_WC’ undeclared (first use in this function)
>       125 |  bo = xe_bo_create_user(xe, NULL, NULL, size, DRM_XE_GEM_CPU_CACHING_WC,
>
> drivers/gpu/drm/xe/tests/xe_dma_buf.c appears to be missing a:
>
>     #include <drm/xe_drm.h>

I had a missing CONFIG_KUNIT, added this line and posted this:

https://patchwork.freedesktop.org/series/127598/#rev3

Actually posted another version here with a separate 'fixup' to
drivers/gpu/drm/xe/tests/xe_dma_buf.c:

https://patchwork.freedesktop.org/series/127664/

Both should be fine. Please pick one.

Thanks.
--
Ashutosh