Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Aravind Iddamsetty <aravind.iddamsetty@linux.intel.com>
Cc: francois.dugast@intel.com,
	Lucas De Marchi <lucas.demarchi@intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	intel-xe@lists.freedesktop.org
Subject: Re: [PATCH] drm/xe/pmu: Remove PMU from Xe till uapi is finalized
Date: Sun, 10 Dec 2023 22:35:48 -0800	[thread overview]
Message-ID: <87il55i6uz.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <aecbe74c-af61-4ea8-984b-c7d5ff3133c1@linux.intel.com>

On Sun, 10 Dec 2023 22:04:25 -0800, Aravind Iddamsetty wrote:
>

Hi Aravind,

> On 12/10/23 04:22, Dixit, Ashutosh wrote:
> > On Sat, 09 Dec 2023 14:43:52 -0800, Ashutosh Dixit wrote:
> >> PMU uapi is likely to change in the future. Till the uapi is finalized,
> >> remove PMU from Xe. PMU can be re-added after uapi is finalized.
>
> Hi Ashutosh,
>
> Is it possible to have the infra as it is and just remove the events
> part.

If you want to send a patch which can do this cleanly please go ahead. I
was trying it but it was looking odd that the infra is there but no events
were exposed.

> As there is follow on series from Riana which uses the infra
> https://patchwork.freedesktop.org/series/126919/.  or the other
> alternative would be for Riana to bring in the infra as part of her
> series.

So that is why I thought it would be easier if deleted the whole thing now
and later Riana or Umesh could add an initial patch, authored by you, which
adds the PMU infrastructure and then add their part in separate patches.

Thanks.
--
Ashutosh

> > Complete removal of PMU for now is probably preferable than what was done
> > in:
> >
> > https://patchwork.freedesktop.org/series/127590/
> >
> > Also, it is probably preferable to remove PMU code via a rebase, but if
> > that is time consuming, adding this patch will remove PMU code.
> >
> > I was trying to send a series of 'fixup' patches, but that seemed difficult
> > because a large number of patches have touched non-PMU files, so all those
> > patches will need to be fixed up.
> >
> > Thanks.
> > --
> > Ashutosh

  reply	other threads:[~2023-12-11  6:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-09 22:43 [PATCH] drm/xe/pmu: Remove PMU from Xe till uapi is finalized Ashutosh Dixit
2023-12-09 22:46 ` ✓ CI.Patch_applied: success for drm/xe/pmu: Remove PMU from Xe till uapi is finalized (rev2) Patchwork
2023-12-09 22:46 ` ✗ CI.checkpatch: warning " Patchwork
2023-12-09 22:46 ` ✗ CI.KUnit: failure " Patchwork
2023-12-09 22:52 ` [PATCH] drm/xe/pmu: Remove PMU from Xe till uapi is finalized Dixit, Ashutosh
2023-12-11  6:04   ` Aravind Iddamsetty
2023-12-11  6:35     ` Dixit, Ashutosh [this message]
2023-12-11  7:03       ` Aravind Iddamsetty
2023-12-11 16:29 ` Lucas De Marchi
2023-12-11 18:25 ` Umesh Nerlige Ramappa
2023-12-11 21:30   ` Francois Dugast
2023-12-12  4:05     ` Dixit, Ashutosh
  -- strict thread matches above, loose matches on Subject: below --
2023-12-12  3:41 Ashutosh Dixit
2023-12-09 22:43 Ashutosh Dixit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87il55i6uz.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=aravind.iddamsetty@linux.intel.com \
    --cc=francois.dugast@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox