Re: [PATCH 10/17] drm/xe/oa/uapi: Read file_operation

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Tue, 19 Dec 2023 19:01:57 -0800, Umesh Nerlige Ramappa wrote:
>

Hi Umesh,

> > +static int xe_oa_append_status(struct xe_oa_stream *stream, char __user *buf,
> > +			       size_t count, size_t *offset,
> > +			       enum drm_xe_oa_record_type type)
>
> space/indent ^
>
> > +{
> > +	struct drm_xe_oa_record_header header = { type, 0, sizeof(header) };
> > +
> > +	if ((count - *offset) < header.size)
> > +		return -ENOSPC;
> > +
> > +	if (copy_to_user(buf + *offset, &header, sizeof(header)))
> > +		return -EFAULT;
> > +
> > +	*offset += header.size;
> > +
> > +	return 0;
> > +}
> > +
> > +static int xe_oa_append_sample(struct xe_oa_stream *stream, char __user *buf,
> > +			       size_t count, size_t *offset, const u8 *report)
>
> space/indent ^ and a couple more places, in this patch.
>
> With some indents addressed, this is:

Indents are fine and patches have gone through checkpatch. These indents
may look off in the patches sometimes (say due to the additional +
character) but in reality they are fine.

> Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>

Thanks.
--
Ashutosh