Re: [PATCH 09/17] drm/xe/oa/uapi: Expose OA stream fd

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Tue, 19 Dec 2023 18:52:58 -0800, Umesh Nerlige Ramappa wrote:
>
> On Thu, Dec 07, 2023 at 10:43:21PM -0800, Ashutosh Dixit wrote:
> > The OA stream open perf op returns an fd with its own file_operations for
> > the newly initialized OA stream. These file_operations allow userspace to
> > enable or disable the stream, as well as apply a different metric
> > configuration for the OA stream. Userspace can also poll for data
> > availability. OA stream initialization is completed in this commit by
> > enabling the OA stream. When sampling is enabled this starts a hrtimer
> > which periodically checks for data availablility.
> >
> > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>
> lgtm
>
> Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>

Thanks, though the question here is can we avoid introducing the read()
interface and can just do with mmap. For v8, I'm assuming we need read()
too, but let's revisit afterwards.

Thanks.
--
Ashutosh