Re: [PATCH 1/6] drm/xe: Drop unused param from xe_device_create()

[Gustavo Sousa <gustavo.sousa@intel.com>]

Michal Wajdeczko <michal.wajdeczko@intel.com> writes:

> We never used or need anything from the struct pci_device_id there.
> And while around, add simple kernel-doc for this function.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_device.c | 11 +++++++++--
>  drivers/gpu/drm/xe/xe_device.h |  3 +--
>  drivers/gpu/drm/xe/xe_pci.c    |  2 +-
>  3 files changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index 576095cf0952..3f063e5530bb 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -475,8 +475,15 @@ static void xe_device_destroy(struct drm_device *dev, void *dummy)
>  	ttm_device_fini(&xe->ttm);
>  }
>  
> -struct xe_device *xe_device_create(struct pci_dev *pdev,
> -				   const struct pci_device_id *ent)
> +/**
> + * xe_device_create() - Create a new &xe_device instance
> + * @pdev: the parent &pci_dev
> + *
> + * Allocate and initialize a device managed Xe device structure.
> + *
> + * Return: pointer to new &xe_device on success, or ERR_PTR on failure.
> + */
> +struct xe_device *xe_device_create(struct pci_dev *pdev)
>  {
>  	const struct drm_driver *driver = &regular_driver;
>  	struct xe_device *xe;
> diff --git a/drivers/gpu/drm/xe/xe_device.h b/drivers/gpu/drm/xe/xe_device.h
> index 355d69dc8f54..27cd2329b99f 100644
> --- a/drivers/gpu/drm/xe/xe_device.h
> +++ b/drivers/gpu/drm/xe/xe_device.h
> @@ -43,8 +43,7 @@ static inline struct xe_device *ttm_to_xe_device(struct ttm_device *ttm)
>  	return container_of(ttm, struct xe_device, ttm);
>  }
>  
> -struct xe_device *xe_device_create(struct pci_dev *pdev,
> -				   const struct pci_device_id *ent);
> +struct xe_device *xe_device_create(struct pci_dev *pdev);
>  int xe_device_probe_early(struct xe_device *xe);
>  int xe_device_probe(struct xe_device *xe);
>  void xe_device_remove(struct xe_device *xe);
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index e2a1232c4fbf..c2bf9f0c325b 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -1092,7 +1092,7 @@ static int xe_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>  	if (err)
>  		return err;
>  
> -	xe = xe_device_create(pdev, ent);
> +	xe = xe_device_create(pdev);
>  	if (IS_ERR(xe))
>  		return PTR_ERR(xe);
>  
> -- 
> 2.47.1