Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/4] Cleanup and fixes in drmm_add_action_or_reset usage
@ 2024-04-08 14:49 Himal Prasad Ghimiray
  2024-04-08 14:49 ` [PATCH v2 1/4] drm/xe: Simplify function return using drmm_add_action_or_reset() Himal Prasad Ghimiray
                   ` (11 more replies)
  0 siblings, 12 replies; 20+ messages in thread
From: Himal Prasad Ghimiray @ 2024-04-08 14:49 UTC (permalink / raw)
  To: intel-xe
  Cc: Himal Prasad Ghimiray, Rodrigo Vivi, Tejas Upadhyay,
	Daniele Ceraolo Spurio, Niranjana Vishwanathapura

drmm_add_action_or_reset automatically triggers the corresponding action
if there's a failure. However, certain functions were previously relying
on return codes to trigger cleanup, leading to redundant calls. Removed
these functions to prevent multiple invocations.

In case of a failure, drmm_add_action_or_reset automatically triggers a
warning message, such as 'failed to add action "action_name" for
"drm_device".' Despite this, the driver was redundantly issuing similar
warning messages upon failure, offering no additional value. Removed few 
of these redundant warnings calls.

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Tejas Upadhyay <tejas.upadhyay@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Himal Prasad Ghimiray (4):
  drm/xe: Simplify function return using drmm_add_action_or_reset()
  drm/xe: Incase of action add failure, remove sysfs only once.
  drm/xe: Incase of action add failure, free_gsc_pkt only once.
  drm/xe: Return NULL incase of drmm_add_action_or_reset failure

 drivers/gpu/drm/xe/display/xe_display.c       |  8 +------
 drivers/gpu/drm/xe/xe_device.c                |  6 +----
 drivers/gpu/drm/xe/xe_gsc_proxy.c             |  7 +-----
 drivers/gpu/drm/xe/xe_gt.c                    |  6 +----
 drivers/gpu/drm/xe/xe_gt_ccs_mode.c           |  7 ++----
 drivers/gpu/drm/xe/xe_guc_pc.c                |  6 +----
 drivers/gpu/drm/xe/xe_huc.c                   |  9 +-------
 drivers/gpu/drm/xe/xe_hw_engine.c             |  6 +----
 drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.c | 22 +++++--------------
 9 files changed, 14 insertions(+), 63 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2024-04-10 13:49 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-08 14:49 [PATCH 0/4] Cleanup and fixes in drmm_add_action_or_reset usage Himal Prasad Ghimiray
2024-04-08 14:49 ` [PATCH v2 1/4] drm/xe: Simplify function return using drmm_add_action_or_reset() Himal Prasad Ghimiray
2024-04-08 15:08   ` Jani Nikula
2024-04-09 19:48     ` Lucas De Marchi
2024-04-08 14:49 ` [PATCH v2 2/4] drm/xe: Incase of action add failure, remove sysfs only once Himal Prasad Ghimiray
2024-04-09 19:52   ` Lucas De Marchi
2024-04-10  8:16     ` Ghimiray, Himal Prasad
2024-04-10 13:49       ` Lucas De Marchi
2024-04-08 14:49 ` [PATCH v2 3/4] drm/xe: Incase of action add failure, free_gsc_pkt " Himal Prasad Ghimiray
2024-04-08 17:32   ` Daniele Ceraolo Spurio
2024-04-08 14:49 ` [PATCH v2 4/4] drm/xe: Return NULL incase of drmm_add_action_or_reset failure Himal Prasad Ghimiray
2024-04-09 19:55   ` Lucas De Marchi
2024-04-08 16:58 ` ✓ CI.Patch_applied: success for Cleanup and fixes in drmm_add_action_or_reset usage (rev2) Patchwork
2024-04-08 16:58 ` ✓ CI.checkpatch: " Patchwork
2024-04-08 16:59 ` ✓ CI.KUnit: " Patchwork
2024-04-08 17:11 ` ✓ CI.Build: " Patchwork
2024-04-08 17:14 ` ✓ CI.Hooks: " Patchwork
2024-04-08 17:15 ` ✓ CI.checksparse: " Patchwork
2024-04-08 17:42 ` ✓ CI.BAT: " Patchwork
2024-04-08 21:14 ` ✗ CI.FULL: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox