From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Guy Zadicario <gzadicario@habana.ai>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH 2/2] drm/xe/uapi: Multiplex PERF ops through a single PERF ioctl
Date: Wed, 11 Oct 2023 10:33:32 -0700 [thread overview]
Message-ID: <87lec9t66r.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <DB4PR02MB86074153DF64F83B00E66CAFDECCA@DB4PR02MB8607.eurprd02.prod.outlook.com>
On Wed, 11 Oct 2023 04:24:21 -0700, Guy Zadicario wrote:
>
Hi Guy,
>
> Replying to you only since I do not have access to my mailbox from
> text-based email client (trying to get there but IT guys runs me crazy ☹)
> I wasn't sure if reply from outlook work ok, is it?
Once in a while is ok, but if you are going to respond regularly on the
mailing list, a text based email client is preferable.
>
> The only comment I have is that enum @drm_xe_perf_op includes operations
> on a perf stream fd only and not operations on the main perf ioctl. Do
> we want to merge both types of operations in the same enum? If so, you
> need to add to that enum operations for OPEN,ADD_CONFIG,REMOVE_CONFIG.
You are absolutely right, I missed out on adding 'enum drm_xe_perf_op'
which was there in the original OA series. I've added it in v2 and also
cleaned up the naming and some other minor changes. The perf fd ioct's are
in a separate 'enum drm_xe_perf_ioctls'.
https://patchwork.freedesktop.org/series/124994/
Thanks so much.
--
Ashutosh
next prev parent reply other threads:[~2023-10-11 17:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 22:24 [Intel-xe] [PATCH 0/2] Xe PERF layer Ashutosh Dixit
2023-10-09 22:24 ` [Intel-xe] [PATCH 1/2] drm/xe/uapi: "Perf" layer to support multiple perf counter stream types Ashutosh Dixit
2023-10-09 22:24 ` [Intel-xe] [PATCH 2/2] drm/xe/uapi: Multiplex PERF ops through a single PERF ioctl Ashutosh Dixit
[not found] ` <DB4PR02MB86074153DF64F83B00E66CAFDECCA@DB4PR02MB8607.eurprd02.prod.outlook.com>
2023-10-11 17:33 ` Dixit, Ashutosh [this message]
2023-10-09 22:29 ` [Intel-xe] ✓ CI.Patch_applied: success for Xe PERF layer Patchwork
2023-10-09 22:29 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-10-09 22:30 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-10-09 22:37 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-10-09 22:38 ` [Intel-xe] ✗ CI.Hooks: failure " Patchwork
2023-10-09 22:39 ` [Intel-xe] ✓ CI.checksparse: success " Patchwork
2023-10-09 23:11 ` [Intel-xe] ✓ CI.BAT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-10-11 17:26 [Intel-xe] [PATCH v2 0/2] " Ashutosh Dixit
2023-10-11 17:26 ` [Intel-xe] [PATCH 2/2] drm/xe/uapi: Multiplex PERF ops through a single PERF ioctl Ashutosh Dixit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lec9t66r.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=gzadicario@habana.ai \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox