Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/uc: Don't emit false error if running in execlist mode
@ 2024-05-21 11:48 Michal Wajdeczko
  2024-05-21 14:53 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (9 more replies)
  0 siblings, 10 replies; 12+ messages in thread
From: Michal Wajdeczko @ 2024-05-21 11:48 UTC (permalink / raw)
  To: intel-xe; +Cc: Michal Wajdeczko, Daniele Ceraolo Spurio

When running in execlist mode (using force_execlist=1 modparam)
we incorrectly select the error path in xe_uc_init(), leading to
an unwanted error message like this:

[ ] xe 0000:00:00.0: [drm] *ERROR* GT0: Failed to initialize uC (0000000000000000)

Fix that by doing early return like we do in other similar cases.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
---
 drivers/gpu/drm/xe/xe_uc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_uc.c b/drivers/gpu/drm/xe/xe_uc.c
index 0186eafc947d..85808706d1c8 100644
--- a/drivers/gpu/drm/xe/xe_uc.c
+++ b/drivers/gpu/drm/xe/xe_uc.c
@@ -51,7 +51,7 @@ int xe_uc_init(struct xe_uc *uc)
 		goto err;
 
 	if (!xe_device_uc_enabled(uc_to_xe(uc)))
-		goto err;
+		return 0;
 
 	ret = xe_wopcm_init(&uc->wopcm);
 	if (ret)
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2024-05-23  0:39 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-21 11:48 [PATCH] drm/xe/uc: Don't emit false error if running in execlist mode Michal Wajdeczko
2024-05-21 14:53 ` ✓ CI.Patch_applied: success for " Patchwork
2024-05-21 14:53 ` ✗ CI.checkpatch: warning " Patchwork
2024-05-21 14:54 ` ✓ CI.KUnit: success " Patchwork
2024-05-21 15:06 ` ✓ CI.Build: " Patchwork
2024-05-21 15:08 ` ✓ CI.Hooks: " Patchwork
2024-05-21 15:10 ` ✓ CI.checksparse: " Patchwork
2024-05-21 15:39 ` ✓ CI.BAT: " Patchwork
2024-05-21 20:30 ` ✗ CI.FULL: failure " Patchwork
2024-05-22  9:27   ` Michal Wajdeczko
2024-05-22 16:08 ` [PATCH] " Daniele Ceraolo Spurio
2024-05-23  0:38 ` John Harrison

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox