Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Restore EIO errno return when GuC PC start fails
@ 2025-03-28 18:17 Rodrigo Vivi
  2025-03-28 20:52 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 11+ messages in thread
From: Rodrigo Vivi @ 2025-03-28 18:17 UTC (permalink / raw)
  To: intel-xe; +Cc: Rodrigo Vivi, Dan Carpenter

Commit b4b05e53b550 ("drm/xe/guc_pc: Retry and wait longer for GuC PC
start") from Mar 7, 2025 (linux-next), leads to the following Smatch
static checker warning:

        drivers/gpu/drm/xe/xe_guc_pc.c:1073 xe_guc_pc_start()
        warn: missing error code here? '_dev_err()' failed. 'ret' = '0'

Fixes: b4b05e53b550 ("drm/xe/guc_pc: Retry and wait longer for GuC PC start")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/intel-xe/1454a5f1-ee18-4df1-a6b2-a4a3dddcd1cb@stanley.mountain/
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_pc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c
index 85215313976c..43b1192ba61c 100644
--- a/drivers/gpu/drm/xe/xe_guc_pc.c
+++ b/drivers/gpu/drm/xe/xe_guc_pc.c
@@ -1070,6 +1070,7 @@ int xe_guc_pc_start(struct xe_guc_pc *pc)
 		if (wait_for_pc_state(pc, SLPC_GLOBAL_STATE_RUNNING,
 				      SLPC_RESET_EXTENDED_TIMEOUT_MS)) {
 			xe_gt_err(gt, "GuC PC Start failed: Dynamic GT frequency control and GT sleep states are now disabled.\n");
+			ret = -EIO;
 			goto out;
 		}
 
-- 
2.49.0


^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2025-03-31 15:27 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-28 18:17 [PATCH] drm/xe: Restore EIO errno return when GuC PC start fails Rodrigo Vivi
2025-03-28 20:52 ` ✓ CI.Patch_applied: success for " Patchwork
2025-03-28 20:52 ` ✓ CI.checkpatch: " Patchwork
2025-03-28 20:53 ` ✓ CI.KUnit: " Patchwork
2025-03-28 21:10 ` ✓ CI.Build: " Patchwork
2025-03-28 21:12 ` ✓ CI.Hooks: " Patchwork
2025-03-28 21:14 ` ✓ CI.checksparse: " Patchwork
2025-03-28 21:48 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-29 13:01 ` ✓ Xe.CI.Full: " Patchwork
2025-03-31 14:59 ` [PATCH] " Lucas De Marchi
2025-03-31 15:26   ` Rodrigo Vivi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox