Re: [Intel-xe] [PATCH 04/10] fixup! drm/xe: Introduce Xe assert macros

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Tue, Oct 03, 2023 at 05:34:51PM +0300, Jani Nikula wrote:
> Do not log or reference display details in xe_assert(). xe_assert() is
> not used in display code, and referencing display details in xe core
> just makes the code juggling with display integration more difficult.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_assert.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_assert.h b/drivers/gpu/drm/xe/xe_assert.h
> index 035e6a44afe6..34c142e6cfb0 100644
> --- a/drivers/gpu/drm/xe/xe_assert.h
> +++ b/drivers/gpu/drm/xe/xe_assert.h
> @@ -112,7 +112,6 @@
>  			"platform: %d subplatform: %d\n"					\
>  			"graphics: %s %u.%02u step %s\n"					\
>  			"media: %s %u.%02u step %s\n"						\
> -			"display: %s step %s\n"							\
>  			msg,									\
>  			__xe->info.platform, __xe->info.subplatform,				\
>  			__xe->info.graphics_name,						\
> @@ -123,8 +122,6 @@
>  			__xe->info.media_verx100 / 100,						\
>  			__xe->info.media_verx100 % 100,						\
>  			xe_step_name(__xe->info.step.media),					\
> -			str_enabled_disabled(__xe->info.enable_display),			\
> -			xe_step_name(__xe->info.step.display),					\
>  			## arg);								\
>  })
>  
> -- 
> 2.39.2
>