Re: [Intel-xe] [PATCH 10/10] fixup! drm/xe/display: Implement display support

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Tue, Oct 03, 2023 at 05:34:57PM +0300, Jani Nikula wrote:
> These checks no longer make sense, as has_display() has already been
> checked.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

I haven't carefully checked the code path, but it makes sense to me

Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>


> ---
>  drivers/gpu/drm/xe/xe_display.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_display.c b/drivers/gpu/drm/xe/xe_display.c
> index 70e7afc0a890..f8ca8ad65ef7 100644
> --- a/drivers/gpu/drm/xe/xe_display.c
> +++ b/drivers/gpu/drm/xe/xe_display.c
> @@ -349,8 +349,7 @@ void xe_display_pm_suspend(struct xe_device *xe)
>  	 * properly.
>  	 */
>  	intel_power_domains_disable(xe);
> -	if (has_display(xe))
> -		drm_kms_helper_poll_disable(&xe->drm);
> +	drm_kms_helper_poll_disable(&xe->drm);
>  
>  	intel_display_driver_suspend(xe);
>  
> @@ -395,8 +394,7 @@ void xe_display_pm_resume(struct xe_device *xe)
>  
>  	intel_dmc_resume(xe);
>  
> -	if (has_display(xe))
> -		drm_mode_config_reset(&xe->drm);
> +	drm_mode_config_reset(&xe->drm);
>  
>  	intel_display_driver_init_hw(xe);
>  	intel_hpd_init(xe);
> @@ -406,8 +404,7 @@ void xe_display_pm_resume(struct xe_device *xe)
>  	intel_display_driver_resume(xe);
>  
>  	intel_hpd_poll_disable(xe);
> -	if (has_display(xe))
> -		drm_kms_helper_poll_enable(&xe->drm);
> +	drm_kms_helper_poll_enable(&xe->drm);
>  
>  	intel_opregion_resume(xe);
>  
> -- 
> 2.39.2
>