Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: lucas.demarchi@intel.com, intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH 06/10] fixup! drm/xe/display: Implement display support
Date: Wed, 4 Oct 2023 10:05:59 -0400	[thread overview]
Message-ID: <ZR1xR+NhF3qOC96q@intel.com> (raw)
In-Reply-To: <cd5a872a961405fd27aa07d1f4a1169080b4cc3e.1696343521.git.jani.nikula@intel.com>

On Tue, Oct 03, 2023 at 05:34:53PM +0300, Jani Nikula wrote:
> The diag push/pop stuff is unnecessary leftovers.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>


Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>


> ---
>  drivers/gpu/drm/xe/xe_display.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_display.c b/drivers/gpu/drm/xe/xe_display.c
> index 82d2c42629ce..391f08c1caca 100644
> --- a/drivers/gpu/drm/xe/xe_display.c
> +++ b/drivers/gpu/drm/xe/xe_display.c
> @@ -417,10 +417,6 @@ void xe_display_pm_resume(struct xe_device *xe)
>  	intel_power_domains_enable(xe);
>  }
>  
> -/* Display info initialization */
> -__diag_push();
> -__diag_ignore_all("-Woverride-init", "Allow field overrides in table");
> -
>  void xe_display_probe(struct xe_device *xe)
>  {
>  	if (!xe->info.enable_display)
> @@ -435,4 +431,3 @@ void xe_display_probe(struct xe_device *xe)
>  	xe->info.enable_display = false;
>  	unset_display_features(xe);
>  }
> -__diag_pop();
> -- 
> 2.39.2
> 

  reply	other threads:[~2023-10-04 14:06 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-03 14:34 [Intel-xe] [PATCH 00/10] xe/display: clarify display configuration Jani Nikula
2023-10-03 14:34 ` [Intel-xe] [PATCH 01/10] fixup! drm/xe/display: Implement display support Jani Nikula
2023-10-04 14:02   ` Rodrigo Vivi
2023-10-04 14:23     ` Jani Nikula
2023-10-04 14:41       ` Rodrigo Vivi
2023-10-04 14:25     ` Jani Nikula
2023-10-03 14:34 ` [Intel-xe] [PATCH 02/10] " Jani Nikula
2023-10-04 14:04   ` Rodrigo Vivi
2023-10-03 14:34 ` [Intel-xe] [PATCH 03/10] " Jani Nikula
2023-10-04 14:04   ` Rodrigo Vivi
2023-10-03 14:34 ` [Intel-xe] [PATCH 04/10] fixup! drm/xe: Introduce Xe assert macros Jani Nikula
2023-10-04 14:05   ` Rodrigo Vivi
2023-10-03 14:34 ` [Intel-xe] [PATCH 05/10] fixup! drm/xe/display: Implement display support Jani Nikula
2023-10-04 14:05   ` Rodrigo Vivi
2023-10-03 14:34 ` [Intel-xe] [PATCH 06/10] " Jani Nikula
2023-10-04 14:05   ` Rodrigo Vivi [this message]
2023-10-04 16:19   ` Lucas De Marchi
2023-10-04 16:31     ` Jani Nikula
2023-10-03 14:34 ` [Intel-xe] [PATCH 07/10] " Jani Nikula
2023-10-04 14:06   ` Rodrigo Vivi
2023-10-03 14:34 ` [Intel-xe] [PATCH 08/10] " Jani Nikula
2023-10-04 14:23   ` Rodrigo Vivi
2023-10-04 14:37     ` Jani Nikula
2023-10-04 16:14       ` Rodrigo Vivi
2023-10-04 16:41   ` Lucas De Marchi
2023-10-04 17:11     ` Jani Nikula
2023-10-04 18:03       ` Lucas De Marchi
2023-10-03 14:34 ` [Intel-xe] [PATCH 09/10] " Jani Nikula
2023-10-04 14:21   ` Rodrigo Vivi
2023-10-04 16:28   ` Lucas De Marchi
2023-10-04 17:32     ` Jani Nikula
2023-10-03 14:34 ` [Intel-xe] [PATCH 10/10] " Jani Nikula
2023-10-04 14:09   ` Rodrigo Vivi
2023-10-03 14:48 ` [Intel-xe] ✓ CI.Patch_applied: success for xe/display: clarify display configuration Patchwork
2023-10-03 14:48 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-10-03 14:49 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-10-03 14:56 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-10-03 14:57 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-10-03 14:58 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-10-03 15:35 ` [Intel-xe] ✓ CI.BAT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZR1xR+NhF3qOC96q@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox