Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/pm: hide d3cold sysfs threshold
@ 2024-02-21 17:10 Matthew Auld
  2024-02-21 17:16 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: Matthew Auld @ 2024-02-21 17:10 UTC (permalink / raw)
  To: intel-xe; +Cc: Anshuman Gupta, Rodrigo Vivi

There are known deadlocks and lockdep splats with d3cold and dgpu, which
is why it is disabled by default. However we still don't want CI or
actual users trying to override the DEFAULT_VRAM_THRESHOLD and then end
up enabling d3cold support. For now keep the sysfs hidden if
DEFAULT_VRAM_THRESHOLD is zero.

References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1246
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Anshuman Gupta <anshuman.gupta@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_pm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
index ab283e9a8b4e..829f165e30b4 100644
--- a/drivers/gpu/drm/xe/xe_pm.c
+++ b/drivers/gpu/drm/xe/xe_pm.c
@@ -189,7 +189,8 @@ void xe_pm_init(struct xe_device *xe)
 	xe->d3cold.capable = xe_pm_pci_d3cold_capable(xe);
 
 	if (xe->d3cold.capable) {
-		xe_device_sysfs_init(xe);
+		if (DEFAULT_VRAM_THRESHOLD)
+			xe_device_sysfs_init(xe);
 		xe_pm_set_vram_threshold(xe, DEFAULT_VRAM_THRESHOLD);
 	}
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2024-02-21 17:52 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-21 17:10 [PATCH] drm/xe/pm: hide d3cold sysfs threshold Matthew Auld
2024-02-21 17:16 ` ✓ CI.Patch_applied: success for " Patchwork
2024-02-21 17:16 ` ✗ CI.checkpatch: warning " Patchwork
2024-02-21 17:17 ` ✓ CI.KUnit: success " Patchwork
2024-02-21 17:27 ` ✓ CI.Build: " Patchwork
2024-02-21 17:28 ` ✓ CI.Hooks: " Patchwork
2024-02-21 17:29 ` ✓ CI.checksparse: " Patchwork
2024-02-21 17:50 ` ✓ CI.BAT: " Patchwork
2024-02-21 17:52 ` [PATCH] " Rodrigo Vivi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox