Re: [PATCH v2 19/43] drm/xe/wa: Convert register access to use xe_mmio

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Fri, Sep 06, 2024 at 05:08:08PM -0700, Matt Roper wrote:
> Stop using GT pointers for register access.
> 
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_wa.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c
> index 28b7f95b6c2f..d8a5a85e9ebd 100644
> --- a/drivers/gpu/drm/xe/xe_wa.c
> +++ b/drivers/gpu/drm/xe/xe_wa.c
> @@ -883,11 +883,11 @@ void xe_wa_dump(struct xe_gt *gt, struct drm_printer *p)
>   */
>  void xe_wa_apply_tile_workarounds(struct xe_tile *tile)
>  {
> -	struct xe_gt *mmio = tile->primary_gt;
> +	struct xe_mmio *mmio = &tile->mmio;
>  
>  	if (IS_SRIOV_VF(tile->xe))
>  		return;
>  
> -	if (XE_WA(mmio, 22010954014))
> +	if (XE_WA(tile->primary_gt, 22010954014))

this got my head spining... but blame on old xe_gt *mmio

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

>  		xe_mmio_rmw32(mmio, XEHP_CLOCK_GATE_DIS, 0, SGSI_SIDECLK_DIS);
>  }
> -- 
> 2.45.2
>