Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 0/8] drm/i915: PREEMPT_RT related fixups.
@ 2024-06-28 12:57 Sebastian Andrzej Siewior
  2024-06-28 12:58 ` [PATCH v3 1/8] drm/i915: Use preempt_disable/enable_rt() where recommended Sebastian Andrzej Siewior
                   ` (15 more replies)
  0 siblings, 16 replies; 23+ messages in thread
From: Sebastian Andrzej Siewior @ 2024-06-28 12:57 UTC (permalink / raw)
  To: intel-gfx, intel-xe
  Cc: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Thomas Gleixner,
	Tvrtko Ursulin

Hi,

The following patches are from the PREEMPT_RT queue.  It is mostly about
disabling interrupts/preemption which leads to problems. Unfortunately
DRM_I915_LOW_LEVEL_TRACEPOINTS had to be disabled because it acquires locks
from within trace points. Making the lock a raw_spinlock_t led to higher
latencies during video playback
  https://lore.kernel.org/all/20211006164628.s2mtsdd2jdbfyf7g@linutronix.de/

and I'm not sure if I hit the worse case here.
I tested it on a SandyBridge with built-in i915 by using X, OpenGL and
playing videos without noticing any warnings. However, some code paths
were not entered.
I carry them for some time now and most issues were reported by other
people and they reported that things work for them since.

v2…v3 https://lore.kernel.org/all/20240613102818.4056866-1-bigeasy@linutronix.de/
  - Collected tags.
  - Added comment to 3/8 explaining why RT is excluded from the test.
  
v1…v2:
  - The tracing disable bits (4/8) have been reworked after Steven pointed out
    that something isn't right.
  - The irq_work() bits have been dropped because they are no longer
    needed.


Sebastian

^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2024-10-04 10:44 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-28 12:57 [PATCH v3 0/8] drm/i915: PREEMPT_RT related fixups Sebastian Andrzej Siewior
2024-06-28 12:58 ` [PATCH v3 1/8] drm/i915: Use preempt_disable/enable_rt() where recommended Sebastian Andrzej Siewior
2024-06-28 12:58 ` [PATCH v3 2/8] drm/i915: Don't disable interrupts on PREEMPT_RT during atomic updates Sebastian Andrzej Siewior
2024-06-28 12:58 ` [PATCH v3 3/8] drm/i915: Don't check for atomic context on PREEMPT_RT Sebastian Andrzej Siewior
2024-06-28 12:58 ` [PATCH v3 4/8] drm/i915: Disable tracing points " Sebastian Andrzej Siewior
2024-06-28 12:58 ` [PATCH v3 5/8] drm/i915/gt: Use spin_lock_irq() instead of local_irq_disable() + spin_lock() Sebastian Andrzej Siewior
2024-06-28 12:58 ` [PATCH v3 6/8] drm/i915: Drop the irqs_disabled() check Sebastian Andrzej Siewior
2024-06-28 12:58 ` [PATCH v3 7/8] drm/i915/guc: Consider also RCU depth in busy loop Sebastian Andrzej Siewior
2024-06-28 12:58 ` [PATCH v3 8/8] Revert "drm/i915: Depend on !PREEMPT_RT." Sebastian Andrzej Siewior
2024-06-28 13:11 ` ✓ CI.Patch_applied: success for drm/i915: PREEMPT_RT related fixups. (rev5) Patchwork
2024-06-28 13:11 ` ✗ CI.checkpatch: warning " Patchwork
2024-06-28 13:12 ` ✓ CI.KUnit: success " Patchwork
2024-06-28 13:24 ` ✓ CI.Build: " Patchwork
2024-06-28 13:26 ` ✓ CI.Hooks: " Patchwork
2024-06-28 13:28 ` ✗ CI.checksparse: warning " Patchwork
2024-06-28 13:51 ` ✓ CI.BAT: success " Patchwork
2024-10-02 16:25 ` [PATCH v3 0/8] drm/i915: PREEMPT_RT related fixups Sebastian Andrzej Siewior
2024-10-02 16:58   ` Ville Syrjälä
2024-10-04  6:49     ` Sebastian Andrzej Siewior
2024-10-04  8:31       ` Ville Syrjälä
2024-10-04  8:45         ` Sebastian Andrzej Siewior
2024-10-04  9:07           ` Ville Syrjälä
2024-10-04 10:44             ` Sebastian Andrzej Siewior

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox