Re: [PATCH 2/4] drm/xe: Include xe_oa_types.h

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, Nov 14, 2024 at 07:21:46AM -0800, Lucas De Marchi wrote:
> xe_device_types.h and xe_gt_types.h only need to know about the xe_oa
> struct sizes. Include only the _types.h, like done for other components,
> and let the full header to be included by the compilation units.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_device.c       | 1 +
>  drivers/gpu/drm/xe/xe_device_types.h | 2 +-
>  drivers/gpu/drm/xe/xe_gt_types.h     | 2 +-
>  drivers/gpu/drm/xe/xe_query.c        | 1 +
>  4 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index 0e2dd691bdae9..8f7841ad8ded3 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -44,6 +44,7 @@
>  #include "xe_memirq.h"
>  #include "xe_mmio.h"
>  #include "xe_module.h"
> +#include "xe_oa.h"
>  #include "xe_observation.h"
>  #include "xe_pat.h"
>  #include "xe_pcode.h"
> diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
> index 2c6a2040f0d82..ff19bda9ddadc 100644
> --- a/drivers/gpu/drm/xe/xe_device_types.h
> +++ b/drivers/gpu/drm/xe/xe_device_types.h
> @@ -16,7 +16,7 @@
>  #include "xe_heci_gsc.h"
>  #include "xe_lmtt_types.h"
>  #include "xe_memirq_types.h"
> -#include "xe_oa.h"
> +#include "xe_oa_types.h"
>  #include "xe_platform_types.h"
>  #include "xe_pt_types.h"
>  #include "xe_sriov_types.h"
> diff --git a/drivers/gpu/drm/xe/xe_gt_types.h b/drivers/gpu/drm/xe/xe_gt_types.h
> index a287b98ee70b4..20901c01ba29a 100644
> --- a/drivers/gpu/drm/xe/xe_gt_types.h
> +++ b/drivers/gpu/drm/xe/xe_gt_types.h
> @@ -14,7 +14,7 @@
>  #include "xe_gt_stats.h"
>  #include "xe_hw_engine_types.h"
>  #include "xe_hw_fence_types.h"
> -#include "xe_oa.h"
> +#include "xe_oa_types.h"
>  #include "xe_reg_sr_types.h"
>  #include "xe_sa_types.h"
>  #include "xe_uc_types.h"
> diff --git a/drivers/gpu/drm/xe/xe_query.c b/drivers/gpu/drm/xe/xe_query.c
> index 170ae72d1a7bb..3eda616f15026 100644
> --- a/drivers/gpu/drm/xe/xe_query.c
> +++ b/drivers/gpu/drm/xe/xe_query.c
> @@ -23,6 +23,7 @@
>  #include "xe_guc_hwconfig.h"
>  #include "xe_macros.h"
>  #include "xe_mmio.h"
> +#include "xe_oa.h"
>  #include "xe_ttm_vram_mgr.h"
>  #include "xe_wa.h"
>  
> -- 
> 2.47.0
>