* [PATCH 0/2] drm/xe/sysfs: Fix attributes registration on VFs
@ 2025-09-15 14:06 Michal Wajdeczko
2025-09-15 14:06 ` [PATCH 1/2] drm/xe/sysfs: Simplify and fix sysfs registration Michal Wajdeczko
` (4 more replies)
0 siblings, 5 replies; 14+ messages in thread
From: Michal Wajdeczko @ 2025-09-15 14:06 UTC (permalink / raw)
To: intel-xe; +Cc: Michal Wajdeczko
Michal Wajdeczko (2):
drm/xe/sysfs: Simplify and fix sysfs registration
drm/xe/vf: Don't expose sysfs attributes not applicable for VFs
drivers/gpu/drm/xe/xe_device_sysfs.c | 98 ++++++++++++----------------
1 file changed, 40 insertions(+), 58 deletions(-)
--
2.47.1
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/2] drm/xe/sysfs: Simplify and fix sysfs registration
2025-09-15 14:06 [PATCH 0/2] drm/xe/sysfs: Fix attributes registration on VFs Michal Wajdeczko
@ 2025-09-15 14:06 ` Michal Wajdeczko
2025-09-15 15:12 ` Lucas De Marchi
2025-09-15 15:17 ` Raag Jadav
2025-09-15 14:06 ` [PATCH 2/2] drm/xe/vf: Don't expose sysfs attributes not applicable for VFs Michal Wajdeczko
` (3 subsequent siblings)
4 siblings, 2 replies; 14+ messages in thread
From: Michal Wajdeczko @ 2025-09-15 14:06 UTC (permalink / raw)
To: intel-xe; +Cc: Michal Wajdeczko, Lucas De Marchi, Rodrigo Vivi, Raag Jadav
Instead of manually maintaining each sysfs attribute define and use
attribute groups and register them using device managed function.
Then use is_visible() to filter-out unsupported attributes.
This will result not only in less code and smaller footprint:
Function old new delta
late_bind_attr_is_visible - 183 +183
____versions 80832 80896 +64
vram_attr_group - 48 +48
late_bind_attr_group - 48 +48
auto_link_downgrade_attr_group - 48 +48
late_bind_attrs - 24 +24
vram_attrs - 16 +16
__pfx_late_bind_attr_is_visible - 16 +16
xe_device_sysfs_init.cold 20 21 +1
__pfx_xe_device_sysfs_fini 16 - -16
xe_device_sysfs_fini.cold 21 - -21
xe_device_sysfs_fini 271 - -271
xe_device_sysfs_init 421 135 -286
Total: Before=2848898, After=2848752, chg -0.01%
but will also fix some bad error handling that we had here.
Fixes: 0e414bf7ad01 ("drm/xe: Expose PCIe link downgrade attributes")
Fixes: cdc36b66cd41 ("drm/xe: Expose fan control and voltage regulator version")
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Raag Jadav <raag.jadav@intel.com>
---
drivers/gpu/drm/xe/xe_device_sysfs.c | 96 +++++++++++-----------------
1 file changed, 39 insertions(+), 57 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_device_sysfs.c b/drivers/gpu/drm/xe/xe_device_sysfs.c
index 6ee422594b56..5b0b98ac9b17 100644
--- a/drivers/gpu/drm/xe/xe_device_sysfs.c
+++ b/drivers/gpu/drm/xe/xe_device_sysfs.c
@@ -71,6 +71,15 @@ vram_d3cold_threshold_store(struct device *dev, struct device_attribute *attr,
static DEVICE_ATTR_RW(vram_d3cold_threshold);
+static struct attribute *vram_attrs[] = {
+ &dev_attr_vram_d3cold_threshold.attr,
+ NULL
+};
+
+static const struct attribute_group vram_attr_group = {
+ .attrs = vram_attrs,
+};
+
static ssize_t
lb_fan_control_version_show(struct device *dev, struct device_attribute *attr, char *buf)
{
@@ -149,8 +158,16 @@ lb_voltage_regulator_version_show(struct device *dev, struct device_attribute *a
}
static DEVICE_ATTR_ADMIN_RO(lb_voltage_regulator_version);
-static int late_bind_create_files(struct device *dev)
+static struct attribute *late_bind_attrs[] = {
+ &dev_attr_lb_fan_control_version.attr,
+ &dev_attr_lb_voltage_regulator_version.attr,
+ NULL
+};
+
+static umode_t late_bind_attr_is_visible(struct kobject *kobj,
+ struct attribute *attr, int n)
{
+ struct device *dev = kobj_to_dev(kobj);
struct xe_device *xe = pdev_to_xe_device(to_pci_dev(dev));
struct xe_tile *root = xe_device_get_root_tile(xe);
u32 cap = 0;
@@ -160,51 +177,25 @@ static int late_bind_create_files(struct device *dev)
ret = xe_pcode_read(root, PCODE_MBOX(PCODE_LATE_BINDING, GET_CAPABILITY_STATUS, 0),
&cap, NULL);
- if (ret) {
- if (ret == -ENXIO) {
- drm_dbg(&xe->drm, "Late binding not supported by firmware\n");
- ret = 0;
- }
- goto out;
- }
-
- if (REG_FIELD_GET(V1_FAN_SUPPORTED, cap)) {
- ret = sysfs_create_file(&dev->kobj, &dev_attr_lb_fan_control_version.attr);
- if (ret)
- goto out;
- }
-
- if (REG_FIELD_GET(VR_PARAMS_SUPPORTED, cap))
- ret = sysfs_create_file(&dev->kobj, &dev_attr_lb_voltage_regulator_version.attr);
-out:
xe_pm_runtime_put(xe);
-
- return ret;
-}
-
-static void late_bind_remove_files(struct device *dev)
-{
- struct xe_device *xe = pdev_to_xe_device(to_pci_dev(dev));
- struct xe_tile *root = xe_device_get_root_tile(xe);
- u32 cap = 0;
- int ret;
-
- xe_pm_runtime_get(xe);
-
- ret = xe_pcode_read(root, PCODE_MBOX(PCODE_LATE_BINDING, GET_CAPABILITY_STATUS, 0),
- &cap, NULL);
if (ret)
- goto out;
+ return 0;
- if (REG_FIELD_GET(V1_FAN_SUPPORTED, cap))
- sysfs_remove_file(&dev->kobj, &dev_attr_lb_fan_control_version.attr);
+ if (attr == &dev_attr_lb_fan_control_version.attr &&
+ REG_FIELD_GET(V1_FAN_SUPPORTED, cap))
+ return attr->mode;
+ if (attr == &dev_attr_lb_voltage_regulator_version.attr &&
+ REG_FIELD_GET(VR_PARAMS_SUPPORTED, cap))
+ return attr->mode;
- if (REG_FIELD_GET(VR_PARAMS_SUPPORTED, cap))
- sysfs_remove_file(&dev->kobj, &dev_attr_lb_voltage_regulator_version.attr);
-out:
- xe_pm_runtime_put(xe);
+ return 0;
}
+static const struct attribute_group late_bind_attr_group = {
+ .attrs = late_bind_attrs,
+ .is_visible = late_bind_attr_is_visible,
+};
+
/**
* DOC: PCIe Gen5 Limitations
*
@@ -278,24 +269,15 @@ auto_link_downgrade_status_show(struct device *dev, struct device_attribute *att
}
static DEVICE_ATTR_ADMIN_RO(auto_link_downgrade_status);
-static const struct attribute *auto_link_downgrade_attrs[] = {
+static struct attribute *auto_link_downgrade_attrs[] = {
&dev_attr_auto_link_downgrade_capable.attr,
&dev_attr_auto_link_downgrade_status.attr,
NULL
};
-static void xe_device_sysfs_fini(void *arg)
-{
- struct xe_device *xe = arg;
-
- if (xe->d3cold.capable)
- sysfs_remove_file(&xe->drm.dev->kobj, &dev_attr_vram_d3cold_threshold.attr);
-
- if (xe->info.platform == XE_BATTLEMAGE) {
- sysfs_remove_files(&xe->drm.dev->kobj, auto_link_downgrade_attrs);
- late_bind_remove_files(xe->drm.dev);
- }
-}
+static const struct attribute_group auto_link_downgrade_attr_group = {
+ .attrs = auto_link_downgrade_attrs,
+};
int xe_device_sysfs_init(struct xe_device *xe)
{
@@ -303,20 +285,20 @@ int xe_device_sysfs_init(struct xe_device *xe)
int ret;
if (xe->d3cold.capable) {
- ret = sysfs_create_file(&dev->kobj, &dev_attr_vram_d3cold_threshold.attr);
+ ret = devm_device_add_group(dev, &vram_attr_group);
if (ret)
return ret;
}
if (xe->info.platform == XE_BATTLEMAGE) {
- ret = sysfs_create_files(&dev->kobj, auto_link_downgrade_attrs);
+ ret = devm_device_add_group(dev, &auto_link_downgrade_attr_group);
if (ret)
return ret;
- ret = late_bind_create_files(dev);
+ ret = devm_device_add_group(dev, &late_bind_attr_group);
if (ret)
return ret;
}
- return devm_add_action_or_reset(dev, xe_device_sysfs_fini, xe);
+ return 0;
}
--
2.47.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/2] drm/xe/vf: Don't expose sysfs attributes not applicable for VFs
2025-09-15 14:06 [PATCH 0/2] drm/xe/sysfs: Fix attributes registration on VFs Michal Wajdeczko
2025-09-15 14:06 ` [PATCH 1/2] drm/xe/sysfs: Simplify and fix sysfs registration Michal Wajdeczko
@ 2025-09-15 14:06 ` Michal Wajdeczko
2025-09-15 15:18 ` Raag Jadav
2025-09-15 14:12 ` ✓ CI.KUnit: success for drm/xe/sysfs: Fix attributes registration on VFs Patchwork
` (2 subsequent siblings)
4 siblings, 1 reply; 14+ messages in thread
From: Michal Wajdeczko @ 2025-09-15 14:06 UTC (permalink / raw)
To: intel-xe; +Cc: Michal Wajdeczko, Lucas De Marchi, Lukasz Laguna
VFs can't read BMG_PCIE_CAP(0x138340) register nor access PCODE
(already guarded by the info.skip_pcode flag) so we shouldn't
expose attributes that require any of them to avoid errors like:
[] xe 0000:03:00.1: [drm] Tile0: GT0: VF is trying to read an \
inaccessible register 0x138340+0x0
[] RIP: 0010:xe_gt_sriov_vf_read32+0x6c2/0x9a0 [xe]
[] Call Trace:
[] xe_mmio_read32+0x110/0x280 [xe]
[] auto_link_downgrade_capable_show+0x2e/0x70 [xe]
[] dev_attr_show+0x1a/0x70
[] sysfs_kf_seq_show+0xaa/0x120
[] kernfs_seq_show+0x41/0x60
Fixes: 0e414bf7ad01 ("drm/xe: Expose PCIe link downgrade attributes")
Fixes: cdc36b66cd41 ("drm/xe: Expose fan control and voltage regulator version")
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Lukasz Laguna <lukasz.laguna@intel.com>
---
drivers/gpu/drm/xe/xe_device_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_device_sysfs.c b/drivers/gpu/drm/xe/xe_device_sysfs.c
index 5b0b98ac9b17..c5151c86a98a 100644
--- a/drivers/gpu/drm/xe/xe_device_sysfs.c
+++ b/drivers/gpu/drm/xe/xe_device_sysfs.c
@@ -290,7 +290,7 @@ int xe_device_sysfs_init(struct xe_device *xe)
return ret;
}
- if (xe->info.platform == XE_BATTLEMAGE) {
+ if (xe->info.platform == XE_BATTLEMAGE && !IS_SRIOV_VF(xe)) {
ret = devm_device_add_group(dev, &auto_link_downgrade_attr_group);
if (ret)
return ret;
--
2.47.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* ✓ CI.KUnit: success for drm/xe/sysfs: Fix attributes registration on VFs
2025-09-15 14:06 [PATCH 0/2] drm/xe/sysfs: Fix attributes registration on VFs Michal Wajdeczko
2025-09-15 14:06 ` [PATCH 1/2] drm/xe/sysfs: Simplify and fix sysfs registration Michal Wajdeczko
2025-09-15 14:06 ` [PATCH 2/2] drm/xe/vf: Don't expose sysfs attributes not applicable for VFs Michal Wajdeczko
@ 2025-09-15 14:12 ` Patchwork
2025-09-15 14:51 ` ✓ Xe.CI.BAT: " Patchwork
2025-09-15 17:44 ` ✗ Xe.CI.Full: failure " Patchwork
4 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2025-09-15 14:12 UTC (permalink / raw)
To: Michal Wajdeczko; +Cc: intel-xe
== Series Details ==
Series: drm/xe/sysfs: Fix attributes registration on VFs
URL : https://patchwork.freedesktop.org/series/154534/
State : success
== Summary ==
+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig
[14:11:47] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[14:11:51] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[14:12:20] Starting KUnit Kernel (1/1)...
[14:12:20] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[14:12:20] ================== guc_buf (11 subtests) ===================
[14:12:20] [PASSED] test_smallest
[14:12:20] [PASSED] test_largest
[14:12:20] [PASSED] test_granular
[14:12:20] [PASSED] test_unique
[14:12:20] [PASSED] test_overlap
[14:12:20] [PASSED] test_reusable
[14:12:20] [PASSED] test_too_big
[14:12:20] [PASSED] test_flush
[14:12:20] [PASSED] test_lookup
[14:12:20] [PASSED] test_data
[14:12:20] [PASSED] test_class
[14:12:20] ===================== [PASSED] guc_buf =====================
[14:12:20] =================== guc_dbm (7 subtests) ===================
[14:12:20] [PASSED] test_empty
[14:12:20] [PASSED] test_default
[14:12:20] ======================== test_size ========================
[14:12:20] [PASSED] 4
[14:12:20] [PASSED] 8
[14:12:20] [PASSED] 32
[14:12:20] [PASSED] 256
[14:12:20] ==================== [PASSED] test_size ====================
[14:12:20] ======================= test_reuse ========================
[14:12:20] [PASSED] 4
[14:12:20] [PASSED] 8
[14:12:20] [PASSED] 32
[14:12:20] [PASSED] 256
[14:12:20] =================== [PASSED] test_reuse ====================
[14:12:20] =================== test_range_overlap ====================
[14:12:20] [PASSED] 4
[14:12:20] [PASSED] 8
[14:12:20] [PASSED] 32
[14:12:20] [PASSED] 256
[14:12:20] =============== [PASSED] test_range_overlap ================
[14:12:20] =================== test_range_compact ====================
[14:12:20] [PASSED] 4
[14:12:20] [PASSED] 8
[14:12:20] [PASSED] 32
[14:12:20] [PASSED] 256
[14:12:20] =============== [PASSED] test_range_compact ================
[14:12:20] ==================== test_range_spare =====================
[14:12:20] [PASSED] 4
[14:12:20] [PASSED] 8
[14:12:20] [PASSED] 32
[14:12:20] [PASSED] 256
[14:12:20] ================ [PASSED] test_range_spare =================
[14:12:20] ===================== [PASSED] guc_dbm =====================
[14:12:20] =================== guc_idm (6 subtests) ===================
[14:12:20] [PASSED] bad_init
[14:12:20] [PASSED] no_init
[14:12:20] [PASSED] init_fini
[14:12:20] [PASSED] check_used
[14:12:20] [PASSED] check_quota
[14:12:20] [PASSED] check_all
[14:12:20] ===================== [PASSED] guc_idm =====================
[14:12:20] ================== no_relay (3 subtests) ===================
[14:12:20] [PASSED] xe_drops_guc2pf_if_not_ready
[14:12:20] [PASSED] xe_drops_guc2vf_if_not_ready
[14:12:20] [PASSED] xe_rejects_send_if_not_ready
[14:12:20] ==================== [PASSED] no_relay =====================
[14:12:20] ================== pf_relay (14 subtests) ==================
[14:12:20] [PASSED] pf_rejects_guc2pf_too_short
[14:12:20] [PASSED] pf_rejects_guc2pf_too_long
[14:12:20] [PASSED] pf_rejects_guc2pf_no_payload
[14:12:20] [PASSED] pf_fails_no_payload
[14:12:20] [PASSED] pf_fails_bad_origin
[14:12:20] [PASSED] pf_fails_bad_type
[14:12:20] [PASSED] pf_txn_reports_error
[14:12:20] [PASSED] pf_txn_sends_pf2guc
[14:12:20] [PASSED] pf_sends_pf2guc
[14:12:20] [SKIPPED] pf_loopback_nop
[14:12:20] [SKIPPED] pf_loopback_echo
[14:12:20] [SKIPPED] pf_loopback_fail
[14:12:20] [SKIPPED] pf_loopback_busy
[14:12:20] [SKIPPED] pf_loopback_retry
[14:12:20] ==================== [PASSED] pf_relay =====================
[14:12:20] ================== vf_relay (3 subtests) ===================
[14:12:20] [PASSED] vf_rejects_guc2vf_too_short
[14:12:20] [PASSED] vf_rejects_guc2vf_too_long
[14:12:20] [PASSED] vf_rejects_guc2vf_no_payload
[14:12:20] ==================== [PASSED] vf_relay =====================
[14:12:20] ===================== lmtt (1 subtest) =====================
[14:12:20] ======================== test_ops =========================
[14:12:20] [PASSED] 2-level
[14:12:20] [PASSED] multi-level
[14:12:20] ==================== [PASSED] test_ops =====================
[14:12:20] ====================== [PASSED] lmtt =======================
[14:12:20] ================= pf_service (11 subtests) =================
[14:12:20] [PASSED] pf_negotiate_any
[14:12:20] [PASSED] pf_negotiate_base_match
[14:12:20] [PASSED] pf_negotiate_base_newer
[14:12:20] [PASSED] pf_negotiate_base_next
[14:12:20] [SKIPPED] pf_negotiate_base_older
[14:12:20] [PASSED] pf_negotiate_base_prev
[14:12:20] [PASSED] pf_negotiate_latest_match
[14:12:20] [PASSED] pf_negotiate_latest_newer
[14:12:20] [PASSED] pf_negotiate_latest_next
[14:12:20] [SKIPPED] pf_negotiate_latest_older
[14:12:20] [SKIPPED] pf_negotiate_latest_prev
[14:12:20] =================== [PASSED] pf_service ====================
[14:12:20] =================== xe_mocs (2 subtests) ===================
[14:12:20] ================ xe_live_mocs_kernel_kunit ================
[14:12:20] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============
[14:12:20] ================ xe_live_mocs_reset_kunit =================
[14:12:20] ============ [SKIPPED] xe_live_mocs_reset_kunit ============
[14:12:20] ==================== [SKIPPED] xe_mocs =====================
[14:12:20] ================= xe_migrate (2 subtests) ==================
[14:12:20] ================= xe_migrate_sanity_kunit =================
[14:12:20] ============ [SKIPPED] xe_migrate_sanity_kunit =============
[14:12:20] ================== xe_validate_ccs_kunit ==================
[14:12:20] ============= [SKIPPED] xe_validate_ccs_kunit ==============
[14:12:20] =================== [SKIPPED] xe_migrate ===================
[14:12:20] ================== xe_dma_buf (1 subtest) ==================
[14:12:20] ==================== xe_dma_buf_kunit =====================
[14:12:20] ================ [SKIPPED] xe_dma_buf_kunit ================
[14:12:20] =================== [SKIPPED] xe_dma_buf ===================
[14:12:20] ================= xe_bo_shrink (1 subtest) =================
[14:12:20] =================== xe_bo_shrink_kunit ====================
[14:12:20] =============== [SKIPPED] xe_bo_shrink_kunit ===============
[14:12:20] ================== [SKIPPED] xe_bo_shrink ==================
[14:12:20] ==================== xe_bo (2 subtests) ====================
[14:12:20] ================== xe_ccs_migrate_kunit ===================
[14:12:20] ============== [SKIPPED] xe_ccs_migrate_kunit ==============
[14:12:20] ==================== xe_bo_evict_kunit ====================
[14:12:20] =============== [SKIPPED] xe_bo_evict_kunit ================
[14:12:20] ===================== [SKIPPED] xe_bo ======================
[14:12:20] ==================== args (11 subtests) ====================
[14:12:20] [PASSED] count_args_test
[14:12:20] [PASSED] call_args_example
[14:12:20] [PASSED] call_args_test
[14:12:20] [PASSED] drop_first_arg_example
[14:12:20] [PASSED] drop_first_arg_test
[14:12:20] [PASSED] first_arg_example
[14:12:20] [PASSED] first_arg_test
[14:12:20] [PASSED] last_arg_example
[14:12:20] [PASSED] last_arg_test
[14:12:20] [PASSED] pick_arg_example
[14:12:20] [PASSED] sep_comma_example
[14:12:20] ====================== [PASSED] args =======================
[14:12:20] =================== xe_pci (3 subtests) ====================
[14:12:20] ==================== check_graphics_ip ====================
[14:12:20] [PASSED] 12.70 Xe_LPG
[14:12:20] [PASSED] 12.71 Xe_LPG
[14:12:20] [PASSED] 12.74 Xe_LPG+
[14:12:20] [PASSED] 20.01 Xe2_HPG
[14:12:20] [PASSED] 20.02 Xe2_HPG
[14:12:20] [PASSED] 20.04 Xe2_LPG
[14:12:20] [PASSED] 30.00 Xe3_LPG
[14:12:20] [PASSED] 30.01 Xe3_LPG
[14:12:20] [PASSED] 30.03 Xe3_LPG
[14:12:20] ================ [PASSED] check_graphics_ip ================
[14:12:20] ===================== check_media_ip ======================
[14:12:20] [PASSED] 13.00 Xe_LPM+
[14:12:20] [PASSED] 13.01 Xe2_HPM
[14:12:20] [PASSED] 20.00 Xe2_LPM
[14:12:20] [PASSED] 30.00 Xe3_LPM
[14:12:20] [PASSED] 30.02 Xe3_LPM
[14:12:20] ================= [PASSED] check_media_ip ==================
[14:12:20] ================= check_platform_gt_count =================
[14:12:20] [PASSED] 0x9A60 (TIGERLAKE)
[14:12:20] [PASSED] 0x9A68 (TIGERLAKE)
[14:12:20] [PASSED] 0x9A70 (TIGERLAKE)
[14:12:20] [PASSED] 0x9A40 (TIGERLAKE)
[14:12:20] [PASSED] 0x9A49 (TIGERLAKE)
[14:12:20] [PASSED] 0x9A59 (TIGERLAKE)
[14:12:20] [PASSED] 0x9A78 (TIGERLAKE)
[14:12:20] [PASSED] 0x9AC0 (TIGERLAKE)
[14:12:20] [PASSED] 0x9AC9 (TIGERLAKE)
[14:12:20] [PASSED] 0x9AD9 (TIGERLAKE)
[14:12:20] [PASSED] 0x9AF8 (TIGERLAKE)
[14:12:20] [PASSED] 0x4C80 (ROCKETLAKE)
[14:12:20] [PASSED] 0x4C8A (ROCKETLAKE)
[14:12:20] [PASSED] 0x4C8B (ROCKETLAKE)
[14:12:20] [PASSED] 0x4C8C (ROCKETLAKE)
[14:12:20] [PASSED] 0x4C90 (ROCKETLAKE)
[14:12:20] [PASSED] 0x4C9A (ROCKETLAKE)
[14:12:20] [PASSED] 0x4680 (ALDERLAKE_S)
[14:12:20] [PASSED] 0x4682 (ALDERLAKE_S)
[14:12:20] [PASSED] 0x4688 (ALDERLAKE_S)
[14:12:20] [PASSED] 0x468A (ALDERLAKE_S)
[14:12:20] [PASSED] 0x468B (ALDERLAKE_S)
[14:12:20] [PASSED] 0x4690 (ALDERLAKE_S)
[14:12:20] [PASSED] 0x4692 (ALDERLAKE_S)
[14:12:20] [PASSED] 0x4693 (ALDERLAKE_S)
[14:12:20] [PASSED] 0x46A0 (ALDERLAKE_P)
[14:12:20] [PASSED] 0x46A1 (ALDERLAKE_P)
[14:12:20] [PASSED] 0x46A2 (ALDERLAKE_P)
[14:12:20] [PASSED] 0x46A3 (ALDERLAKE_P)
[14:12:20] [PASSED] 0x46A6 (ALDERLAKE_P)
[14:12:20] [PASSED] 0x46A8 (ALDERLAKE_P)
[14:12:20] [PASSED] 0x46AA (ALDERLAKE_P)
[14:12:20] [PASSED] 0x462A (ALDERLAKE_P)
[14:12:20] [PASSED] 0x4626 (ALDERLAKE_P)
[14:12:20] [PASSED] 0x4628 (ALDERLAKE_P)
[14:12:20] [PASSED] 0x46B0 (ALDERLAKE_P)
[14:12:20] [PASSED] 0x46B1 (ALDERLAKE_P)
[14:12:20] [PASSED] 0x46B2 (ALDERLAKE_P)
[14:12:20] [PASSED] 0x46B3 (ALDERLAKE_P)
[14:12:20] [PASSED] 0x46C0 (ALDERLAKE_P)
[14:12:20] [PASSED] 0x46C1 (ALDERLAKE_P)
[14:12:20] [PASSED] 0x46C2 (ALDERLAKE_P)
[14:12:20] [PASSED] 0x46C3 (ALDERLAKE_P)
[14:12:20] [PASSED] 0x46D0 (ALDERLAKE_N)
[14:12:20] [PASSED] 0x46D1 (ALDERLAKE_N)
[14:12:20] [PASSED] 0x46D2 (ALDERLAKE_N)
[14:12:20] [PASSED] 0x46D3 (ALDERLAKE_N)
[14:12:20] [PASSED] 0x46D4 (ALDERLAKE_N)
[14:12:20] [PASSED] 0xA721 (ALDERLAKE_P)
[14:12:20] [PASSED] 0xA7A1 (ALDERLAKE_P)
[14:12:20] [PASSED] 0xA7A9 (ALDERLAKE_P)
[14:12:20] [PASSED] 0xA7AC (ALDERLAKE_P)
[14:12:20] [PASSED] 0xA7AD (ALDERLAKE_P)
[14:12:20] [PASSED] 0xA720 (ALDERLAKE_P)
[14:12:20] [PASSED] 0xA7A0 (ALDERLAKE_P)
[14:12:20] [PASSED] 0xA7A8 (ALDERLAKE_P)
[14:12:20] [PASSED] 0xA7AA (ALDERLAKE_P)
[14:12:20] [PASSED] 0xA7AB (ALDERLAKE_P)
[14:12:20] [PASSED] 0xA780 (ALDERLAKE_S)
[14:12:20] [PASSED] 0xA781 (ALDERLAKE_S)
[14:12:20] [PASSED] 0xA782 (ALDERLAKE_S)
[14:12:20] [PASSED] 0xA783 (ALDERLAKE_S)
[14:12:20] [PASSED] 0xA788 (ALDERLAKE_S)
[14:12:20] [PASSED] 0xA789 (ALDERLAKE_S)
[14:12:20] [PASSED] 0xA78A (ALDERLAKE_S)
[14:12:20] [PASSED] 0xA78B (ALDERLAKE_S)
[14:12:20] [PASSED] 0x4905 (DG1)
[14:12:20] [PASSED] 0x4906 (DG1)
[14:12:20] [PASSED] 0x4907 (DG1)
[14:12:20] [PASSED] 0x4908 (DG1)
[14:12:20] [PASSED] 0x4909 (DG1)
[14:12:20] [PASSED] 0x56C0 (DG2)
[14:12:20] [PASSED] 0x56C2 (DG2)
[14:12:20] [PASSED] 0x56C1 (DG2)
[14:12:20] [PASSED] 0x7D51 (METEORLAKE)
[14:12:20] [PASSED] 0x7DD1 (METEORLAKE)
[14:12:20] [PASSED] 0x7D41 (METEORLAKE)
[14:12:20] [PASSED] 0x7D67 (METEORLAKE)
[14:12:20] [PASSED] 0xB640 (METEORLAKE)
[14:12:20] [PASSED] 0x56A0 (DG2)
[14:12:20] [PASSED] 0x56A1 (DG2)
[14:12:20] [PASSED] 0x56A2 (DG2)
[14:12:20] [PASSED] 0x56BE (DG2)
[14:12:20] [PASSED] 0x56BF (DG2)
[14:12:20] [PASSED] 0x5690 (DG2)
[14:12:20] [PASSED] 0x5691 (DG2)
[14:12:20] [PASSED] 0x5692 (DG2)
[14:12:20] [PASSED] 0x56A5 (DG2)
[14:12:20] [PASSED] 0x56A6 (DG2)
[14:12:20] [PASSED] 0x56B0 (DG2)
[14:12:20] [PASSED] 0x56B1 (DG2)
[14:12:20] [PASSED] 0x56BA (DG2)
[14:12:20] [PASSED] 0x56BB (DG2)
[14:12:20] [PASSED] 0x56BC (DG2)
[14:12:20] [PASSED] 0x56BD (DG2)
[14:12:20] [PASSED] 0x5693 (DG2)
[14:12:20] [PASSED] 0x5694 (DG2)
[14:12:20] [PASSED] 0x5695 (DG2)
[14:12:20] [PASSED] 0x56A3 (DG2)
[14:12:20] [PASSED] 0x56A4 (DG2)
[14:12:20] [PASSED] 0x56B2 (DG2)
[14:12:20] [PASSED] 0x56B3 (DG2)
[14:12:20] [PASSED] 0x5696 (DG2)
[14:12:20] [PASSED] 0x5697 (DG2)
[14:12:20] [PASSED] 0xB69 (PVC)
[14:12:20] [PASSED] 0xB6E (PVC)
[14:12:20] [PASSED] 0xBD4 (PVC)
[14:12:20] [PASSED] 0xBD5 (PVC)
[14:12:20] [PASSED] 0xBD6 (PVC)
[14:12:20] [PASSED] 0xBD7 (PVC)
[14:12:20] [PASSED] 0xBD8 (PVC)
[14:12:20] [PASSED] 0xBD9 (PVC)
[14:12:20] [PASSED] 0xBDA (PVC)
[14:12:20] [PASSED] 0xBDB (PVC)
[14:12:20] [PASSED] 0xBE0 (PVC)
[14:12:20] [PASSED] 0xBE1 (PVC)
[14:12:20] [PASSED] 0xBE5 (PVC)
[14:12:20] [PASSED] 0x7D40 (METEORLAKE)
[14:12:20] [PASSED] 0x7D45 (METEORLAKE)
[14:12:20] [PASSED] 0x7D55 (METEORLAKE)
[14:12:20] [PASSED] 0x7D60 (METEORLAKE)
[14:12:20] [PASSED] 0x7DD5 (METEORLAKE)
[14:12:20] [PASSED] 0x6420 (LUNARLAKE)
[14:12:20] [PASSED] 0x64A0 (LUNARLAKE)
[14:12:20] [PASSED] 0x64B0 (LUNARLAKE)
[14:12:20] [PASSED] 0xE202 (BATTLEMAGE)
[14:12:20] [PASSED] 0xE209 (BATTLEMAGE)
[14:12:20] [PASSED] 0xE20B (BATTLEMAGE)
[14:12:20] [PASSED] 0xE20C (BATTLEMAGE)
[14:12:20] [PASSED] 0xE20D (BATTLEMAGE)
[14:12:20] [PASSED] 0xE210 (BATTLEMAGE)
[14:12:20] [PASSED] 0xE211 (BATTLEMAGE)
[14:12:20] [PASSED] 0xE212 (BATTLEMAGE)
[14:12:20] [PASSED] 0xE216 (BATTLEMAGE)
[14:12:20] [PASSED] 0xE220 (BATTLEMAGE)
[14:12:20] [PASSED] 0xE221 (BATTLEMAGE)
[14:12:20] [PASSED] 0xE222 (BATTLEMAGE)
[14:12:20] [PASSED] 0xE223 (BATTLEMAGE)
[14:12:20] [PASSED] 0xB080 (PANTHERLAKE)
[14:12:20] [PASSED] 0xB081 (PANTHERLAKE)
[14:12:20] [PASSED] 0xB082 (PANTHERLAKE)
[14:12:20] [PASSED] 0xB083 (PANTHERLAKE)
[14:12:20] [PASSED] 0xB084 (PANTHERLAKE)
[14:12:20] [PASSED] 0xB085 (PANTHERLAKE)
[14:12:20] [PASSED] 0xB086 (PANTHERLAKE)
[14:12:20] [PASSED] 0xB087 (PANTHERLAKE)
[14:12:20] [PASSED] 0xB08F (PANTHERLAKE)
[14:12:20] [PASSED] 0xB090 (PANTHERLAKE)
[14:12:20] [PASSED] 0xB0A0 (PANTHERLAKE)
[14:12:20] [PASSED] 0xB0B0 (PANTHERLAKE)
[14:12:20] [PASSED] 0xFD80 (PANTHERLAKE)
[14:12:20] [PASSED] 0xFD81 (PANTHERLAKE)
[14:12:20] ============= [PASSED] check_platform_gt_count =============
[14:12:20] ===================== [PASSED] xe_pci ======================
[14:12:20] =================== xe_rtp (2 subtests) ====================
[14:12:20] =============== xe_rtp_process_to_sr_tests ================
[14:12:20] [PASSED] coalesce-same-reg
[14:12:20] [PASSED] no-match-no-add
[14:12:20] [PASSED] match-or
[14:12:20] [PASSED] match-or-xfail
[14:12:20] [PASSED] no-match-no-add-multiple-rules
[14:12:20] [PASSED] two-regs-two-entries
[14:12:20] [PASSED] clr-one-set-other
[14:12:20] [PASSED] set-field
[14:12:20] [PASSED] conflict-duplicate
[14:12:20] [PASSED] conflict-not-disjoint
[14:12:20] [PASSED] conflict-reg-type
[14:12:20] =========== [PASSED] xe_rtp_process_to_sr_tests ============
[14:12:20] ================== xe_rtp_process_tests ===================
[14:12:20] [PASSED] active1
[14:12:20] [PASSED] active2
[14:12:20] [PASSED] active-inactive
[14:12:20] [PASSED] inactive-active
[14:12:20] [PASSED] inactive-1st_or_active-inactive
[14:12:20] [PASSED] inactive-2nd_or_active-inactive
[14:12:20] [PASSED] inactive-last_or_active-inactive
[14:12:20] [PASSED] inactive-no_or_active-inactive
[14:12:20] ============== [PASSED] xe_rtp_process_tests ===============
[14:12:20] ===================== [PASSED] xe_rtp ======================
[14:12:20] ==================== xe_wa (1 subtest) =====================
[14:12:20] ======================== xe_wa_gt =========================
[14:12:20] [PASSED] TIGERLAKE B0
[14:12:20] [PASSED] DG1 A0
[14:12:20] [PASSED] DG1 B0
[14:12:20] [PASSED] ALDERLAKE_S A0
[14:12:20] [PASSED] ALDERLAKE_S B0
[14:12:20] [PASSED] ALDERLAKE_S C0
[14:12:20] [PASSED] ALDERLAKE_S D0
[14:12:20] [PASSED] ALDERLAKE_P A0
[14:12:20] [PASSED] ALDERLAKE_P B0
[14:12:20] [PASSED] ALDERLAKE_P C0
[14:12:20] [PASSED] ALDERLAKE_S RPLS D0
[14:12:20] [PASSED] ALDERLAKE_P RPLU E0
[14:12:20] [PASSED] DG2 G10 C0
[14:12:20] [PASSED] DG2 G11 B1
[14:12:20] [PASSED] DG2 G12 A1
[14:12:20] [PASSED] METEORLAKE 12.70(Xe_LPG) A0 13.00(Xe_LPM+) A0
[14:12:20] [PASSED] METEORLAKE 12.71(Xe_LPG) A0 13.00(Xe_LPM+) A0
[14:12:20] [PASSED] METEORLAKE 12.74(Xe_LPG+) A0 13.00(Xe_LPM+) A0
[14:12:20] [PASSED] LUNARLAKE 20.04(Xe2_LPG) A0 20.00(Xe2_LPM) A0
stty: 'standard input': Inappropriate ioctl for device
[14:12:20] [PASSED] LUNARLAKE 20.04(Xe2_LPG) B0 20.00(Xe2_LPM) A0
[14:12:20] [PASSED] BATTLEMAGE 20.01(Xe2_HPG) A0 13.01(Xe2_HPM) A1
[14:12:20] [PASSED] PANTHERLAKE 30.00(Xe3_LPG) A0 30.00(Xe3_LPM) A0
[14:12:20] ==================== [PASSED] xe_wa_gt =====================
[14:12:20] ====================== [PASSED] xe_wa ======================
[14:12:20] ============================================================
[14:12:20] Testing complete. Ran 298 tests: passed: 282, skipped: 16
[14:12:20] Elapsed time: 33.569s total, 4.274s configuring, 28.928s building, 0.324s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig
[14:12:20] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[14:12:22] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[14:12:45] Starting KUnit Kernel (1/1)...
[14:12:45] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[14:12:45] == drm_test_atomic_get_connector_for_encoder (1 subtest) ===
[14:12:45] [PASSED] drm_test_drm_atomic_get_connector_for_encoder
[14:12:45] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ====
[14:12:45] =========== drm_validate_clone_mode (2 subtests) ===========
[14:12:45] ============== drm_test_check_in_clone_mode ===============
[14:12:45] [PASSED] in_clone_mode
[14:12:45] [PASSED] not_in_clone_mode
[14:12:45] ========== [PASSED] drm_test_check_in_clone_mode ===========
[14:12:45] =============== drm_test_check_valid_clones ===============
[14:12:45] [PASSED] not_in_clone_mode
[14:12:45] [PASSED] valid_clone
[14:12:45] [PASSED] invalid_clone
[14:12:45] =========== [PASSED] drm_test_check_valid_clones ===========
[14:12:45] ============= [PASSED] drm_validate_clone_mode =============
[14:12:45] ============= drm_validate_modeset (1 subtest) =============
[14:12:45] [PASSED] drm_test_check_connector_changed_modeset
[14:12:45] ============== [PASSED] drm_validate_modeset ===============
[14:12:45] ====== drm_test_bridge_get_current_state (2 subtests) ======
[14:12:45] [PASSED] drm_test_drm_bridge_get_current_state_atomic
[14:12:45] [PASSED] drm_test_drm_bridge_get_current_state_legacy
[14:12:45] ======== [PASSED] drm_test_bridge_get_current_state ========
[14:12:45] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ======
[14:12:45] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic
[14:12:45] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled
[14:12:45] [PASSED] drm_test_drm_bridge_helper_reset_crtc_legacy
[14:12:45] ======== [PASSED] drm_test_bridge_helper_reset_crtc ========
[14:12:45] ============== drm_bridge_alloc (2 subtests) ===============
[14:12:45] [PASSED] drm_test_drm_bridge_alloc_basic
[14:12:45] [PASSED] drm_test_drm_bridge_alloc_get_put
[14:12:45] ================ [PASSED] drm_bridge_alloc =================
[14:12:45] ================== drm_buddy (7 subtests) ==================
[14:12:45] [PASSED] drm_test_buddy_alloc_limit
[14:12:45] [PASSED] drm_test_buddy_alloc_optimistic
[14:12:45] [PASSED] drm_test_buddy_alloc_pessimistic
[14:12:45] [PASSED] drm_test_buddy_alloc_pathological
[14:12:45] [PASSED] drm_test_buddy_alloc_contiguous
[14:12:45] [PASSED] drm_test_buddy_alloc_clear
[14:12:45] [PASSED] drm_test_buddy_alloc_range_bias
[14:12:45] ==================== [PASSED] drm_buddy ====================
[14:12:45] ============= drm_cmdline_parser (40 subtests) =============
[14:12:45] [PASSED] drm_test_cmdline_force_d_only
[14:12:45] [PASSED] drm_test_cmdline_force_D_only_dvi
[14:12:45] [PASSED] drm_test_cmdline_force_D_only_hdmi
[14:12:45] [PASSED] drm_test_cmdline_force_D_only_not_digital
[14:12:45] [PASSED] drm_test_cmdline_force_e_only
[14:12:45] [PASSED] drm_test_cmdline_res
[14:12:45] [PASSED] drm_test_cmdline_res_vesa
[14:12:45] [PASSED] drm_test_cmdline_res_vesa_rblank
[14:12:45] [PASSED] drm_test_cmdline_res_rblank
[14:12:45] [PASSED] drm_test_cmdline_res_bpp
[14:12:45] [PASSED] drm_test_cmdline_res_refresh
[14:12:45] [PASSED] drm_test_cmdline_res_bpp_refresh
[14:12:45] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced
[14:12:45] [PASSED] drm_test_cmdline_res_bpp_refresh_margins
[14:12:45] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off
[14:12:45] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on
[14:12:45] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog
[14:12:45] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital
[14:12:45] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on
[14:12:45] [PASSED] drm_test_cmdline_res_margins_force_on
[14:12:45] [PASSED] drm_test_cmdline_res_vesa_margins
[14:12:45] [PASSED] drm_test_cmdline_name
[14:12:45] [PASSED] drm_test_cmdline_name_bpp
[14:12:45] [PASSED] drm_test_cmdline_name_option
[14:12:45] [PASSED] drm_test_cmdline_name_bpp_option
[14:12:45] [PASSED] drm_test_cmdline_rotate_0
[14:12:45] [PASSED] drm_test_cmdline_rotate_90
[14:12:45] [PASSED] drm_test_cmdline_rotate_180
[14:12:45] [PASSED] drm_test_cmdline_rotate_270
[14:12:45] [PASSED] drm_test_cmdline_hmirror
[14:12:45] [PASSED] drm_test_cmdline_vmirror
[14:12:45] [PASSED] drm_test_cmdline_margin_options
[14:12:45] [PASSED] drm_test_cmdline_multiple_options
[14:12:45] [PASSED] drm_test_cmdline_bpp_extra_and_option
[14:12:45] [PASSED] drm_test_cmdline_extra_and_option
[14:12:45] [PASSED] drm_test_cmdline_freestanding_options
[14:12:45] [PASSED] drm_test_cmdline_freestanding_force_e_and_options
[14:12:45] [PASSED] drm_test_cmdline_panel_orientation
[14:12:45] ================ drm_test_cmdline_invalid =================
[14:12:45] [PASSED] margin_only
[14:12:45] [PASSED] interlace_only
[14:12:45] [PASSED] res_missing_x
[14:12:45] [PASSED] res_missing_y
[14:12:45] [PASSED] res_bad_y
[14:12:45] [PASSED] res_missing_y_bpp
[14:12:45] [PASSED] res_bad_bpp
[14:12:45] [PASSED] res_bad_refresh
[14:12:45] [PASSED] res_bpp_refresh_force_on_off
[14:12:45] [PASSED] res_invalid_mode
[14:12:45] [PASSED] res_bpp_wrong_place_mode
[14:12:45] [PASSED] name_bpp_refresh
[14:12:45] [PASSED] name_refresh
[14:12:45] [PASSED] name_refresh_wrong_mode
[14:12:45] [PASSED] name_refresh_invalid_mode
[14:12:45] [PASSED] rotate_multiple
[14:12:45] [PASSED] rotate_invalid_val
[14:12:45] [PASSED] rotate_truncated
[14:12:45] [PASSED] invalid_option
[14:12:45] [PASSED] invalid_tv_option
[14:12:45] [PASSED] truncated_tv_option
[14:12:45] ============ [PASSED] drm_test_cmdline_invalid =============
[14:12:45] =============== drm_test_cmdline_tv_options ===============
[14:12:45] [PASSED] NTSC
[14:12:45] [PASSED] NTSC_443
[14:12:45] [PASSED] NTSC_J
[14:12:45] [PASSED] PAL
[14:12:45] [PASSED] PAL_M
[14:12:45] [PASSED] PAL_N
[14:12:45] [PASSED] SECAM
[14:12:45] [PASSED] MONO_525
[14:12:45] [PASSED] MONO_625
[14:12:45] =========== [PASSED] drm_test_cmdline_tv_options ===========
[14:12:45] =============== [PASSED] drm_cmdline_parser ================
[14:12:45] ========== drmm_connector_hdmi_init (20 subtests) ==========
[14:12:45] [PASSED] drm_test_connector_hdmi_init_valid
[14:12:45] [PASSED] drm_test_connector_hdmi_init_bpc_8
[14:12:45] [PASSED] drm_test_connector_hdmi_init_bpc_10
[14:12:45] [PASSED] drm_test_connector_hdmi_init_bpc_12
[14:12:45] [PASSED] drm_test_connector_hdmi_init_bpc_invalid
[14:12:45] [PASSED] drm_test_connector_hdmi_init_bpc_null
[14:12:45] [PASSED] drm_test_connector_hdmi_init_formats_empty
[14:12:45] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb
[14:12:45] === drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[14:12:45] [PASSED] supported_formats=0x9 yuv420_allowed=1
[14:12:45] [PASSED] supported_formats=0x9 yuv420_allowed=0
[14:12:45] [PASSED] supported_formats=0x3 yuv420_allowed=1
[14:12:45] [PASSED] supported_formats=0x3 yuv420_allowed=0
[14:12:45] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[14:12:45] [PASSED] drm_test_connector_hdmi_init_null_ddc
[14:12:45] [PASSED] drm_test_connector_hdmi_init_null_product
[14:12:45] [PASSED] drm_test_connector_hdmi_init_null_vendor
[14:12:45] [PASSED] drm_test_connector_hdmi_init_product_length_exact
[14:12:45] [PASSED] drm_test_connector_hdmi_init_product_length_too_long
[14:12:45] [PASSED] drm_test_connector_hdmi_init_product_valid
[14:12:45] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact
[14:12:45] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long
[14:12:45] [PASSED] drm_test_connector_hdmi_init_vendor_valid
[14:12:45] ========= drm_test_connector_hdmi_init_type_valid =========
[14:12:45] [PASSED] HDMI-A
[14:12:45] [PASSED] HDMI-B
[14:12:45] ===== [PASSED] drm_test_connector_hdmi_init_type_valid =====
[14:12:45] ======== drm_test_connector_hdmi_init_type_invalid ========
[14:12:45] [PASSED] Unknown
[14:12:45] [PASSED] VGA
[14:12:45] [PASSED] DVI-I
[14:12:45] [PASSED] DVI-D
[14:12:45] [PASSED] DVI-A
[14:12:45] [PASSED] Composite
[14:12:45] [PASSED] SVIDEO
[14:12:45] [PASSED] LVDS
[14:12:45] [PASSED] Component
[14:12:45] [PASSED] DIN
[14:12:45] [PASSED] DP
[14:12:45] [PASSED] TV
[14:12:45] [PASSED] eDP
[14:12:45] [PASSED] Virtual
[14:12:45] [PASSED] DSI
[14:12:45] [PASSED] DPI
[14:12:45] [PASSED] Writeback
[14:12:45] [PASSED] SPI
[14:12:45] [PASSED] USB
[14:12:45] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ====
[14:12:45] ============ [PASSED] drmm_connector_hdmi_init =============
[14:12:45] ============= drmm_connector_init (3 subtests) =============
[14:12:45] [PASSED] drm_test_drmm_connector_init
[14:12:45] [PASSED] drm_test_drmm_connector_init_null_ddc
[14:12:45] ========= drm_test_drmm_connector_init_type_valid =========
[14:12:45] [PASSED] Unknown
[14:12:45] [PASSED] VGA
[14:12:45] [PASSED] DVI-I
[14:12:45] [PASSED] DVI-D
[14:12:45] [PASSED] DVI-A
[14:12:45] [PASSED] Composite
[14:12:45] [PASSED] SVIDEO
[14:12:45] [PASSED] LVDS
[14:12:45] [PASSED] Component
[14:12:45] [PASSED] DIN
[14:12:45] [PASSED] DP
[14:12:45] [PASSED] HDMI-A
[14:12:45] [PASSED] HDMI-B
[14:12:45] [PASSED] TV
[14:12:45] [PASSED] eDP
[14:12:45] [PASSED] Virtual
[14:12:45] [PASSED] DSI
[14:12:45] [PASSED] DPI
[14:12:45] [PASSED] Writeback
[14:12:45] [PASSED] SPI
[14:12:45] [PASSED] USB
[14:12:45] ===== [PASSED] drm_test_drmm_connector_init_type_valid =====
[14:12:45] =============== [PASSED] drmm_connector_init ===============
[14:12:45] ========= drm_connector_dynamic_init (6 subtests) ==========
[14:12:45] [PASSED] drm_test_drm_connector_dynamic_init
[14:12:45] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc
[14:12:45] [PASSED] drm_test_drm_connector_dynamic_init_not_added
[14:12:45] [PASSED] drm_test_drm_connector_dynamic_init_properties
[14:12:45] ===== drm_test_drm_connector_dynamic_init_type_valid ======
[14:12:45] [PASSED] Unknown
[14:12:45] [PASSED] VGA
[14:12:45] [PASSED] DVI-I
[14:12:45] [PASSED] DVI-D
[14:12:45] [PASSED] DVI-A
[14:12:45] [PASSED] Composite
[14:12:45] [PASSED] SVIDEO
[14:12:45] [PASSED] LVDS
[14:12:45] [PASSED] Component
[14:12:45] [PASSED] DIN
[14:12:45] [PASSED] DP
[14:12:45] [PASSED] HDMI-A
[14:12:45] [PASSED] HDMI-B
[14:12:45] [PASSED] TV
[14:12:45] [PASSED] eDP
[14:12:45] [PASSED] Virtual
[14:12:45] [PASSED] DSI
[14:12:45] [PASSED] DPI
[14:12:45] [PASSED] Writeback
[14:12:45] [PASSED] SPI
[14:12:45] [PASSED] USB
[14:12:45] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid ==
[14:12:45] ======== drm_test_drm_connector_dynamic_init_name =========
[14:12:45] [PASSED] Unknown
[14:12:45] [PASSED] VGA
[14:12:45] [PASSED] DVI-I
[14:12:45] [PASSED] DVI-D
[14:12:45] [PASSED] DVI-A
[14:12:45] [PASSED] Composite
[14:12:45] [PASSED] SVIDEO
[14:12:45] [PASSED] LVDS
[14:12:45] [PASSED] Component
[14:12:45] [PASSED] DIN
[14:12:45] [PASSED] DP
[14:12:45] [PASSED] HDMI-A
[14:12:45] [PASSED] HDMI-B
[14:12:45] [PASSED] TV
[14:12:45] [PASSED] eDP
[14:12:45] [PASSED] Virtual
[14:12:45] [PASSED] DSI
[14:12:45] [PASSED] DPI
[14:12:45] [PASSED] Writeback
[14:12:45] [PASSED] SPI
[14:12:45] [PASSED] USB
[14:12:45] ==== [PASSED] drm_test_drm_connector_dynamic_init_name =====
[14:12:45] =========== [PASSED] drm_connector_dynamic_init ============
[14:12:45] ==== drm_connector_dynamic_register_early (4 subtests) =====
[14:12:45] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list
[14:12:45] [PASSED] drm_test_drm_connector_dynamic_register_early_defer
[14:12:45] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init
[14:12:45] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object
[14:12:45] ====== [PASSED] drm_connector_dynamic_register_early =======
[14:12:45] ======= drm_connector_dynamic_register (7 subtests) ========
[14:12:45] [PASSED] drm_test_drm_connector_dynamic_register_on_list
[14:12:45] [PASSED] drm_test_drm_connector_dynamic_register_no_defer
[14:12:45] [PASSED] drm_test_drm_connector_dynamic_register_no_init
[14:12:45] [PASSED] drm_test_drm_connector_dynamic_register_mode_object
[14:12:45] [PASSED] drm_test_drm_connector_dynamic_register_sysfs
[14:12:45] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name
[14:12:45] [PASSED] drm_test_drm_connector_dynamic_register_debugfs
[14:12:45] ========= [PASSED] drm_connector_dynamic_register ==========
[14:12:45] = drm_connector_attach_broadcast_rgb_property (2 subtests) =
[14:12:45] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property
[14:12:45] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector
[14:12:45] === [PASSED] drm_connector_attach_broadcast_rgb_property ===
[14:12:45] ========== drm_get_tv_mode_from_name (2 subtests) ==========
[14:12:45] ========== drm_test_get_tv_mode_from_name_valid ===========
[14:12:45] [PASSED] NTSC
[14:12:45] [PASSED] NTSC-443
[14:12:45] [PASSED] NTSC-J
[14:12:45] [PASSED] PAL
[14:12:45] [PASSED] PAL-M
[14:12:45] [PASSED] PAL-N
[14:12:45] [PASSED] SECAM
[14:12:45] [PASSED] Mono
[14:12:45] ====== [PASSED] drm_test_get_tv_mode_from_name_valid =======
[14:12:45] [PASSED] drm_test_get_tv_mode_from_name_truncated
[14:12:45] ============ [PASSED] drm_get_tv_mode_from_name ============
[14:12:45] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) =
[14:12:45] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb
[14:12:45] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc
[14:12:45] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1
[14:12:45] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc
[14:12:45] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1
[14:12:45] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double
[14:12:45] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid =
[14:12:45] [PASSED] VIC 96
[14:12:45] [PASSED] VIC 97
[14:12:45] [PASSED] VIC 101
[14:12:45] [PASSED] VIC 102
[14:12:45] [PASSED] VIC 106
[14:12:45] [PASSED] VIC 107
[14:12:45] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid ===
[14:12:45] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc
[14:12:45] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc
[14:12:45] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc
[14:12:45] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc
[14:12:45] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc
[14:12:45] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ====
[14:12:45] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) ==
[14:12:45] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name ====
[14:12:45] [PASSED] Automatic
[14:12:45] [PASSED] Full
[14:12:45] [PASSED] Limited 16:235
[14:12:45] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name ===
[14:12:45] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid
[14:12:45] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ====
[14:12:45] == drm_hdmi_connector_get_output_format_name (2 subtests) ==
[14:12:45] === drm_test_drm_hdmi_connector_get_output_format_name ====
[14:12:45] [PASSED] RGB
[14:12:45] [PASSED] YUV 4:2:0
[14:12:45] [PASSED] YUV 4:2:2
[14:12:45] [PASSED] YUV 4:4:4
[14:12:45] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name ===
[14:12:45] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid
[14:12:45] ==== [PASSED] drm_hdmi_connector_get_output_format_name ====
[14:12:45] ============= drm_damage_helper (21 subtests) ==============
[14:12:45] [PASSED] drm_test_damage_iter_no_damage
[14:12:45] [PASSED] drm_test_damage_iter_no_damage_fractional_src
[14:12:45] [PASSED] drm_test_damage_iter_no_damage_src_moved
[14:12:45] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved
[14:12:45] [PASSED] drm_test_damage_iter_no_damage_not_visible
[14:12:45] [PASSED] drm_test_damage_iter_no_damage_no_crtc
[14:12:45] [PASSED] drm_test_damage_iter_no_damage_no_fb
[14:12:45] [PASSED] drm_test_damage_iter_simple_damage
[14:12:45] [PASSED] drm_test_damage_iter_single_damage
[14:12:45] [PASSED] drm_test_damage_iter_single_damage_intersect_src
[14:12:45] [PASSED] drm_test_damage_iter_single_damage_outside_src
[14:12:45] [PASSED] drm_test_damage_iter_single_damage_fractional_src
[14:12:45] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src
[14:12:45] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src
[14:12:45] [PASSED] drm_test_damage_iter_single_damage_src_moved
[14:12:45] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved
[14:12:45] [PASSED] drm_test_damage_iter_damage
[14:12:45] [PASSED] drm_test_damage_iter_damage_one_intersect
[14:12:45] [PASSED] drm_test_damage_iter_damage_one_outside
[14:12:45] [PASSED] drm_test_damage_iter_damage_src_moved
[14:12:45] [PASSED] drm_test_damage_iter_damage_not_visible
[14:12:45] ================ [PASSED] drm_damage_helper ================
[14:12:45] ============== drm_dp_mst_helper (3 subtests) ==============
[14:12:45] ============== drm_test_dp_mst_calc_pbn_mode ==============
[14:12:45] [PASSED] Clock 154000 BPP 30 DSC disabled
[14:12:45] [PASSED] Clock 234000 BPP 30 DSC disabled
[14:12:45] [PASSED] Clock 297000 BPP 24 DSC disabled
[14:12:45] [PASSED] Clock 332880 BPP 24 DSC enabled
[14:12:45] [PASSED] Clock 324540 BPP 24 DSC enabled
[14:12:45] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ==========
[14:12:45] ============== drm_test_dp_mst_calc_pbn_div ===============
[14:12:45] [PASSED] Link rate 2000000 lane count 4
[14:12:45] [PASSED] Link rate 2000000 lane count 2
[14:12:45] [PASSED] Link rate 2000000 lane count 1
[14:12:45] [PASSED] Link rate 1350000 lane count 4
[14:12:45] [PASSED] Link rate 1350000 lane count 2
[14:12:45] [PASSED] Link rate 1350000 lane count 1
[14:12:45] [PASSED] Link rate 1000000 lane count 4
[14:12:45] [PASSED] Link rate 1000000 lane count 2
[14:12:45] [PASSED] Link rate 1000000 lane count 1
[14:12:45] [PASSED] Link rate 810000 lane count 4
[14:12:45] [PASSED] Link rate 810000 lane count 2
[14:12:45] [PASSED] Link rate 810000 lane count 1
[14:12:45] [PASSED] Link rate 540000 lane count 4
[14:12:45] [PASSED] Link rate 540000 lane count 2
[14:12:45] [PASSED] Link rate 540000 lane count 1
[14:12:45] [PASSED] Link rate 270000 lane count 4
[14:12:45] [PASSED] Link rate 270000 lane count 2
[14:12:45] [PASSED] Link rate 270000 lane count 1
[14:12:45] [PASSED] Link rate 162000 lane count 4
[14:12:45] [PASSED] Link rate 162000 lane count 2
[14:12:45] [PASSED] Link rate 162000 lane count 1
[14:12:45] ========== [PASSED] drm_test_dp_mst_calc_pbn_div ===========
[14:12:45] ========= drm_test_dp_mst_sideband_msg_req_decode =========
[14:12:45] [PASSED] DP_ENUM_PATH_RESOURCES with port number
[14:12:45] [PASSED] DP_POWER_UP_PHY with port number
[14:12:45] [PASSED] DP_POWER_DOWN_PHY with port number
[14:12:45] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks
[14:12:45] [PASSED] DP_ALLOCATE_PAYLOAD with port number
[14:12:45] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI
[14:12:45] [PASSED] DP_ALLOCATE_PAYLOAD with PBN
[14:12:45] [PASSED] DP_QUERY_PAYLOAD with port number
[14:12:45] [PASSED] DP_QUERY_PAYLOAD with VCPI
[14:12:45] [PASSED] DP_REMOTE_DPCD_READ with port number
[14:12:45] [PASSED] DP_REMOTE_DPCD_READ with DPCD address
[14:12:45] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes
[14:12:45] [PASSED] DP_REMOTE_DPCD_WRITE with port number
[14:12:45] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address
[14:12:45] [PASSED] DP_REMOTE_DPCD_WRITE with data array
[14:12:45] [PASSED] DP_REMOTE_I2C_READ with port number
[14:12:45] [PASSED] DP_REMOTE_I2C_READ with I2C device ID
[14:12:45] [PASSED] DP_REMOTE_I2C_READ with transactions array
[14:12:45] [PASSED] DP_REMOTE_I2C_WRITE with port number
[14:12:45] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID
[14:12:45] [PASSED] DP_REMOTE_I2C_WRITE with data array
[14:12:45] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID
[14:12:45] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID
[14:12:45] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event
[14:12:45] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event
[14:12:45] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior
[14:12:45] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior
[14:12:45] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode =====
[14:12:45] ================ [PASSED] drm_dp_mst_helper ================
[14:12:45] ================== drm_exec (7 subtests) ===================
[14:12:45] [PASSED] sanitycheck
[14:12:45] [PASSED] test_lock
[14:12:45] [PASSED] test_lock_unlock
[14:12:45] [PASSED] test_duplicates
[14:12:45] [PASSED] test_prepare
[14:12:45] [PASSED] test_prepare_array
[14:12:45] [PASSED] test_multiple_loops
[14:12:45] ==================== [PASSED] drm_exec =====================
[14:12:45] =========== drm_format_helper_test (17 subtests) ===========
[14:12:45] ============== drm_test_fb_xrgb8888_to_gray8 ==============
[14:12:45] [PASSED] single_pixel_source_buffer
[14:12:45] [PASSED] single_pixel_clip_rectangle
[14:12:45] [PASSED] well_known_colors
[14:12:45] [PASSED] destination_pitch
[14:12:45] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ==========
[14:12:45] ============= drm_test_fb_xrgb8888_to_rgb332 ==============
[14:12:45] [PASSED] single_pixel_source_buffer
[14:12:45] [PASSED] single_pixel_clip_rectangle
[14:12:45] [PASSED] well_known_colors
[14:12:45] [PASSED] destination_pitch
[14:12:45] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ==========
[14:12:45] ============= drm_test_fb_xrgb8888_to_rgb565 ==============
[14:12:45] [PASSED] single_pixel_source_buffer
[14:12:45] [PASSED] single_pixel_clip_rectangle
[14:12:45] [PASSED] well_known_colors
[14:12:45] [PASSED] destination_pitch
[14:12:45] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ==========
[14:12:45] ============ drm_test_fb_xrgb8888_to_xrgb1555 =============
[14:12:45] [PASSED] single_pixel_source_buffer
[14:12:45] [PASSED] single_pixel_clip_rectangle
[14:12:45] [PASSED] well_known_colors
[14:12:45] [PASSED] destination_pitch
[14:12:45] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 =========
[14:12:45] ============ drm_test_fb_xrgb8888_to_argb1555 =============
[14:12:45] [PASSED] single_pixel_source_buffer
[14:12:45] [PASSED] single_pixel_clip_rectangle
[14:12:45] [PASSED] well_known_colors
[14:12:45] [PASSED] destination_pitch
[14:12:45] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 =========
[14:12:45] ============ drm_test_fb_xrgb8888_to_rgba5551 =============
[14:12:45] [PASSED] single_pixel_source_buffer
[14:12:45] [PASSED] single_pixel_clip_rectangle
[14:12:45] [PASSED] well_known_colors
[14:12:45] [PASSED] destination_pitch
[14:12:45] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 =========
[14:12:45] ============= drm_test_fb_xrgb8888_to_rgb888 ==============
[14:12:45] [PASSED] single_pixel_source_buffer
[14:12:45] [PASSED] single_pixel_clip_rectangle
[14:12:45] [PASSED] well_known_colors
[14:12:45] [PASSED] destination_pitch
[14:12:45] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ==========
[14:12:45] ============= drm_test_fb_xrgb8888_to_bgr888 ==============
[14:12:45] [PASSED] single_pixel_source_buffer
[14:12:45] [PASSED] single_pixel_clip_rectangle
[14:12:45] [PASSED] well_known_colors
[14:12:45] [PASSED] destination_pitch
[14:12:45] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ==========
[14:12:45] ============ drm_test_fb_xrgb8888_to_argb8888 =============
[14:12:45] [PASSED] single_pixel_source_buffer
[14:12:45] [PASSED] single_pixel_clip_rectangle
[14:12:45] [PASSED] well_known_colors
[14:12:45] [PASSED] destination_pitch
[14:12:45] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 =========
[14:12:45] =========== drm_test_fb_xrgb8888_to_xrgb2101010 ===========
[14:12:45] [PASSED] single_pixel_source_buffer
[14:12:45] [PASSED] single_pixel_clip_rectangle
[14:12:45] [PASSED] well_known_colors
[14:12:45] [PASSED] destination_pitch
[14:12:45] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 =======
[14:12:45] =========== drm_test_fb_xrgb8888_to_argb2101010 ===========
[14:12:45] [PASSED] single_pixel_source_buffer
[14:12:45] [PASSED] single_pixel_clip_rectangle
[14:12:45] [PASSED] well_known_colors
[14:12:45] [PASSED] destination_pitch
[14:12:45] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 =======
[14:12:45] ============== drm_test_fb_xrgb8888_to_mono ===============
[14:12:45] [PASSED] single_pixel_source_buffer
[14:12:45] [PASSED] single_pixel_clip_rectangle
[14:12:45] [PASSED] well_known_colors
[14:12:45] [PASSED] destination_pitch
[14:12:45] ========== [PASSED] drm_test_fb_xrgb8888_to_mono ===========
[14:12:45] ==================== drm_test_fb_swab =====================
[14:12:45] [PASSED] single_pixel_source_buffer
[14:12:45] [PASSED] single_pixel_clip_rectangle
[14:12:45] [PASSED] well_known_colors
[14:12:45] [PASSED] destination_pitch
[14:12:45] ================ [PASSED] drm_test_fb_swab =================
[14:12:45] ============ drm_test_fb_xrgb8888_to_xbgr8888 =============
[14:12:45] [PASSED] single_pixel_source_buffer
[14:12:45] [PASSED] single_pixel_clip_rectangle
[14:12:45] [PASSED] well_known_colors
[14:12:45] [PASSED] destination_pitch
[14:12:45] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 =========
[14:12:45] ============ drm_test_fb_xrgb8888_to_abgr8888 =============
[14:12:45] [PASSED] single_pixel_source_buffer
[14:12:45] [PASSED] single_pixel_clip_rectangle
[14:12:45] [PASSED] well_known_colors
[14:12:45] [PASSED] destination_pitch
[14:12:45] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 =========
[14:12:45] ================= drm_test_fb_clip_offset =================
[14:12:45] [PASSED] pass through
[14:12:45] [PASSED] horizontal offset
[14:12:45] [PASSED] vertical offset
[14:12:45] [PASSED] horizontal and vertical offset
[14:12:45] [PASSED] horizontal offset (custom pitch)
[14:12:45] [PASSED] vertical offset (custom pitch)
[14:12:45] [PASSED] horizontal and vertical offset (custom pitch)
[14:12:45] ============= [PASSED] drm_test_fb_clip_offset =============
[14:12:45] =================== drm_test_fb_memcpy ====================
[14:12:45] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258)
[14:12:45] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258)
[14:12:45] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559)
[14:12:45] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258)
[14:12:45] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258)
[14:12:45] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559)
[14:12:45] [PASSED] well_known_colors: XB24 little-endian (0x34324258)
[14:12:45] [PASSED] well_known_colors: XRA8 little-endian (0x38415258)
[14:12:45] [PASSED] well_known_colors: YU24 little-endian (0x34325559)
[14:12:45] [PASSED] destination_pitch: XB24 little-endian (0x34324258)
[14:12:45] [PASSED] destination_pitch: XRA8 little-endian (0x38415258)
[14:12:45] [PASSED] destination_pitch: YU24 little-endian (0x34325559)
[14:12:45] =============== [PASSED] drm_test_fb_memcpy ================
[14:12:45] ============= [PASSED] drm_format_helper_test ==============
[14:12:45] ================= drm_format (18 subtests) =================
[14:12:45] [PASSED] drm_test_format_block_width_invalid
[14:12:45] [PASSED] drm_test_format_block_width_one_plane
[14:12:45] [PASSED] drm_test_format_block_width_two_plane
[14:12:45] [PASSED] drm_test_format_block_width_three_plane
[14:12:45] [PASSED] drm_test_format_block_width_tiled
[14:12:45] [PASSED] drm_test_format_block_height_invalid
[14:12:45] [PASSED] drm_test_format_block_height_one_plane
[14:12:45] [PASSED] drm_test_format_block_height_two_plane
[14:12:45] [PASSED] drm_test_format_block_height_three_plane
[14:12:45] [PASSED] drm_test_format_block_height_tiled
[14:12:45] [PASSED] drm_test_format_min_pitch_invalid
[14:12:45] [PASSED] drm_test_format_min_pitch_one_plane_8bpp
[14:12:45] [PASSED] drm_test_format_min_pitch_one_plane_16bpp
[14:12:45] [PASSED] drm_test_format_min_pitch_one_plane_24bpp
[14:12:45] [PASSED] drm_test_format_min_pitch_one_plane_32bpp
[14:12:45] [PASSED] drm_test_format_min_pitch_two_plane
[14:12:45] [PASSED] drm_test_format_min_pitch_three_plane_8bpp
[14:12:45] [PASSED] drm_test_format_min_pitch_tiled
[14:12:45] =================== [PASSED] drm_format ====================
[14:12:45] ============== drm_framebuffer (10 subtests) ===============
[14:12:45] ========== drm_test_framebuffer_check_src_coords ==========
[14:12:45] [PASSED] Success: source fits into fb
[14:12:45] [PASSED] Fail: overflowing fb with x-axis coordinate
[14:12:45] [PASSED] Fail: overflowing fb with y-axis coordinate
[14:12:45] [PASSED] Fail: overflowing fb with source width
[14:12:45] [PASSED] Fail: overflowing fb with source height
[14:12:45] ====== [PASSED] drm_test_framebuffer_check_src_coords ======
[14:12:45] [PASSED] drm_test_framebuffer_cleanup
[14:12:45] =============== drm_test_framebuffer_create ===============
[14:12:45] [PASSED] ABGR8888 normal sizes
[14:12:45] [PASSED] ABGR8888 max sizes
[14:12:45] [PASSED] ABGR8888 pitch greater than min required
[14:12:45] [PASSED] ABGR8888 pitch less than min required
[14:12:45] [PASSED] ABGR8888 Invalid width
[14:12:45] [PASSED] ABGR8888 Invalid buffer handle
[14:12:45] [PASSED] No pixel format
[14:12:45] [PASSED] ABGR8888 Width 0
[14:12:45] [PASSED] ABGR8888 Height 0
[14:12:45] [PASSED] ABGR8888 Out of bound height * pitch combination
[14:12:45] [PASSED] ABGR8888 Large buffer offset
[14:12:45] [PASSED] ABGR8888 Buffer offset for inexistent plane
[14:12:45] [PASSED] ABGR8888 Invalid flag
[14:12:45] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers
[14:12:45] [PASSED] ABGR8888 Valid buffer modifier
[14:12:45] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE)
[14:12:45] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS
[14:12:45] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS
[14:12:45] [PASSED] NV12 Normal sizes
[14:12:45] [PASSED] NV12 Max sizes
[14:12:45] [PASSED] NV12 Invalid pitch
[14:12:45] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag
[14:12:45] [PASSED] NV12 different modifier per-plane
[14:12:45] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE
[14:12:45] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS
[14:12:45] [PASSED] NV12 Modifier for inexistent plane
[14:12:45] [PASSED] NV12 Handle for inexistent plane
[14:12:45] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS
[14:12:45] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier
[14:12:45] [PASSED] YVU420 Normal sizes
[14:12:45] [PASSED] YVU420 Max sizes
[14:12:45] [PASSED] YVU420 Invalid pitch
[14:12:45] [PASSED] YVU420 Different pitches
[14:12:45] [PASSED] YVU420 Different buffer offsets/pitches
[14:12:45] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS
[14:12:45] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS
[14:12:45] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS
[14:12:45] [PASSED] YVU420 Valid modifier
[14:12:45] [PASSED] YVU420 Different modifiers per plane
[14:12:45] [PASSED] YVU420 Modifier for inexistent plane
[14:12:45] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR)
[14:12:45] [PASSED] X0L2 Normal sizes
[14:12:45] [PASSED] X0L2 Max sizes
[14:12:45] [PASSED] X0L2 Invalid pitch
[14:12:45] [PASSED] X0L2 Pitch greater than minimum required
[14:12:45] [PASSED] X0L2 Handle for inexistent plane
[14:12:45] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set
[14:12:45] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set
[14:12:45] [PASSED] X0L2 Valid modifier
[14:12:45] [PASSED] X0L2 Modifier for inexistent plane
[14:12:45] =========== [PASSED] drm_test_framebuffer_create ===========
[14:12:45] [PASSED] drm_test_framebuffer_free
[14:12:45] [PASSED] drm_test_framebuffer_init
[14:12:45] [PASSED] drm_test_framebuffer_init_bad_format
[14:12:45] [PASSED] drm_test_framebuffer_init_dev_mismatch
[14:12:45] [PASSED] drm_test_framebuffer_lookup
[14:12:45] [PASSED] drm_test_framebuffer_lookup_inexistent
[14:12:45] [PASSED] drm_test_framebuffer_modifiers_not_supported
[14:12:45] ================= [PASSED] drm_framebuffer =================
[14:12:45] ================ drm_gem_shmem (8 subtests) ================
[14:12:45] [PASSED] drm_gem_shmem_test_obj_create
[14:12:45] [PASSED] drm_gem_shmem_test_obj_create_private
[14:12:45] [PASSED] drm_gem_shmem_test_pin_pages
[14:12:45] [PASSED] drm_gem_shmem_test_vmap
[14:12:45] [PASSED] drm_gem_shmem_test_get_pages_sgt
[14:12:45] [PASSED] drm_gem_shmem_test_get_sg_table
[14:12:45] [PASSED] drm_gem_shmem_test_madvise
[14:12:45] [PASSED] drm_gem_shmem_test_purge
[14:12:45] ================== [PASSED] drm_gem_shmem ==================
[14:12:45] === drm_atomic_helper_connector_hdmi_check (27 subtests) ===
[14:12:45] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode
[14:12:45] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1
[14:12:45] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode
[14:12:45] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1
[14:12:45] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode
[14:12:45] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1
[14:12:45] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420 =======
[14:12:45] [PASSED] Automatic
[14:12:45] [PASSED] Full
[14:12:45] [PASSED] Limited 16:235
[14:12:45] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 ===
[14:12:45] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed
[14:12:45] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed
[14:12:45] [PASSED] drm_test_check_disable_connector
[14:12:45] [PASSED] drm_test_check_hdmi_funcs_reject_rate
[14:12:45] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb
[14:12:45] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420
[14:12:45] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422
[14:12:45] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420
[14:12:45] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420
[14:12:45] [PASSED] drm_test_check_output_bpc_crtc_mode_changed
[14:12:45] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed
[14:12:45] [PASSED] drm_test_check_output_bpc_dvi
[14:12:45] [PASSED] drm_test_check_output_bpc_format_vic_1
[14:12:45] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only
[14:12:45] [PASSED] drm_test_check_output_bpc_format_display_rgb_only
[14:12:45] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only
[14:12:45] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only
[14:12:45] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc
[14:12:45] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc
[14:12:45] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc
[14:12:45] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ======
[14:12:45] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ====
[14:12:45] [PASSED] drm_test_check_broadcast_rgb_value
[14:12:45] [PASSED] drm_test_check_bpc_8_value
[14:12:45] [PASSED] drm_test_check_bpc_10_value
[14:12:45] [PASSED] drm_test_check_bpc_12_value
[14:12:45] [PASSED] drm_test_check_format_value
[14:12:45] [PASSED] drm_test_check_tmds_char_value
[14:12:45] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ======
[14:12:45] = drm_atomic_helper_connector_hdmi_mode_valid (4 subtests) =
[14:12:45] [PASSED] drm_test_check_mode_valid
[14:12:45] [PASSED] drm_test_check_mode_valid_reject
[14:12:45] [PASSED] drm_test_check_mode_valid_reject_rate
[14:12:45] [PASSED] drm_test_check_mode_valid_reject_max_clock
[14:12:45] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid ===
[14:12:45] ================= drm_managed (2 subtests) =================
[14:12:45] [PASSED] drm_test_managed_release_action
[14:12:45] [PASSED] drm_test_managed_run_action
[14:12:45] =================== [PASSED] drm_managed ===================
[14:12:45] =================== drm_mm (6 subtests) ====================
[14:12:45] [PASSED] drm_test_mm_init
[14:12:45] [PASSED] drm_test_mm_debug
[14:12:45] [PASSED] drm_test_mm_align32
[14:12:45] [PASSED] drm_test_mm_align64
[14:12:45] [PASSED] drm_test_mm_lowest
[14:12:45] [PASSED] drm_test_mm_highest
[14:12:45] ===================== [PASSED] drm_mm ======================
[14:12:45] ============= drm_modes_analog_tv (5 subtests) =============
[14:12:45] [PASSED] drm_test_modes_analog_tv_mono_576i
[14:12:45] [PASSED] drm_test_modes_analog_tv_ntsc_480i
[14:12:45] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined
[14:12:45] [PASSED] drm_test_modes_analog_tv_pal_576i
[14:12:45] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined
[14:12:45] =============== [PASSED] drm_modes_analog_tv ===============
[14:12:45] ============== drm_plane_helper (2 subtests) ===============
[14:12:45] =============== drm_test_check_plane_state ================
[14:12:45] [PASSED] clipping_simple
[14:12:45] [PASSED] clipping_rotate_reflect
[14:12:45] [PASSED] positioning_simple
[14:12:45] [PASSED] upscaling
[14:12:45] [PASSED] downscaling
[14:12:45] [PASSED] rounding1
[14:12:45] [PASSED] rounding2
[14:12:45] [PASSED] rounding3
[14:12:45] [PASSED] rounding4
[14:12:45] =========== [PASSED] drm_test_check_plane_state ============
[14:12:45] =========== drm_test_check_invalid_plane_state ============
[14:12:45] [PASSED] positioning_invalid
[14:12:45] [PASSED] upscaling_invalid
[14:12:45] [PASSED] downscaling_invalid
[14:12:45] ======= [PASSED] drm_test_check_invalid_plane_state ========
[14:12:45] ================ [PASSED] drm_plane_helper =================
[14:12:45] ====== drm_connector_helper_tv_get_modes (1 subtest) =======
[14:12:45] ====== drm_test_connector_helper_tv_get_modes_check =======
[14:12:45] [PASSED] None
[14:12:45] [PASSED] PAL
[14:12:45] [PASSED] NTSC
[14:12:45] [PASSED] Both, NTSC Default
[14:12:45] [PASSED] Both, PAL Default
[14:12:45] [PASSED] Both, NTSC Default, with PAL on command-line
[14:12:45] [PASSED] Both, PAL Default, with NTSC on command-line
[14:12:45] == [PASSED] drm_test_connector_helper_tv_get_modes_check ===
[14:12:45] ======== [PASSED] drm_connector_helper_tv_get_modes ========
[14:12:45] ================== drm_rect (9 subtests) ===================
[14:12:45] [PASSED] drm_test_rect_clip_scaled_div_by_zero
[14:12:45] [PASSED] drm_test_rect_clip_scaled_not_clipped
[14:12:45] [PASSED] drm_test_rect_clip_scaled_clipped
[14:12:45] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned
[14:12:45] ================= drm_test_rect_intersect =================
[14:12:45] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0
[14:12:45] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1
[14:12:45] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0
[14:12:45] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1
[14:12:45] [PASSED] right x left: 2x1+0+0 x 3x1+1+0
[14:12:45] [PASSED] left x right: 3x1+1+0 x 2x1+0+0
[14:12:45] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1
[14:12:45] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0
[14:12:45] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1
[14:12:45] [PASSED] touching side: 1x1+0+0 x 1x1+1+0
[14:12:45] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0
[14:12:45] [PASSED] inside another: 2x2+0+0 x 1x1+1+1
[14:12:45] [PASSED] far away: 1x1+0+0 x 1x1+3+6
[14:12:45] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10
[14:12:45] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10
[14:12:45] ============= [PASSED] drm_test_rect_intersect =============
[14:12:45] ================ drm_test_rect_calc_hscale ================
[14:12:45] [PASSED] normal use
[14:12:45] [PASSED] out of max range
[14:12:45] [PASSED] out of min range
[14:12:45] [PASSED] zero dst
[14:12:45] [PASSED] negative src
[14:12:45] [PASSED] negative dst
[14:12:45] ============ [PASSED] drm_test_rect_calc_hscale ============
[14:12:45] ================ drm_test_rect_calc_vscale ================
[14:12:45] [PASSED] normal use
[14:12:45] [PASSED] out of max range
[14:12:45] [PASSED] out of min range
[14:12:45] [PASSED] zero dst
[14:12:45] [PASSED] negative src
[14:12:45] [PASSED] negative dst
[14:12:45] ============ [PASSED] drm_test_rect_calc_vscale ============
[14:12:45] ================== drm_test_rect_rotate ===================
[14:12:45] [PASSED] reflect-x
[14:12:45] [PASSED] reflect-y
[14:12:45] [PASSED] rotate-0
[14:12:45] [PASSED] rotate-90
[14:12:45] [PASSED] rotate-180
[14:12:45] [PASSED] rotate-270
stty: 'standard input': Inappropriate ioctl for device
[14:12:45] ============== [PASSED] drm_test_rect_rotate ===============
[14:12:45] ================ drm_test_rect_rotate_inv =================
[14:12:45] [PASSED] reflect-x
[14:12:45] [PASSED] reflect-y
[14:12:45] [PASSED] rotate-0
[14:12:45] [PASSED] rotate-90
[14:12:45] [PASSED] rotate-180
[14:12:45] [PASSED] rotate-270
[14:12:45] ============ [PASSED] drm_test_rect_rotate_inv =============
[14:12:45] ==================== [PASSED] drm_rect =====================
[14:12:45] ============ drm_sysfb_modeset_test (1 subtest) ============
[14:12:45] ============ drm_test_sysfb_build_fourcc_list =============
[14:12:45] [PASSED] no native formats
[14:12:45] [PASSED] XRGB8888 as native format
[14:12:45] [PASSED] remove duplicates
[14:12:45] [PASSED] convert alpha formats
[14:12:45] [PASSED] random formats
[14:12:45] ======== [PASSED] drm_test_sysfb_build_fourcc_list =========
[14:12:45] ============= [PASSED] drm_sysfb_modeset_test ==============
[14:12:45] ============================================================
[14:12:45] Testing complete. Ran 616 tests: passed: 616
[14:12:45] Elapsed time: 24.602s total, 1.713s configuring, 22.671s building, 0.194s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig
[14:12:45] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[14:12:47] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[14:12:55] Starting KUnit Kernel (1/1)...
[14:12:55] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[14:12:55] ================= ttm_device (5 subtests) ==================
[14:12:55] [PASSED] ttm_device_init_basic
[14:12:55] [PASSED] ttm_device_init_multiple
[14:12:55] [PASSED] ttm_device_fini_basic
[14:12:55] [PASSED] ttm_device_init_no_vma_man
[14:12:55] ================== ttm_device_init_pools ==================
[14:12:55] [PASSED] No DMA allocations, no DMA32 required
[14:12:55] [PASSED] DMA allocations, DMA32 required
[14:12:55] [PASSED] No DMA allocations, DMA32 required
[14:12:55] [PASSED] DMA allocations, no DMA32 required
[14:12:55] ============== [PASSED] ttm_device_init_pools ==============
[14:12:55] =================== [PASSED] ttm_device ====================
[14:12:55] ================== ttm_pool (8 subtests) ===================
[14:12:55] ================== ttm_pool_alloc_basic ===================
[14:12:55] [PASSED] One page
[14:12:55] [PASSED] More than one page
[14:12:55] [PASSED] Above the allocation limit
[14:12:55] [PASSED] One page, with coherent DMA mappings enabled
[14:12:55] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[14:12:55] ============== [PASSED] ttm_pool_alloc_basic ===============
[14:12:55] ============== ttm_pool_alloc_basic_dma_addr ==============
[14:12:55] [PASSED] One page
[14:12:55] [PASSED] More than one page
[14:12:55] [PASSED] Above the allocation limit
[14:12:55] [PASSED] One page, with coherent DMA mappings enabled
[14:12:55] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[14:12:55] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ==========
[14:12:55] [PASSED] ttm_pool_alloc_order_caching_match
[14:12:55] [PASSED] ttm_pool_alloc_caching_mismatch
[14:12:55] [PASSED] ttm_pool_alloc_order_mismatch
[14:12:55] [PASSED] ttm_pool_free_dma_alloc
[14:12:55] [PASSED] ttm_pool_free_no_dma_alloc
[14:12:55] [PASSED] ttm_pool_fini_basic
[14:12:55] ==================== [PASSED] ttm_pool =====================
[14:12:55] ================ ttm_resource (8 subtests) =================
[14:12:55] ================= ttm_resource_init_basic =================
[14:12:55] [PASSED] Init resource in TTM_PL_SYSTEM
[14:12:55] [PASSED] Init resource in TTM_PL_VRAM
[14:12:55] [PASSED] Init resource in a private placement
[14:12:55] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags
[14:12:55] ============= [PASSED] ttm_resource_init_basic =============
[14:12:55] [PASSED] ttm_resource_init_pinned
[14:12:55] [PASSED] ttm_resource_fini_basic
[14:12:55] [PASSED] ttm_resource_manager_init_basic
[14:12:55] [PASSED] ttm_resource_manager_usage_basic
[14:12:55] [PASSED] ttm_resource_manager_set_used_basic
[14:12:55] [PASSED] ttm_sys_man_alloc_basic
[14:12:55] [PASSED] ttm_sys_man_free_basic
[14:12:55] ================== [PASSED] ttm_resource ===================
[14:12:55] =================== ttm_tt (15 subtests) ===================
[14:12:55] ==================== ttm_tt_init_basic ====================
[14:12:55] [PASSED] Page-aligned size
[14:12:55] [PASSED] Extra pages requested
[14:12:55] ================ [PASSED] ttm_tt_init_basic ================
[14:12:55] [PASSED] ttm_tt_init_misaligned
[14:12:55] [PASSED] ttm_tt_fini_basic
[14:12:55] [PASSED] ttm_tt_fini_sg
[14:12:55] [PASSED] ttm_tt_fini_shmem
[14:12:55] [PASSED] ttm_tt_create_basic
[14:12:55] [PASSED] ttm_tt_create_invalid_bo_type
[14:12:55] [PASSED] ttm_tt_create_ttm_exists
[14:12:55] [PASSED] ttm_tt_create_failed
[14:12:55] [PASSED] ttm_tt_destroy_basic
[14:12:55] [PASSED] ttm_tt_populate_null_ttm
[14:12:55] [PASSED] ttm_tt_populate_populated_ttm
[14:12:55] [PASSED] ttm_tt_unpopulate_basic
[14:12:55] [PASSED] ttm_tt_unpopulate_empty_ttm
[14:12:55] [PASSED] ttm_tt_swapin_basic
[14:12:55] ===================== [PASSED] ttm_tt ======================
[14:12:55] =================== ttm_bo (14 subtests) ===================
[14:12:55] =========== ttm_bo_reserve_optimistic_no_ticket ===========
[14:12:55] [PASSED] Cannot be interrupted and sleeps
[14:12:55] [PASSED] Cannot be interrupted, locks straight away
[14:12:55] [PASSED] Can be interrupted, sleeps
[14:12:55] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket =======
[14:12:55] [PASSED] ttm_bo_reserve_locked_no_sleep
[14:12:55] [PASSED] ttm_bo_reserve_no_wait_ticket
[14:12:55] [PASSED] ttm_bo_reserve_double_resv
[14:12:55] [PASSED] ttm_bo_reserve_interrupted
[14:12:55] [PASSED] ttm_bo_reserve_deadlock
[14:12:55] [PASSED] ttm_bo_unreserve_basic
[14:12:55] [PASSED] ttm_bo_unreserve_pinned
[14:12:55] [PASSED] ttm_bo_unreserve_bulk
[14:12:55] [PASSED] ttm_bo_put_basic
[14:12:55] [PASSED] ttm_bo_put_shared_resv
[14:12:55] [PASSED] ttm_bo_pin_basic
[14:12:55] [PASSED] ttm_bo_pin_unpin_resource
[14:12:55] [PASSED] ttm_bo_multiple_pin_one_unpin
[14:12:55] ===================== [PASSED] ttm_bo ======================
[14:12:55] ============== ttm_bo_validate (21 subtests) ===============
[14:12:55] ============== ttm_bo_init_reserved_sys_man ===============
[14:12:55] [PASSED] Buffer object for userspace
[14:12:55] [PASSED] Kernel buffer object
[14:12:55] [PASSED] Shared buffer object
[14:12:55] ========== [PASSED] ttm_bo_init_reserved_sys_man ===========
[14:12:55] ============== ttm_bo_init_reserved_mock_man ==============
[14:12:55] [PASSED] Buffer object for userspace
[14:12:55] [PASSED] Kernel buffer object
[14:12:55] [PASSED] Shared buffer object
[14:12:55] ========== [PASSED] ttm_bo_init_reserved_mock_man ==========
[14:12:55] [PASSED] ttm_bo_init_reserved_resv
[14:12:55] ================== ttm_bo_validate_basic ==================
[14:12:55] [PASSED] Buffer object for userspace
[14:12:55] [PASSED] Kernel buffer object
[14:12:55] [PASSED] Shared buffer object
[14:12:55] ============== [PASSED] ttm_bo_validate_basic ==============
[14:12:55] [PASSED] ttm_bo_validate_invalid_placement
[14:12:55] ============= ttm_bo_validate_same_placement ==============
[14:12:55] [PASSED] System manager
[14:12:55] [PASSED] VRAM manager
[14:12:55] ========= [PASSED] ttm_bo_validate_same_placement ==========
[14:12:55] [PASSED] ttm_bo_validate_failed_alloc
[14:12:55] [PASSED] ttm_bo_validate_pinned
[14:12:55] [PASSED] ttm_bo_validate_busy_placement
[14:12:55] ================ ttm_bo_validate_multihop =================
[14:12:55] [PASSED] Buffer object for userspace
[14:12:55] [PASSED] Kernel buffer object
[14:12:55] [PASSED] Shared buffer object
[14:12:55] ============ [PASSED] ttm_bo_validate_multihop =============
[14:12:55] ========== ttm_bo_validate_no_placement_signaled ==========
[14:12:55] [PASSED] Buffer object in system domain, no page vector
[14:12:55] [PASSED] Buffer object in system domain with an existing page vector
[14:12:55] ====== [PASSED] ttm_bo_validate_no_placement_signaled ======
[14:12:55] ======== ttm_bo_validate_no_placement_not_signaled ========
[14:12:55] [PASSED] Buffer object for userspace
[14:12:55] [PASSED] Kernel buffer object
[14:12:55] [PASSED] Shared buffer object
[14:12:55] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ====
[14:12:55] [PASSED] ttm_bo_validate_move_fence_signaled
[14:12:55] ========= ttm_bo_validate_move_fence_not_signaled =========
[14:12:55] [PASSED] Waits for GPU
[14:12:55] [PASSED] Tries to lock straight away
[14:12:55] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled =====
[14:12:55] [PASSED] ttm_bo_validate_happy_evict
[14:12:55] [PASSED] ttm_bo_validate_all_pinned_evict
[14:12:55] [PASSED] ttm_bo_validate_allowed_only_evict
[14:12:55] [PASSED] ttm_bo_validate_deleted_evict
[14:12:55] [PASSED] ttm_bo_validate_busy_domain_evict
[14:12:55] [PASSED] ttm_bo_validate_evict_gutting
[14:12:55] [PASSED] ttm_bo_validate_recrusive_evict
stty: 'standard input': Inappropriate ioctl for device
[14:12:55] ================= [PASSED] ttm_bo_validate =================
[14:12:55] ============================================================
[14:12:55] Testing complete. Ran 101 tests: passed: 101
[14:12:55] Elapsed time: 9.932s total, 1.702s configuring, 7.964s building, 0.230s running
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* ✓ Xe.CI.BAT: success for drm/xe/sysfs: Fix attributes registration on VFs
2025-09-15 14:06 [PATCH 0/2] drm/xe/sysfs: Fix attributes registration on VFs Michal Wajdeczko
` (2 preceding siblings ...)
2025-09-15 14:12 ` ✓ CI.KUnit: success for drm/xe/sysfs: Fix attributes registration on VFs Patchwork
@ 2025-09-15 14:51 ` Patchwork
2025-09-15 17:44 ` ✗ Xe.CI.Full: failure " Patchwork
4 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2025-09-15 14:51 UTC (permalink / raw)
To: Michal Wajdeczko; +Cc: intel-xe
[-- Attachment #1: Type: text/plain, Size: 871 bytes --]
== Series Details ==
Series: drm/xe/sysfs: Fix attributes registration on VFs
URL : https://patchwork.freedesktop.org/series/154534/
State : success
== Summary ==
CI Bug Log - changes from xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c_BAT -> xe-pw-154534v1_BAT
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Changes
-------
No changes found
Build changes
-------------
* Linux: xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c -> xe-pw-154534v1
IGT_8540: 8540
xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c: 6b4b640e8f446e569cdca0396efa12903de0896c
xe-pw-154534v1: 154534v1
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/index.html
[-- Attachment #2: Type: text/html, Size: 1419 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] drm/xe/sysfs: Simplify and fix sysfs registration
2025-09-15 14:06 ` [PATCH 1/2] drm/xe/sysfs: Simplify and fix sysfs registration Michal Wajdeczko
@ 2025-09-15 15:12 ` Lucas De Marchi
2025-09-15 15:33 ` Michal Wajdeczko
2025-09-15 15:17 ` Raag Jadav
1 sibling, 1 reply; 14+ messages in thread
From: Lucas De Marchi @ 2025-09-15 15:12 UTC (permalink / raw)
To: Michal Wajdeczko; +Cc: intel-xe, Rodrigo Vivi, Raag Jadav
On Mon, Sep 15, 2025 at 04:06:13PM +0200, Michal Wajdeczko wrote:
>Instead of manually maintaining each sysfs attribute define and use
>attribute groups and register them using device managed function.
>Then use is_visible() to filter-out unsupported attributes.
>
>This will result not only in less code and smaller footprint:
>
> Function old new delta
> late_bind_attr_is_visible - 183 +183
> ____versions 80832 80896 +64
> vram_attr_group - 48 +48
> late_bind_attr_group - 48 +48
> auto_link_downgrade_attr_group - 48 +48
> late_bind_attrs - 24 +24
> vram_attrs - 16 +16
> __pfx_late_bind_attr_is_visible - 16 +16
> xe_device_sysfs_init.cold 20 21 +1
> __pfx_xe_device_sysfs_fini 16 - -16
> xe_device_sysfs_fini.cold 21 - -21
> xe_device_sysfs_fini 271 - -271
> xe_device_sysfs_init 421 135 -286
> Total: Before=2848898, After=2848752, chg -0.01%
>
>but will also fix some bad error handling that we had here.
>
>Fixes: 0e414bf7ad01 ("drm/xe: Expose PCIe link downgrade attributes")
>Fixes: cdc36b66cd41 ("drm/xe: Expose fan control and voltage regulator version")
we should probably land the fix separately though:
https://lore.kernel.org/intel-xe/7p7wqbghc2ebupbzljjaegakun3azczuby2haiqmmneavnpl44@joqtzfismsgv/
and suggestion to rather use attribute group, similarly to what you're
doing here:
https://lore.kernel.org/intel-xe/3tkvzv7krbeuofuew44zm3ibenlntqkfclueq3soazkagwkezg@wtdhq4yvengu/
>Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>Cc: Raag Jadav <raag.jadav@intel.com>
>---
> drivers/gpu/drm/xe/xe_device_sysfs.c | 96 +++++++++++-----------------
> 1 file changed, 39 insertions(+), 57 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_device_sysfs.c b/drivers/gpu/drm/xe/xe_device_sysfs.c
>index 6ee422594b56..5b0b98ac9b17 100644
>--- a/drivers/gpu/drm/xe/xe_device_sysfs.c
>+++ b/drivers/gpu/drm/xe/xe_device_sysfs.c
>@@ -71,6 +71,15 @@ vram_d3cold_threshold_store(struct device *dev, struct device_attribute *attr,
>
> static DEVICE_ATTR_RW(vram_d3cold_threshold);
>
>+static struct attribute *vram_attrs[] = {
>+ &dev_attr_vram_d3cold_threshold.attr,
>+ NULL
>+};
>+
>+static const struct attribute_group vram_attr_group = {
>+ .attrs = vram_attrs,
since we are already checking by the attribute inside the is_visible
hook, couldn't we just add 1 group for "device attributes" and
share a single function?
>+};
>+
> static ssize_t
> lb_fan_control_version_show(struct device *dev, struct device_attribute *attr, char *buf)
> {
>@@ -149,8 +158,16 @@ lb_voltage_regulator_version_show(struct device *dev, struct device_attribute *a
> }
> static DEVICE_ATTR_ADMIN_RO(lb_voltage_regulator_version);
>
>-static int late_bind_create_files(struct device *dev)
>+static struct attribute *late_bind_attrs[] = {
>+ &dev_attr_lb_fan_control_version.attr,
>+ &dev_attr_lb_voltage_regulator_version.attr,
As above, I think we can just consider them "device attributes".
Lucas De Marchi
>+ NULL
>+};
>+
>+static umode_t late_bind_attr_is_visible(struct kobject *kobj,
>+ struct attribute *attr, int n)
> {
>+ struct device *dev = kobj_to_dev(kobj);
> struct xe_device *xe = pdev_to_xe_device(to_pci_dev(dev));
> struct xe_tile *root = xe_device_get_root_tile(xe);
> u32 cap = 0;
>@@ -160,51 +177,25 @@ static int late_bind_create_files(struct device *dev)
>
> ret = xe_pcode_read(root, PCODE_MBOX(PCODE_LATE_BINDING, GET_CAPABILITY_STATUS, 0),
> &cap, NULL);
>- if (ret) {
>- if (ret == -ENXIO) {
>- drm_dbg(&xe->drm, "Late binding not supported by firmware\n");
>- ret = 0;
>- }
>- goto out;
>- }
>-
>- if (REG_FIELD_GET(V1_FAN_SUPPORTED, cap)) {
>- ret = sysfs_create_file(&dev->kobj, &dev_attr_lb_fan_control_version.attr);
>- if (ret)
>- goto out;
>- }
>-
>- if (REG_FIELD_GET(VR_PARAMS_SUPPORTED, cap))
>- ret = sysfs_create_file(&dev->kobj, &dev_attr_lb_voltage_regulator_version.attr);
>-out:
> xe_pm_runtime_put(xe);
>-
>- return ret;
>-}
>-
>-static void late_bind_remove_files(struct device *dev)
>-{
>- struct xe_device *xe = pdev_to_xe_device(to_pci_dev(dev));
>- struct xe_tile *root = xe_device_get_root_tile(xe);
>- u32 cap = 0;
>- int ret;
>-
>- xe_pm_runtime_get(xe);
>-
>- ret = xe_pcode_read(root, PCODE_MBOX(PCODE_LATE_BINDING, GET_CAPABILITY_STATUS, 0),
>- &cap, NULL);
> if (ret)
>- goto out;
>+ return 0;
>
>- if (REG_FIELD_GET(V1_FAN_SUPPORTED, cap))
>- sysfs_remove_file(&dev->kobj, &dev_attr_lb_fan_control_version.attr);
>+ if (attr == &dev_attr_lb_fan_control_version.attr &&
>+ REG_FIELD_GET(V1_FAN_SUPPORTED, cap))
>+ return attr->mode;
>+ if (attr == &dev_attr_lb_voltage_regulator_version.attr &&
>+ REG_FIELD_GET(VR_PARAMS_SUPPORTED, cap))
>+ return attr->mode;
>
>- if (REG_FIELD_GET(VR_PARAMS_SUPPORTED, cap))
>- sysfs_remove_file(&dev->kobj, &dev_attr_lb_voltage_regulator_version.attr);
>-out:
>- xe_pm_runtime_put(xe);
>+ return 0;
> }
>
>+static const struct attribute_group late_bind_attr_group = {
>+ .attrs = late_bind_attrs,
>+ .is_visible = late_bind_attr_is_visible,
>+};
>+
> /**
> * DOC: PCIe Gen5 Limitations
> *
>@@ -278,24 +269,15 @@ auto_link_downgrade_status_show(struct device *dev, struct device_attribute *att
> }
> static DEVICE_ATTR_ADMIN_RO(auto_link_downgrade_status);
>
>-static const struct attribute *auto_link_downgrade_attrs[] = {
>+static struct attribute *auto_link_downgrade_attrs[] = {
> &dev_attr_auto_link_downgrade_capable.attr,
> &dev_attr_auto_link_downgrade_status.attr,
> NULL
> };
>
>-static void xe_device_sysfs_fini(void *arg)
>-{
>- struct xe_device *xe = arg;
>-
>- if (xe->d3cold.capable)
>- sysfs_remove_file(&xe->drm.dev->kobj, &dev_attr_vram_d3cold_threshold.attr);
>-
>- if (xe->info.platform == XE_BATTLEMAGE) {
>- sysfs_remove_files(&xe->drm.dev->kobj, auto_link_downgrade_attrs);
>- late_bind_remove_files(xe->drm.dev);
>- }
>-}
>+static const struct attribute_group auto_link_downgrade_attr_group = {
>+ .attrs = auto_link_downgrade_attrs,
>+};
>
> int xe_device_sysfs_init(struct xe_device *xe)
> {
>@@ -303,20 +285,20 @@ int xe_device_sysfs_init(struct xe_device *xe)
> int ret;
>
> if (xe->d3cold.capable) {
>- ret = sysfs_create_file(&dev->kobj, &dev_attr_vram_d3cold_threshold.attr);
>+ ret = devm_device_add_group(dev, &vram_attr_group);
> if (ret)
> return ret;
> }
>
> if (xe->info.platform == XE_BATTLEMAGE) {
>- ret = sysfs_create_files(&dev->kobj, auto_link_downgrade_attrs);
>+ ret = devm_device_add_group(dev, &auto_link_downgrade_attr_group);
> if (ret)
> return ret;
>
>- ret = late_bind_create_files(dev);
>+ ret = devm_device_add_group(dev, &late_bind_attr_group);
> if (ret)
> return ret;
> }
>
>- return devm_add_action_or_reset(dev, xe_device_sysfs_fini, xe);
>+ return 0;
> }
>--
>2.47.1
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] drm/xe/sysfs: Simplify and fix sysfs registration
2025-09-15 14:06 ` [PATCH 1/2] drm/xe/sysfs: Simplify and fix sysfs registration Michal Wajdeczko
2025-09-15 15:12 ` Lucas De Marchi
@ 2025-09-15 15:17 ` Raag Jadav
2025-09-15 15:51 ` Michal Wajdeczko
1 sibling, 1 reply; 14+ messages in thread
From: Raag Jadav @ 2025-09-15 15:17 UTC (permalink / raw)
To: Michal Wajdeczko; +Cc: intel-xe, Lucas De Marchi, Rodrigo Vivi
On Mon, Sep 15, 2025 at 04:06:13PM +0200, Michal Wajdeczko wrote:
> Instead of manually maintaining each sysfs attribute define and use
> attribute groups and register them using device managed function.
> Then use is_visible() to filter-out unsupported attributes.
>
> This will result not only in less code and smaller footprint:
>
> Function old new delta
> late_bind_attr_is_visible - 183 +183
> ____versions 80832 80896 +64
> vram_attr_group - 48 +48
> late_bind_attr_group - 48 +48
> auto_link_downgrade_attr_group - 48 +48
> late_bind_attrs - 24 +24
> vram_attrs - 16 +16
> __pfx_late_bind_attr_is_visible - 16 +16
> xe_device_sysfs_init.cold 20 21 +1
> __pfx_xe_device_sysfs_fini 16 - -16
> xe_device_sysfs_fini.cold 21 - -21
> xe_device_sysfs_fini 271 - -271
> xe_device_sysfs_init 421 135 -286
> Total: Before=2848898, After=2848752, chg -0.01%
I find the summary to be sufficient but upto you.
> but will also fix some bad error handling that we had here.
>
> Fixes: 0e414bf7ad01 ("drm/xe: Expose PCIe link downgrade attributes")
> Fixes: cdc36b66cd41 ("drm/xe: Expose fan control and voltage regulator version")
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Raag Jadav <raag.jadav@intel.com>
> ---
> drivers/gpu/drm/xe/xe_device_sysfs.c | 96 +++++++++++-----------------
> 1 file changed, 39 insertions(+), 57 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_device_sysfs.c b/drivers/gpu/drm/xe/xe_device_sysfs.c
> index 6ee422594b56..5b0b98ac9b17 100644
> --- a/drivers/gpu/drm/xe/xe_device_sysfs.c
> +++ b/drivers/gpu/drm/xe/xe_device_sysfs.c
> @@ -71,6 +71,15 @@ vram_d3cold_threshold_store(struct device *dev, struct device_attribute *attr,
>
> static DEVICE_ATTR_RW(vram_d3cold_threshold);
>
> +static struct attribute *vram_attrs[] = {
> + &dev_attr_vram_d3cold_threshold.attr,
> + NULL
> +};
> +
> +static const struct attribute_group vram_attr_group = {
> + .attrs = vram_attrs,
> +};
> +
> static ssize_t
> lb_fan_control_version_show(struct device *dev, struct device_attribute *attr, char *buf)
> {
> @@ -149,8 +158,16 @@ lb_voltage_regulator_version_show(struct device *dev, struct device_attribute *a
> }
> static DEVICE_ATTR_ADMIN_RO(lb_voltage_regulator_version);
>
> -static int late_bind_create_files(struct device *dev)
> +static struct attribute *late_bind_attrs[] = {
> + &dev_attr_lb_fan_control_version.attr,
> + &dev_attr_lb_voltage_regulator_version.attr,
> + NULL
> +};
> +
> +static umode_t late_bind_attr_is_visible(struct kobject *kobj,
> + struct attribute *attr, int n)
> {
> + struct device *dev = kobj_to_dev(kobj);
> struct xe_device *xe = pdev_to_xe_device(to_pci_dev(dev));
> struct xe_tile *root = xe_device_get_root_tile(xe);
> u32 cap = 0;
> @@ -160,51 +177,25 @@ static int late_bind_create_files(struct device *dev)
>
> ret = xe_pcode_read(root, PCODE_MBOX(PCODE_LATE_BINDING, GET_CAPABILITY_STATUS, 0),
> &cap, NULL);
> - if (ret) {
> - if (ret == -ENXIO) {
> - drm_dbg(&xe->drm, "Late binding not supported by firmware\n");
> - ret = 0;
> - }
> - goto out;
> - }
> -
> - if (REG_FIELD_GET(V1_FAN_SUPPORTED, cap)) {
> - ret = sysfs_create_file(&dev->kobj, &dev_attr_lb_fan_control_version.attr);
> - if (ret)
> - goto out;
> - }
> -
> - if (REG_FIELD_GET(VR_PARAMS_SUPPORTED, cap))
> - ret = sysfs_create_file(&dev->kobj, &dev_attr_lb_voltage_regulator_version.attr);
> -out:
> xe_pm_runtime_put(xe);
> -
> - return ret;
> -}
> -
> -static void late_bind_remove_files(struct device *dev)
> -{
> - struct xe_device *xe = pdev_to_xe_device(to_pci_dev(dev));
> - struct xe_tile *root = xe_device_get_root_tile(xe);
> - u32 cap = 0;
> - int ret;
> -
> - xe_pm_runtime_get(xe);
> -
> - ret = xe_pcode_read(root, PCODE_MBOX(PCODE_LATE_BINDING, GET_CAPABILITY_STATUS, 0),
> - &cap, NULL);
> if (ret)
> - goto out;
> + return 0;
Should we keep the original log so we don't have to guesswork our way around
random pcode errors?
PS: I've found patience algo to generate much readable diffs but ofcourse
it's a personal preference :)
Raag
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/2] drm/xe/vf: Don't expose sysfs attributes not applicable for VFs
2025-09-15 14:06 ` [PATCH 2/2] drm/xe/vf: Don't expose sysfs attributes not applicable for VFs Michal Wajdeczko
@ 2025-09-15 15:18 ` Raag Jadav
0 siblings, 0 replies; 14+ messages in thread
From: Raag Jadav @ 2025-09-15 15:18 UTC (permalink / raw)
To: Michal Wajdeczko; +Cc: intel-xe, Lucas De Marchi, Lukasz Laguna
On Mon, Sep 15, 2025 at 04:06:14PM +0200, Michal Wajdeczko wrote:
> VFs can't read BMG_PCIE_CAP(0x138340) register nor access PCODE
> (already guarded by the info.skip_pcode flag) so we shouldn't
> expose attributes that require any of them to avoid errors like:
>
> [] xe 0000:03:00.1: [drm] Tile0: GT0: VF is trying to read an \
> inaccessible register 0x138340+0x0
> [] RIP: 0010:xe_gt_sriov_vf_read32+0x6c2/0x9a0 [xe]
> [] Call Trace:
> [] xe_mmio_read32+0x110/0x280 [xe]
> [] auto_link_downgrade_capable_show+0x2e/0x70 [xe]
> [] dev_attr_show+0x1a/0x70
> [] sysfs_kf_seq_show+0xaa/0x120
> [] kernfs_seq_show+0x41/0x60
>
> Fixes: 0e414bf7ad01 ("drm/xe: Expose PCIe link downgrade attributes")
> Fixes: cdc36b66cd41 ("drm/xe: Expose fan control and voltage regulator version")
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Lukasz Laguna <lukasz.laguna@intel.com>
Finally.
Reviewed-by: Raag Jadav <raag.jadav@intel.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] drm/xe/sysfs: Simplify and fix sysfs registration
2025-09-15 15:12 ` Lucas De Marchi
@ 2025-09-15 15:33 ` Michal Wajdeczko
2025-09-16 13:52 ` Lucas De Marchi
0 siblings, 1 reply; 14+ messages in thread
From: Michal Wajdeczko @ 2025-09-15 15:33 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-xe, Rodrigo Vivi, Raag Jadav
On 9/15/2025 5:12 PM, Lucas De Marchi wrote:
> On Mon, Sep 15, 2025 at 04:06:13PM +0200, Michal Wajdeczko wrote:
>> Instead of manually maintaining each sysfs attribute define and use
>> attribute groups and register them using device managed function.
>> Then use is_visible() to filter-out unsupported attributes.
>>
>> This will result not only in less code and smaller footprint:
>>
>> Function old new delta
>> late_bind_attr_is_visible - 183 +183
>> ____versions 80832 80896 +64
>> vram_attr_group - 48 +48
>> late_bind_attr_group - 48 +48
>> auto_link_downgrade_attr_group - 48 +48
>> late_bind_attrs - 24 +24
>> vram_attrs - 16 +16
>> __pfx_late_bind_attr_is_visible - 16 +16
>> xe_device_sysfs_init.cold 20 21 +1
>> __pfx_xe_device_sysfs_fini 16 - -16
>> xe_device_sysfs_fini.cold 21 - -21
>> xe_device_sysfs_fini 271 - -271
>> xe_device_sysfs_init 421 135 -286
>> Total: Before=2848898, After=2848752, chg -0.01%
>>
>> but will also fix some bad error handling that we had here.
>>
>> Fixes: 0e414bf7ad01 ("drm/xe: Expose PCIe link downgrade attributes")
>> Fixes: cdc36b66cd41 ("drm/xe: Expose fan control and voltage regulator version")
>
> we should probably land the fix separately though:
> https://lore.kernel.org/intel-xe/7p7wqbghc2ebupbzljjaegakun3azczuby2haiqmmneavnpl44@joqtzfismsgv/
>
> and suggestion to rather use attribute group, similarly to what you're
> doing here:
> https://lore.kernel.org/intel-xe/3tkvzv7krbeuofuew44zm3ibenlntqkfclueq3soazkagwkezg@wtdhq4yvengu/
>
>
>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Raag Jadav <raag.jadav@intel.com>
>> ---
>> drivers/gpu/drm/xe/xe_device_sysfs.c | 96 +++++++++++-----------------
>> 1 file changed, 39 insertions(+), 57 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_device_sysfs.c b/drivers/gpu/drm/xe/xe_device_sysfs.c
>> index 6ee422594b56..5b0b98ac9b17 100644
>> --- a/drivers/gpu/drm/xe/xe_device_sysfs.c
>> +++ b/drivers/gpu/drm/xe/xe_device_sysfs.c
>> @@ -71,6 +71,15 @@ vram_d3cold_threshold_store(struct device *dev, struct device_attribute *attr,
>>
>> static DEVICE_ATTR_RW(vram_d3cold_threshold);
>>
>> +static struct attribute *vram_attrs[] = {
>> + &dev_attr_vram_d3cold_threshold.attr,
>> + NULL
>> +};
>> +
>> +static const struct attribute_group vram_attr_group = {
>> + .attrs = vram_attrs,
>
> since we are already checking by the attribute inside the is_visible
> hook, couldn't we just add 1 group for "device attributes" and
> share a single function?
I tried that approach first, but checking for late_bind_attrs was
so different that decided to keep it separated from other attrs
after all, this is what the purpose of having multiple groups is, no?
>
>> +};
>> +
>> static ssize_t
>> lb_fan_control_version_show(struct device *dev, struct device_attribute *attr, char *buf)
>> {
>> @@ -149,8 +158,16 @@ lb_voltage_regulator_version_show(struct device *dev, struct device_attribute *a
>> }
>> static DEVICE_ATTR_ADMIN_RO(lb_voltage_regulator_version);
>>
>> -static int late_bind_create_files(struct device *dev)
>> +static struct attribute *late_bind_attrs[] = {
>> + &dev_attr_lb_fan_control_version.attr,
>> + &dev_attr_lb_voltage_regulator_version.attr,
>
> As above, I think we can just consider them "device attributes".
IMO we should _group_ related attributes into "attribute_group" and
either add them based on single prerequisite condition and/or provide
is_visible filter to control each attribute separately
now as we only have five attribute, it's tempting to put all into
one group, but I assume we will soon have more attributes, and trying
to manage them as single group may not scale, so it's better to show
how to split related attrs now
>
> Lucas De Marchi
>
>> + NULL
>> +};
>> +
>> +static umode_t late_bind_attr_is_visible(struct kobject *kobj,
>> + struct attribute *attr, int n)
>> {
>> + struct device *dev = kobj_to_dev(kobj);
>> struct xe_device *xe = pdev_to_xe_device(to_pci_dev(dev));
>> struct xe_tile *root = xe_device_get_root_tile(xe);
>> u32 cap = 0;
>> @@ -160,51 +177,25 @@ static int late_bind_create_files(struct device *dev)
>>
>> ret = xe_pcode_read(root, PCODE_MBOX(PCODE_LATE_BINDING, GET_CAPABILITY_STATUS, 0),
>> &cap, NULL);
>> - if (ret) {
>> - if (ret == -ENXIO) {
>> - drm_dbg(&xe->drm, "Late binding not supported by firmware\n");
>> - ret = 0;
>> - }
>> - goto out;
>> - }
>> -
>> - if (REG_FIELD_GET(V1_FAN_SUPPORTED, cap)) {
>> - ret = sysfs_create_file(&dev->kobj, &dev_attr_lb_fan_control_version.attr);
>> - if (ret)
>> - goto out;
>> - }
>> -
>> - if (REG_FIELD_GET(VR_PARAMS_SUPPORTED, cap))
>> - ret = sysfs_create_file(&dev->kobj, &dev_attr_lb_voltage_regulator_version.attr);
>> -out:
>> xe_pm_runtime_put(xe);
>> -
>> - return ret;
>> -}
>> -
>> -static void late_bind_remove_files(struct device *dev)
>> -{
>> - struct xe_device *xe = pdev_to_xe_device(to_pci_dev(dev));
>> - struct xe_tile *root = xe_device_get_root_tile(xe);
>> - u32 cap = 0;
>> - int ret;
>> -
>> - xe_pm_runtime_get(xe);
>> -
>> - ret = xe_pcode_read(root, PCODE_MBOX(PCODE_LATE_BINDING, GET_CAPABILITY_STATUS, 0),
>> - &cap, NULL);
>> if (ret)
>> - goto out;
>> + return 0;
>>
>> - if (REG_FIELD_GET(V1_FAN_SUPPORTED, cap))
>> - sysfs_remove_file(&dev->kobj, &dev_attr_lb_fan_control_version.attr);
>> + if (attr == &dev_attr_lb_fan_control_version.attr &&
>> + REG_FIELD_GET(V1_FAN_SUPPORTED, cap))
>> + return attr->mode;
>> + if (attr == &dev_attr_lb_voltage_regulator_version.attr &&
>> + REG_FIELD_GET(VR_PARAMS_SUPPORTED, cap))
>> + return attr->mode;
>>
>> - if (REG_FIELD_GET(VR_PARAMS_SUPPORTED, cap))
>> - sysfs_remove_file(&dev->kobj, &dev_attr_lb_voltage_regulator_version.attr);
>> -out:
>> - xe_pm_runtime_put(xe);
>> + return 0;
>> }
>>
>> +static const struct attribute_group late_bind_attr_group = {
>> + .attrs = late_bind_attrs,
>> + .is_visible = late_bind_attr_is_visible,
>> +};
>> +
>> /**
>> * DOC: PCIe Gen5 Limitations
>> *
>> @@ -278,24 +269,15 @@ auto_link_downgrade_status_show(struct device *dev, struct device_attribute *att
>> }
>> static DEVICE_ATTR_ADMIN_RO(auto_link_downgrade_status);
>>
>> -static const struct attribute *auto_link_downgrade_attrs[] = {
>> +static struct attribute *auto_link_downgrade_attrs[] = {
>> &dev_attr_auto_link_downgrade_capable.attr,
>> &dev_attr_auto_link_downgrade_status.attr,
>> NULL
>> };
>>
>> -static void xe_device_sysfs_fini(void *arg)
>> -{
>> - struct xe_device *xe = arg;
>> -
>> - if (xe->d3cold.capable)
>> - sysfs_remove_file(&xe->drm.dev->kobj, &dev_attr_vram_d3cold_threshold.attr);
>> -
>> - if (xe->info.platform == XE_BATTLEMAGE) {
>> - sysfs_remove_files(&xe->drm.dev->kobj, auto_link_downgrade_attrs);
>> - late_bind_remove_files(xe->drm.dev);
>> - }
>> -}
>> +static const struct attribute_group auto_link_downgrade_attr_group = {
>> + .attrs = auto_link_downgrade_attrs,
>> +};
>>
>> int xe_device_sysfs_init(struct xe_device *xe)
>> {
>> @@ -303,20 +285,20 @@ int xe_device_sysfs_init(struct xe_device *xe)
>> int ret;
>>
>> if (xe->d3cold.capable) {
>> - ret = sysfs_create_file(&dev->kobj, &dev_attr_vram_d3cold_threshold.attr);
>> + ret = devm_device_add_group(dev, &vram_attr_group);
>> if (ret)
>> return ret;
>> }
>>
>> if (xe->info.platform == XE_BATTLEMAGE) {
>> - ret = sysfs_create_files(&dev->kobj, auto_link_downgrade_attrs);
>> + ret = devm_device_add_group(dev, &auto_link_downgrade_attr_group);
>> if (ret)
>> return ret;
>>
>> - ret = late_bind_create_files(dev);
>> + ret = devm_device_add_group(dev, &late_bind_attr_group);
>> if (ret)
>> return ret;
>> }
>>
>> - return devm_add_action_or_reset(dev, xe_device_sysfs_fini, xe);
>> + return 0;
>> }
>> --
>> 2.47.1
>>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] drm/xe/sysfs: Simplify and fix sysfs registration
2025-09-15 15:17 ` Raag Jadav
@ 2025-09-15 15:51 ` Michal Wajdeczko
2025-09-15 16:03 ` Raag Jadav
0 siblings, 1 reply; 14+ messages in thread
From: Michal Wajdeczko @ 2025-09-15 15:51 UTC (permalink / raw)
To: Raag Jadav; +Cc: intel-xe, Lucas De Marchi, Rodrigo Vivi
On 9/15/2025 5:17 PM, Raag Jadav wrote:
> On Mon, Sep 15, 2025 at 04:06:13PM +0200, Michal Wajdeczko wrote:
>> Instead of manually maintaining each sysfs attribute define and use
>> attribute groups and register them using device managed function.
>> Then use is_visible() to filter-out unsupported attributes.
>>
>> This will result not only in less code and smaller footprint:
>>
>> Function old new delta
>> late_bind_attr_is_visible - 183 +183
>> ____versions 80832 80896 +64
>> vram_attr_group - 48 +48
>> late_bind_attr_group - 48 +48
>> auto_link_downgrade_attr_group - 48 +48
>> late_bind_attrs - 24 +24
>> vram_attrs - 16 +16
>> __pfx_late_bind_attr_is_visible - 16 +16
>> xe_device_sysfs_init.cold 20 21 +1
>> __pfx_xe_device_sysfs_fini 16 - -16
>> xe_device_sysfs_fini.cold 21 - -21
>> xe_device_sysfs_fini 271 - -271
>> xe_device_sysfs_init 421 135 -286
>> Total: Before=2848898, After=2848752, chg -0.01%
>
> I find the summary to be sufficient but upto you.
sure, can strip this (if there will be v2)
>
>> but will also fix some bad error handling that we had here.
>>
>> Fixes: 0e414bf7ad01 ("drm/xe: Expose PCIe link downgrade attributes")
>> Fixes: cdc36b66cd41 ("drm/xe: Expose fan control and voltage regulator version")
>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Raag Jadav <raag.jadav@intel.com>
>> ---
>> drivers/gpu/drm/xe/xe_device_sysfs.c | 96 +++++++++++-----------------
>> 1 file changed, 39 insertions(+), 57 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_device_sysfs.c b/drivers/gpu/drm/xe/xe_device_sysfs.c
>> index 6ee422594b56..5b0b98ac9b17 100644
>> --- a/drivers/gpu/drm/xe/xe_device_sysfs.c
>> +++ b/drivers/gpu/drm/xe/xe_device_sysfs.c
>> @@ -71,6 +71,15 @@ vram_d3cold_threshold_store(struct device *dev, struct device_attribute *attr,
>>
>> static DEVICE_ATTR_RW(vram_d3cold_threshold);
>>
>> +static struct attribute *vram_attrs[] = {
>> + &dev_attr_vram_d3cold_threshold.attr,
>> + NULL
>> +};
>> +
>> +static const struct attribute_group vram_attr_group = {
>> + .attrs = vram_attrs,
>> +};
>> +
>> static ssize_t
>> lb_fan_control_version_show(struct device *dev, struct device_attribute *attr, char *buf)
>> {
>> @@ -149,8 +158,16 @@ lb_voltage_regulator_version_show(struct device *dev, struct device_attribute *a
>> }
>> static DEVICE_ATTR_ADMIN_RO(lb_voltage_regulator_version);
>>
>> -static int late_bind_create_files(struct device *dev)
>> +static struct attribute *late_bind_attrs[] = {
>> + &dev_attr_lb_fan_control_version.attr,
>> + &dev_attr_lb_voltage_regulator_version.attr,
>> + NULL
>> +};
>> +
>> +static umode_t late_bind_attr_is_visible(struct kobject *kobj,
>> + struct attribute *attr, int n)
>> {
>> + struct device *dev = kobj_to_dev(kobj);
>> struct xe_device *xe = pdev_to_xe_device(to_pci_dev(dev));
>> struct xe_tile *root = xe_device_get_root_tile(xe);
>> u32 cap = 0;
>> @@ -160,51 +177,25 @@ static int late_bind_create_files(struct device *dev)
>>
>> ret = xe_pcode_read(root, PCODE_MBOX(PCODE_LATE_BINDING, GET_CAPABILITY_STATUS, 0),
>> &cap, NULL);
>> - if (ret) {
>> - if (ret == -ENXIO) {
>> - drm_dbg(&xe->drm, "Late binding not supported by firmware\n");
>> - ret = 0;
>> - }
>> - goto out;
>> - }
>> -
>> - if (REG_FIELD_GET(V1_FAN_SUPPORTED, cap)) {
>> - ret = sysfs_create_file(&dev->kobj, &dev_attr_lb_fan_control_version.attr);
>> - if (ret)
>> - goto out;
>> - }
>> -
>> - if (REG_FIELD_GET(VR_PARAMS_SUPPORTED, cap))
>> - ret = sysfs_create_file(&dev->kobj, &dev_attr_lb_voltage_regulator_version.attr);
>> -out:
>> xe_pm_runtime_put(xe);
>> -
>> - return ret;
>> -}
>> -
>> -static void late_bind_remove_files(struct device *dev)
>> -{
>> - struct xe_device *xe = pdev_to_xe_device(to_pci_dev(dev));
>> - struct xe_tile *root = xe_device_get_root_tile(xe);
>> - u32 cap = 0;
>> - int ret;
>> -
>> - xe_pm_runtime_get(xe);
>> -
>> - ret = xe_pcode_read(root, PCODE_MBOX(PCODE_LATE_BINDING, GET_CAPABILITY_STATUS, 0),
>> - &cap, NULL);
>> if (ret)
>> - goto out;
>> + return 0;
>
> Should we keep the original log so we don't have to guesswork our way around
> random pcode errors?
hmm, I was assuming that PCODE_LATE_BINDING is also used elsewhere
so it will be reported, but it looks that it's not
but OTOH, is it a right place (sysfs init, or now is_visible)
to report any missing firmware cap?
maybe there should be xe_lb_init() somewhere, where we can report any
unexpected problems, and then in xe_sysfs_init() we will just use
already retrieved and confirmed cap?
but, still the aim of this series was different
>
> PS: I've found patience algo to generate much readable diffs but ofcourse
> it's a personal preference :)
it was patience algorithm already ;)
>
> Raag
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] drm/xe/sysfs: Simplify and fix sysfs registration
2025-09-15 15:51 ` Michal Wajdeczko
@ 2025-09-15 16:03 ` Raag Jadav
0 siblings, 0 replies; 14+ messages in thread
From: Raag Jadav @ 2025-09-15 16:03 UTC (permalink / raw)
To: Michal Wajdeczko; +Cc: intel-xe, Lucas De Marchi, Rodrigo Vivi
On Mon, Sep 15, 2025 at 05:51:33PM +0200, Michal Wajdeczko wrote:
> On 9/15/2025 5:17 PM, Raag Jadav wrote:
> > On Mon, Sep 15, 2025 at 04:06:13PM +0200, Michal Wajdeczko wrote:
> > > Instead of manually maintaining each sysfs attribute define and use
> > > attribute groups and register them using device managed function.
> > > Then use is_visible() to filter-out unsupported attributes.
> > >
> > > This will result not only in less code and smaller footprint:
> > >
> > > Function old new delta
> > > late_bind_attr_is_visible - 183 +183
> > > ____versions 80832 80896 +64
> > > vram_attr_group - 48 +48
> > > late_bind_attr_group - 48 +48
> > > auto_link_downgrade_attr_group - 48 +48
> > > late_bind_attrs - 24 +24
> > > vram_attrs - 16 +16
> > > __pfx_late_bind_attr_is_visible - 16 +16
> > > xe_device_sysfs_init.cold 20 21 +1
> > > __pfx_xe_device_sysfs_fini 16 - -16
> > > xe_device_sysfs_fini.cold 21 - -21
> > > xe_device_sysfs_fini 271 - -271
> > > xe_device_sysfs_init 421 135 -286
> > > Total: Before=2848898, After=2848752, chg -0.01%
> >
> > I find the summary to be sufficient but upto you.
>
> sure, can strip this (if there will be v2)
Thanks.
> > > but will also fix some bad error handling that we had here.
> > >
> > > Fixes: 0e414bf7ad01 ("drm/xe: Expose PCIe link downgrade attributes")
> > > Fixes: cdc36b66cd41 ("drm/xe: Expose fan control and voltage regulator version")
> > > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> > > Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > Cc: Raag Jadav <raag.jadav@intel.com>
> > > ---
> > > drivers/gpu/drm/xe/xe_device_sysfs.c | 96 +++++++++++-----------------
> > > 1 file changed, 39 insertions(+), 57 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/xe/xe_device_sysfs.c b/drivers/gpu/drm/xe/xe_device_sysfs.c
> > > index 6ee422594b56..5b0b98ac9b17 100644
> > > --- a/drivers/gpu/drm/xe/xe_device_sysfs.c
> > > +++ b/drivers/gpu/drm/xe/xe_device_sysfs.c
> > > @@ -71,6 +71,15 @@ vram_d3cold_threshold_store(struct device *dev, struct device_attribute *attr,
> > >
> > > static DEVICE_ATTR_RW(vram_d3cold_threshold);
> > >
> > > +static struct attribute *vram_attrs[] = {
> > > + &dev_attr_vram_d3cold_threshold.attr,
> > > + NULL
> > > +};
> > > +
> > > +static const struct attribute_group vram_attr_group = {
> > > + .attrs = vram_attrs,
> > > +};
> > > +
> > > static ssize_t
> > > lb_fan_control_version_show(struct device *dev, struct device_attribute *attr, char *buf)
> > > {
> > > @@ -149,8 +158,16 @@ lb_voltage_regulator_version_show(struct device *dev, struct device_attribute *a
> > > }
> > > static DEVICE_ATTR_ADMIN_RO(lb_voltage_regulator_version);
> > >
> > > -static int late_bind_create_files(struct device *dev)
> > > +static struct attribute *late_bind_attrs[] = {
> > > + &dev_attr_lb_fan_control_version.attr,
> > > + &dev_attr_lb_voltage_regulator_version.attr,
> > > + NULL
> > > +};
> > > +
> > > +static umode_t late_bind_attr_is_visible(struct kobject *kobj,
> > > + struct attribute *attr, int n)
> > > {
> > > + struct device *dev = kobj_to_dev(kobj);
> > > struct xe_device *xe = pdev_to_xe_device(to_pci_dev(dev));
> > > struct xe_tile *root = xe_device_get_root_tile(xe);
> > > u32 cap = 0;
> > > @@ -160,51 +177,25 @@ static int late_bind_create_files(struct device *dev)
> > >
> > > ret = xe_pcode_read(root, PCODE_MBOX(PCODE_LATE_BINDING, GET_CAPABILITY_STATUS, 0),
> > > &cap, NULL);
> > > - if (ret) {
> > > - if (ret == -ENXIO) {
> > > - drm_dbg(&xe->drm, "Late binding not supported by firmware\n");
> > > - ret = 0;
> > > - }
> > > - goto out;
> > > - }
> > > -
> > > - if (REG_FIELD_GET(V1_FAN_SUPPORTED, cap)) {
> > > - ret = sysfs_create_file(&dev->kobj, &dev_attr_lb_fan_control_version.attr);
> > > - if (ret)
> > > - goto out;
> > > - }
> > > -
> > > - if (REG_FIELD_GET(VR_PARAMS_SUPPORTED, cap))
> > > - ret = sysfs_create_file(&dev->kobj, &dev_attr_lb_voltage_regulator_version.attr);
> > > -out:
> > > xe_pm_runtime_put(xe);
> > > -
> > > - return ret;
> > > -}
> > > -
> > > -static void late_bind_remove_files(struct device *dev)
> > > -{
> > > - struct xe_device *xe = pdev_to_xe_device(to_pci_dev(dev));
> > > - struct xe_tile *root = xe_device_get_root_tile(xe);
> > > - u32 cap = 0;
> > > - int ret;
> > > -
> > > - xe_pm_runtime_get(xe);
> > > -
> > > - ret = xe_pcode_read(root, PCODE_MBOX(PCODE_LATE_BINDING, GET_CAPABILITY_STATUS, 0),
> > > - &cap, NULL);
> > > if (ret)
> > > - goto out;
> > > + return 0;
> >
> > Should we keep the original log so we don't have to guesswork our way around
> > random pcode errors?
>
> hmm, I was assuming that PCODE_LATE_BINDING is also used elsewhere
> so it will be reported, but it looks that it's not
>
> but OTOH, is it a right place (sysfs init, or now is_visible)
> to report any missing firmware cap?
>
> maybe there should be xe_lb_init() somewhere, where we can report any
> unexpected problems, and then in xe_sysfs_init() we will just use
> already retrieved and confirmed cap?
The idea was to land the sysfs along with [1] but it still seems going
through its own hoops due to cross subsys dependency.
[1] https://lore.kernel.org/intel-xe/20250905154953.3974335-1-badal.nilawar@intel.com/
Raag
^ permalink raw reply [flat|nested] 14+ messages in thread
* ✗ Xe.CI.Full: failure for drm/xe/sysfs: Fix attributes registration on VFs
2025-09-15 14:06 [PATCH 0/2] drm/xe/sysfs: Fix attributes registration on VFs Michal Wajdeczko
` (3 preceding siblings ...)
2025-09-15 14:51 ` ✓ Xe.CI.BAT: " Patchwork
@ 2025-09-15 17:44 ` Patchwork
4 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2025-09-15 17:44 UTC (permalink / raw)
To: Michal Wajdeczko; +Cc: intel-xe
[-- Attachment #1: Type: text/plain, Size: 49027 bytes --]
== Series Details ==
Series: drm/xe/sysfs: Fix attributes registration on VFs
URL : https://patchwork.freedesktop.org/series/154534/
State : failure
== Summary ==
CI Bug Log - changes from xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c_FULL -> xe-pw-154534v1_FULL
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with xe-pw-154534v1_FULL absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in xe-pw-154534v1_FULL, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (4 -> 4)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in xe-pw-154534v1_FULL:
### IGT changes ###
#### Possible regressions ####
* igt@kms_atomic_interruptible@atomic-setmode@pipe-a-hdmi-a-6:
- shard-dg2-set2: [PASS][1] -> [INCOMPLETE][2] +1 other test incomplete
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-dg2-463/igt@kms_atomic_interruptible@atomic-setmode@pipe-a-hdmi-a-6.html
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-433/igt@kms_atomic_interruptible@atomic-setmode@pipe-a-hdmi-a-6.html
Known issues
------------
Here are the changes found in xe-pw-154534v1_FULL that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@intel_hwmon@hwmon-write:
- shard-bmg: NOTRUN -> [FAIL][3] ([Intel XE#4665])
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-4/igt@intel_hwmon@hwmon-write.html
* igt@kms_atomic_transition@plane-toggle-modeset-transition:
- shard-adlp: [PASS][4] -> [FAIL][5] ([Intel XE#3908]) +3 other tests fail
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-adlp-1/igt@kms_atomic_transition@plane-toggle-modeset-transition.html
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-2/igt@kms_atomic_transition@plane-toggle-modeset-transition.html
* igt@kms_big_fb@4-tiled-64bpp-rotate-0:
- shard-adlp: NOTRUN -> [SKIP][6] ([Intel XE#1124])
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-8/igt@kms_big_fb@4-tiled-64bpp-rotate-0.html
* igt@kms_big_fb@4-tiled-64bpp-rotate-90:
- shard-bmg: NOTRUN -> [SKIP][7] ([Intel XE#2327])
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-8/igt@kms_big_fb@4-tiled-64bpp-rotate-90.html
* igt@kms_big_fb@y-tiled-16bpp-rotate-180:
- shard-bmg: NOTRUN -> [SKIP][8] ([Intel XE#1124]) +2 other tests skip
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-4/igt@kms_big_fb@y-tiled-16bpp-rotate-180.html
* igt@kms_bw@connected-linear-tiling-2-displays-2560x1440p:
- shard-bmg: [PASS][9] -> [SKIP][10] ([Intel XE#2314] / [Intel XE#2894])
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-bmg-2/igt@kms_bw@connected-linear-tiling-2-displays-2560x1440p.html
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-6/igt@kms_bw@connected-linear-tiling-2-displays-2560x1440p.html
* igt@kms_ccs@ccs-on-another-bo-y-tiled-gen12-rc-ccs:
- shard-adlp: NOTRUN -> [SKIP][11] ([Intel XE#455] / [Intel XE#787]) +1 other test skip
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-8/igt@kms_ccs@ccs-on-another-bo-y-tiled-gen12-rc-ccs.html
* igt@kms_ccs@ccs-on-another-bo-y-tiled-gen12-rc-ccs@pipe-b-hdmi-a-1:
- shard-adlp: NOTRUN -> [SKIP][12] ([Intel XE#787]) +2 other tests skip
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-8/igt@kms_ccs@ccs-on-another-bo-y-tiled-gen12-rc-ccs@pipe-b-hdmi-a-1.html
* igt@kms_ccs@crc-primary-basic-y-tiled-ccs:
- shard-bmg: NOTRUN -> [SKIP][13] ([Intel XE#2887]) +3 other tests skip
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-8/igt@kms_ccs@crc-primary-basic-y-tiled-ccs.html
* igt@kms_ccs@crc-primary-basic-y-tiled-ccs@pipe-d-hdmi-a-2:
- shard-dg2-set2: NOTRUN -> [SKIP][14] ([Intel XE#787]) +160 other tests skip
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-432/igt@kms_ccs@crc-primary-basic-y-tiled-ccs@pipe-d-hdmi-a-2.html
* igt@kms_ccs@crc-primary-suspend-4-tiled-dg2-rc-ccs-cc:
- shard-bmg: NOTRUN -> [SKIP][15] ([Intel XE#3432])
[15]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-8/igt@kms_ccs@crc-primary-suspend-4-tiled-dg2-rc-ccs-cc.html
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-mc-ccs:
- shard-dg2-set2: [PASS][16] -> [INCOMPLETE][17] ([Intel XE#1727] / [Intel XE#3113] / [Intel XE#4345])
[16]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-dg2-432/igt@kms_ccs@random-ccs-data-4-tiled-dg2-mc-ccs.html
[17]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-464/igt@kms_ccs@random-ccs-data-4-tiled-dg2-mc-ccs.html
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-mc-ccs@pipe-b-dp-4:
- shard-dg2-set2: NOTRUN -> [INCOMPLETE][18] ([Intel XE#1727] / [Intel XE#3113] / [Intel XE#4345])
[18]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-464/igt@kms_ccs@random-ccs-data-4-tiled-dg2-mc-ccs@pipe-b-dp-4.html
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs-cc:
- shard-dg2-set2: [PASS][19] -> [INCOMPLETE][20] ([Intel XE#1727] / [Intel XE#3113] / [Intel XE#4212] / [Intel XE#4345] / [Intel XE#4522])
[19]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-dg2-463/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs-cc.html
[20]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-433/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs-cc.html
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs-cc@pipe-b-dp-4:
- shard-dg2-set2: [PASS][21] -> [INCOMPLETE][22] ([Intel XE#1727] / [Intel XE#3113] / [Intel XE#4212] / [Intel XE#4522])
[21]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-dg2-463/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs-cc@pipe-b-dp-4.html
[22]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-433/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs-cc@pipe-b-dp-4.html
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs@pipe-d-hdmi-a-6:
- shard-dg2-set2: NOTRUN -> [INCOMPLETE][23] ([Intel XE#1727] / [Intel XE#3113])
[23]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-466/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs@pipe-d-hdmi-a-6.html
* igt@kms_ccs@random-ccs-data-4-tiled-mtl-mc-ccs@pipe-d-dp-2:
- shard-dg2-set2: NOTRUN -> [SKIP][24] ([Intel XE#455] / [Intel XE#787]) +27 other tests skip
[24]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-432/igt@kms_ccs@random-ccs-data-4-tiled-mtl-mc-ccs@pipe-d-dp-2.html
* igt@kms_cdclk@mode-transition-all-outputs:
- shard-adlp: NOTRUN -> [SKIP][25] ([Intel XE#4418])
[25]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-8/igt@kms_cdclk@mode-transition-all-outputs.html
- shard-dg2-set2: NOTRUN -> [SKIP][26] ([Intel XE#4418])
[26]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-436/igt@kms_cdclk@mode-transition-all-outputs.html
* igt@kms_cdclk@plane-scaling@pipe-b-dp-4:
- shard-dg2-set2: NOTRUN -> [SKIP][27] ([Intel XE#4416]) +3 other tests skip
[27]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-463/igt@kms_cdclk@plane-scaling@pipe-b-dp-4.html
* igt@kms_chamelium_color@ctm-negative:
- shard-bmg: NOTRUN -> [SKIP][28] ([Intel XE#2325])
[28]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-8/igt@kms_chamelium_color@ctm-negative.html
* igt@kms_chamelium_edid@hdmi-edid-change-during-suspend:
- shard-adlp: NOTRUN -> [SKIP][29] ([Intel XE#373])
[29]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-8/igt@kms_chamelium_edid@hdmi-edid-change-during-suspend.html
* igt@kms_chamelium_hpd@dp-hpd-storm-disable:
- shard-bmg: NOTRUN -> [SKIP][30] ([Intel XE#2252]) +2 other tests skip
[30]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-4/igt@kms_chamelium_hpd@dp-hpd-storm-disable.html
* igt@kms_content_protection@lic-type-0@pipe-a-dp-2:
- shard-dg2-set2: NOTRUN -> [FAIL][31] ([Intel XE#1178])
[31]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-432/igt@kms_content_protection@lic-type-0@pipe-a-dp-2.html
* igt@kms_cursor_crc@cursor-offscreen-512x512:
- shard-dg2-set2: NOTRUN -> [SKIP][32] ([Intel XE#308])
[32]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-464/igt@kms_cursor_crc@cursor-offscreen-512x512.html
* igt@kms_cursor_crc@cursor-onscreen-32x32:
- shard-bmg: NOTRUN -> [SKIP][33] ([Intel XE#2320]) +1 other test skip
[33]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-8/igt@kms_cursor_crc@cursor-onscreen-32x32.html
* igt@kms_cursor_legacy@cursora-vs-flipb-legacy:
- shard-bmg: [PASS][34] -> [SKIP][35] ([Intel XE#2291])
[34]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-bmg-3/igt@kms_cursor_legacy@cursora-vs-flipb-legacy.html
[35]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-6/igt@kms_cursor_legacy@cursora-vs-flipb-legacy.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-bmg: [PASS][36] -> [FAIL][37] ([Intel XE#1475])
[36]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-bmg-1/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
[37]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-8/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-2:
- shard-dg2-set2: NOTRUN -> [SKIP][38] ([Intel XE#4494])
[38]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-432/igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-2.html
* igt@kms_fbc_dirty_rect@fbc-dirty-rectangle-dirtyfb-tests:
- shard-bmg: NOTRUN -> [SKIP][39] ([Intel XE#4422])
[39]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-4/igt@kms_fbc_dirty_rect@fbc-dirty-rectangle-dirtyfb-tests.html
* igt@kms_feature_discovery@display-2x:
- shard-bmg: [PASS][40] -> [SKIP][41] ([Intel XE#2373])
[40]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-bmg-2/igt@kms_feature_discovery@display-2x.html
[41]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-6/igt@kms_feature_discovery@display-2x.html
* igt@kms_flip@2x-plain-flip:
- shard-bmg: [PASS][42] -> [SKIP][43] ([Intel XE#2316]) +3 other tests skip
[42]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-bmg-3/igt@kms_flip@2x-plain-flip.html
[43]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-6/igt@kms_flip@2x-plain-flip.html
* igt@kms_flip@dpms-off-confusion-interruptible@c-hdmi-a1:
- shard-adlp: [PASS][44] -> [DMESG-WARN][45] ([Intel XE#4543]) +2 other tests dmesg-warn
[44]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-adlp-8/igt@kms_flip@dpms-off-confusion-interruptible@c-hdmi-a1.html
[45]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-9/igt@kms_flip@dpms-off-confusion-interruptible@c-hdmi-a1.html
* igt@kms_flip@flip-vs-expired-vblank@b-edp1:
- shard-lnl: [PASS][46] -> [FAIL][47] ([Intel XE#301])
[46]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-lnl-1/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html
[47]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-lnl-8/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-lnl: [PASS][48] -> [FAIL][49] ([Intel XE#301] / [Intel XE#3149]) +1 other test fail
[48]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-lnl-1/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
[49]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-lnl-8/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-bmg: [PASS][50] -> [INCOMPLETE][51] ([Intel XE#2049] / [Intel XE#2597]) +1 other test incomplete
[50]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-bmg-8/igt@kms_flip@flip-vs-suspend-interruptible.html
[51]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-4/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling:
- shard-bmg: NOTRUN -> [SKIP][52] ([Intel XE#2293] / [Intel XE#2380])
[52]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-8/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling@pipe-a-valid-mode:
- shard-bmg: NOTRUN -> [SKIP][53] ([Intel XE#2293])
[53]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-8/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@drrs-2p-primscrn-indfb-pgflip-blt:
- shard-adlp: NOTRUN -> [SKIP][54] ([Intel XE#656]) +2 other tests skip
[54]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-8/igt@kms_frontbuffer_tracking@drrs-2p-primscrn-indfb-pgflip-blt.html
* igt@kms_frontbuffer_tracking@drrs-2p-scndscrn-cur-indfb-move:
- shard-bmg: NOTRUN -> [SKIP][55] ([Intel XE#2312])
[55]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-6/igt@kms_frontbuffer_tracking@drrs-2p-scndscrn-cur-indfb-move.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-wc:
- shard-bmg: NOTRUN -> [SKIP][56] ([Intel XE#5390]) +1 other test skip
[56]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-8/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcdrrs-2p-primscrn-indfb-pgflip-blt:
- shard-dg2-set2: NOTRUN -> [SKIP][57] ([Intel XE#651]) +5 other tests skip
[57]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-464/igt@kms_frontbuffer_tracking@fbcdrrs-2p-primscrn-indfb-pgflip-blt.html
* igt@kms_frontbuffer_tracking@fbcdrrs-2p-scndscrn-indfb-msflip-blt:
- shard-bmg: NOTRUN -> [SKIP][58] ([Intel XE#2311]) +2 other tests skip
[58]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-8/igt@kms_frontbuffer_tracking@fbcdrrs-2p-scndscrn-indfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render:
- shard-adlp: NOTRUN -> [SKIP][59] ([Intel XE#653])
[59]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-blt:
- shard-dg2-set2: NOTRUN -> [SKIP][60] ([Intel XE#653]) +7 other tests skip
[60]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-464/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-onoff:
- shard-bmg: NOTRUN -> [SKIP][61] ([Intel XE#2313]) +8 other tests skip
[61]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-4/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-onoff.html
* igt@kms_pipe_stress@stress-xrgb8888-ytiled:
- shard-dg2-set2: NOTRUN -> [SKIP][62] ([Intel XE#4359])
[62]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-464/igt@kms_pipe_stress@stress-xrgb8888-ytiled.html
* igt@kms_plane@pixel-format-source-clamping@pipe-b-plane-0:
- shard-adlp: NOTRUN -> [FAIL][63] ([Intel XE#5195]) +4 other tests fail
[63]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-8/igt@kms_plane@pixel-format-source-clamping@pipe-b-plane-0.html
* igt@kms_plane_cursor@primary@pipe-a-hdmi-a-2-size-256:
- shard-dg2-set2: NOTRUN -> [FAIL][64] ([Intel XE#616]) +3 other tests fail
[64]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-432/igt@kms_plane_cursor@primary@pipe-a-hdmi-a-2-size-256.html
* igt@kms_plane_lowres@tiling-yf:
- shard-bmg: NOTRUN -> [SKIP][65] ([Intel XE#2393])
[65]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-4/igt@kms_plane_lowres@tiling-yf.html
* igt@kms_plane_multiple@2x-tiling-yf:
- shard-bmg: NOTRUN -> [SKIP][66] ([Intel XE#5021])
[66]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-8/igt@kms_plane_multiple@2x-tiling-yf.html
* igt@kms_plane_scaling@2x-scaler-multi-pipe:
- shard-bmg: [PASS][67] -> [SKIP][68] ([Intel XE#2571])
[67]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-bmg-3/igt@kms_plane_scaling@2x-scaler-multi-pipe.html
[68]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-6/igt@kms_plane_scaling@2x-scaler-multi-pipe.html
* igt@kms_pm_dc@dc5-retention-flops:
- shard-dg2-set2: NOTRUN -> [SKIP][69] ([Intel XE#3309])
[69]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-464/igt@kms_pm_dc@dc5-retention-flops.html
* igt@kms_psr2_sf@fbc-psr2-overlay-plane-update-sf-dmg-area:
- shard-bmg: NOTRUN -> [SKIP][70] ([Intel XE#1406] / [Intel XE#1489]) +3 other tests skip
[70]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-4/igt@kms_psr2_sf@fbc-psr2-overlay-plane-update-sf-dmg-area.html
* igt@kms_psr2_sf@pr-plane-move-sf-dmg-area:
- shard-adlp: NOTRUN -> [SKIP][71] ([Intel XE#1406] / [Intel XE#1489])
[71]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-8/igt@kms_psr2_sf@pr-plane-move-sf-dmg-area.html
* igt@kms_psr2_sf@pr-primary-plane-update-sf-dmg-area:
- shard-dg2-set2: NOTRUN -> [SKIP][72] ([Intel XE#1406] / [Intel XE#1489])
[72]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-464/igt@kms_psr2_sf@pr-primary-plane-update-sf-dmg-area.html
* igt@kms_psr@fbc-psr2-primary-blt:
- shard-bmg: NOTRUN -> [SKIP][73] ([Intel XE#1406] / [Intel XE#2234] / [Intel XE#2850]) +4 other tests skip
[73]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-8/igt@kms_psr@fbc-psr2-primary-blt.html
* igt@kms_psr@psr-sprite-render:
- shard-adlp: NOTRUN -> [SKIP][74] ([Intel XE#1406] / [Intel XE#2850] / [Intel XE#929])
[74]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-8/igt@kms_psr@psr-sprite-render.html
- shard-dg2-set2: NOTRUN -> [SKIP][75] ([Intel XE#1406] / [Intel XE#2850] / [Intel XE#929])
[75]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-436/igt@kms_psr@psr-sprite-render.html
* igt@kms_rotation_crc@primary-y-tiled-reflect-x-0:
- shard-bmg: NOTRUN -> [SKIP][76] ([Intel XE#2330])
[76]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-8/igt@kms_rotation_crc@primary-y-tiled-reflect-x-0.html
- shard-dg2-set2: NOTRUN -> [SKIP][77] ([Intel XE#1127])
[77]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-432/igt@kms_rotation_crc@primary-y-tiled-reflect-x-0.html
* igt@kms_sequence@queue-busy@pipe-a-hdmi-a-1:
- shard-adlp: [PASS][78] -> [DMESG-WARN][79] ([Intel XE#2953] / [Intel XE#4173]) +2 other tests dmesg-warn
[78]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-adlp-6/igt@kms_sequence@queue-busy@pipe-a-hdmi-a-1.html
[79]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-6/igt@kms_sequence@queue-busy@pipe-a-hdmi-a-1.html
* igt@kms_tiled_display@basic-test-pattern-with-chamelium:
- shard-bmg: NOTRUN -> [SKIP][80] ([Intel XE#2426])
[80]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-8/igt@kms_tiled_display@basic-test-pattern-with-chamelium.html
* igt@kms_vrr@max-min:
- shard-bmg: NOTRUN -> [SKIP][81] ([Intel XE#1499])
[81]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-8/igt@kms_vrr@max-min.html
- shard-dg2-set2: NOTRUN -> [SKIP][82] ([Intel XE#455])
[82]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-432/igt@kms_vrr@max-min.html
* igt@xe_eudebug@basic-vm-access-parameters:
- shard-dg2-set2: NOTRUN -> [SKIP][83] ([Intel XE#4837]) +4 other tests skip
[83]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-464/igt@xe_eudebug@basic-vm-access-parameters.html
* igt@xe_eudebug@basic-vm-bind-discovery:
- shard-bmg: NOTRUN -> [SKIP][84] ([Intel XE#4837]) +5 other tests skip
[84]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-4/igt@xe_eudebug@basic-vm-bind-discovery.html
* igt@xe_eudebug@discovery-empty-clients:
- shard-adlp: NOTRUN -> [SKIP][85] ([Intel XE#4837] / [Intel XE#5565])
[85]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-8/igt@xe_eudebug@discovery-empty-clients.html
* igt@xe_exec_basic@multigpu-once-basic-defer-mmap:
- shard-dg2-set2: [PASS][86] -> [SKIP][87] ([Intel XE#1392]) +8 other tests skip
[86]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-dg2-433/igt@xe_exec_basic@multigpu-once-basic-defer-mmap.html
[87]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-432/igt@xe_exec_basic@multigpu-once-basic-defer-mmap.html
* igt@xe_exec_basic@multigpu-once-bindexecqueue-userptr-invalidate:
- shard-bmg: NOTRUN -> [SKIP][88] ([Intel XE#2322]) +1 other test skip
[88]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-8/igt@xe_exec_basic@multigpu-once-bindexecqueue-userptr-invalidate.html
* igt@xe_exec_basic@multigpu-once-bindexecqueue-userptr-rebind:
- shard-adlp: NOTRUN -> [SKIP][89] ([Intel XE#1392] / [Intel XE#5575]) +1 other test skip
[89]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-8/igt@xe_exec_basic@multigpu-once-bindexecqueue-userptr-rebind.html
* igt@xe_exec_fault_mode@twice-bindexecqueue-rebind-prefetch:
- shard-adlp: NOTRUN -> [SKIP][90] ([Intel XE#288] / [Intel XE#5561]) +3 other tests skip
[90]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-8/igt@xe_exec_fault_mode@twice-bindexecqueue-rebind-prefetch.html
* igt@xe_exec_fault_mode@twice-userptr-invalidate-race:
- shard-dg2-set2: NOTRUN -> [SKIP][91] ([Intel XE#288]) +6 other tests skip
[91]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-464/igt@xe_exec_fault_mode@twice-userptr-invalidate-race.html
* igt@xe_exec_system_allocator@many-execqueues-mmap-remap-ro-dontunmap-eocheck:
- shard-adlp: NOTRUN -> [SKIP][92] ([Intel XE#4915]) +21 other tests skip
[92]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-8/igt@xe_exec_system_allocator@many-execqueues-mmap-remap-ro-dontunmap-eocheck.html
* igt@xe_exec_system_allocator@threads-many-execqueues-mmap:
- shard-bmg: [PASS][93] -> [ABORT][94] ([Intel XE#3970])
[93]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-bmg-6/igt@xe_exec_system_allocator@threads-many-execqueues-mmap.html
[94]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-5/igt@xe_exec_system_allocator@threads-many-execqueues-mmap.html
* igt@xe_exec_system_allocator@threads-shared-vm-many-large-execqueues-mmap-new-race-nomemset:
- shard-dg2-set2: NOTRUN -> [SKIP][95] ([Intel XE#4915]) +46 other tests skip
[95]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-432/igt@xe_exec_system_allocator@threads-shared-vm-many-large-execqueues-mmap-new-race-nomemset.html
* igt@xe_exec_system_allocator@threads-shared-vm-many-stride-mmap-free-huge:
- shard-bmg: NOTRUN -> [SKIP][96] ([Intel XE#4943]) +3 other tests skip
[96]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-4/igt@xe_exec_system_allocator@threads-shared-vm-many-stride-mmap-free-huge.html
* igt@xe_mmap@small-bar:
- shard-adlp: NOTRUN -> [SKIP][97] ([Intel XE#512])
[97]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-8/igt@xe_mmap@small-bar.html
* igt@xe_peer2peer@write@write-gpua-vram01-gpub-system-p2p:
- shard-dg2-set2: NOTRUN -> [FAIL][98] ([Intel XE#1173])
[98]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-463/igt@xe_peer2peer@write@write-gpua-vram01-gpub-system-p2p.html
* igt@xe_pm@d3cold-basic:
- shard-dg2-set2: NOTRUN -> [SKIP][99] ([Intel XE#2284] / [Intel XE#366])
[99]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-464/igt@xe_pm@d3cold-basic.html
* igt@xe_pm@d3cold-mmap-system:
- shard-bmg: NOTRUN -> [SKIP][100] ([Intel XE#2284]) +1 other test skip
[100]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-4/igt@xe_pm@d3cold-mmap-system.html
* igt@xe_pm@d3hot-i2c:
- shard-dg2-set2: NOTRUN -> [SKIP][101] ([Intel XE#5742])
[101]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-432/igt@xe_pm@d3hot-i2c.html
- shard-bmg: NOTRUN -> [SKIP][102] ([Intel XE#5742])
[102]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-8/igt@xe_pm@d3hot-i2c.html
* igt@xe_pxp@pxp-stale-bo-exec-post-rpm:
- shard-dg2-set2: NOTRUN -> [SKIP][103] ([Intel XE#4733])
[103]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-432/igt@xe_pxp@pxp-stale-bo-exec-post-rpm.html
* igt@xe_pxp@pxp-termination-key-update-post-suspend:
- shard-bmg: NOTRUN -> [SKIP][104] ([Intel XE#4733]) +1 other test skip
[104]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-8/igt@xe_pxp@pxp-termination-key-update-post-suspend.html
* igt@xe_sriov_auto_provisioning@selfconfig-reprovision-reduce-numvfs:
- shard-dg2-set2: NOTRUN -> [SKIP][105] ([Intel XE#4130])
[105]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-432/igt@xe_sriov_auto_provisioning@selfconfig-reprovision-reduce-numvfs.html
#### Possible fixes ####
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-lnl: [FAIL][106] ([Intel XE#3718]) -> [PASS][107] +1 other test pass
[106]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-lnl-4/igt@kms_async_flips@alternate-sync-async-flip.html
[107]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-lnl-2/igt@kms_async_flips@alternate-sync-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-adlp: [DMESG-FAIL][108] ([Intel XE#4543]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-adlp-2/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
[109]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-3/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
* igt@kms_bw@connected-linear-tiling-2-displays-3840x2160p:
- shard-bmg: [SKIP][110] ([Intel XE#2314] / [Intel XE#2894]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-bmg-6/igt@kms_bw@connected-linear-tiling-2-displays-3840x2160p.html
[111]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-5/igt@kms_bw@connected-linear-tiling-2-displays-3840x2160p.html
* igt@kms_ccs@crc-primary-suspend-4-tiled-bmg-ccs:
- shard-bmg: [INCOMPLETE][112] ([Intel XE#3862]) -> [PASS][113] +1 other test pass
[112]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-bmg-5/igt@kms_ccs@crc-primary-suspend-4-tiled-bmg-ccs.html
[113]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-4/igt@kms_ccs@crc-primary-suspend-4-tiled-bmg-ccs.html
* igt@kms_ccs@crc-primary-suspend-4-tiled-dg2-mc-ccs@pipe-d-dp-4:
- shard-dg2-set2: [INCOMPLETE][114] ([Intel XE#3862]) -> [PASS][115] +1 other test pass
[114]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-dg2-434/igt@kms_ccs@crc-primary-suspend-4-tiled-dg2-mc-ccs@pipe-d-dp-4.html
[115]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-464/igt@kms_ccs@crc-primary-suspend-4-tiled-dg2-mc-ccs@pipe-d-dp-4.html
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs@pipe-b-dp-4:
- shard-dg2-set2: [INCOMPLETE][116] ([Intel XE#1727] / [Intel XE#3113] / [Intel XE#4212] / [Intel XE#4522]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-dg2-463/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs@pipe-b-dp-4.html
[117]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-466/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs@pipe-b-dp-4.html
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-bmg: [FAIL][118] ([Intel XE#5299]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-bmg-2/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
[119]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-6/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
* igt@kms_flip@2x-flip-vs-modeset:
- shard-bmg: [SKIP][120] ([Intel XE#2316]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-bmg-6/igt@kms_flip@2x-flip-vs-modeset.html
[121]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-3/igt@kms_flip@2x-flip-vs-modeset.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-adlp: [DMESG-WARN][122] ([Intel XE#2953] / [Intel XE#4173] / [Intel XE#4543]) -> [PASS][123] +1 other test pass
[122]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-adlp-8/igt@kms_flip@flip-vs-suspend-interruptible.html
[123]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-9/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_flip@flip-vs-suspend@c-hdmi-a1:
- shard-adlp: [DMESG-WARN][124] ([Intel XE#4543]) -> [PASS][125] +2 other tests pass
[124]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-adlp-4/igt@kms_flip@flip-vs-suspend@c-hdmi-a1.html
[125]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-6/igt@kms_flip@flip-vs-suspend@c-hdmi-a1.html
* igt@kms_hdr@static-toggle-suspend:
- shard-bmg: [SKIP][126] ([Intel XE#1503]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-bmg-6/igt@kms_hdr@static-toggle-suspend.html
[127]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-3/igt@kms_hdr@static-toggle-suspend.html
* igt@kms_lease@simple-lease:
- shard-adlp: [ABORT][128] ([Intel XE#2953]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-adlp-2/igt@kms_lease@simple-lease.html
[129]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-8/igt@kms_lease@simple-lease.html
* igt@kms_lease@simple-lease@pipe-a-hdmi-a-1:
- shard-adlp: [ABORT][130] ([Intel XE#2953] / [Intel XE#4173]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-adlp-2/igt@kms_lease@simple-lease@pipe-a-hdmi-a-1.html
[131]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-8/igt@kms_lease@simple-lease@pipe-a-hdmi-a-1.html
* igt@kms_setmode@basic:
- shard-adlp: [FAIL][132] ([Intel XE#2883]) -> [PASS][133] +2 other tests pass
[132]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-adlp-8/igt@kms_setmode@basic.html
[133]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-9/igt@kms_setmode@basic.html
* igt@kms_vrr@cmrr@pipe-a-edp-1:
- shard-lnl: [FAIL][134] ([Intel XE#4459]) -> [PASS][135] +1 other test pass
[134]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-lnl-4/igt@kms_vrr@cmrr@pipe-a-edp-1.html
[135]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-lnl-2/igt@kms_vrr@cmrr@pipe-a-edp-1.html
* igt@xe_exec_basic@multigpu-many-execqueues-many-vm-bindexecqueue-userptr-rebind:
- shard-dg2-set2: [SKIP][136] ([Intel XE#1392]) -> [PASS][137] +5 other tests pass
[136]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-dg2-432/igt@xe_exec_basic@multigpu-many-execqueues-many-vm-bindexecqueue-userptr-rebind.html
[137]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-463/igt@xe_exec_basic@multigpu-many-execqueues-many-vm-bindexecqueue-userptr-rebind.html
* igt@xe_exec_reset@parallel-gt-reset:
- shard-adlp: [DMESG-WARN][138] ([Intel XE#3876]) -> [PASS][139]
[138]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-adlp-1/igt@xe_exec_reset@parallel-gt-reset.html
[139]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-3/igt@xe_exec_reset@parallel-gt-reset.html
* igt@xe_wedged@basic-wedged:
- shard-adlp: [DMESG-WARN][140] ([Intel XE#2953] / [Intel XE#4173]) -> [PASS][141] +9 other tests pass
[140]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-adlp-8/igt@xe_wedged@basic-wedged.html
[141]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-adlp-9/igt@xe_wedged@basic-wedged.html
#### Warnings ####
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs:
- shard-dg2-set2: [INCOMPLETE][142] ([Intel XE#1727] / [Intel XE#3113] / [Intel XE#4212] / [Intel XE#4345] / [Intel XE#4522]) -> [INCOMPLETE][143] ([Intel XE#1727] / [Intel XE#3113] / [Intel XE#4345])
[142]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-dg2-463/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs.html
[143]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-466/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs.html
* igt@kms_content_protection@srm:
- shard-bmg: [FAIL][144] ([Intel XE#1178]) -> [SKIP][145] ([Intel XE#2341])
[144]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-bmg-2/igt@kms_content_protection@srm.html
[145]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-6/igt@kms_content_protection@srm.html
* igt@kms_frontbuffer_tracking@drrs-2p-primscrn-pri-indfb-draw-mmap-wc:
- shard-bmg: [SKIP][146] ([Intel XE#2311]) -> [SKIP][147] ([Intel XE#2312]) +13 other tests skip
[146]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-bmg-3/igt@kms_frontbuffer_tracking@drrs-2p-primscrn-pri-indfb-draw-mmap-wc.html
[147]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-6/igt@kms_frontbuffer_tracking@drrs-2p-primscrn-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@drrs-2p-scndscrn-shrfb-msflip-blt:
- shard-bmg: [SKIP][148] ([Intel XE#2312]) -> [SKIP][149] ([Intel XE#2311]) +3 other tests skip
[148]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-bmg-6/igt@kms_frontbuffer_tracking@drrs-2p-scndscrn-shrfb-msflip-blt.html
[149]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-3/igt@kms_frontbuffer_tracking@drrs-2p-scndscrn-shrfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc:
- shard-bmg: [SKIP][150] ([Intel XE#5390]) -> [SKIP][151] ([Intel XE#2312]) +9 other tests skip
[150]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-bmg-2/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc.html
[151]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-move:
- shard-bmg: [SKIP][152] ([Intel XE#2312]) -> [SKIP][153] ([Intel XE#5390]) +2 other tests skip
[152]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-bmg-6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-move.html
[153]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-move.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-blt:
- shard-bmg: [SKIP][154] ([Intel XE#2313]) -> [SKIP][155] ([Intel XE#2312]) +8 other tests skip
[154]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-bmg-3/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-blt.html
[155]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-6/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-wc:
- shard-bmg: [SKIP][156] ([Intel XE#2312]) -> [SKIP][157] ([Intel XE#2313]) +2 other tests skip
[156]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-bmg-6/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-wc.html
[157]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-3/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-wc.html
* igt@kms_hdr@brightness-with-hdr:
- shard-bmg: [SKIP][158] ([Intel XE#3544]) -> [SKIP][159] ([Intel XE#3374] / [Intel XE#3544])
[158]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-bmg-1/igt@kms_hdr@brightness-with-hdr.html
[159]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-8/igt@kms_hdr@brightness-with-hdr.html
* igt@xe_fault_injection@probe-fail-guc-xe_guc_ct_send_recv:
- shard-dg2-set2: [ABORT][160] -> [ABORT][161] ([Intel XE#4917])
[160]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-dg2-433/igt@xe_fault_injection@probe-fail-guc-xe_guc_ct_send_recv.html
[161]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-432/igt@xe_fault_injection@probe-fail-guc-xe_guc_ct_send_recv.html
- shard-bmg: [ABORT][162] ([Intel XE#4917] / [Intel XE#5466] / [Intel XE#5530]) -> [ABORT][163] ([Intel XE#5466] / [Intel XE#5530])
[162]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-bmg-7/igt@xe_fault_injection@probe-fail-guc-xe_guc_ct_send_recv.html
[163]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-bmg-5/igt@xe_fault_injection@probe-fail-guc-xe_guc_ct_send_recv.html
* igt@xe_peer2peer@read:
- shard-dg2-set2: [FAIL][164] ([Intel XE#1173]) -> [SKIP][165] ([Intel XE#1061])
[164]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-dg2-435/igt@xe_peer2peer@read.html
[165]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-432/igt@xe_peer2peer@read.html
* igt@xe_peer2peer@write:
- shard-dg2-set2: [SKIP][166] ([Intel XE#1061]) -> [FAIL][167] ([Intel XE#1173])
[166]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c/shard-dg2-432/igt@xe_peer2peer@write.html
[167]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/shard-dg2-463/igt@xe_peer2peer@write.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[Intel XE#1061]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1061
[Intel XE#1124]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1124
[Intel XE#1127]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1127
[Intel XE#1173]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1173
[Intel XE#1178]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1178
[Intel XE#1392]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1392
[Intel XE#1406]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1406
[Intel XE#1475]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1475
[Intel XE#1489]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1489
[Intel XE#1499]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1499
[Intel XE#1503]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1503
[Intel XE#1727]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1727
[Intel XE#2049]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2049
[Intel XE#2234]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2234
[Intel XE#2252]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2252
[Intel XE#2284]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2284
[Intel XE#2291]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2291
[Intel XE#2293]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2293
[Intel XE#2311]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2311
[Intel XE#2312]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2312
[Intel XE#2313]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2313
[Intel XE#2314]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2314
[Intel XE#2316]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2316
[Intel XE#2320]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2320
[Intel XE#2322]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2322
[Intel XE#2325]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2325
[Intel XE#2327]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2327
[Intel XE#2330]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2330
[Intel XE#2341]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2341
[Intel XE#2373]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2373
[Intel XE#2380]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2380
[Intel XE#2393]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2393
[Intel XE#2426]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2426
[Intel XE#2571]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2571
[Intel XE#2597]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2597
[Intel XE#2850]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2850
[Intel XE#288]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/288
[Intel XE#2883]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2883
[Intel XE#2887]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2887
[Intel XE#2894]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2894
[Intel XE#2953]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2953
[Intel XE#301]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/301
[Intel XE#308]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/308
[Intel XE#3113]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3113
[Intel XE#3149]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3149
[Intel XE#3309]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3309
[Intel XE#3374]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3374
[Intel XE#3432]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3432
[Intel XE#3544]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3544
[Intel XE#366]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/366
[Intel XE#3718]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3718
[Intel XE#373]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/373
[Intel XE#3862]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3862
[Intel XE#3876]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3876
[Intel XE#3908]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3908
[Intel XE#3970]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3970
[Intel XE#4130]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4130
[Intel XE#4173]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4173
[Intel XE#4212]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4212
[Intel XE#4345]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4345
[Intel XE#4359]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4359
[Intel XE#4416]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4416
[Intel XE#4418]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4418
[Intel XE#4422]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4422
[Intel XE#4459]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4459
[Intel XE#4494]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4494
[Intel XE#4522]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4522
[Intel XE#4543]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4543
[Intel XE#455]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/455
[Intel XE#4665]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4665
[Intel XE#4733]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4733
[Intel XE#4837]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4837
[Intel XE#4915]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4915
[Intel XE#4917]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4917
[Intel XE#4943]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4943
[Intel XE#5021]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5021
[Intel XE#512]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/512
[Intel XE#5195]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5195
[Intel XE#5299]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5299
[Intel XE#5390]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5390
[Intel XE#5466]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5466
[Intel XE#5530]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5530
[Intel XE#5561]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5561
[Intel XE#5565]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5565
[Intel XE#5575]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5575
[Intel XE#5742]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5742
[Intel XE#5786]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5786
[Intel XE#5890]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5890
[Intel XE#616]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/616
[Intel XE#651]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/651
[Intel XE#653]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/653
[Intel XE#656]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/656
[Intel XE#787]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/787
[Intel XE#929]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/929
Build changes
-------------
* Linux: xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c -> xe-pw-154534v1
IGT_8540: 8540
xe-3759-6b4b640e8f446e569cdca0396efa12903de0896c: 6b4b640e8f446e569cdca0396efa12903de0896c
xe-pw-154534v1: 154534v1
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-154534v1/index.html
[-- Attachment #2: Type: text/html, Size: 58669 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] drm/xe/sysfs: Simplify and fix sysfs registration
2025-09-15 15:33 ` Michal Wajdeczko
@ 2025-09-16 13:52 ` Lucas De Marchi
2025-09-16 14:56 ` Michal Wajdeczko
0 siblings, 1 reply; 14+ messages in thread
From: Lucas De Marchi @ 2025-09-16 13:52 UTC (permalink / raw)
To: Michal Wajdeczko; +Cc: intel-xe, Rodrigo Vivi, Raag Jadav
On Mon, Sep 15, 2025 at 05:33:29PM +0200, Michal Wajdeczko wrote:
>
>
>On 9/15/2025 5:12 PM, Lucas De Marchi wrote:
>> On Mon, Sep 15, 2025 at 04:06:13PM +0200, Michal Wajdeczko wrote:
>>> Instead of manually maintaining each sysfs attribute define and use
>>> attribute groups and register them using device managed function.
>>> Then use is_visible() to filter-out unsupported attributes.
>>>
>>> This will result not only in less code and smaller footprint:
>>>
>>> Function old new delta
>>> late_bind_attr_is_visible - 183 +183
>>> ____versions 80832 80896 +64
>>> vram_attr_group - 48 +48
>>> late_bind_attr_group - 48 +48
>>> auto_link_downgrade_attr_group - 48 +48
>>> late_bind_attrs - 24 +24
>>> vram_attrs - 16 +16
>>> __pfx_late_bind_attr_is_visible - 16 +16
>>> xe_device_sysfs_init.cold 20 21 +1
>>> __pfx_xe_device_sysfs_fini 16 - -16
>>> xe_device_sysfs_fini.cold 21 - -21
>>> xe_device_sysfs_fini 271 - -271
>>> xe_device_sysfs_init 421 135 -286
>>> Total: Before=2848898, After=2848752, chg -0.01%
>>>
>>> but will also fix some bad error handling that we had here.
>>>
>>> Fixes: 0e414bf7ad01 ("drm/xe: Expose PCIe link downgrade attributes")
>>> Fixes: cdc36b66cd41 ("drm/xe: Expose fan control and voltage regulator version")
>>
>> we should probably land the fix separately though:
>> https://lore.kernel.org/intel-xe/7p7wqbghc2ebupbzljjaegakun3azczuby2haiqmmneavnpl44@joqtzfismsgv/
>>
>> and suggestion to rather use attribute group, similarly to what you're
>> doing here:
>> https://lore.kernel.org/intel-xe/3tkvzv7krbeuofuew44zm3ibenlntqkfclueq3soazkagwkezg@wtdhq4yvengu/
>>
>>
>>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>> Cc: Raag Jadav <raag.jadav@intel.com>
>>> ---
>>> drivers/gpu/drm/xe/xe_device_sysfs.c | 96 +++++++++++-----------------
>>> 1 file changed, 39 insertions(+), 57 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/xe/xe_device_sysfs.c b/drivers/gpu/drm/xe/xe_device_sysfs.c
>>> index 6ee422594b56..5b0b98ac9b17 100644
>>> --- a/drivers/gpu/drm/xe/xe_device_sysfs.c
>>> +++ b/drivers/gpu/drm/xe/xe_device_sysfs.c
>>> @@ -71,6 +71,15 @@ vram_d3cold_threshold_store(struct device *dev, struct device_attribute *attr,
>>>
>>> static DEVICE_ATTR_RW(vram_d3cold_threshold);
>>>
>>> +static struct attribute *vram_attrs[] = {
>>> + &dev_attr_vram_d3cold_threshold.attr,
>>> + NULL
>>> +};
>>> +
>>> +static const struct attribute_group vram_attr_group = {
>>> + .attrs = vram_attrs,
>>
>> since we are already checking by the attribute inside the is_visible
>> hook, couldn't we just add 1 group for "device attributes" and
>> share a single function?
>
>I tried that approach first, but checking for late_bind_attrs was
>so different that decided to keep it separated from other attrs
>
>after all, this is what the purpose of having multiple groups is, no?
yes, my concern was just about having too much boilerplate. Looking
again at the late_bind_attr_is_visible() you added I'm ok with that
though.
>
>>
>>> +};
>>> +
>>> static ssize_t
>>> lb_fan_control_version_show(struct device *dev, struct device_attribute *attr, char *buf)
>>> {
>>> @@ -149,8 +158,16 @@ lb_voltage_regulator_version_show(struct device *dev, struct device_attribute *a
>>> }
>>> static DEVICE_ATTR_ADMIN_RO(lb_voltage_regulator_version);
>>>
>>> -static int late_bind_create_files(struct device *dev)
>>> +static struct attribute *late_bind_attrs[] = {
>>> + &dev_attr_lb_fan_control_version.attr,
>>> + &dev_attr_lb_voltage_regulator_version.attr,
>>
>> As above, I think we can just consider them "device attributes".
>
>IMO we should _group_ related attributes into "attribute_group" and
>either add them based on single prerequisite condition and/or provide
>is_visible filter to control each attribute separately
ok
>
>now as we only have five attribute, it's tempting to put all into
>one group, but I assume we will soon have more attributes, and trying
>to manage them as single group may not scale, so it's better to show
>how to split related attrs now
ok, fair enough.
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
But as I said before, I'm going to land the fix from the other patch
series first as that can be propagated much more easily to stable.
Maybe one step further would be adding something like this on top?
(WARNING: just build-tested, may very well not work as is)
| diff --git a/drivers/base/core.c b/drivers/base/core.c
| index d22d6b23e7589..a84b74e487b0e 100644
| --- a/drivers/base/core.c
| +++ b/drivers/base/core.c
| @@ -2858,6 +2858,15 @@ static void devm_attr_group_remove(struct device *dev, void *res)
| sysfs_remove_group(&dev->kobj, group);
| }
|
| +static void devm_attr_groups_remove(struct device *dev, void *res)
| +{
| + union device_attr_group_devres *devres = res;
| + const struct attribute_group **groups = devres->groups;
| +
| + dev_dbg(dev, "%s: removing groups %p\n", __func__, groups);
| + sysfs_remove_groups(&dev->kobj, groups);
| +}
| +
| /**
| * devm_device_add_group - given a device, create a managed attribute group
| * @dev: The device to create the group for
| @@ -2890,6 +2899,39 @@ int devm_device_add_group(struct device *dev, const struct attribute_group *grp)
| }
| EXPORT_SYMBOL_GPL(devm_device_add_group);
|
| +/**
| + * devm_device_add_groups - given a device, create managed attribute groups
| + * @dev: The device to create the groups for
| + * @grp: The attribute group array to create
| + *
| + * This function creates the groups in the NULL-terminated array for the first
| + * time. It will explicitly warn and error if any of the attribute files being
| + * created already exist.
| + *
| + * Returns 0 on success or error code on failure.
| + */
| +int devm_device_add_groups(struct device *dev, const struct attribute_group **groups)
| +{
| + union device_attr_group_devres *devres;
| + int error;
| +
| + devres = devres_alloc(devm_attr_groups_remove,
| + sizeof(*devres), GFP_KERNEL);
| + if (!devres)
| + return -ENOMEM;
| +
| + error = sysfs_create_groups(&dev->kobj, groups);
| + if (error) {
| + devres_free(devres);
| + return error;
| + }
| +
| + devres->groups = groups;
| + devres_add(dev, devres);
| + return 0;
| +}
| +EXPORT_SYMBOL_GPL(devm_device_add_groups);
| +
| static int device_add_attrs(struct device *dev)
| {
| const struct class *class = dev->class;
| diff --git a/drivers/gpu/drm/xe/xe_device_sysfs.c b/drivers/gpu/drm/xe/xe_device_sysfs.c
| index c5151c86a98ae..e398176679e48 100644
| --- a/drivers/gpu/drm/xe/xe_device_sysfs.c
| +++ b/drivers/gpu/drm/xe/xe_device_sysfs.c
| @@ -69,6 +69,15 @@ vram_d3cold_threshold_store(struct device *dev, struct device_attribute *attr,
| return ret ?: count;
| }
|
| +static umode_t vram_attr_is_visible(struct kobject *kobj,
| + struct attribute *attr, int n)
| +{
| + struct device *dev = kobj_to_dev(kobj);
| + struct xe_device *xe = pdev_to_xe_device(to_pci_dev(dev));
| +
| + return xe->d3cold.capable ? attr->mode : 0;
| +}
| +
| static DEVICE_ATTR_RW(vram_d3cold_threshold);
|
| static struct attribute *vram_attrs[] = {
| @@ -78,6 +87,7 @@ static struct attribute *vram_attrs[] = {
|
| static const struct attribute_group vram_attr_group = {
| .attrs = vram_attrs,
| + .is_visible = vram_attr_is_visible,
| };
|
| static ssize_t
| @@ -173,8 +183,10 @@ static umode_t late_bind_attr_is_visible(struct kobject *kobj,
| u32 cap = 0;
| int ret;
|
| - xe_pm_runtime_get(xe);
| + if (xe->info.platform != XE_BATTLEMAGE || IS_SRIOV_VF(xe))
| + return 0;
|
| + xe_pm_runtime_get(xe);
| ret = xe_pcode_read(root, PCODE_MBOX(PCODE_LATE_BINDING, GET_CAPABILITY_STATUS, 0),
| &cap, NULL);
| xe_pm_runtime_put(xe);
| @@ -269,6 +281,15 @@ auto_link_downgrade_status_show(struct device *dev, struct device_attribute *att
| }
| static DEVICE_ATTR_ADMIN_RO(auto_link_downgrade_status);
|
| +static umode_t auto_link_downgrade_attr_is_visible(struct kobject *kobj,
| + struct attribute *attr, int n)
| +{
| + struct device *dev = kobj_to_dev(kobj);
| + struct xe_device *xe = pdev_to_xe_device(to_pci_dev(dev));
| +
| + return xe->info.platform == XE_BATTLEMAGE && !IS_SRIOV_VF(xe);
| +}
| +
| static struct attribute *auto_link_downgrade_attrs[] = {
| &dev_attr_auto_link_downgrade_capable.attr,
| &dev_attr_auto_link_downgrade_status.attr,
| @@ -277,28 +298,17 @@ static struct attribute *auto_link_downgrade_attrs[] = {
|
| static const struct attribute_group auto_link_downgrade_attr_group = {
| .attrs = auto_link_downgrade_attrs,
| + .is_visible = auto_link_downgrade_attr_is_visible,
| +};
| +
| +static const struct attribute_group *device_groups[] = {
| + &vram_attr_group,
| + &late_bind_attr_group,
| + &auto_link_downgrade_attr_group,
| + NULL,
| };
|
| int xe_device_sysfs_init(struct xe_device *xe)
| {
| - struct device *dev = xe->drm.dev;
| - int ret;
| -
| - if (xe->d3cold.capable) {
| - ret = devm_device_add_group(dev, &vram_attr_group);
| - if (ret)
| - return ret;
| - }
| -
| - if (xe->info.platform == XE_BATTLEMAGE && !IS_SRIOV_VF(xe)) {
| - ret = devm_device_add_group(dev, &auto_link_downgrade_attr_group);
| - if (ret)
| - return ret;
| -
| - ret = devm_device_add_group(dev, &late_bind_attr_group);
| - if (ret)
| - return ret;
| - }
| -
| - return 0;
| + return devm_device_add_groups(xe->drm.dev, device_groups);
| }
| diff --git a/include/linux/device.h b/include/linux/device.h
| index 0470d19da7f2c..63cc4aaf5f416 100644
| --- a/include/linux/device.h
| +++ b/include/linux/device.h
| @@ -1170,6 +1170,9 @@ static inline void device_remove_group(struct device *dev,
| int __must_check devm_device_add_group(struct device *dev,
| const struct attribute_group *grp);
|
| +int __must_check devm_device_add_groups(struct device *dev,
| + const struct attribute_group **groups);
| +
| /*
| * get_device - atomically increment the reference count for the device.
| *
Thoughts?
Lucas De Marchi
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] drm/xe/sysfs: Simplify and fix sysfs registration
2025-09-16 13:52 ` Lucas De Marchi
@ 2025-09-16 14:56 ` Michal Wajdeczko
0 siblings, 0 replies; 14+ messages in thread
From: Michal Wajdeczko @ 2025-09-16 14:56 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-xe, Rodrigo Vivi, Raag Jadav
On 9/16/2025 3:52 PM, Lucas De Marchi wrote:
> On Mon, Sep 15, 2025 at 05:33:29PM +0200, Michal Wajdeczko wrote:
>>
>>
>> On 9/15/2025 5:12 PM, Lucas De Marchi wrote:
>>> On Mon, Sep 15, 2025 at 04:06:13PM +0200, Michal Wajdeczko wrote:
>>>> Instead of manually maintaining each sysfs attribute define and use
>>>> attribute groups and register them using device managed function.
>>>> Then use is_visible() to filter-out unsupported attributes.
>>>>
>>>> This will result not only in less code and smaller footprint:
>>>>
>>>> Function old new delta
>>>> late_bind_attr_is_visible - 183 +183
>>>> ____versions 80832 80896 +64
>>>> vram_attr_group - 48 +48
>>>> late_bind_attr_group - 48 +48
>>>> auto_link_downgrade_attr_group - 48 +48
>>>> late_bind_attrs - 24 +24
>>>> vram_attrs - 16 +16
>>>> __pfx_late_bind_attr_is_visible - 16 +16
>>>> xe_device_sysfs_init.cold 20 21 +1
>>>> __pfx_xe_device_sysfs_fini 16 - -16
>>>> xe_device_sysfs_fini.cold 21 - -21
>>>> xe_device_sysfs_fini 271 - -271
>>>> xe_device_sysfs_init 421 135 -286
>>>> Total: Before=2848898, After=2848752, chg -0.01%
>>>>
>>>> but will also fix some bad error handling that we had here.
>>>>
>>>> Fixes: 0e414bf7ad01 ("drm/xe: Expose PCIe link downgrade attributes")
>>>> Fixes: cdc36b66cd41 ("drm/xe: Expose fan control and voltage regulator version")
>>>
>>> we should probably land the fix separately though:
>>> https://lore.kernel.org/intel-xe/7p7wqbghc2ebupbzljjaegakun3azczuby2haiqmmneavnpl44@joqtzfismsgv/
>>>
>>> and suggestion to rather use attribute group, similarly to what you're
>>> doing here:
>>> https://lore.kernel.org/intel-xe/3tkvzv7krbeuofuew44zm3ibenlntqkfclueq3soazkagwkezg@wtdhq4yvengu/
>>>
>>>
>>>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>>>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>>>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>>> Cc: Raag Jadav <raag.jadav@intel.com>
>>>> ---
>>>> drivers/gpu/drm/xe/xe_device_sysfs.c | 96 +++++++++++-----------------
>>>> 1 file changed, 39 insertions(+), 57 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/xe/xe_device_sysfs.c b/drivers/gpu/drm/xe/xe_device_sysfs.c
>>>> index 6ee422594b56..5b0b98ac9b17 100644
>>>> --- a/drivers/gpu/drm/xe/xe_device_sysfs.c
>>>> +++ b/drivers/gpu/drm/xe/xe_device_sysfs.c
>>>> @@ -71,6 +71,15 @@ vram_d3cold_threshold_store(struct device *dev, struct device_attribute *attr,
>>>>
>>>> static DEVICE_ATTR_RW(vram_d3cold_threshold);
>>>>
>>>> +static struct attribute *vram_attrs[] = {
>>>> + &dev_attr_vram_d3cold_threshold.attr,
>>>> + NULL
>>>> +};
>>>> +
>>>> +static const struct attribute_group vram_attr_group = {
>>>> + .attrs = vram_attrs,
>>>
>>> since we are already checking by the attribute inside the is_visible
>>> hook, couldn't we just add 1 group for "device attributes" and
>>> share a single function?
>>
>> I tried that approach first, but checking for late_bind_attrs was
>> so different that decided to keep it separated from other attrs
>>
>> after all, this is what the purpose of having multiple groups is, no?
>
> yes, my concern was just about having too much boilerplate. Looking
> again at the late_bind_attr_is_visible() you added I'm ok with that
> though.
>
>>
>>>
>>>> +};
>>>> +
>>>> static ssize_t
>>>> lb_fan_control_version_show(struct device *dev, struct device_attribute *attr, char *buf)
>>>> {
>>>> @@ -149,8 +158,16 @@ lb_voltage_regulator_version_show(struct device *dev, struct device_attribute *a
>>>> }
>>>> static DEVICE_ATTR_ADMIN_RO(lb_voltage_regulator_version);
>>>>
>>>> -static int late_bind_create_files(struct device *dev)
>>>> +static struct attribute *late_bind_attrs[] = {
>>>> + &dev_attr_lb_fan_control_version.attr,
>>>> + &dev_attr_lb_voltage_regulator_version.attr,
>>>
>>> As above, I think we can just consider them "device attributes".
>>
>> IMO we should _group_ related attributes into "attribute_group" and
>> either add them based on single prerequisite condition and/or provide
>> is_visible filter to control each attribute separately
>
> ok
>
>>
>> now as we only have five attribute, it's tempting to put all into
>> one group, but I assume we will soon have more attributes, and trying
>> to manage them as single group may not scale, so it's better to show
>> how to split related attrs now
>
> ok, fair enough.
>
> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
> But as I said before, I'm going to land the fix from the other patch
> series first as that can be propagated much more easily to stable.
>
> Maybe one step further would be adding something like this on top?
> (WARNING: just build-tested, may very well not work as is)
>
> | diff --git a/drivers/base/core.c b/drivers/base/core.c
> | index d22d6b23e7589..a84b74e487b0e 100644
> | --- a/drivers/base/core.c
> | +++ b/drivers/base/core.c
> | @@ -2858,6 +2858,15 @@ static void devm_attr_group_remove(struct device *dev, void *res)
> | sysfs_remove_group(&dev->kobj, group);
> | }
> | | +static void devm_attr_groups_remove(struct device *dev, void *res)
> | +{
> | + union device_attr_group_devres *devres = res;
> | + const struct attribute_group **groups = devres->groups;
> | +
> | + dev_dbg(dev, "%s: removing groups %p\n", __func__, groups);
> | + sysfs_remove_groups(&dev->kobj, groups);
> | +}
> | +
> | /**
> | * devm_device_add_group - given a device, create a managed attribute group
> | * @dev: The device to create the group for
> | @@ -2890,6 +2899,39 @@ int devm_device_add_group(struct device *dev, const struct attribute_group *grp)
> | }
> | EXPORT_SYMBOL_GPL(devm_device_add_group);
> | | +/**
> | + * devm_device_add_groups - given a device, create managed attribute groups
> | + * @dev: The device to create the groups for
> | + * @grp: The attribute group array to create
> | + *
> | + * This function creates the groups in the NULL-terminated array for the first
> | + * time. It will explicitly warn and error if any of the attribute files being
> | + * created already exist.
> | + *
> | + * Returns 0 on success or error code on failure.
> | + */
> | +int devm_device_add_groups(struct device *dev, const struct attribute_group **groups)
well, this would be nice to have, but short term I would just stay
with currently available devm_device_add_group() since our two other
groups would have very simple is_visible() logic, so it really doesn't
matter if we have 2x extra:
umode_t vram_attr_is_visible()
{
...
return xe->d3cold.capable ? attr->mode : 0;
}
and single:
{
devm_device_add_groups(dev, xe_groups);
}
vs simple extra 2x conditions:
{
if (xe->d3cold.capable)
devm_device_add_group(dev, vram);
}
and who knows how it would take to land this in sysfs core ...
unless we want to show preferred code layout, so short term we can keep
our fini action, with:
void fini(arg)
{
device_remove_groups(dev, xe_groups);
}
ps. actually I exactly did this this way in my rev0 but then
decided to use devm_device_add_group() due to trivial conditions
> | +{
> | + union device_attr_group_devres *devres;
> | + int error;
> | +
> | + devres = devres_alloc(devm_attr_groups_remove,
> | + sizeof(*devres), GFP_KERNEL);
> | + if (!devres)
> | + return -ENOMEM;
> | +
> | + error = sysfs_create_groups(&dev->kobj, groups);
> | + if (error) {
> | + devres_free(devres);
> | + return error;
> | + }
> | +
> | + devres->groups = groups;
> | + devres_add(dev, devres);
> | + return 0;
> | +}
> | +EXPORT_SYMBOL_GPL(devm_device_add_groups);
> | +
> | static int device_add_attrs(struct device *dev)
> | {
> | const struct class *class = dev->class;
> | diff --git a/drivers/gpu/drm/xe/xe_device_sysfs.c b/drivers/gpu/drm/xe/xe_device_sysfs.c
> | index c5151c86a98ae..e398176679e48 100644
> | --- a/drivers/gpu/drm/xe/xe_device_sysfs.c
> | +++ b/drivers/gpu/drm/xe/xe_device_sysfs.c
> | @@ -69,6 +69,15 @@ vram_d3cold_threshold_store(struct device *dev, struct device_attribute *attr,
> | return ret ?: count;
> | }
> | | +static umode_t vram_attr_is_visible(struct kobject *kobj,
> | + struct attribute *attr, int n)
> | +{
> | + struct device *dev = kobj_to_dev(kobj);
> | + struct xe_device *xe = pdev_to_xe_device(to_pci_dev(dev));
> | +
> | + return xe->d3cold.capable ? attr->mode : 0;
> | +}
> | +
> | static DEVICE_ATTR_RW(vram_d3cold_threshold);
> | | static struct attribute *vram_attrs[] = {
> | @@ -78,6 +87,7 @@ static struct attribute *vram_attrs[] = {
> | | static const struct attribute_group vram_attr_group = {
> | .attrs = vram_attrs,
> | + .is_visible = vram_attr_is_visible,
> | };
> | | static ssize_t
> | @@ -173,8 +183,10 @@ static umode_t late_bind_attr_is_visible(struct kobject *kobj,
> | u32 cap = 0;
> | int ret;
> | | - xe_pm_runtime_get(xe);
> | + if (xe->info.platform != XE_BATTLEMAGE || IS_SRIOV_VF(xe))
> | + return 0;
> | | + xe_pm_runtime_get(xe);
> | ret = xe_pcode_read(root, PCODE_MBOX(PCODE_LATE_BINDING, GET_CAPABILITY_STATUS, 0),
> | &cap, NULL);
> | xe_pm_runtime_put(xe);
> | @@ -269,6 +281,15 @@ auto_link_downgrade_status_show(struct device *dev, struct device_attribute *att
> | }
> | static DEVICE_ATTR_ADMIN_RO(auto_link_downgrade_status);
> | | +static umode_t auto_link_downgrade_attr_is_visible(struct kobject *kobj,
> | + struct attribute *attr, int n)
> | +{
> | + struct device *dev = kobj_to_dev(kobj);
> | + struct xe_device *xe = pdev_to_xe_device(to_pci_dev(dev));
> | +
> | + return xe->info.platform == XE_BATTLEMAGE && !IS_SRIOV_VF(xe);
> | +}
> | +
> | static struct attribute *auto_link_downgrade_attrs[] = {
> | &dev_attr_auto_link_downgrade_capable.attr,
> | &dev_attr_auto_link_downgrade_status.attr,
> | @@ -277,28 +298,17 @@ static struct attribute *auto_link_downgrade_attrs[] = {
> | | static const struct attribute_group auto_link_downgrade_attr_group = {
> | .attrs = auto_link_downgrade_attrs,
> | + .is_visible = auto_link_downgrade_attr_is_visible,
> | +};
> | +
> | +static const struct attribute_group *device_groups[] = {
> | + &vram_attr_group,
> | + &late_bind_attr_group,
> | + &auto_link_downgrade_attr_group,
> | + NULL,
> | };
> | | int xe_device_sysfs_init(struct xe_device *xe)
> | {
> | - struct device *dev = xe->drm.dev;
> | - int ret;
> | -
> | - if (xe->d3cold.capable) {
> | - ret = devm_device_add_group(dev, &vram_attr_group);
> | - if (ret)
> | - return ret;
> | - }
> | -
> | - if (xe->info.platform == XE_BATTLEMAGE && !IS_SRIOV_VF(xe)) {
> | - ret = devm_device_add_group(dev, &auto_link_downgrade_attr_group);
> | - if (ret)
> | - return ret;
> | -
> | - ret = devm_device_add_group(dev, &late_bind_attr_group);
> | - if (ret)
> | - return ret;
> | - }
> | -
> | - return 0;
> | + return devm_device_add_groups(xe->drm.dev, device_groups);
> | }
> | diff --git a/include/linux/device.h b/include/linux/device.h
> | index 0470d19da7f2c..63cc4aaf5f416 100644
> | --- a/include/linux/device.h
> | +++ b/include/linux/device.h
> | @@ -1170,6 +1170,9 @@ static inline void device_remove_group(struct device *dev,
> | int __must_check devm_device_add_group(struct device *dev,
> | const struct attribute_group *grp);
> | | +int __must_check devm_device_add_groups(struct device *dev,
> | + const struct attribute_group **groups);
> | +
> | /*
> | * get_device - atomically increment the reference count for the device.
> | *
>
>
> Thoughts?
>
> Lucas De Marchi
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2025-09-16 14:56 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-15 14:06 [PATCH 0/2] drm/xe/sysfs: Fix attributes registration on VFs Michal Wajdeczko
2025-09-15 14:06 ` [PATCH 1/2] drm/xe/sysfs: Simplify and fix sysfs registration Michal Wajdeczko
2025-09-15 15:12 ` Lucas De Marchi
2025-09-15 15:33 ` Michal Wajdeczko
2025-09-16 13:52 ` Lucas De Marchi
2025-09-16 14:56 ` Michal Wajdeczko
2025-09-15 15:17 ` Raag Jadav
2025-09-15 15:51 ` Michal Wajdeczko
2025-09-15 16:03 ` Raag Jadav
2025-09-15 14:06 ` [PATCH 2/2] drm/xe/vf: Don't expose sysfs attributes not applicable for VFs Michal Wajdeczko
2025-09-15 15:18 ` Raag Jadav
2025-09-15 14:12 ` ✓ CI.KUnit: success for drm/xe/sysfs: Fix attributes registration on VFs Patchwork
2025-09-15 14:51 ` ✓ Xe.CI.BAT: " Patchwork
2025-09-15 17:44 ` ✗ Xe.CI.Full: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox