Re: [PATCH v7 07/12] drm/xe: Privatize xe_ggtt_node

[Matthew Brost <matthew.brost@intel.com>]

On Wed, Oct 15, 2025 at 09:47:16AM +0200, Maarten Lankhorst wrote:
> Nothing requires it any more, make the member private.
> 
> Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_ggtt.c       | 18 ++++++++++++++++++
>  drivers/gpu/drm/xe/xe_ggtt_types.h | 19 +------------------
>  2 files changed, 19 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_ggtt.c b/drivers/gpu/drm/xe/xe_ggtt.c
> index 05515037e2d6a..5c07d63189ab1 100644
> --- a/drivers/gpu/drm/xe/xe_ggtt.c
> +++ b/drivers/gpu/drm/xe/xe_ggtt.c
> @@ -34,6 +34,24 @@
>  #include "xe_wa.h"
>  #include "xe_wopcm.h"
>  
> +/**
> + * struct xe_ggtt_node - A node in GGTT.
> + *
> + * This struct needs to be initialized (only-once) with xe_ggtt_node_init() before any node
> + * insertion, reservation, or 'ballooning'.
> + * It will, then, be finalized by either xe_ggtt_node_remove() or xe_ggtt_node_deballoon().
> + */
> +struct xe_ggtt_node {
> +	/** @ggtt: Back pointer to xe_ggtt where this region will be inserted at */
> +	struct xe_ggtt *ggtt;
> +	/** @base: A drm_mm_node */
> +	struct drm_mm_node base;
> +	/** @delayed_removal_work: The work struct for the delayed removal */
> +	struct work_struct delayed_removal_work;
> +	/** @invalidate_on_remove: If it needs invalidation upon removal */
> +	bool invalidate_on_remove;
> +};
> +
>  /**
>   * DOC: Global Graphics Translation Table (GGTT)
>   *
> diff --git a/drivers/gpu/drm/xe/xe_ggtt_types.h b/drivers/gpu/drm/xe/xe_ggtt_types.h
> index f4aa5671cb3e3..31054e00daa6b 100644
> --- a/drivers/gpu/drm/xe/xe_ggtt_types.h
> +++ b/drivers/gpu/drm/xe/xe_ggtt_types.h
> @@ -11,6 +11,7 @@
>  #include "xe_pt_types.h"
>  
>  struct xe_bo;
> +struct xe_ggtt_node;
>  struct xe_gt;
>  
>  /**
> @@ -53,24 +54,6 @@ struct xe_ggtt {
>  	struct workqueue_struct *wq;
>  };
>  
> -/**
> - * struct xe_ggtt_node - A node in GGTT.
> - *
> - * This struct needs to be initialized (only-once) with xe_ggtt_node_init() before any node
> - * insertion, reservation, or 'ballooning'.
> - * It will, then, be finalized by either xe_ggtt_node_remove() or xe_ggtt_node_deballoon().
> - */
> -struct xe_ggtt_node {
> -	/** @ggtt: Back pointer to xe_ggtt where this region will be inserted at */
> -	struct xe_ggtt *ggtt;
> -	/** @base: A drm_mm_node */
> -	struct drm_mm_node base;
> -	/** @delayed_removal_work: The work struct for the delayed removal */
> -	struct work_struct delayed_removal_work;
> -	/** @invalidate_on_remove: If it needs invalidation upon removal */
> -	bool invalidate_on_remove;
> -};
> -
>  typedef void (*xe_ggtt_set_pte_fn)(struct xe_ggtt *ggtt, u64 addr, u64 pte);
>  typedef void (*xe_ggtt_transform_cb)(struct xe_ggtt *ggtt,
>  				     struct xe_ggtt_node *node,
> -- 
> 2.51.0
>