Re: [PATCH v7 03/12] drm/xe: Add xe_ggtt_node_addr() to avoid dereferencing xe_ggtt_node

[Matthew Brost <matthew.brost@intel.com>]

On Thu, Oct 16, 2025 at 08:13:44AM +0200, Maarten Lankhorst wrote:
> Hey,
> 
> Den 2025-10-15 kl. 23:49, skrev Matthew Brost:
> > On Wed, Oct 15, 2025 at 09:47:12AM +0200, Maarten Lankhorst wrote:
> >> This function makes it possible to add an offset that is applied to
> >> all xe_ggtt_node's, and hides the internals from all its users.
> >>
> >> Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
> >> ---
> >>  drivers/gpu/drm/xe/xe_bo.h   |  8 +++++---
> >>  drivers/gpu/drm/xe/xe_ggtt.c | 11 +++++++++++
> >>  drivers/gpu/drm/xe/xe_ggtt.h |  2 ++
> >>  3 files changed, 18 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/xe/xe_bo.h b/drivers/gpu/drm/xe/xe_bo.h
> >> index 353d607d301da..dd67a6f40a16d 100644
> >> --- a/drivers/gpu/drm/xe/xe_bo.h
> >> +++ b/drivers/gpu/drm/xe/xe_bo.h
> >> @@ -9,6 +9,7 @@
> >>  #include <drm/ttm/ttm_tt.h>
> >>  
> >>  #include "xe_bo_types.h"
> >> +#include "xe_ggtt.h"
> >>  #include "xe_macros.h"
> >>  #include "xe_validation.h"
> >>  #include "xe_vm_types.h"
> >> @@ -251,13 +252,14 @@ static inline u32
> >>  __xe_bo_ggtt_addr(struct xe_bo *bo, u8 tile_id)
> >>  {
> >>  	struct xe_ggtt_node *ggtt_node = bo->ggtt_node[tile_id];
> >> +	u64 offset;
> >>  
> >>  	if (XE_WARN_ON(!ggtt_node))
> >>  		return 0;
> >>  
> >> -	XE_WARN_ON(ggtt_node->base.size > xe_bo_size(bo));
> > 
> > Is there any reason this warning was dropped? It's not immediately
> > obvious to me why it would be.
> > 
> The impossibility because of being allocated with a different size
> than xe_bo_size() in __xe_ggtt_insert_bo_at(). I dropped it
> because it's redundant.

Ok, makes sense. I suppose with the GGTT being private you can't access
this information a bit later in the series.

Matt 

> 
> Kind regards,
> ~Maarten Lankhorst