Re: [PATCH v2 2/3] drm/xe/sa: Add lockdep annotations for SA manager swap_guard

[Matthew Brost <matthew.brost@intel.com>]

On Wed, Feb 04, 2026 at 04:46:45PM +0000, Satyanarayana K V P wrote:
> Annotate the SA manager init path to model taking swap_guard while under
> reclaim context. This helps lockdep catch potential circular dependencies
> between fs_reclaim and swap_guard in debug builds.

I'd mention without this annotation it lockdep is unware of this chain
until the shrinker runs.

> 
> Signed-off-by: Satyanarayana K V P <satyanarayana.k.v.p@intel.com>
> Suggested-by: Matthew Brost <matthew.brost@intel.com>

I'd make this the last patch in series so it goes in after the reclaim
problem is fixed.

But patch itself LGTM:

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Matthew Auld <matthew.auld@intel.com>
> 
> ---
> V1 -> V2:
> - None.
> ---
>  drivers/gpu/drm/xe/xe_sa.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_sa.c b/drivers/gpu/drm/xe/xe_sa.c
> index b738102575d4..5efbb5a09f77 100644
> --- a/drivers/gpu/drm/xe/xe_sa.c
> +++ b/drivers/gpu/drm/xe/xe_sa.c
> @@ -89,6 +89,12 @@ struct xe_sa_manager *__xe_sa_bo_manager_init(struct xe_tile *tile, u32 size,
>  		if (ret)
>  			return ERR_PTR(ret);
>  
> +		if (IS_ENABLED(CONFIG_PROVE_LOCKING)) {
> +			fs_reclaim_acquire(GFP_KERNEL);
> +			might_lock(&sa_manager->swap_guard);
> +			fs_reclaim_release(GFP_KERNEL);
> +		}
> +
>  		shadow = xe_managed_bo_create_pin_map(xe, tile, size,
>  						      XE_BO_FLAG_VRAM_IF_DGFX(tile) |
>  						      XE_BO_FLAG_GGTT |
> -- 
> 2.43.0
>