Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
To: "Jouni Högander" <jouni.hogander@intel.com>,
	intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 2/5] drm/i915/psr: Add DSC_SU_PARAMETER_SET_0 registers for PSR configuration
Date: Wed, 25 Feb 2026 09:51:51 +0530	[thread overview]
Message-ID: <af2b2ba4-05b9-4cb6-a01e-25c2132152fe@intel.com> (raw)
In-Reply-To: <20260219130743.1232188-3-jouni.hogander@intel.com>


On 2/19/2026 6:37 PM, Jouni Högander wrote:
> Add DSC_SU_PARAMETER_SET_0_DSC0 and DSC_SU_PARAMETER_SET_0_DSC1 register
> definitions for Selective Update Early Transport configuration.
>
> Bspec: 71709
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_psr_regs.h | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr_regs.h b/drivers/gpu/drm/i915/display/intel_psr_regs.h
> index 8afbf5a38335..3d1523dece8b 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr_regs.h
> +++ b/drivers/gpu/drm/i915/display/intel_psr_regs.h
> @@ -266,6 +266,18 @@
>   #define _PIPE_SRCSZ_ERLY_TPT_B	0x71074
>   #define PIPE_SRCSZ_ERLY_TPT(pipe)	_MMIO_PIPE((pipe), _PIPE_SRCSZ_ERLY_TPT_A, _PIPE_SRCSZ_ERLY_TPT_B)
>   
> +#define _DSC_SU_PARAMETER_SET_0_DSC0_A		0x78064


I understand these are needed for PSR SU region, but these seem to 
belong to DSC registers file with other DSC registers.


Regards,

Ankit

> +#define _DSC_SU_PARAMETER_SET_0_DSC0_B		0x78264
> +#define DSC_SU_PARAMETER_SET_0_DSC0(pipe)	_MMIO_PIPE((pipe), _DSC_SU_PARAMETER_SET_0_DSC0_A, _DSC_SU_PARAMETER_SET_0_DSC0_B)
> +#define   DSC_SU_PARAMETER_SET_0_SU_SLICE_ROW_PER_FRAME_MASK	REG_GENMASK(31, 20)
> +#define   DSC_SU_PARAMETER_SET_0_SU_SLICE_ROW_PER_FRAME(rows)	REG_FIELD_PREP(DSC_SU_PARAMETER_SET_0_SU_SLICE_ROW_PER_FRAME_MASK, (rows))
> +#define   DSC_SU_PARAMETER_SET_0_SU_PIC_HEIGHT_MASK		REG_GENMASK(15, 0)
> +#define   DSC_SU_PARAMETER_SET_0_SU_PIC_HEIGHT(h)		REG_FIELD_PREP(DSC_SU_PARAMETER_SET_0_SU_PIC_HEIGHT_MASK, (h))
> +
> +#define _DSC_SU_PARAMETER_SET_0_DSC1_A		0x78164
> +#define _DSC_SU_PARAMETER_SET_0_DSC1_B		0x78364
> +#define DSC_SU_PARAMETER_SET_0_DSC1(pipe)	_MMIO_PIPE((pipe), _DSC_SU_PARAMETER_SET_0_DSC1_A, _DSC_SU_PARAMETER_SET_0_DSC1_B)
> +
>   #define _PR_ALPM_CTL_A	0x60948
>   #define PR_ALPM_CTL(dev_priv, tran)	_MMIO_TRANS2(dev_priv, tran, _PR_ALPM_CTL_A)
>   #define  PR_ALPM_CTL_ALLOW_LINK_OFF_BETWEEN_AS_SDP_AND_SU	BIT(6)

  reply	other threads:[~2026-02-25  4:22 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-19 13:07 [PATCH 0/5] PSR/PR Selective Fetch Early Transport fixes Jouni Högander
2026-02-19 13:07 ` [PATCH 1/5] drm/i915/psr: Repeat Selective Update area alignment Jouni Högander
2026-02-25  4:13   ` Nautiyal, Ankit K
2026-02-25  6:33     ` Hogander, Jouni
2026-02-19 13:07 ` [PATCH 2/5] drm/i915/psr: Add DSC_SU_PARAMETER_SET_0 registers for PSR configuration Jouni Högander
2026-02-25  4:21   ` Nautiyal, Ankit K [this message]
2026-02-25  6:30     ` Hogander, Jouni
2026-02-25 12:39       ` Nautiyal, Ankit K
2026-02-19 13:07 ` [PATCH 3/5] drm/i915/dsc: Convert intel_dsc_get_vdsc_per_pipe as non-static Jouni Högander
2026-02-25  5:04   ` Nautiyal, Ankit K
2026-02-19 13:07 ` [PATCH 4/5] drm/i915/psr: DSC configuration for Early Transport Jouni Högander
2026-02-25 12:06   ` Nautiyal, Ankit K
2026-02-25 12:26     ` Hogander, Jouni
2026-02-25 13:29     ` Jani Nikula
2026-02-25 14:30       ` Nautiyal, Ankit K
2026-02-19 13:07 ` [PATCH 5/5] drm/i915/psr: Drop cursor_in_su_area from intel_psr2_sel_fetch_et_alignment Jouni Högander
2026-02-19 13:45 ` ✗ CI.checkpatch: warning for PSR/PR Selective Fetch Early Transport fixes Patchwork
2026-02-19 13:47 ` ✓ CI.KUnit: success " Patchwork
2026-02-19 14:02 ` ✗ CI.checksparse: warning " Patchwork
2026-02-20  8:20 ` ✓ Xe.CI.BAT: success " Patchwork
2026-02-20  9:57 ` ✓ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af2b2ba4-05b9-4cb6-a01e-25c2132152fe@intel.com \
    --to=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jouni.hogander@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox