Re: [RFC v1 2/5] drm/xe/fwctl: Add uAPI definitions for Xe FWCTL support

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Fri, Mar 20, 2026 at 12:25:30AM -0700, Anoop, Vijay wrote:
> From: Anoop Vijay <anoop.c.vijay@intel.com>
> 
> Add Xe-specific uAPI definitions for FWCTL support. Introduce
> include/uapi/fwctl/xe.h to describe userspace ABI for Xe firmware
> control operations, and extend core FWCTL uAPI to recognize
> Xe device type.
> 
> This patch adds uAPI definitions only. No functional kernel code
> is introduced.
> 
> Signed-off-by: Anoop Vijay <anoop.c.vijay@intel.com>
> ---
>  include/uapi/fwctl/fwctl.h |  1 +
>  include/uapi/fwctl/xe.h    | 38 ++++++++++++++++++++++++++++++++++++++
>  2 files changed, 39 insertions(+)
>  create mode 100644 include/uapi/fwctl/xe.h
> 
> diff --git a/include/uapi/fwctl/fwctl.h b/include/uapi/fwctl/fwctl.h
> index 716ac0eee42d..c63bc15159d3 100644
> --- a/include/uapi/fwctl/fwctl.h
> +++ b/include/uapi/fwctl/fwctl.h
> @@ -45,6 +45,7 @@ enum fwctl_device_type {
>  	FWCTL_DEVICE_TYPE_MLX5 = 1,
>  	FWCTL_DEVICE_TYPE_CXL = 2,
>  	FWCTL_DEVICE_TYPE_PDS = 4,
> +	FWCTL_DEVICE_TYPE_XE = 5,

I don't believe we should have a generic XE component here, but one per
FW since we have many different FW underneath and each one with its
own different Mailboxes.

Check: https://lore.kernel.org/intel-xe/20250429073804.972137-10-badal.nilawar@intel.com/

>  };
>  
>  /**
> diff --git a/include/uapi/fwctl/xe.h b/include/uapi/fwctl/xe.h
> new file mode 100644
> index 000000000000..fb5612dec610
> --- /dev/null
> +++ b/include/uapi/fwctl/xe.h
> @@ -0,0 +1,38 @@
> +/* SPDX-License-Identifier: MIT */
> +/*
> + * Copyright © 2026 Intel Corporation
> + */
> +
> +#ifndef _UAPI_FWCTL_XE_H_
> +#define _UAPI_FWCTL_XE_H_
> +
> +#include <linux/types.h>
> +
> +/**
> + * DOC: Xe FWCTL Interface
> + *
> + * The Xe FWCTL interface provides userspace access to firmware subsystems
> + * on Intel Xe discrete GPUs. It exposes firmware management capabilities
> + * through the kernel FWCTL framework.
> + */
> +
> +/**
> + * struct fwctl_info_xe - FWCTL Information struct for Xe
> + *
> + * @fw_caps: Firmware capability bitmap
> + * @platform: Platform type
> + */
> +struct fwctl_info_xe {
> +	__u32 fw_caps;
> +	__u32 platform;
> +};
> +
> +/**
> + * struct fwctl_rpc_xe - Common Xe FWCTL RPC header
> + * @firmware_type: Firmware type
> + */
> +struct fwctl_rpc_xe {
> +	__u32 firmware_type;
> +};
> +
> +#endif
> -- 
> 2.43.0
>