Re: [RFC v1 0/5] drm/xe/fwctl: Add FWCTL interface for Xe firmware management

[Anoop Vijay <anoop.c.vijay@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3460 bytes --]

Hi,

Bumping this RFC series and requesting a review.

Feedback on the proposed interface and overall approach would be greatly 
appreciated before I proceed to the next revision.

Thanks,
Anoop

On 20-03-2026 12:55, Anoop, Vijay wrote:
> From: Anoop Vijay<anoop.c.vijay@intel.com>
>
> This series builds on top of System Controller series[1] and adds FWCTL
> framework support for System Controller firmware access on Intel Xe discrete
> GPUs.
>
> Patches introduce generic FWCTL infrastructure with pluggable firmware
> backend support, implementing initial System Controller backend to enable
> userspace firmware management through standard FWCTL device interfaces.
>
> Key features introduced:
> - Generic xe_fw_ops interface for firmware backend implementations
> - FWCTL device registration and ioctl handlers (info, rpc)
> - System Controller FWCTL backend with scope validation and RPC execution
> - Userspace-accessible firmware RPCs through /dev/fwctl/fwctl<N>
>
> [1]https://patchwork.freedesktop.org/series/163196/
>
> Anoop Vijay (5):
>    drm/xe/xe_sysctrl: Add System Controller support
>    drm/xe/fwctl: Add uAPI definitions for Xe FWCTL support
>    drm/xe/fwctl: Add Xe FWCTL type definitions
>    drm/xe/fwctl: Add Xe FWCTL infrastructure support
>    drm/xe/fwctl: Add System Controller FWCTL RPC handler
>
>   Documentation/userspace-api/fwctl/index.rst   |   1 +
>   drivers/gpu/drm/xe/Kconfig                    |   1 +
>   drivers/gpu/drm/xe/Makefile                   |   4 +
>   drivers/gpu/drm/xe/abi/xe_sysctrl_abi.h       |  94 ++++
>   drivers/gpu/drm/xe/regs/xe_sysctrl_regs.h     |  36 ++
>   drivers/gpu/drm/xe/xe_device.c                |  10 +
>   drivers/gpu/drm/xe/xe_device_types.h          |  10 +
>   drivers/gpu/drm/xe/xe_fwctl.c                 | 206 +++++++++
>   drivers/gpu/drm/xe/xe_fwctl.h                 |  15 +
>   drivers/gpu/drm/xe/xe_fwctl_types.h           |  52 +++
>   drivers/gpu/drm/xe/xe_pci.c                   |   2 +
>   drivers/gpu/drm/xe/xe_pci_types.h             |   1 +
>   drivers/gpu/drm/xe/xe_pm.c                    |  11 +
>   drivers/gpu/drm/xe/xe_sysctrl.c               | 128 ++++++
>   drivers/gpu/drm/xe/xe_sysctrl.h               |  23 +
>   drivers/gpu/drm/xe/xe_sysctrl_fwctl.c         | 136 ++++++
>   drivers/gpu/drm/xe/xe_sysctrl_mailbox.c       | 400 ++++++++++++++++++
>   drivers/gpu/drm/xe/xe_sysctrl_mailbox.h       |  33 ++
>   drivers/gpu/drm/xe/xe_sysctrl_mailbox_types.h |  40 ++
>   drivers/gpu/drm/xe/xe_sysctrl_types.h         |  32 ++
>   include/uapi/fwctl/fwctl.h                    |   1 +
>   include/uapi/fwctl/xe.h                       |  65 +++
>   22 files changed, 1301 insertions(+)
>   create mode 100644 drivers/gpu/drm/xe/abi/xe_sysctrl_abi.h
>   create mode 100644 drivers/gpu/drm/xe/regs/xe_sysctrl_regs.h
>   create mode 100644 drivers/gpu/drm/xe/xe_fwctl.c
>   create mode 100644 drivers/gpu/drm/xe/xe_fwctl.h
>   create mode 100644 drivers/gpu/drm/xe/xe_fwctl_types.h
>   create mode 100644 drivers/gpu/drm/xe/xe_sysctrl.c
>   create mode 100644 drivers/gpu/drm/xe/xe_sysctrl.h
>   create mode 100644 drivers/gpu/drm/xe/xe_sysctrl_fwctl.c
>   create mode 100644 drivers/gpu/drm/xe/xe_sysctrl_mailbox.c
>   create mode 100644 drivers/gpu/drm/xe/xe_sysctrl_mailbox.h
>   create mode 100644 drivers/gpu/drm/xe/xe_sysctrl_mailbox_types.h
>   create mode 100644 drivers/gpu/drm/xe/xe_sysctrl_types.h
>   create mode 100644 include/uapi/fwctl/xe.h
>

[-- Attachment #2: Type: text/html, Size: 4336 bytes --]