Re: [RFC v1 3/5] drm/xe/fwctl: Add Xe FWCTL type definitions

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Fri, Mar 20, 2026 at 12:25:31AM -0700, Anoop, Vijay wrote:
> From: Anoop Vijay <anoop.c.vijay@intel.com>
> 
> Add type definitions required for Xe FWCTL infrastructure. Introduce
> xe_fwctl_types.h to define core data structures used by driver,
> including Xe FWCTL device context, per-file context, and firmware
> operation hooks.
> 
> This patch adds type definitions only and does not introduce functional
> FWCTL logic.

I know it is counter intuitive. Most of the times splitting the work into
smaller patches helps to speed up the review. But in this case here it just
make it a lot harder to review.

A single patch like https://lore.kernel.org/intel-xe/20250429073804.972137-10-badal.nilawar@intel.com/
is probably the way to go.



> Signed-off-by: Anoop Vijay <anoop.c.vijay@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_fwctl_types.h | 52 +++++++++++++++++++++++++++++
>  1 file changed, 52 insertions(+)
>  create mode 100644 drivers/gpu/drm/xe/xe_fwctl_types.h
> 
> diff --git a/drivers/gpu/drm/xe/xe_fwctl_types.h b/drivers/gpu/drm/xe/xe_fwctl_types.h
> new file mode 100644
> index 000000000000..22498f2b2fd9
> --- /dev/null
> +++ b/drivers/gpu/drm/xe/xe_fwctl_types.h
> @@ -0,0 +1,52 @@
> +/* SPDX-License-Identifier: MIT */
> +/*
> + * Copyright © 2026 Intel Corporation
> + */
> +
> +#ifndef _XE_FWCTL_TYPES_H_
> +#define _XE_FWCTL_TYPES_H_
> +
> +#include <linux/fwctl.h>
> +
> +struct xe_device;
> +
> +/**
> + * struct xe_fwctl - Xe fwctl device context
> + * @fwctl: Base fwctl device
> + * @xe: Back-pointer to Xe device
> + *
> + * This structure wraps the fwctl subsystem device with Xe specific
> + * context.
> + */
> +struct xe_fwctl {
> +	struct fwctl_device fwctl;
> +	struct xe_device *xe;
> +};
> +
> +/**
> + * struct xe_fwctl_uctx - Per-FD context
> + * @uctx: Base fwctl context
> + *
> + * Per file-descriptor context for Xe fwctl operations.
> + */
> +struct xe_fwctl_uctx {
> +	struct fwctl_uctx uctx;
> +};
> +
> +/**
> + * struct xe_fw_ops - Per-firmware operations
> + * @name: Firmware name
> + * @rpc: Execute RPC
> + * @validate_scope: Validate RPC vs scope
> + *
> + * Operations table for each firmware type
> + */
> +struct xe_fw_ops {
> +	const char *name;
> +	void *(*rpc)(struct xe_device *xe, enum fwctl_rpc_scope scope,
> +		     void *in, size_t in_len, size_t *out_len);
> +	bool (*validate_scope)(void *in, size_t in_len,
> +			       enum fwctl_rpc_scope scope);
> +};
> +
> +#endif
> -- 
> 2.43.0
>