Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/devcoredump: Drop a FIXME in devcoredump
@ 2026-05-12  5:55 Shekhar Chauhan
  2026-05-12  7:17 ` Vivekanandan, Balasubramani
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Shekhar Chauhan @ 2026-05-12  5:55 UTC (permalink / raw)
  To: intel-xe; +Cc: shekhar.chauhan, balasubramani.vivekanandan

The FIXME says that xe_engine_snapshot_print.. is accessing persistent
driver data, unlike what the FIXME says that it does. Drop the FIXME
since the current code is not going to access the hardware while
dumping.
More details about this patch:
https://patchwork.freedesktop.org/patch/703884/?series=161407&rev=1
The starting two feedbacks make sense and the original patch is wrong
in adding those changes, but the last feedback is the one which
highlights the point.

Signed-off-by: Shekhar Chauhan <shekhar.chauhan@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_capture.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_capture.c b/drivers/gpu/drm/xe/xe_guc_capture.c
index bc49e40165a3..21f7caf9ea08 100644
--- a/drivers/gpu/drm/xe/xe_guc_capture.c
+++ b/drivers/gpu/drm/xe/xe_guc_capture.c
@@ -1841,12 +1841,6 @@ void xe_engine_snapshot_print(struct xe_hw_engine_snapshot *snapshot, struct drm
 		   str_yes_no(snapshot->kernel_reserved));
 
 	for (type = GUC_STATE_CAPTURE_TYPE_GLOBAL; type < GUC_STATE_CAPTURE_TYPE_MAX; type++) {
-		/*
-		 * FIXME: During devcoredump print we should avoid accessing the
-		 * driver pointers for gt or engine. Printing should be done only
-		 * using the snapshot captured. Here we are accessing the gt
-		 * pointer. It should be fixed.
-		 */
 		list = xe_guc_capture_get_reg_desc_list(gt, GUC_CAPTURE_LIST_INDEX_PF, type,
 							capture_class, false);
 		snapshot_print_by_list_order(snapshot, p, type, list);
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-05-12 20:20 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-12  5:55 [PATCH] drm/xe/devcoredump: Drop a FIXME in devcoredump Shekhar Chauhan
2026-05-12  7:17 ` Vivekanandan, Balasubramani
2026-05-12  8:57   ` Shekhar Chauhan
2026-05-12 10:23     ` Vivekanandan, Balasubramani
2026-05-12 10:07 ` ✓ CI.KUnit: success for " Patchwork
2026-05-12 11:24 ` ✓ Xe.CI.BAT: " Patchwork
2026-05-12 20:20 ` ✓ Xe.CI.FULL: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox