Re: [PATCH v4 26/32] drm/xe/pcode: Report 'timeout, retrying' error using SIGID

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, Aug 13, 2026 at 09:46:32AM -0700, Umesh Nerlige Ramappa wrote:
> On Wed, Aug 12, 2026 at 09:14:42PM +0200, Michal Wajdeczko wrote:
> > Report 'timeout, retrying with preemption disabled' error using
> > xe_log_err() helper.
> > 
> > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Riana Tauro <riana.tauro@intel.com>
> > Cc: Aravind Iddamsetty <aravind.iddamsetty@intel.com>
> > Cc: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
> > ---
> > drivers/gpu/drm/xe/xe_pcode.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/xe/xe_pcode.c b/drivers/gpu/drm/xe/xe_pcode.c
> > index 014632e11338..14b13a11d1d6 100644
> > --- a/drivers/gpu/drm/xe/xe_pcode.c
> > +++ b/drivers/gpu/drm/xe/xe_pcode.c
> > @@ -218,8 +218,7 @@ int xe_pcode_request(struct xe_tile *tile, u32 mbox, u32 request,
> > 	 * requests, and for any quirks of the PCODE firmware that delays
> > 	 * the request completion.
> > 	 */
> > -	drm_err(&tile_to_xe(tile)->drm,
> > -		"PCODE timeout, retrying with preemption disabled\n");
> > +	xe_log_err(tile, PCODE, ret, "timeout, retrying with preemption disabled\n");
> > 	preempt_disable();
> > 	ret = pcode_try_request(tile, mbox, request, reply_mask, reply, &status,
> > 				true, 50 * 1000, true);
> 
> + Badal
> 
> Should we report the drm_err before retrying?

agreed. This should be an info at this point...

> 
> Should we add a new log to report a failure after retry?

right, and an error after that if not already there...

But this can be done as a follow-up. Don't block the conversion imho

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> 
> Thanks,
> Umesh
> 
> > -- 2.47.1
> >