Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Matthew Auld" <matthew.auld@intel.com>,
	intel-xe@lists.freedesktop.org,
	"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 5/5] drm/xe/vram: add early VRAM health check
Date: Fri, 28 Aug 2026 12:58:15 -0700	[thread overview]
Message-ID: <apHoVwMsJtrSDIVb@gsse-cloud1.jf.intel.com> (raw)
In-Reply-To: <CAHk-=wg4W6rPEb_gEJVUSuOkhv32NDfXo2=V9gNGL_ACz3PQ1A@mail.gmail.com>

On Fri, Aug 28, 2026 at 09:13:07AM -0700, Linus Torvalds wrote:
> On Fri, 28 Aug 2026 at 08:14, Matthew Auld <matthew.auld@intel.com> wrote:
> >
> > With the fix from Linus, this goes away:
> 
> Side note: I told Greg KH that he should hold off on applying my fix
> to stable - because while it looked ObviouslyCorrect(tm) to me, I had
> only ever tested it on one single machine.
> 
> I'm taking it that the fix has now been tested much more widely and
> found no subtle issues? If so, I should let Greg know to go ahead and
> put it in the stable queue.
> 

I think it's OK to go ahead with backporting your patch to stable. I had
an open question about whether we wanted to implement the fix slightly
differently to avoid asserts triggering elsewhere in the code [1], but
Matt Auld has figured that part out while still carrying your fix
verbatim [2]. The asserts are also harmless and only appear in debug
builds. CI is passing as well [3], which should exercise this path
across several configurations.

We should discuss whether we want to backport [1] too.

Matt

[1] https://patchwork.freedesktop.org/patch/749151/?series=172984&rev=1
[2] https://patchwork.freedesktop.org/patch/749152/?series=172984&rev=1
[3] https://patchwork.freedesktop.org/series/172984/

>                     Linus

  reply	other threads:[~2026-08-28 19:58 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28 15:14 [PATCH 0/5] VRAM health check + CCS fix Matthew Auld
2026-08-28 15:14 ` [PATCH 1/5] drm/xe/migrate: support 4K PTEs for identity map Matthew Auld
2026-08-28 19:46   ` Matthew Brost
2026-09-01  8:48     ` Matthew Auld
2026-09-01 20:07       ` Matthew Brost
2026-08-28 15:14 ` [PATCH 2/5] drm/xe: Don't hand out the flat CCS storage as usable VRAM Matthew Auld
2026-08-28 15:14 ` [PATCH 3/5] drm/xe/vram: report FLAT_CCS base misalignment Matthew Auld
2026-08-28 20:10   ` Matthew Brost
2026-09-01  8:23     ` Matthew Auld
2026-09-01 20:10       ` Matthew Brost
2026-08-28 15:14 ` [PATCH 4/5] drm/xe: add force option for global invalidation Matthew Auld
2026-09-01 20:29   ` Matthew Brost
2026-08-28 15:14 ` [PATCH 5/5] drm/xe/vram: add early VRAM health check Matthew Auld
2026-08-28 16:13   ` Linus Torvalds
2026-08-28 19:58     ` Matthew Brost [this message]
2026-08-28 20:32       ` Linus Torvalds
2026-08-31 20:50         ` Matthew Brost
2026-08-28 16:37   ` Summers, Stuart
2026-09-01  8:33     ` Matthew Auld
2026-09-02  7:45       ` Matthew Brost
2026-09-02 20:34       ` Summers, Stuart
2026-09-03  9:57         ` Matthew Auld
2026-08-28 15:21 ` ✓ CI.KUnit: success for VRAM health check + CCS fix Patchwork
2026-08-28 15:58 ` ✓ Xe.CI.BAT: " Patchwork
2026-08-28 17:06 ` ✓ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apHoVwMsJtrSDIVb@gsse-cloud1.jf.intel.com \
    --to=matthew.brost@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox