Re: [PATCH v3 5/5] drm/xe/ras: Move xe_ras_process_errors() to xe_ras

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Mon, Sep 07, 2026 at 02:04:40PM +0530, Raag Jadav wrote:
> With xe_wedge_fini() now moved to xe_wedge and registered as part of
> xe_device_probe_early(), it is safe to move xe_ras_process_errors() back
> to xe_ras where it belongs. This essentially reverts commit 20bc4883c7c0
> ("drm/xe/ras: Fix boot-time ras error processing") which was added to
> prevent PM reference leak in case of early wedging in probe sequence.
> 
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_device.c | 7 -------
>  drivers/gpu/drm/xe/xe_ras.c    | 7 +++++++
>  2 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index 12279ed27629..8b0ea8a48d57 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -1148,13 +1148,6 @@ int xe_device_probe(struct xe_device *xe)
>  
>  	detect_preproduction_hw(xe);
>  
> -	/*
> -	 * Process and log any errors detected by hardware. Possible results can
> -	 * include declaring the device as wedged, which must be done only after
> -	 * xe_wedge_fini() is registered.
> -	 */
> -	xe_ras_process_errors(xe);
> -
>  	err = devm_add_action_or_reset(xe->drm.dev, xe_device_sanitize, xe);
>  	if (err)
>  		goto err_unregister_display;
> diff --git a/drivers/gpu/drm/xe/xe_ras.c b/drivers/gpu/drm/xe/xe_ras.c
> index 2e8eb8856f97..abf4800ff1e3 100644
> --- a/drivers/gpu/drm/xe/xe_ras.c
> +++ b/drivers/gpu/drm/xe/xe_ras.c
> @@ -933,6 +933,13 @@ void xe_ras_init(struct xe_device *xe)
>  	if (IS_ENABLED(CONFIG_PCIEAER))
>  		ras_usp_aer_init(xe);
>  
> +	/*
> +	 * During probe, process and log any errors detected by firmware while the driver was not
> +	 * loaded. Critical errors such as Punit and CSC are reported through Pcode init failure,
> +	 * causing the driver to enter survivability mode.
> +	 */
> +	xe_ras_process_errors(xe);
> +
>  	ret = devm_device_add_group(xe->drm.dev, &gpu_health_group);
>  	if (ret)
>  		xe_err(xe, "Failed to create GPU health sysfs, err=%d\n", ret);
> -- 
> 2.43.0
>