Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] drm/xe: Support different GuCs per GT
@ 2025-03-07 18:13 Lucas De Marchi
  2025-03-07 18:13 ` [PATCH 1/2] drm/xe/uc: Remove static from loop variable Lucas De Marchi
                   ` (10 more replies)
  0 siblings, 11 replies; 15+ messages in thread
From: Lucas De Marchi @ 2025-03-07 18:13 UTC (permalink / raw)
  To: intel-xe; +Cc: Lucas De Marchi, John Harrison, Matt Roper

This is an alternative approach to what John sent at
https://lore.kernel.org/intel-xe/20250303195215.1046192-1-John.C.Harrison@Intel.com/

Main thing is not making the name of the firmware magic, depending on
part of starting with "g" or "m". So here I add the gt type in a
pahole-friendly way and use it in the tables.

Tested on BMG with the following table, just for tests:

	fw_def(PANTHERLAKE,     GT_TYPE_ANY,    mmp_ver(xe,     guc,    ptl,    70, 38, 1))     \
	fw_def(BATTLEMAGE,      GT_TYPE_MEDIA,  mmp_ver(xe,     guc,    bmg,    70, 40, 2))     \
	fw_def(BATTLEMAGE,      GT_TYPE_ANY,    major_ver(xe,   guc,    bmg,    70, 29, 2))     \
	...

And with that I get (pasting just the relevant parts:

	xe 0000:03:00.0: [drm] Using GuC firmware from xe/bmg_guc_70.bin version 70.36.0
	xe 0000:03:00.0: [drm:xe_guc_ct_enable [xe]] GT0: GuC CT communication channel enabled
	xe 0000:03:00.0: [drm] Using GuC firmware from xe/bmg_guc_70.40.2.bin version 70.40.2
	xe 0000:03:00.0: [drm:xe_guc_ct_enable [xe]] GT1: GuC CT communication channel enabled

Something that we could also discuss is getting rid of the macro
indirections and just type the name of the file. Once upon a time we
needed to use different dirs, but now this only matters per for the file
name. The only repetition would be probably on the version. But I think
it would make it clearer what files we expect to have without the macro
indirections.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
Lucas De Marchi (2):
      drm/xe/uc: Remove static from loop variable
      drm/xe/uc: Add support for different firmware files on each GT

 drivers/gpu/drm/xe/xe_uc_fw.c | 102 ++++++++++++++++++++++++------------------
 1 file changed, 59 insertions(+), 43 deletions(-)
---
base-commit: 2c4fba1d065427efba4aaed5f80f4664c9f4a729
change-id: 20250307-xe-per-gt-fw-4938dff9b339

Best regards,
-- 
Lucas De Marchi <lucas.demarchi@intel.com>


^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2025-03-21 18:42 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-07 18:13 [PATCH 0/2] drm/xe: Support different GuCs per GT Lucas De Marchi
2025-03-07 18:13 ` [PATCH 1/2] drm/xe/uc: Remove static from loop variable Lucas De Marchi
2025-03-20 20:08   ` John Harrison
2025-03-07 18:13 ` [PATCH 2/2] drm/xe/uc: Add support for different firmware files on each GT Lucas De Marchi
2025-03-20 20:09   ` John Harrison
2025-03-07 20:01 ` ✓ CI.Patch_applied: success for drm/xe: Support different GuCs per GT Patchwork
2025-03-07 20:01 ` ✗ CI.checkpatch: warning " Patchwork
2025-03-07 20:02 ` ✓ CI.KUnit: success " Patchwork
2025-03-07 20:19 ` ✓ CI.Build: " Patchwork
2025-03-07 20:21 ` ✓ CI.Hooks: " Patchwork
2025-03-07 20:23 ` ✓ CI.checksparse: " Patchwork
2025-03-07 20:45 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-09  0:37 ` ✗ Xe.CI.Full: failure " Patchwork
2025-03-20 20:09 ` [PATCH 0/2] " John Harrison
2025-03-21 18:42   ` Lucas De Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox