Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 00/13] Cleanup error handling on probe
@ 2025-02-07 22:19 Lucas De Marchi
  2025-02-07 22:19 ` [PATCH v3 01/13] drm/xe: Fix xe_display_fini() calls Lucas De Marchi
                   ` (20 more replies)
  0 siblings, 21 replies; 39+ messages in thread
From: Lucas De Marchi @ 2025-02-07 22:19 UTC (permalink / raw)
  To: intel-xe
  Cc: Rodrigo Vivi, Francois Dugast, Matthew Auld,
	Daniele Ceraolo Spurio, Lucas De Marchi

Mixing style with goto and devm_add_action_or_reset() is very confusing
and error prone. Clean that up. The only missing one is one of the
display calls, but that can be done in parallel to the review of these
first patches.

This received limited load/unload tests on LNL and BMG and should have a
good coverage.

v2:
  - Add callback-based removed to overcome issue with gsc/mei
    integration: it can't be removed with devm.
  - More cleanups, adding drm_dev_unplug in the right place, fixing
    hwmon, pmu and oa
v3:
  - Drop the hwmon patch changing the mutex destroy: we can use drmm_
    only if we also migrate the hwmon allocation to drmm_, but
    there isn't much reason to do so

Lucas De Marchi (13):
  drm/xe: Fix xe_display_fini() calls
  drm/xe: Fix error handling in xe_irq_install()
  drm/xe: Fix xe_tile_init_noalloc() error propagation
  drm/xe: Stop ignoring errors from xe_ttm_stolen_mgr_init()
  drm/xe: Remove leftover pxp comment
  drm/xe: Add callback support for driver remove
  drm/xe: Cleanup unwind of gt initialization
  drm/xe: Cleanup extra calls to xe_hw_fence_irq_finish()
  drm/xe: Move oa fini to xe_oa
  drm/xe: Move drm_dev_unplug() out of display function
  drm/xe/oa: Handle errors in xe_oa_register()
  drm/xe: Fail probe if xe_pmu_register() fails
  drm/xe/hwmon: Stop ignoring errors on probe

 drivers/gpu/drm/xe/display/xe_display.c      |  22 +--
 drivers/gpu/drm/xe/display/xe_display.h      |   2 -
 drivers/gpu/drm/xe/xe_device.c               | 133 ++++++++++++-------
 drivers/gpu/drm/xe/xe_device.h               |   4 +
 drivers/gpu/drm/xe/xe_device_remove_action.h |  24 ++++
 drivers/gpu/drm/xe/xe_device_types.h         |  15 +++
 drivers/gpu/drm/xe/xe_gsc.c                  |   9 --
 drivers/gpu/drm/xe/xe_gsc.h                  |   1 -
 drivers/gpu/drm/xe/xe_gsc_proxy.c            |  63 +++++----
 drivers/gpu/drm/xe/xe_gsc_proxy.h            |   1 -
 drivers/gpu/drm/xe/xe_gsc_types.h            |   3 +
 drivers/gpu/drm/xe/xe_gt.c                   |  50 +++----
 drivers/gpu/drm/xe/xe_gt.h                   |   1 -
 drivers/gpu/drm/xe/xe_hwmon.c                |  31 ++---
 drivers/gpu/drm/xe/xe_hwmon.h                |   4 +-
 drivers/gpu/drm/xe/xe_irq.c                  |  14 +-
 drivers/gpu/drm/xe/xe_oa.c                   |  78 +++++------
 drivers/gpu/drm/xe/xe_oa.h                   |   4 +-
 drivers/gpu/drm/xe/xe_pci.c                  |   4 +-
 drivers/gpu/drm/xe/xe_tile.c                 |   4 +-
 drivers/gpu/drm/xe/xe_ttm_stolen_mgr.c       |  17 +--
 drivers/gpu/drm/xe/xe_ttm_stolen_mgr.h       |   2 +-
 drivers/gpu/drm/xe/xe_uc.c                   |  13 --
 drivers/gpu/drm/xe/xe_uc.h                   |   1 -
 24 files changed, 267 insertions(+), 233 deletions(-)
 create mode 100644 drivers/gpu/drm/xe/xe_device_remove_action.h

-- 
2.48.1


^ permalink raw reply	[flat|nested] 39+ messages in thread

end of thread, other threads:[~2025-02-12  5:45 UTC | newest]

Thread overview: 39+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-07 22:19 [PATCH v3 00/13] Cleanup error handling on probe Lucas De Marchi
2025-02-07 22:19 ` [PATCH v3 01/13] drm/xe: Fix xe_display_fini() calls Lucas De Marchi
2025-02-10 17:56   ` Ghimiray, Himal Prasad
2025-02-10 19:08     ` Ghimiray, Himal Prasad
2025-02-07 22:19 ` [PATCH v3 02/13] drm/xe: Fix error handling in xe_irq_install() Lucas De Marchi
2025-02-10 17:58   ` Ghimiray, Himal Prasad
2025-02-07 22:19 ` [PATCH v3 03/13] drm/xe: Fix xe_tile_init_noalloc() error propagation Lucas De Marchi
2025-02-10  5:52   ` Upadhyay, Tejas
2025-02-10 17:59   ` Ghimiray, Himal Prasad
2025-02-07 22:19 ` [PATCH v3 04/13] drm/xe: Stop ignoring errors from xe_ttm_stolen_mgr_init() Lucas De Marchi
2025-02-10 18:05   ` Ghimiray, Himal Prasad
2025-02-07 22:19 ` [PATCH v3 05/13] drm/xe: Remove leftover pxp comment Lucas De Marchi
2025-02-07 22:19 ` [PATCH v3 06/13] drm/xe: Add callback support for driver remove Lucas De Marchi
2025-02-10 17:41   ` Rodrigo Vivi
2025-02-12  5:45     ` Lucas De Marchi
2025-02-07 22:19 ` [PATCH v3 07/13] drm/xe: Cleanup unwind of gt initialization Lucas De Marchi
2025-02-10 18:54   ` Ghimiray, Himal Prasad
2025-02-07 22:19 ` [PATCH v3 08/13] drm/xe: Cleanup extra calls to xe_hw_fence_irq_finish() Lucas De Marchi
2025-02-10 18:56   ` Ghimiray, Himal Prasad
2025-02-07 22:19 ` [PATCH v3 09/13] drm/xe/oa: Move fini to xe_oa Lucas De Marchi
2025-02-07 22:19 ` [PATCH v3 10/13] drm/xe: Move drm_dev_unplug() out of display function Lucas De Marchi
2025-02-10  5:44   ` Upadhyay, Tejas
2025-02-07 22:19 ` [PATCH v3 11/13] drm/xe/oa: Handle errors in xe_oa_register() Lucas De Marchi
2025-02-07 22:19 ` [PATCH v3 12/13] drm/xe/pmu: Fail probe if xe_pmu_register() fails Lucas De Marchi
2025-02-10 11:17   ` Upadhyay, Tejas
2025-02-10 19:00   ` Ghimiray, Himal Prasad
2025-02-07 22:19 ` [PATCH v3 13/13] drm/xe/hwmon: Stop ignoring errors on probe Lucas De Marchi
2025-02-07 22:31   ` Raag Jadav
2025-02-10  5:31   ` Nilawar, Badal
2025-02-10 15:15     ` Lucas De Marchi
2025-02-10 16:54       ` Nilawar, Badal
2025-02-07 23:42 ` ✓ CI.Patch_applied: success for Cleanup error handling on probe (rev3) Patchwork
2025-02-07 23:42 ` ✗ CI.checkpatch: warning " Patchwork
2025-02-07 23:43 ` ✓ CI.KUnit: success " Patchwork
2025-02-08  0:00 ` ✓ CI.Build: " Patchwork
2025-02-08  0:02 ` ✓ CI.Hooks: " Patchwork
2025-02-08  0:03 ` ✓ CI.checksparse: " Patchwork
2025-02-10  6:05 ` ✓ Xe.CI.BAT: " Patchwork
2025-02-10  6:55 ` ✗ Xe.CI.Full: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox