Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/mocs: Check that MOCS table.ops is assigned
@ 2024-06-26 21:12 Matt Roper
  2024-06-26 21:31 ` Michal Wajdeczko
                   ` (8 more replies)
  0 siblings, 9 replies; 11+ messages in thread
From: Matt Roper @ 2024-06-26 21:12 UTC (permalink / raw)
  To: intel-xe; +Cc: matthew.d.roper

When MOCS debugfs dumping was added in commit 9fbd0adbcbe8
("drm/xe/mocs: Add debugfs node to dump mocs"), a sanity check was added
to xe_mocs_dump() to ensure table.ops->dump is not a NULL pointer.  The
more common programmer mistake when adding MOCS enablement for new
platforms is to simply forget to assign anything to table.ops
altogether.  Extend the check to also cover a NULL table.ops and add a
WARN() so that CI will help us catch these mistakes when new platforms
are enabled in the future.

Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/xe/xe_mocs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_mocs.c b/drivers/gpu/drm/xe/xe_mocs.c
index de3f2d3f1b04..d43900d351f1 100644
--- a/drivers/gpu/drm/xe/xe_mocs.c
+++ b/drivers/gpu/drm/xe/xe_mocs.c
@@ -779,7 +779,7 @@ void xe_mocs_dump(struct xe_gt *gt, struct drm_printer *p)
 
 	flags = get_mocs_settings(xe, &table);
 
-	if (!table.ops->dump)
+	if (xe_gt_WARN_ON(gt, !table.ops || !table.ops->dump))
 		return;
 
 	xe_pm_runtime_get_noresume(xe);
-- 
2.45.0


^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2024-06-27 19:51 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-26 21:12 [PATCH] drm/xe/mocs: Check that MOCS table.ops is assigned Matt Roper
2024-06-26 21:31 ` Michal Wajdeczko
2024-06-27 19:51   ` Matt Roper
2024-06-26 22:37 ` ✓ CI.Patch_applied: success for " Patchwork
2024-06-26 22:38 ` ✓ CI.checkpatch: " Patchwork
2024-06-26 22:39 ` ✓ CI.KUnit: " Patchwork
2024-06-26 22:55 ` ✓ CI.Build: " Patchwork
2024-06-26 22:59 ` ✓ CI.Hooks: " Patchwork
2024-06-26 23:01 ` ✓ CI.checksparse: " Patchwork
2024-06-26 23:24 ` ✓ CI.BAT: " Patchwork
2024-06-27 10:33 ` ✗ CI.FULL: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox