Re: [PATCH v2 4/8] drm/xe/kunit: Add xe_kunit_helper_is_live_test()

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 08 May 2026, Gustavo Sousa <gustavo.sousa@intel.com> wrote:
> +/**
> + * xe_kunit_helper_is_live_test - Return true if @test is a live test.
> + * @test: the &kunit test
> + *
> + * Return: True for a live test and false otherwise.
> + */

Pardon me for being blunt, but I think this is the worst kind of
kernel-doc comment.

It doesn't provide any additional information to what the function name
and signature already convey (which is to say excellent job on naming
the function), but it fails to explain what "live test" means.

The extra bits of useful information people might need after seeing the
function xe_kunit_helper_is_live_test() in code are: What is a live
test, and what is it if it's not live? Dead?


BR,
Jani.

> +bool xe_kunit_helper_is_live_test(struct kunit *test)
> +{
> +	KUNIT_STATIC_STUB_REDIRECT(xe_kunit_helper_is_live_test, test);
> +	return false;
> +}

-- 
Jani Nikula, Intel