Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Mallesh, Koujalagi" <mallesh.koujalagi@intel.com>
To: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>,
	<intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH v5 01/12] drm/xe/log: Add VRAM, PAT, and HWMON DRIVER_HARDWARE components
Date: Thu, 8 Oct 2026 19:29:23 +0530	[thread overview]
Message-ID: <dd9856ae-a088-44fd-aca6-1fb3f2fea15e@intel.com> (raw)
In-Reply-To: <20261007211417.2093611-2-dnyaneshwar.bhadane@intel.com>


On 08-10-2026 02:44 am, Dnyaneshwar Bhadane wrote:
> Register new DRIVER_HARDWARE log components for hardware I/O subsystems
> that currently lack structured error reporting:
>
>    - VRAM (ID 6): Video RAM/Local Memory access and BAR visibility errors
>    - PAT (ID 7): Page Attribute Table programming errors
>    - HWMON (ID 8): Hardware monitor registration and sensor errors
>
> All three use IO_BUS as their default SIGID since they interact with
> hardware through MMIO or PCode register paths.
>
> Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
> ---
>   drivers/gpu/drm/xe/abi/xe_log_abi.h | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/abi/xe_log_abi.h b/drivers/gpu/drm/xe/abi/xe_log_abi.h
> index 526aadf85fe9..ef45c3a9b414 100644
> --- a/drivers/gpu/drm/xe/abi/xe_log_abi.h
> +++ b/drivers/gpu/drm/xe/abi/xe_log_abi.h
> @@ -151,6 +151,9 @@ enum xe_log_location_bits {
>   	define(DRIVER_HARDWARE, 3, GT, GT_TDR, "Graphics Technology")		\
>   	define(DRIVER_HARDWARE, 4, LMTT, IO_BUS, "LMEM Translation Table")	\
>   	define(DRIVER_HARDWARE, 5, MEMIRQ, IO_BUS, "Memory Based IRQ")		\
> +	define(DRIVER_HARDWARE, 6, VRAM, IO_BUS, "Local Memory")		\

Add Video Memory/Local Memory

With that

Reviewed-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>

> +	define(DRIVER_HARDWARE, 7, PAT, IO_BUS, "Page Attribute Table")		\
> +	define(DRIVER_HARDWARE, 8, HWMON, IO_BUS, "Hardware Monitoring")	\
>   	/* */									\
>   	define(DRIVER_FEATURE, 1, PF, SW, "SR-IOV Physical Function")		\
>   	define(DRIVER_FEATURE, 2, VF, SW, "SR-IOV Virtual Function")		\

  reply	other threads:[~2026-10-08 13:59 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07 21:14 [PATCH v5 00/12] drm/xe: Convert IO_BUS errors to structured xe_log API Dnyaneshwar Bhadane
2026-10-07 21:14 ` [PATCH v5 01/12] drm/xe/log: Add VRAM, PAT, and HWMON DRIVER_HARDWARE components Dnyaneshwar Bhadane
2026-10-08 13:59   ` Mallesh, Koujalagi [this message]
2026-10-07 21:14 ` [PATCH v5 02/12] drm/xe/ggtt: Report GGTT errors using structured logging Dnyaneshwar Bhadane
2026-10-07 21:14 ` [PATCH v5 03/12] drm/xe/hwmon: Report errors using structured xe_log API Dnyaneshwar Bhadane
2026-10-08 13:01   ` Mallesh, Koujalagi
2026-10-07 21:14 ` [PATCH v5 04/12] drm/xe/mmio: Report BAR mapping " Dnyaneshwar Bhadane
2026-10-07 21:14 ` [PATCH v5 05/12] drm/xe/memirq: Report " Dnyaneshwar Bhadane
2026-10-07 21:20   ` sashiko-bot
2026-10-07 21:14 ` [PATCH v5 06/12] drm/xe/reg_sr: Report save-restore " Dnyaneshwar Bhadane
2026-10-07 21:23   ` sashiko-bot
2026-10-08 13:45   ` Mallesh, Koujalagi
2026-10-07 21:14 ` [PATCH v5 07/12] drm/xe/pat: Return error from xe_pat_init_early() on unknown platform Dnyaneshwar Bhadane
2026-10-07 21:14 ` [PATCH v5 08/12] drm/xe/pat: Report missing PAT table using structured xe_log API Dnyaneshwar Bhadane
2026-10-07 21:14 ` [PATCH v5 09/12] drm/xe/pci: Report unknown GMDID versions " Dnyaneshwar Bhadane
2026-10-07 21:14 ` [PATCH v5 10/12] drm/xe/lmtt: Report invalidation errors " Dnyaneshwar Bhadane
2026-10-08 13:07   ` Mallesh, Koujalagi
2026-10-07 21:14 ` [PATCH v5 11/12] drm/xe/vram: Report tile vs device VRAM visibility errors Dnyaneshwar Bhadane
2026-10-08 13:25   ` Mallesh, Koujalagi
2026-10-09 10:42     ` Bhadane, Dnyaneshwar
2026-10-07 21:14 ` [PATCH v5 12/12] drm/xe/vram: Report VRAM errors using structured xe_log API Dnyaneshwar Bhadane
2026-10-07 21:19   ` sashiko-bot
2026-10-07 21:40 ` ✗ CI.checkpatch: warning for drm/xe: Convert IO_BUS errors to structured xe_log API (rev5) Patchwork
2026-10-07 21:42 ` ✓ CI.KUnit: success " Patchwork
2026-10-07 22:32 ` ✓ Xe.CI.BAT: " Patchwork
2026-10-08  2:59 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd9856ae-a088-44fd-aca6-1fb3f2fea15e@intel.com \
    --to=mallesh.koujalagi@intel.com \
    --cc=dnyaneshwar.bhadane@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox