Re: [PATCH v5 05/12] drm/xe/memirq: Report errors using structured xe_log API

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] xe: unused memirq_err macro left after xe_log_err conversion
--

commit 80879014db70d4e6f21e887b68845ca29011c158
Author: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>

    drm/xe/memirq: Report errors using structured xe_log API
    
    Replace memirq_err() calls with xe_log_err() using the MEMIRQ
    component tag for memory-based IRQ failures.

> diff --git a/drivers/gpu/drm/xe/xe_memirq.c b/drivers/gpu/drm/xe/xe_memirq.c
> index 9dfe965cb46ec..32b9f87a10ecf 100644
> --- a/drivers/gpu/drm/xe/xe_memirq.c
> +++ b/drivers/gpu/drm/xe/xe_memirq.c
[ ... ]
> @@ -232,7 +233,7 @@ static int memirq_alloc_pages(struct xe_memirq *memirq)
>  	return 0;
>  
>  out:
> -	memirq_err(memirq, "Failed to allocate memirq page (%pe)\n", ERR_PTR(err));
> +	xe_log_err(tile, MEMIRQ, err, "Failed to allocate memirq page\n");

[Severity: Low]
Is the definition of memirq_err() now completely unused?

Looking at drivers/gpu/drm/xe/xe_memirq.c, there is a macro definition that
appears to be orphaned by this conversion:

#define memirq_err(m, _fmt, ...)	memirq_printk(m, err, _fmt, ##__VA_ARGS__)

Should this macro be removed as well since all callers have been updated to use
xe_log_err()?

>  	return err;
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261007211417.2093611-1-dnyaneshwar.bhadane@intel.com?part=5