From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/display: add intel_display_device_present()
Date: Tue, 09 Sep 2025 11:22:41 +0300 [thread overview]
Message-ID: <de15cab0effcd479aac174af603a24d4ae3d2a8a@intel.com> (raw)
In-Reply-To: <aLrJLuvHzyW-kjT-@intel.com>
On Fri, 05 Sep 2025, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, Sep 03, 2025 at 12:04:08PM +0300, Jani Nikula wrote:
>> Add a proper function for display && HAS_DISPLAY(display) to hide
>> indirect struct intel_display access via the macro from a number of
>> places outside of display. This makes struct intel_display * an opaque
>> pointer in these places. All HAS_DISPLAY() usage is now constrained
>> within display.
>
> Looks all right. Though a lot of code where this gets used really
> shouldn't exist outside the display code in the first place. But
> cleaning all that up is going to take some effort.
Agreed.
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Pushed to din, thanks for the review.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2025-09-09 8:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 9:04 [PATCH] drm/i915/display: add intel_display_device_present() Jani Nikula
2025-09-03 9:32 ` ✓ CI.KUnit: success for drm/i915/display: add intel_display_device_present() (rev3) Patchwork
2025-09-03 16:19 ` ✗ Xe.CI.Full: failure " Patchwork
2025-09-05 11:27 ` [PATCH] drm/i915/display: add intel_display_device_present() Ville Syrjälä
2025-09-09 8:22 ` Jani Nikula [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-05-27 11:46 Jani Nikula
2025-05-27 19:14 ` Rodrigo Vivi
2025-05-30 9:38 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de15cab0effcd479aac174af603a24d4ae3d2a8a@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox