Re: [PATCH v4 00/20] MADVISE FOR XE

["Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>]

On 29-07-2025 10:11, Matthew Brost wrote:
> On Fri, Jun 13, 2025 at 06:25:38PM +0530, Himal Prasad Ghimiray wrote:
>> Provides a user API to assign attributes like pat_index, atomic
>> operation type, and preferred location for SVM ranges.
>> The Kernel Mode Driver (KMD) may split existing VMAs to cover input
>> ranges, assign user-provided attributes, and invalidate existing PTEs so
>> that the next page fault/prefetch can use the new attributes.
>>
>> -v4:
>> fix atomic policies
>> fix attribute copy
>> address review comments
>>
> 
> We are getting real close to this being fully reviewed, so I think we
> need a UMD PR for this ASAP.

Sure

> 
> Matt
> 
>> Himal Prasad Ghimiray (20):
>>    Introduce drm_gpuvm_sm_map_ops_flags enums for sm_map_ops
>>    drm/xe/uapi: Add madvise interface
>>    drm/xe/vm: Add attributes struct as member of vma
>>    drm/xe/vma: Move pat_index to vma attributes
>>    drm/xe/vma: Modify new_vma to accept struct xe_vma_mem_attr as
>>      parameter
>>    drm/gpusvm: Make drm_gpusvm_for_each_* macros public
>>    drm/xe/svm: Split system allocator vma incase of madvise call
>>    drm/xe/svm: Add xe_svm_ranges_zap_ptes_in_range() for PTE zapping
>>    drm/xe: Implement madvise ioctl for xe
>>    drm/xe/vm: Add an identifier for madvise in xe_vma_ops
>>    drm/xe: Allow CPU address mirror VMA unbind with gpu bindings for
>>      madvise
>>    drm/xe/svm : Add svm ranges migration policy on atomic access
>>    drm/xe/madvise: Update migration policy based on preferred location
>>    drm/xe/svm: Support DRM_XE_SVM_ATTR_PAT memory attribute
>>    drm/xe/uapi: Add flag for consulting madvise hints on svm prefetch
>>    drm/xe/svm: Consult madvise preferred location in prefetch
>>    drm/xe/bo: Add attributes field to xe_bo
>>    drm/xe/bo: Update atomic_access attribute on madvise
>>    drm/xe/uapi: Add UAPI for querying VMA count and memory attributes
>>    drm/xe/madvise: Skip vma invalidation if mem attr are unchanged
>>
>>   drivers/gpu/drm/drm_gpusvm.c           | 122 ++------
>>   drivers/gpu/drm/drm_gpuvm.c            |  93 ++++--
>>   drivers/gpu/drm/nouveau/nouveau_uvmm.c |   1 +
>>   drivers/gpu/drm/xe/Makefile            |   1 +
>>   drivers/gpu/drm/xe/xe_bo.c             |  21 +-
>>   drivers/gpu/drm/xe/xe_bo_types.h       |   8 +
>>   drivers/gpu/drm/xe/xe_device.c         |   3 +
>>   drivers/gpu/drm/xe/xe_gt_pagefault.c   |   2 +-
>>   drivers/gpu/drm/xe/xe_pt.c             |  25 +-
>>   drivers/gpu/drm/xe/xe_svm.c            | 110 ++++++-
>>   drivers/gpu/drm/xe/xe_svm.h            |  22 ++
>>   drivers/gpu/drm/xe/xe_tile.h           |  18 ++
>>   drivers/gpu/drm/xe/xe_vm.c             | 295 +++++++++++++++++--
>>   drivers/gpu/drm/xe/xe_vm.h             |   6 +-
>>   drivers/gpu/drm/xe/xe_vm_madvise.c     | 389 +++++++++++++++++++++++++
>>   drivers/gpu/drm/xe/xe_vm_madvise.h     |  15 +
>>   drivers/gpu/drm/xe/xe_vm_types.h       |  38 ++-
>>   include/drm/drm_gpusvm.h               |  70 +++++
>>   include/drm/drm_gpuvm.h                |  25 +-
>>   include/uapi/drm/xe_drm.h              | 253 ++++++++++++++++
>>   20 files changed, 1368 insertions(+), 149 deletions(-)
>>   create mode 100644 drivers/gpu/drm/xe/xe_vm_madvise.c
>>   create mode 100644 drivers/gpu/drm/xe/xe_vm_madvise.h
>>
>> -- 
>> 2.34.1
>>