Re: [PATCH v11 1/5] drm/xe/guc: Prepare GuC register list and update ADS size for error capture

["Dong, Zhanjun" <zhanjun.dong@intel.com>]

As guc double-load will be changed in the future, the comment will be 
removed to avoid misleading.

Regards,
Zhanjun Dong

On 2024-06-28 12:05 p.m., Lucas De Marchi wrote:
> On Mon, Jun 24, 2024 at 02:54:00PM GMT, Zhanjun Dong wrote:
>> @@ -398,6 +401,12 @@ int xe_guc_ads_init(struct xe_guc_ads *ads)
>>     struct xe_bo *bo;
>>
>>     ads->golden_lrc_size = calculate_golden_lrc_size(ads);
>> +    /*
>> +     * At time of ads init, hwconfig was not loaded, engine info like
>> +     * engine mask is not ready.
> 
> pass by comment: this never really mattered and was just artificially
> done due to delaying the engine_mask initialization. engine_mask comes
> from fuses and possible engines from platform, not from hwconfig.
> This is gone since commit d69c3d4b5382 ("drm/xe/ads: Use flexible-array")
> 
> For ADS initialization I believe we still want size 0 when loading guc
> for hwconfig and only calculate it when it's for real. This guc double-load
> is something we may get rid of in future.
> 
> Lucas De Marchi