Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Dong, Zhanjun" <zhanjun.dong@intel.com>
To: "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>,
	"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH v11 1/5] drm/xe/guc: Prepare GuC register list and update ADS size for error capture
Date: Fri, 28 Jun 2024 16:05:53 -0400	[thread overview]
Message-ID: <fccf45bd-1188-4c1c-8bb6-8b8cff20a594@intel.com> (raw)
In-Reply-To: <81cfebe69df10f62992cac555ca85801b63afa27.camel@intel.com>



On 2024-06-26 8:13 p.m., Teres Alexis, Alan Previn wrote:
> 
> Hi Zhanjun, i see you addressed everything i commented on in rev8 as
> well as everything that Michal commented on in rev9 (except one which
> wasnt an issue but was by design).
> 
> Although I still found couple of the issues which are not nits, they
> are very trivial so i'm giving a conditional RB for the comments i
> prefixed with "rb-condition".
> 
> Reviewed-by: Alan Previn <alan.previn.teres.alexis@intel.com>
> 

Thanks, will post next rev as rb-condition suggested.

  reply	other threads:[~2024-06-28 20:06 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-24 21:53 [PATCH v11 0/5] drm/xe/guc: Add GuC based register capture for error capture Zhanjun Dong
2024-06-24 21:54 ` [PATCH v11 1/5] drm/xe/guc: Prepare GuC register list and update ADS size " Zhanjun Dong
2024-06-27  0:13   ` Teres Alexis, Alan Previn
2024-06-28 20:05     ` Dong, Zhanjun [this message]
2024-06-27 18:45   ` Michal Wajdeczko
2024-06-28 23:00     ` Dong, Zhanjun
2024-06-28 16:05   ` Lucas De Marchi
2024-06-28 20:06     ` Dong, Zhanjun
2024-06-28 20:17       ` Lucas De Marchi
2024-06-24 21:54 ` [PATCH v11 2/5] drm/xe/guc: Add XE_LP steered register lists Zhanjun Dong
2024-06-24 21:54 ` [PATCH v11 3/5] drm/xe/guc: Add capture size check in GuC log buffer Zhanjun Dong
2024-06-27 18:56   ` Michal Wajdeczko
2024-06-28 23:15     ` Dong, Zhanjun
2024-07-03  3:10   ` Teres Alexis, Alan Previn
2024-07-04 20:27     ` Dong, Zhanjun
2024-06-24 21:54 ` [PATCH v11 4/5] drm/xe/guc: Extract GuC error capture lists Zhanjun Dong
2024-06-28  0:01   ` Teres Alexis, Alan Previn
2024-06-24 21:54 ` [PATCH v11 5/5] drm/xe/guc: Plumb GuC-capture into dev coredump Zhanjun Dong
2024-06-24 21:59 ` ✓ CI.Patch_applied: success for drm/xe/guc: Add GuC based register capture for error capture (rev11) Patchwork
2024-06-24 21:59 ` ✗ CI.checkpatch: warning " Patchwork
2024-06-24 22:00 ` ✓ CI.KUnit: success " Patchwork
2024-06-24 22:12 ` ✓ CI.Build: " Patchwork
2024-06-24 22:14 ` ✗ CI.Hooks: failure " Patchwork
2024-06-24 22:16 ` ✓ CI.checksparse: success " Patchwork
2024-06-24 22:39 ` ✓ CI.BAT: " Patchwork
2024-06-25  0:52 ` ✗ CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fccf45bd-1188-4c1c-8bb6-8b8cff20a594@intel.com \
    --to=zhanjun.dong@intel.com \
    --cc=alan.previn.teres.alexis@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox