Re: [PATCH v2 1/2] drm/xe: Fix Prevent VFs from exposing the CCS mode sysfs file

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 1/29/2026 6:22 PM, Nareshkumar Gollakoti wrote:
> Skipping creation of sysfs file in VF Mode to ensure VFs do not expose
> CCS mode changes
> 
> Fixes: f3bc5bb4d53d2 ("drm/xe: Allow userspace to configure CCS mode")

shouldn't this be

Fixes: 97fedf015cd9 ("drm/xe: Use fixed CCS mode when running in SR-IOV mode")

or since it wasn't really broken, maybe we need no Fixes tag at all?

adding maintainers to confirm

> Signed-off-by: Nareshkumar Gollakoti <naresh.kumar.g@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_gt_ccs_mode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt_ccs_mode.c b/drivers/gpu/drm/xe/xe_gt_ccs_mode.c
> index 50fffc9ebf62..e146e00b0ca2 100644
> --- a/drivers/gpu/drm/xe/xe_gt_ccs_mode.c
> +++ b/drivers/gpu/drm/xe/xe_gt_ccs_mode.c
> @@ -191,7 +191,7 @@ int xe_gt_ccs_mode_sysfs_init(struct xe_gt *gt)
>  	struct xe_device *xe = gt_to_xe(gt);
>  	int err;
>  
> -	if (!xe_gt_ccs_mode_enabled(gt))
> +	if (!xe_gt_ccs_mode_enabled(gt) || IS_SRIOV_VF(xe))
>  		return 0;

I guess there should be no users on VFs that would like to read it back
(as CCS mode was/is always fixed/const for VFs), so this fine,

Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

>  
>  	err = sysfs_create_files(gt->sysfs, gt_ccs_mode_attrs);