[PATCH v9 00/14] drm/xe/hwmon: Update hwmon thermal mailbox

[PATCH v9 00/14] drm/xe/hwmon: Update hwmon thermal mailbox

[Karthik Poosa]

This series adds CRI-specific temperature sensor handling to the Xe
hwmon implementation and fixes couple of hwmon issues.

CRI platforms may report unavailable temperature sensors and support
a variable number of VRAM temperature channels depending on platform
configuration. This series adds the required sensor presence checks and
uses platform-reported thermal configuration data to expose only valid
temperature-related hwmon attributes.

The series also corrects the telemetry group selection used for memory
controller temperature reporting.

v2:
 - Address review comments from Sashiko, Badal and Raag.
 - Enable IEEE 754 temperature decoding for MMIO temperature registers.
  - Split sensor validity check into mailbox vs MMIO handling; add
    is_temp_available() / is_temp_is_visible().
 - Temporarily disable memory controller and PCIe temperatures on CRI.

v3:
  - Detect unavailable temperature sensors: rephrase a debug log.
  - Decode mailbox temperatures as 8-bit sign-magnitude values instead of
    s8.
  - Use VRAM temperature sensor count from thermal config on CRI: address
    review comments from sashiko-bot@kernel.org and Rodrigo.
  - Decode CRI temperature registers as IEEE-754: reject temperatures that
    overflow long on 32-bit systems.

v4:
  - Address review comments and issues report from Rodrigo and
    sashiko-bot@kernel.org.
  - Decode mailbox temperatures as 8-bit sign-magnitude values.
  - Cache sensor availability during registration.
  - Enable memory controller and pcie sensors for CRI.
  - Derive the VRAM channel count from the CRI MSU enable mask.
  - Use CRI-specific package and VRAM temperature registers.
  - Handle the CRI memory controller and pcie sensor offsets as per CRI.

v5:
 - Remove the unintended IGT prefix from the patch titles.

v6:
 - Address issues reported by sashiko-bot@kernel.org.
 - Add VRAM individual channel CRI_VRAM_TEMPERATURE_N register for CRI.

v7:
 - Address review comments from Rodrigo.
    - Use ret instead of count in patch 1.
    - Return true for platforms without temperature sentinels support.
    - Rename has_mbx_temp_sentinel to has_temp_sentinel.
    - Add a info flag for pcie sensor offset.
    - Simplify temperature channels config.

v8:
 - Address review comment from Sashiko.
 - Revert the unconditional validation of temperature readings on
   non-sentinel platforms.
   This avoids creating spurious VRAM temperature channels when the
   corresponding sensors are unavailable.

v9:
 - Address review comment from Rodrigo.
 - Use helper for pcie sensor offset instead of info field.

Karthik Poosa (14):
  drm/xe/hwmon: Handle pcode read failures of
    xe_hwmon_pcode_rmw_power_limit
  drm/xe/hwmon: Decode mailbox temperature as sign-magnitude
  drm/xe/hwmon: Fix memory controller thermal data handling
  drm/xe/hwmon: Add helpers to validate thermal sensor readings
  drm/xe/hwmon: Handle unavailable memory controller sensors
  drm/xe/hwmon: Detect unavailable PCIe thermal sensors
  drm/xe/hwmon: Consolidate temperature sensor availability checks
  drm/xe/hwmon: Cache temperature availability to reduce probe time
  drm/xe/hwmon: use CRI-specific package and VRAM temperature registers
  drm/xe/hwmon: Add platform-aware VRAM thermal channel support
  drm/xe/hwmon: Decode CRI temperature registers as IEEE-754
  drm/xe/hwmon: Update memory controller temperature offset for CRI
  drm/xe/hwmon: add PCIe temperature support for CRI
  drm/xe/hwmon: Simplify temperature channels config

 drivers/gpu/drm/xe/regs/xe_pcode_regs.h |   4 +
 drivers/gpu/drm/xe/xe_device_types.h    |   4 +
 drivers/gpu/drm/xe/xe_hwmon.c           | 450 ++++++++++++++++++------
 drivers/gpu/drm/xe/xe_pci.c             |   4 +
 drivers/gpu/drm/xe/xe_pci_types.h       |   2 +
 drivers/gpu/drm/xe/xe_pcode_api.h       |   2 -
 6 files changed, 366 insertions(+), 100 deletions(-)

-- 
2.25.1

[PATCH v9 01/14] drm/xe/hwmon: Handle pcode read failures of xe_hwmon_pcode_rmw_power_limit

[Karthik Poosa]

Return early when the pcode read operation fails in
xe_hwmon_pcode_rmw_power_limit() and check the returned error in
callers to avoid updating power limit settings with invalid data.

Fixes: 8aa7306631f0 ("drm/xe/hwmon: Fix xe_hwmon_power_max_write")
Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_hwmon.c | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index 5edeac961ec3..9884e06f83e5 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -232,9 +232,11 @@ static int xe_hwmon_pcode_rmw_power_limit(const struct xe_hwmon *hwmon, u32 attr
 						  READ_PSYSGPU_POWER_LIMIT :
 						  READ_PACKAGE_POWER_LIMIT,
 						  prepare_power_limit_param2(hwmon)), &val0, &val1);
-	if (ret)
-		drm_dbg(&hwmon->xe->drm, "read failed ch %d val0 0x%08x, val1 0x%08x, ret %d\n",
+	if (ret) {
+		drm_err(&hwmon->xe->drm, "read failed ch %d val0 0x%08x, val1 0x%08x, ret %d\n",
 			channel, val0, val1, ret);
+		return ret;
+	}
 
 	if (attr == PL1_HWMON_ATTR)
 		val0 = (val0 & ~clr) | set;
@@ -394,7 +396,9 @@ static int xe_hwmon_power_max_write(struct xe_hwmon *hwmon, u32 attr, int channe
 		if (hwmon->xe->info.has_mbx_power_limits) {
 			drm_dbg(&hwmon->xe->drm, "disabling %s on channel %d\n",
 				PWR_ATTR_TO_STR(attr), channel);
-			xe_hwmon_pcode_rmw_power_limit(hwmon, attr, channel, PWR_LIM_EN, 0);
+			ret = xe_hwmon_pcode_rmw_power_limit(hwmon, attr, channel, PWR_LIM_EN, 0);
+			if (ret)
+				goto unlock;
 			xe_hwmon_pcode_read_power_limit(hwmon, attr, channel, &reg_val);
 		} else {
 			reg_val = xe_mmio_rmw32(mmio, rapl_limit, PWR_LIM_EN, 0);
@@ -679,15 +683,19 @@ xe_hwmon_power_max_interval_store(struct device *dev, struct device_attribute *a
 
 	mutex_lock(&hwmon->hwmon_lock);
 
-	if (hwmon->xe->info.has_mbx_power_limits)
-		xe_hwmon_pcode_rmw_power_limit(hwmon, power_attr, channel, PWR_LIM_TIME, rxy);
-	else
+	ret = count;
+	if (hwmon->xe->info.has_mbx_power_limits) {
+		ret = xe_hwmon_pcode_rmw_power_limit(hwmon, power_attr, channel, PWR_LIM_TIME, rxy);
+		if (!ret)
+			ret = count;
+	} else {
 		r = xe_mmio_rmw32(mmio, xe_hwmon_get_reg(hwmon, REG_PKG_RAPL_LIMIT, channel),
 				  PWR_LIM_TIME, rxy);
+	}
 
 	mutex_unlock(&hwmon->hwmon_lock);
 
-	return count;
+	return ret;
 }
 
 /* PSYS PL1 */
-- 
2.25.1

[PATCH v9 02/14] drm/xe/hwmon: Decode mailbox temperature as sign-magnitude

[Karthik Poosa]

The mailbox temperature is an 8-bit sign-magnitude value (bit 7 sign,
bits 6:0 magnitude, range -127..127), not two's-complement. Casting the
raw byte to s8 decodes negative readings incorrectly.

Add mbx_temp_decode(), store the raw byte as u8, and use it in
get_mc_temp() and get_pcie_temp() so temperatures are decoded correctly.

Fixes: 3a0cb885e111 ("drm/xe/hwmon: Expose memory controller temperature")
Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_hwmon.c | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index 9884e06f83e5..c63aa708ab6f 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -104,6 +104,10 @@ enum sensor_attr_power {
 /* Index of memory controller in READ_THERMAL_DATA output */
 #define TEMP_INDEX_MCTRL	2
 
+/* Mailbox temperature is sign-magnitude: bit 7 sign, bits 6:0 magnitude. */
+#define TEMP_MBX_SIGN		BIT(7)
+#define TEMP_MBX_MAG		GENMASK(6, 0)
+
 /* Maximum characters in hwmon label name */
 #define MAX_LABEL_SIZE		16
 
@@ -139,8 +143,8 @@ struct xe_hwmon_thermal_info {
 	};
 	/** @count: no of temperature sensors available for the platform */
 	u8 count;
-	/** @value: signed value from each sensor */
-	s8 value[U8_MAX];
+	/** @value: per-sensor raw mailbox temperature; bit7=sign, bits6:0=magnitude */
+	u8 value[U8_MAX];
 	/** @vram_label: vram label names */
 	char vram_label[MAX_VRAM_CHANNELS][MAX_LABEL_SIZE];
 };
@@ -816,6 +820,14 @@ static int xe_hwmon_pcode_read_thermal_info(struct xe_hwmon *hwmon)
 	return ret;
 }
 
+/* Decode an 8-bit sign-magnitude mailbox temperature to degrees Celsius. */
+static int mbx_temp_decode(u8 value)
+{
+	int temp = value & TEMP_MBX_MAG;
+
+	return (value & TEMP_MBX_SIGN) ? -temp : temp;
+}
+
 static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
 {
 	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
@@ -832,7 +844,7 @@ static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
 	}
 
 	for (i = TEMP_INDEX_MCTRL; i < hwmon->temp.count - 1; i++)
-		average += hwmon->temp.value[i];
+		average += mbx_temp_decode(hwmon->temp.value[i]);
 
 	average /= (hwmon->temp.count - TEMP_INDEX_MCTRL - 1);
 	*val = average * MILLIDEGREE_PER_DEGREE;
@@ -855,7 +867,7 @@ static int get_pcie_temp(struct xe_hwmon *hwmon, long *val)
 		data = REG_FIELD_GET(PCIE_SENSOR_MASK, data);
 
 	data = REG_FIELD_GET(TEMP_MASK, data);
-	*val = (s8)data * MILLIDEGREE_PER_DEGREE;
+	*val = mbx_temp_decode(data) * MILLIDEGREE_PER_DEGREE;
 
 	return 0;
 }
-- 
2.25.1

[PATCH v9 03/14] drm/xe/hwmon: Fix memory controller thermal data handling

[Karthik Poosa]

Read all required thermal groups in get_mc_temp() and use an aligned
u32 buffer for PCODE accesses to avoid unaligned memory accesses and
ensure correct MC temperature reporting.

Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Fixes: 3a0cb885e111 ("drm/xe/hwmon: Expose memory controller temperature")
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_hwmon.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index c63aa708ab6f..33d0ca7d86e4 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -143,8 +143,12 @@ struct xe_hwmon_thermal_info {
 	};
 	/** @count: no of temperature sensors available for the platform */
 	u8 count;
-	/** @value: per-sensor raw mailbox temperature; bit7=sign, bits6:0=magnitude */
-	u8 value[U8_MAX];
+	union {
+		/** @value: per-sensor raw mailbox temperature; bit7=sign, bits6:0=magnitude */
+		u8 value[U8_MAX + 1];
+		/** @dword: sensor values as dwords, u32-aligned for pcode reads */
+		u32 dword[DIV_ROUND_UP(U8_MAX + 1, sizeof(u32))];
+	};
 	/** @vram_label: vram label names */
 	char vram_label[MAX_VRAM_CHANNELS][MAX_LABEL_SIZE];
 };
@@ -831,16 +835,16 @@ static int mbx_temp_decode(u8 value)
 static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
 {
 	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
-	u32 *dword = (u32 *)hwmon->temp.value;
 	s32 average = 0;
 	int ret, i;
 
-	for (i = 0; i < DIV_ROUND_UP(TEMP_LIMIT_MAX, sizeof(u32)); i++) {
+	for (i = 0; i < DIV_ROUND_UP(hwmon->temp.count, sizeof(u32)); i++) {
 		ret = xe_pcode_read(root_tile, PCODE_MBOX(PCODE_THERMAL_INFO, READ_THERMAL_DATA, i),
-				    (dword + i), NULL);
+				    &hwmon->temp.dword[i], NULL);
 		if (ret)
 			return ret;
-		drm_dbg(&hwmon->xe->drm, "thermal data for group %d val 0x%x\n", i, dword[i]);
+		drm_dbg(&hwmon->xe->drm, "thermal data for group %d val 0x%x\n", i,
+			hwmon->temp.dword[i]);
 	}
 
 	for (i = TEMP_INDEX_MCTRL; i < hwmon->temp.count - 1; i++)
-- 
2.25.1

[PATCH v9 04/14] drm/xe/hwmon: Add helpers to validate thermal sensor readings

[Karthik Poosa]

Add mmio_temp_valid() and mbx_temp_valid() to check whether a temperature
sensor reading is valid. An MMIO value of 0xFFFFFFFF or a mailbox value of
0xFF indicates the sensor is unavailable.

Gate these checks behind has_temp_sentinel, enabled on CRI currently.

Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_device_types.h |  2 ++
 drivers/gpu/drm/xe/xe_hwmon.c        | 20 ++++++++++++++++++++
 drivers/gpu/drm/xe/xe_pci.c          |  2 ++
 drivers/gpu/drm/xe/xe_pci_types.h    |  1 +
 4 files changed, 25 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
index 4e0e1bc040c1..beb0ceaabb3f 100644
--- a/drivers/gpu/drm/xe/xe_device_types.h
+++ b/drivers/gpu/drm/xe/xe_device_types.h
@@ -227,6 +227,8 @@ struct xe_device {
 		u8 has_sriov:1;
 		/** @info.has_sysctrl: Supports System Controller */
 		u8 has_sysctrl:1;
+		/** @info.has_temp_sentinel: Device has temperature-unavailable sentinels */
+		u8 has_temp_sentinel:1;
 		/** @info.has_usm: Device has unified shared memory support */
 		u8 has_usm:1;
 		/** @info.has_64bit_timestamp: Device supports 64-bit timestamps */
diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index 33d0ca7d86e4..5bbcb81529db 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -104,6 +104,9 @@ enum sensor_attr_power {
 /* Index of memory controller in READ_THERMAL_DATA output */
 #define TEMP_INDEX_MCTRL	2
 
+/* Mailbox sentinel reported for an unavailable temperature sensor */
+#define TEMP_MBX_INVALID	0xFF
+
 /* Mailbox temperature is sign-magnitude: bit 7 sign, bits 6:0 magnitude. */
 #define TEMP_MBX_SIGN		BIT(7)
 #define TEMP_MBX_MAG		GENMASK(6, 0)
@@ -824,6 +827,23 @@ static int xe_hwmon_pcode_read_thermal_info(struct xe_hwmon *hwmon)
 	return ret;
 }
 
+static inline bool mmio_temp_valid(const struct xe_hwmon *hwmon, u32 value)
+{
+	/*
+	 * On platforms lacking temperature sentinel support, a value of 0 is treated
+	 * as invalid. While 0°C is theoretically possible, it is highly unlikely for
+	 * a discrete GPU in normal environments, making it a reasonable fallback
+	 * indicator for invalid or uninitialized temperature readings.
+	 */
+	return hwmon->xe->info.has_temp_sentinel ? value != U32_MAX : value != 0;
+}
+
+/* Mailbox temperature is sign-magnitude (bit 7 sign, bits 6:0 magnitude). */
+static inline bool mbx_temp_valid(const struct xe_hwmon *hwmon, u8 value)
+{
+	return hwmon->xe->info.has_temp_sentinel ? value != TEMP_MBX_INVALID : value != 0;
+}
+
 /* Decode an 8-bit sign-magnitude mailbox temperature to degrees Celsius. */
 static int mbx_temp_decode(u8 value)
 {
diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
index e44b74b9aa27..111d0aa45b10 100644
--- a/drivers/gpu/drm/xe/xe_pci.c
+++ b/drivers/gpu/drm/xe/xe_pci.c
@@ -486,6 +486,7 @@ static const struct xe_device_desc cri_desc = {
 	.has_soc_remapper_telem = true,
 	.has_sriov = true,
 	.has_sysctrl = true,
+	.has_temp_sentinel = true,
 	.max_gt_per_tile = 2,
 	MULTI_LRC_MASK,
 	.require_force_probe = true,
@@ -817,6 +818,7 @@ static int xe_info_init_early(struct xe_device *xe,
 	xe->info.has_sriov = xe_configfs_primary_gt_allowed(to_pci_dev(xe->drm.dev)) &&
 		desc->has_sriov;
 	xe->info.has_sysctrl = desc->has_sysctrl;
+	xe->info.has_temp_sentinel = desc->has_temp_sentinel;
 	xe->info.skip_guc_pc = desc->skip_guc_pc;
 	xe->info.skip_pcode = desc->skip_pcode;
 	xe->info.needs_scratch = desc->needs_scratch;
diff --git a/drivers/gpu/drm/xe/xe_pci_types.h b/drivers/gpu/drm/xe/xe_pci_types.h
index 448bbe5ba1d7..15eedac8467a 100644
--- a/drivers/gpu/drm/xe/xe_pci_types.h
+++ b/drivers/gpu/drm/xe/xe_pci_types.h
@@ -61,6 +61,7 @@ struct xe_device_desc {
 	u8 has_soc_remapper_telem:1;
 	u8 has_sriov:1;
 	u8 has_sysctrl:1;
+	u8 has_temp_sentinel:1;
 	u8 needs_scratch:1;
 	u8 skip_guc_pc:1;
 	u8 skip_pcode:1;
-- 
2.25.1

[PATCH v9 05/14] drm/xe/hwmon: Handle unavailable memory controller sensors

[Karthik Poosa]

Skip memory controller sensors that report invalid readings when
computing the average temperature in get_mc_temp(). Return -ENXIO when
no valid sensor data is available, and allow the helper to be used as
an availability probe by making the output parameter optional.

Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Fixes: 3a0cb885e111 ("drm/xe/hwmon: Expose memory controller temperature")
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_hwmon.c | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index 5bbcb81529db..89e47d013dc6 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -855,8 +855,8 @@ static int mbx_temp_decode(u8 value)
 static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
 {
 	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
+	int ret, i, count = 0;
 	s32 average = 0;
-	int ret, i;
 
 	for (i = 0; i < DIV_ROUND_UP(hwmon->temp.count, sizeof(u32)); i++) {
 		ret = xe_pcode_read(root_tile, PCODE_MBOX(PCODE_THERMAL_INFO, READ_THERMAL_DATA, i),
@@ -867,11 +867,23 @@ static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
 			hwmon->temp.dword[i]);
 	}
 
-	for (i = TEMP_INDEX_MCTRL; i < hwmon->temp.count - 1; i++)
+	for (i = TEMP_INDEX_MCTRL; i < hwmon->temp.count - 1; i++) {
+		if (!mbx_temp_valid(hwmon, hwmon->temp.value[i]))
+			continue;
 		average += mbx_temp_decode(hwmon->temp.value[i]);
+		count++;
+	}
+
+	if (!count) {
+		drm_dbg(&hwmon->xe->drm, "Memory controller temperature unavailable!\n");
+		return -ENXIO;
+	}
+
+	average /= count;
+
+	if (val)
+		*val = average * MILLIDEGREE_PER_DEGREE;
 
-	average /= (hwmon->temp.count - TEMP_INDEX_MCTRL - 1);
-	*val = average * MILLIDEGREE_PER_DEGREE;
 	return 0;
 }
 
-- 
2.25.1

[PATCH v9 06/14] drm/xe/hwmon: Detect unavailable PCIe thermal sensors

[Karthik Poosa]

Return -ENXIO from get_pcie_temp() when the mailbox reports an invalid
reading, so the PCIe sensor can be treated as unavailable. Guard the val
store so the function can be used purely as an availability probe. No
sysfs visibility changes.

Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_hwmon.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index 89e47d013dc6..accccadbe3e6 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -903,7 +903,13 @@ static int get_pcie_temp(struct xe_hwmon *hwmon, long *val)
 		data = REG_FIELD_GET(PCIE_SENSOR_MASK, data);
 
 	data = REG_FIELD_GET(TEMP_MASK, data);
-	*val = mbx_temp_decode(data) * MILLIDEGREE_PER_DEGREE;
+	if (!mbx_temp_valid(hwmon, data)) {
+		drm_dbg(&hwmon->xe->drm, "PCIe temperature not available\n");
+		return -ENXIO;
+	}
+
+	if (val)
+		*val = mbx_temp_decode(data) * MILLIDEGREE_PER_DEGREE;
 
 	return 0;
 }
-- 
2.25.1

[PATCH v9 07/14] drm/xe/hwmon: Consolidate temperature sensor availability checks

[Karthik Poosa]

Replace is_vram_ch_available() with a generalized is_temp_available()
that validates PKG, VRAM, per-channel VRAM, memory controller and PCIe
sensors using the new validity helpers. Rename the existing callers to
the new helper.

Use is_temp_available() from xe_hwmon_temp_is_visible() so attributes for
sensors that are not present are not exposed during hwmon registration.

Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Assisted-by: LLM
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_hwmon.c | 64 ++++++++++++++++++++++-------------
 1 file changed, 40 insertions(+), 24 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index accccadbe3e6..62e341ef37e9 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -1008,19 +1008,39 @@ static void xe_hwmon_get_voltage(struct xe_hwmon *hwmon, int channel, long *valu
 	*value = DIV_ROUND_CLOSEST(REG_FIELD_GET(VOLTAGE_MASK, reg_val) * 2500, SF_VOLTAGE);
 }
 
-static inline bool is_vram_ch_available(struct xe_hwmon *hwmon, int channel)
+static bool is_temp_available(struct xe_hwmon *hwmon, int channel)
 {
 	struct xe_mmio *mmio = xe_root_tile_mmio(hwmon->xe);
-	int vram_id = channel - CHANNEL_VRAM_N;
-	struct xe_reg vram_reg;
+	struct xe_reg reg;
+	u32 reg_val;
 
-	vram_reg = xe_hwmon_get_reg(hwmon, REG_TEMP, channel);
-	if (!xe_reg_is_valid(vram_reg) || !xe_mmio_read32(mmio, vram_reg))
-		return false;
+	switch (channel) {
+	case CHANNEL_PKG:
+	case CHANNEL_VRAM:
+	case CHANNEL_VRAM_N...CHANNEL_VRAM_N_MAX:
+		reg = xe_hwmon_get_reg(hwmon, REG_TEMP, channel);
+		if (!xe_reg_is_valid(reg))
+			return false;
+
+		reg_val = xe_mmio_read32(mmio, reg);
+		if (!mmio_temp_valid(hwmon, reg_val)) {
+			drm_dbg(&hwmon->xe->drm,
+				"channel %d temperature unavailable, val 0x%x\n", channel, reg_val);
+			return false;
+		}
+
+		if (channel >= CHANNEL_VRAM_N)
+			sprintf(hwmon->temp.vram_label[channel - CHANNEL_VRAM_N],
+				"vram_ch_%d", channel - CHANNEL_VRAM_N);
 
-	/* Create label only for available vram channel */
-	sprintf(hwmon->temp.vram_label[vram_id], "vram_ch_%d", vram_id);
-	return true;
+		return true;
+	case CHANNEL_MCTRL:
+		return hwmon->temp.count && !get_mc_temp(hwmon, NULL);
+	case CHANNEL_PCIE:
+		return hwmon->temp.count && !get_pcie_temp(hwmon, NULL);
+	default:
+		return false;
+	}
 }
 
 static umode_t
@@ -1030,14 +1050,13 @@ xe_hwmon_temp_is_visible(struct xe_hwmon *hwmon, u32 attr, int channel)
 	case hwmon_temp_emergency:
 		switch (channel) {
 		case CHANNEL_PKG:
-			return hwmon->temp.limit[TEMP_LIMIT_PKG_SHUTDOWN] ? 0444 : 0;
-		case CHANNEL_VRAM:
-			return hwmon->temp.limit[TEMP_LIMIT_MEM_SHUTDOWN] ? 0444 : 0;
 		case CHANNEL_MCTRL:
 		case CHANNEL_PCIE:
-			return hwmon->temp.count ? 0444 : 0;
+			return (is_temp_available(hwmon, channel) &&
+				hwmon->temp.limit[TEMP_LIMIT_PKG_SHUTDOWN]) ? 0444 : 0;
+		case CHANNEL_VRAM:
 		case CHANNEL_VRAM_N...CHANNEL_VRAM_N_MAX:
-			return (is_vram_ch_available(hwmon, channel) &&
+			return (is_temp_available(hwmon, channel) &&
 				hwmon->temp.limit[TEMP_LIMIT_MEM_SHUTDOWN]) ? 0444 : 0;
 		default:
 			return 0;
@@ -1045,14 +1064,13 @@ xe_hwmon_temp_is_visible(struct xe_hwmon *hwmon, u32 attr, int channel)
 	case hwmon_temp_crit:
 		switch (channel) {
 		case CHANNEL_PKG:
-			return hwmon->temp.limit[TEMP_LIMIT_PKG_CRIT] ? 0444 : 0;
-		case CHANNEL_VRAM:
-			return hwmon->temp.limit[TEMP_LIMIT_MEM_CRIT] ? 0444 : 0;
 		case CHANNEL_MCTRL:
 		case CHANNEL_PCIE:
-			return hwmon->temp.count ? 0444 : 0;
+			return (is_temp_available(hwmon, channel) &&
+				hwmon->temp.limit[TEMP_LIMIT_PKG_CRIT]) ? 0444 : 0;
+		case CHANNEL_VRAM:
 		case CHANNEL_VRAM_N...CHANNEL_VRAM_N_MAX:
-			return (is_vram_ch_available(hwmon, channel) &&
+			return (is_temp_available(hwmon, channel) &&
 				hwmon->temp.limit[TEMP_LIMIT_MEM_CRIT]) ? 0444 : 0;
 		default:
 			return 0;
@@ -1060,7 +1078,8 @@ xe_hwmon_temp_is_visible(struct xe_hwmon *hwmon, u32 attr, int channel)
 	case hwmon_temp_max:
 		switch (channel) {
 		case CHANNEL_PKG:
-			return hwmon->temp.limit[TEMP_LIMIT_PKG_MAX] ? 0444 : 0;
+			return (is_temp_available(hwmon, channel) &&
+				hwmon->temp.limit[TEMP_LIMIT_PKG_MAX]) ? 0444 : 0;
 		default:
 			return 0;
 		}
@@ -1069,13 +1088,10 @@ xe_hwmon_temp_is_visible(struct xe_hwmon *hwmon, u32 attr, int channel)
 		switch (channel) {
 		case CHANNEL_PKG:
 		case CHANNEL_VRAM:
-			return xe_reg_is_valid(xe_hwmon_get_reg(hwmon, REG_TEMP,
-								channel)) ? 0444 : 0;
 		case CHANNEL_MCTRL:
 		case CHANNEL_PCIE:
-			return hwmon->temp.count ? 0444 : 0;
 		case CHANNEL_VRAM_N...CHANNEL_VRAM_N_MAX:
-			return is_vram_ch_available(hwmon, channel) ? 0444 : 0;
+			return is_temp_available(hwmon, channel) ? 0444 : 0;
 		default:
 			return 0;
 		}
-- 
2.25.1

[PATCH v9 08/14] drm/xe/hwmon: Cache temperature availability to reduce probe time

[Karthik Poosa]

Avoid probing temperature sensor availability from the hwmon is_visible()
callback. For MCTRL and PCIe channels, that path can trigger repeated
blocking mailbox reads while sysfs attributes are being created, increasing
probe time and making attribute creation sensitive to transient failures.

Probe temperature availability once during preregistration and cache the
result for subsequent visibility checks.

Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Assisted-by: LLM
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_hwmon.c | 39 +++++++++++++++++++++++------------
 1 file changed, 26 insertions(+), 13 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index 62e341ef37e9..b8682eb233e4 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -146,6 +146,8 @@ struct xe_hwmon_thermal_info {
 	};
 	/** @count: no of temperature sensors available for the platform */
 	u8 count;
+	/** @available: temperature sensor availability cached at registration */
+	bool available[CHANNEL_MAX];
 	union {
 		/** @value: per-sensor raw mailbox temperature; bit7=sign, bits6:0=magnitude */
 		u8 value[U8_MAX + 1];
@@ -1008,7 +1010,7 @@ static void xe_hwmon_get_voltage(struct xe_hwmon *hwmon, int channel, long *valu
 	*value = DIV_ROUND_CLOSEST(REG_FIELD_GET(VOLTAGE_MASK, reg_val) * 2500, SF_VOLTAGE);
 }
 
-static bool is_temp_available(struct xe_hwmon *hwmon, int channel)
+static bool xe_hwmon_temp_probe(struct xe_hwmon *hwmon, int channel)
 {
 	struct xe_mmio *mmio = xe_root_tile_mmio(hwmon->xe);
 	struct xe_reg reg;
@@ -1029,10 +1031,6 @@ static bool is_temp_available(struct xe_hwmon *hwmon, int channel)
 			return false;
 		}
 
-		if (channel >= CHANNEL_VRAM_N)
-			sprintf(hwmon->temp.vram_label[channel - CHANNEL_VRAM_N],
-				"vram_ch_%d", channel - CHANNEL_VRAM_N);
-
 		return true;
 	case CHANNEL_MCTRL:
 		return hwmon->temp.count && !get_mc_temp(hwmon, NULL);
@@ -1043,6 +1041,22 @@ static bool is_temp_available(struct xe_hwmon *hwmon, int channel)
 	}
 }
 
+static void xe_hwmon_init_temp_info(struct xe_hwmon *hwmon)
+{
+	int channel;
+
+	if (hwmon->xe->info.has_mbx_thermal_info && xe_hwmon_pcode_read_thermal_info(hwmon))
+		drm_warn(&hwmon->xe->drm, "Thermal mailbox not supported by card firmware\n");
+
+	for (channel = 0; channel < CHANNEL_MAX; channel++) {
+		hwmon->temp.available[channel] = xe_hwmon_temp_probe(hwmon, channel);
+		if (hwmon->temp.available[channel] &&
+		    in_range(channel, CHANNEL_VRAM_N, MAX_VRAM_CHANNELS))
+			snprintf(hwmon->temp.vram_label[channel - CHANNEL_VRAM_N], MAX_LABEL_SIZE,
+				 "vram_ch_%d", channel - CHANNEL_VRAM_N);
+	}
+}
+
 static umode_t
 xe_hwmon_temp_is_visible(struct xe_hwmon *hwmon, u32 attr, int channel)
 {
@@ -1052,11 +1066,11 @@ xe_hwmon_temp_is_visible(struct xe_hwmon *hwmon, u32 attr, int channel)
 		case CHANNEL_PKG:
 		case CHANNEL_MCTRL:
 		case CHANNEL_PCIE:
-			return (is_temp_available(hwmon, channel) &&
+			return (hwmon->temp.available[channel] &&
 				hwmon->temp.limit[TEMP_LIMIT_PKG_SHUTDOWN]) ? 0444 : 0;
 		case CHANNEL_VRAM:
 		case CHANNEL_VRAM_N...CHANNEL_VRAM_N_MAX:
-			return (is_temp_available(hwmon, channel) &&
+			return (hwmon->temp.available[channel] &&
 				hwmon->temp.limit[TEMP_LIMIT_MEM_SHUTDOWN]) ? 0444 : 0;
 		default:
 			return 0;
@@ -1066,11 +1080,11 @@ xe_hwmon_temp_is_visible(struct xe_hwmon *hwmon, u32 attr, int channel)
 		case CHANNEL_PKG:
 		case CHANNEL_MCTRL:
 		case CHANNEL_PCIE:
-			return (is_temp_available(hwmon, channel) &&
+			return (hwmon->temp.available[channel] &&
 				hwmon->temp.limit[TEMP_LIMIT_PKG_CRIT]) ? 0444 : 0;
 		case CHANNEL_VRAM:
 		case CHANNEL_VRAM_N...CHANNEL_VRAM_N_MAX:
-			return (is_temp_available(hwmon, channel) &&
+			return (hwmon->temp.available[channel] &&
 				hwmon->temp.limit[TEMP_LIMIT_MEM_CRIT]) ? 0444 : 0;
 		default:
 			return 0;
@@ -1078,7 +1092,7 @@ xe_hwmon_temp_is_visible(struct xe_hwmon *hwmon, u32 attr, int channel)
 	case hwmon_temp_max:
 		switch (channel) {
 		case CHANNEL_PKG:
-			return (is_temp_available(hwmon, channel) &&
+			return (hwmon->temp.available[channel] &&
 				hwmon->temp.limit[TEMP_LIMIT_PKG_MAX]) ? 0444 : 0;
 		default:
 			return 0;
@@ -1091,7 +1105,7 @@ xe_hwmon_temp_is_visible(struct xe_hwmon *hwmon, u32 attr, int channel)
 		case CHANNEL_MCTRL:
 		case CHANNEL_PCIE:
 		case CHANNEL_VRAM_N...CHANNEL_VRAM_N_MAX:
-			return is_temp_available(hwmon, channel) ? 0444 : 0;
+			return hwmon->temp.available[channel] ? 0444 : 0;
 		default:
 			return 0;
 		}
@@ -1633,8 +1647,7 @@ xe_hwmon_get_preregistration_info(struct xe_hwmon *hwmon)
 		if (xe_hwmon_is_visible(hwmon, hwmon_fan, hwmon_fan_input, channel))
 			xe_hwmon_fan_input_read(hwmon, channel, &fan_speed);
 
-	if (hwmon->xe->info.has_mbx_thermal_info && xe_hwmon_pcode_read_thermal_info(hwmon))
-		drm_warn(&hwmon->xe->drm, "Thermal mailbox not supported by card firmware\n");
+	xe_hwmon_init_temp_info(hwmon);
 }
 
 int xe_hwmon_register(struct xe_device *xe)
-- 
2.25.1

[PATCH v9 09/14] drm/xe/hwmon: use CRI-specific package and VRAM temperature registers

[Karthik Poosa]

Crescent Island uses different MMIO offsets for package and VRAM
temperature than Battlemage. Add CRI-specific register definitions
and select them in xe_hwmon_get_reg() for REG_TEMP handling.

Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/regs/xe_pcode_regs.h | 3 +++
 drivers/gpu/drm/xe/xe_hwmon.c           | 9 ++++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/regs/xe_pcode_regs.h b/drivers/gpu/drm/xe/regs/xe_pcode_regs.h
index c63b409d7a82..a969661f0c95 100644
--- a/drivers/gpu/drm/xe/regs/xe_pcode_regs.h
+++ b/drivers/gpu/drm/xe/regs/xe_pcode_regs.h
@@ -28,6 +28,9 @@
 #define BMG_PACKAGE_TEMPERATURE			XE_REG(0x138434)
 
 #define CRI_PACKAGE_ENERGY_STATUS		XE_REG(0x138120)
+#define CRI_PACKAGE_TEMPERATURE			XE_REG(0x138344)
+#define CRI_VRAM_TEMPERATURE			XE_REG(0x138348)
 #define CRI_PLATFORM_ENERGY_STATUS		XE_REG(0x138458)
+#define CRI_VRAM_TEMPERATURE_N(n)		XE_REG(0x138a00 + ((n) * (sizeof(u32))))
 
 #endif /* _XE_PCODE_REGS_H_ */
diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index b8682eb233e4..bafa175f8457 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -276,7 +276,14 @@ static struct xe_reg xe_hwmon_get_reg(struct xe_hwmon *hwmon, enum xe_hwmon_reg
 
 	switch (hwmon_reg) {
 	case REG_TEMP:
-		if (xe->info.platform == XE_BATTLEMAGE || xe->info.platform == XE_CRESCENTISLAND) {
+		if (xe->info.platform == XE_CRESCENTISLAND) {
+			if (channel == CHANNEL_PKG)
+				return CRI_PACKAGE_TEMPERATURE;
+			else if (channel == CHANNEL_VRAM)
+				return CRI_VRAM_TEMPERATURE;
+			else if (in_range(channel, CHANNEL_VRAM_N, MAX_VRAM_CHANNELS))
+				return CRI_VRAM_TEMPERATURE_N(channel - CHANNEL_VRAM_N);
+		} else if (xe->info.platform == XE_BATTLEMAGE) {
 			if (channel == CHANNEL_PKG)
 				return BMG_PACKAGE_TEMPERATURE;
 			else if (channel == CHANNEL_VRAM)
-- 
2.25.1

[PATCH v9 10/14] drm/xe/hwmon: Add platform-aware VRAM thermal channel support

[Karthik Poosa]

On CRI, derive the number of available VRAM temperature channels from the
CRI_MSU_VRAM_ENABLE register, where each enabled MSU contributes
VRAM_CHANNELS_PER_MSU channels.
 
Increase the maximum supported VRAM channel count to 80 and use the
derived count to control VRAM sensor enumeration, channel access, and
VRAM label allocation. Add a has_fixed_vram_channels platform flag to
preserve the existing fixed-channel behavior on non-CRI platforms.

Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/regs/xe_pcode_regs.h |   1 +
 drivers/gpu/drm/xe/xe_device_types.h    |   2 +
 drivers/gpu/drm/xe/xe_hwmon.c           | 164 +++++++++++++++++++++---
 drivers/gpu/drm/xe/xe_pci.c             |   2 +
 drivers/gpu/drm/xe/xe_pci_types.h       |   1 +
 5 files changed, 154 insertions(+), 16 deletions(-)

diff --git a/drivers/gpu/drm/xe/regs/xe_pcode_regs.h b/drivers/gpu/drm/xe/regs/xe_pcode_regs.h
index a969661f0c95..d9e4847dd68e 100644
--- a/drivers/gpu/drm/xe/regs/xe_pcode_regs.h
+++ b/drivers/gpu/drm/xe/regs/xe_pcode_regs.h
@@ -28,6 +28,7 @@
 #define BMG_PACKAGE_TEMPERATURE			XE_REG(0x138434)
 
 #define CRI_PACKAGE_ENERGY_STATUS		XE_REG(0x138120)
+#define CRI_MSU_VRAM_ENABLE			XE_REG(0x138340)
 #define CRI_PACKAGE_TEMPERATURE			XE_REG(0x138344)
 #define CRI_VRAM_TEMPERATURE			XE_REG(0x138348)
 #define CRI_PLATFORM_ENERGY_STATUS		XE_REG(0x138458)
diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
index beb0ceaabb3f..161ba2b27f47 100644
--- a/drivers/gpu/drm/xe/xe_device_types.h
+++ b/drivers/gpu/drm/xe/xe_device_types.h
@@ -185,6 +185,8 @@ struct xe_device {
 		u8 has_drm_ras:1;
 		/** @info.has_fan_control: Device supports fan control */
 		u8 has_fan_control:1;
+		/** @info.has_fixed_vram_channels: Device has fixed VRAM temperature channels */
+		u8 has_fixed_vram_channels:1;
 		/** @info.has_flat_ccs: Whether flat CCS metadata is used */
 		u8 has_flat_ccs:1;
 		/** @info.has_gsc_nvm: Device has gsc non-volatile memory */
diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index bafa175f8457..9d83d9d2286e 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -39,7 +39,11 @@ enum xe_hwmon_reg_operation {
 	REG_READ64,
 };
 
-#define MAX_VRAM_CHANNELS      (16)
+#define MAX_VRAM_CHANNELS	80
+#define FIXED_VRAM_CHANNELS	16
+
+/* Each MSU enable bit maps to one VRAM subsystem of 4 channels. */
+#define VRAM_CHANNELS_PER_MSU	4
 
 enum xe_hwmon_channel {
 	CHANNEL_CARD,
@@ -48,6 +52,7 @@ enum xe_hwmon_channel {
 	CHANNEL_MCTRL,
 	CHANNEL_PCIE,
 	CHANNEL_VRAM_N,
+	/* Compile-time upper bound; actual channel count is hwmon->temp.vram_count */
 	CHANNEL_VRAM_N_MAX = CHANNEL_VRAM_N + MAX_VRAM_CHANNELS - 1,
 	CHANNEL_MAX,
 };
@@ -144,18 +149,22 @@ struct xe_hwmon_thermal_info {
 		/** @data: temperature limits in dwords */
 		u32 data[DIV_ROUND_UP(TEMP_LIMIT_MAX, sizeof(u32))];
 	};
-	/** @count: no of temperature sensors available for the platform */
+	/** @count: temperature sensors count from READ_THERMAL_CONFIG */
 	u8 count;
+	/** @vram_count: exclusive upper bound for VRAM temperature channel indices */
+	u8 vram_count;
 	/** @available: temperature sensor availability cached at registration */
 	bool available[CHANNEL_MAX];
+	/** @msu_mask: VRAM subsystem enable mask read from MMIO */
+	u32 msu_mask;
 	union {
 		/** @value: per-sensor raw mailbox temperature; bit7=sign, bits6:0=magnitude */
 		u8 value[U8_MAX + 1];
 		/** @dword: sensor values as dwords, u32-aligned for pcode reads */
 		u32 dword[DIV_ROUND_UP(U8_MAX + 1, sizeof(u32))];
 	};
-	/** @vram_label: vram label names */
-	char vram_label[MAX_VRAM_CHANNELS][MAX_LABEL_SIZE];
+	/** @vram_label: vram label names, dynamically allocated based on vram_count */
+	char (*vram_label)[MAX_LABEL_SIZE];
 };
 
 /**
@@ -269,6 +278,14 @@ static int xe_hwmon_pcode_rmw_power_limit(const struct xe_hwmon *hwmon, u32 attr
 	return ret;
 }
 
+static bool xe_hwmon_vram_channel_enabled(const struct xe_hwmon *hwmon, int index)
+{
+	if (hwmon->xe->info.platform == XE_CRESCENTISLAND)
+		return hwmon->temp.msu_mask & BIT(index / VRAM_CHANNELS_PER_MSU);
+
+	return true;
+}
+
 static struct xe_reg xe_hwmon_get_reg(struct xe_hwmon *hwmon, enum xe_hwmon_reg hwmon_reg,
 				      int channel)
 {
@@ -281,14 +298,16 @@ static struct xe_reg xe_hwmon_get_reg(struct xe_hwmon *hwmon, enum xe_hwmon_reg
 				return CRI_PACKAGE_TEMPERATURE;
 			else if (channel == CHANNEL_VRAM)
 				return CRI_VRAM_TEMPERATURE;
-			else if (in_range(channel, CHANNEL_VRAM_N, MAX_VRAM_CHANNELS))
+			else if (in_range(channel, CHANNEL_VRAM_N, hwmon->temp.vram_count) &&
+				 xe_hwmon_vram_channel_enabled(hwmon, channel - CHANNEL_VRAM_N))
 				return CRI_VRAM_TEMPERATURE_N(channel - CHANNEL_VRAM_N);
 		} else if (xe->info.platform == XE_BATTLEMAGE) {
 			if (channel == CHANNEL_PKG)
 				return BMG_PACKAGE_TEMPERATURE;
 			else if (channel == CHANNEL_VRAM)
 				return BMG_VRAM_TEMPERATURE;
-			else if (in_range(channel, CHANNEL_VRAM_N, MAX_VRAM_CHANNELS))
+			else if (in_range(channel, CHANNEL_VRAM_N, hwmon->temp.vram_count) &&
+				 xe_hwmon_vram_channel_enabled(hwmon, channel - CHANNEL_VRAM_N))
 				return BMG_VRAM_TEMPERATURE_N(channel - CHANNEL_VRAM_N);
 		} else if (xe->info.platform == XE_DG2) {
 			if (channel == CHANNEL_PKG)
@@ -800,6 +819,70 @@ static const struct hwmon_channel_info * const hwmon_info[] = {
 			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
 			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
 			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
 			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL),
 	HWMON_CHANNEL_INFO(power, HWMON_P_MAX | HWMON_P_RATED_MAX | HWMON_P_LABEL | HWMON_P_CRIT |
 			   HWMON_P_CAP,
@@ -814,15 +897,37 @@ static const struct hwmon_channel_info * const hwmon_info[] = {
 static int xe_hwmon_pcode_read_thermal_info(struct xe_hwmon *hwmon)
 {
 	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
+	struct xe_mmio *mmio = xe_root_tile_mmio(hwmon->xe);
 	u32 config = 0;
 	int ret;
 
+	/*
+	 * Only CRI reports dynamic VRAM channel state. Fixed-channel platforms
+	 * set the count up front so those sensors stay visible even if the thermal
+	 * mailbox reads below fail.
+	 */
+	if (hwmon->xe->info.has_fixed_vram_channels)
+		hwmon->temp.vram_count = FIXED_VRAM_CHANNELS;
+
+	if (hwmon->xe->info.platform == XE_CRESCENTISLAND) {
+		hwmon->temp.msu_mask = xe_mmio_read32(mmio, CRI_MSU_VRAM_ENABLE);
+		hwmon->temp.vram_count = fls(hwmon->temp.msu_mask) * VRAM_CHANNELS_PER_MSU;
+		drm_dbg(&hwmon->xe->drm, "MSU VRAM enable mask 0x%x, VRAM channel bound %d\n",
+			hwmon->temp.msu_mask, hwmon->temp.vram_count);
+		if (hwmon->temp.vram_count > MAX_VRAM_CHANNELS) {
+			drm_warn(&hwmon->xe->drm,
+				 "VRAM channel bound %d exceeds max %d, clamping\n",
+				 hwmon->temp.vram_count, MAX_VRAM_CHANNELS);
+			hwmon->temp.vram_count = MAX_VRAM_CHANNELS;
+		}
+	}
+
 	ret = xe_pcode_read(root_tile, PCODE_MBOX(PCODE_THERMAL_INFO, READ_THERMAL_LIMITS, 0),
 			    &hwmon->temp.data[0], &hwmon->temp.data[1]);
 	if (ret)
 		return ret;
 
-	drm_dbg(&hwmon->xe->drm, "thermal info read val 0x%x val1 0x%x\n",
+	drm_dbg(&hwmon->xe->drm, "thermal info read val 0x%08x val1 0x%08x\n",
 		hwmon->temp.data[0], hwmon->temp.data[1]);
 
 	ret = xe_pcode_read(root_tile, PCODE_MBOX(PCODE_THERMAL_INFO, READ_THERMAL_CONFIG, 0),
@@ -1031,6 +1136,14 @@ static bool xe_hwmon_temp_probe(struct xe_hwmon *hwmon, int channel)
 		if (!xe_reg_is_valid(reg))
 			return false;
 
+		/*
+		 * On CRI, VRAM channel presence comes from the MSU enable mask
+		 * (applied in xe_hwmon_get_reg()); the temperature register's
+		 * 0xffffffff sentinel is not reliable for VRAM channels.
+		 */
+		if (hwmon->xe->info.platform == XE_CRESCENTISLAND && channel >= CHANNEL_VRAM_N)
+			return true;
+
 		reg_val = xe_mmio_read32(mmio, reg);
 		if (!mmio_temp_valid(hwmon, reg_val)) {
 			drm_dbg(&hwmon->xe->drm,
@@ -1048,20 +1161,31 @@ static bool xe_hwmon_temp_probe(struct xe_hwmon *hwmon, int channel)
 	}
 }
 
-static void xe_hwmon_init_temp_info(struct xe_hwmon *hwmon)
+static int xe_hwmon_init_temp_info(struct xe_hwmon *hwmon)
 {
+	struct device *dev = hwmon->xe->drm.dev;
 	int channel;
 
 	if (hwmon->xe->info.has_mbx_thermal_info && xe_hwmon_pcode_read_thermal_info(hwmon))
 		drm_warn(&hwmon->xe->drm, "Thermal mailbox not supported by card firmware\n");
 
+	/* vram_count is known only after reading thermal info above. */
+	if (hwmon->temp.vram_count) {
+		hwmon->temp.vram_label = devm_kcalloc(dev, hwmon->temp.vram_count,
+						      MAX_LABEL_SIZE, GFP_KERNEL);
+		if (!hwmon->temp.vram_label)
+			return -ENOMEM;
+	}
+
 	for (channel = 0; channel < CHANNEL_MAX; channel++) {
 		hwmon->temp.available[channel] = xe_hwmon_temp_probe(hwmon, channel);
-		if (hwmon->temp.available[channel] &&
-		    in_range(channel, CHANNEL_VRAM_N, MAX_VRAM_CHANNELS))
+		if (hwmon->temp.available[channel] && hwmon->temp.vram_label &&
+		    in_range(channel, CHANNEL_VRAM_N, hwmon->temp.vram_count))
 			snprintf(hwmon->temp.vram_label[channel - CHANNEL_VRAM_N], MAX_LABEL_SIZE,
 				 "vram_ch_%d", channel - CHANNEL_VRAM_N);
 	}
+
+	return 0;
 }
 
 static umode_t
@@ -1557,8 +1681,10 @@ static int xe_hwmon_read_label(struct device *dev,
 			*str = "mctrl";
 		else if (channel == CHANNEL_PCIE)
 			*str = "pcie";
-		else if (in_range(channel, CHANNEL_VRAM_N, MAX_VRAM_CHANNELS))
+		else if (in_range(channel, CHANNEL_VRAM_N, hwmon->temp.vram_count))
 			*str = hwmon->temp.vram_label[channel - CHANNEL_VRAM_N];
+		else
+			return -EOPNOTSUPP;
 		return 0;
 	case hwmon_power:
 	case hwmon_energy:
@@ -1586,7 +1712,7 @@ static const struct hwmon_chip_info hwmon_chip_info = {
 	.info = hwmon_info,
 };
 
-static void
+static int
 xe_hwmon_get_preregistration_info(struct xe_hwmon *hwmon)
 {
 	struct xe_mmio *mmio = xe_root_tile_mmio(hwmon->xe);
@@ -1654,7 +1780,7 @@ xe_hwmon_get_preregistration_info(struct xe_hwmon *hwmon)
 		if (xe_hwmon_is_visible(hwmon, hwmon_fan, hwmon_fan_input, channel))
 			xe_hwmon_fan_input_read(hwmon, channel, &fan_speed);
 
-	xe_hwmon_init_temp_info(hwmon);
+	return xe_hwmon_init_temp_info(hwmon);
 }
 
 int xe_hwmon_register(struct xe_device *xe)
@@ -1683,7 +1809,9 @@ int xe_hwmon_register(struct xe_device *xe)
 	hwmon->xe = xe;
 	xe->hwmon = hwmon;
 
-	xe_hwmon_get_preregistration_info(hwmon);
+	ret = xe_hwmon_get_preregistration_info(hwmon);
+	if (ret)
+		goto err_null_hwmon;
 
 	drm_dbg(&xe->drm, "Register xe hwmon interface\n");
 
@@ -1693,10 +1821,14 @@ int xe_hwmon_register(struct xe_device *xe)
 								hwmon_groups);
 	if (IS_ERR(hwmon->hwmon_dev)) {
 		drm_err(&xe->drm, "Failed to register xe hwmon (%pe)\n", hwmon->hwmon_dev);
-		xe->hwmon = NULL;
-		return PTR_ERR(hwmon->hwmon_dev);
+		ret = PTR_ERR(hwmon->hwmon_dev);
+		goto err_null_hwmon;
 	}
 
 	return 0;
+
+err_null_hwmon:
+	xe->hwmon = NULL;
+	return ret;
 }
 MODULE_IMPORT_NS("INTEL_PMT_TELEMETRY");
diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
index 111d0aa45b10..e754668100cf 100644
--- a/drivers/gpu/drm/xe/xe_pci.c
+++ b/drivers/gpu/drm/xe/xe_pci.c
@@ -417,6 +417,7 @@ static const struct xe_device_desc bmg_desc = {
 	.dma_mask_size = 46,
 	.has_display = true,
 	.has_fan_control = true,
+	.has_fixed_vram_channels = true,
 	.has_flat_ccs = 1,
 	.has_mbx_power_limits = true,
 	.has_mbx_thermal_info = true,
@@ -798,6 +799,7 @@ static int xe_info_init_early(struct xe_device *xe,
 	xe->info.has_device_uid = desc->has_device_uid;
 	xe->info.has_drm_ras = desc->has_drm_ras;
 	xe->info.has_fan_control = desc->has_fan_control;
+	xe->info.has_fixed_vram_channels = desc->has_fixed_vram_channels;
 	/* runtime fusing may force flat_ccs to disabled later */
 	xe->info.has_flat_ccs = desc->has_flat_ccs;
 	xe->info.has_mbx_power_limits = desc->has_mbx_power_limits;
diff --git a/drivers/gpu/drm/xe/xe_pci_types.h b/drivers/gpu/drm/xe/xe_pci_types.h
index 15eedac8467a..ce0b0f6c5b18 100644
--- a/drivers/gpu/drm/xe/xe_pci_types.h
+++ b/drivers/gpu/drm/xe/xe_pci_types.h
@@ -43,6 +43,7 @@ struct xe_device_desc {
 	u8 has_device_uid:1;
 	u8 has_drm_ras:1;
 	u8 has_fan_control:1;
+	u8 has_fixed_vram_channels:1;
 	u8 has_flat_ccs:1;
 	u8 has_gsc_nvm:1;
 	u8 has_heci_gscfi:1;
-- 
2.25.1

[PATCH v9 11/14] drm/xe/hwmon: Decode CRI temperature registers as IEEE-754

[Karthik Poosa]

CRI temperature registers encode package and VRAM temperatures as
IEEE-754 floating-point values. Decode these values before exposing
them through hwmon.
 
Use integer-based IEEE-754 decoding since kernel code does not use
floating-point operations and hwmon reports integer temperatures.

v2: Add missing description for parameter 'temperature' in
    xe_hwmon_temperature_decode().

Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Assisted-by: LLM
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_hwmon.c | 93 +++++++++++++++++++++++++++++------
 1 file changed, 79 insertions(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index 9d83d9d2286e..8617b5e84b50 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -1245,6 +1245,70 @@ xe_hwmon_temp_is_visible(struct xe_hwmon *hwmon, u32 attr, int channel)
 	}
 }
 
+#define IEEE754_SIGN		REG_BIT(31)
+#define IEEE754_EXP_MASK	REG_GENMASK(30, 23)
+#define IEEE754_MANTISSA_MASK	REG_GENMASK(22, 0)
+#define IEEE754_EXP_BIAS	127 /* Exponent bias to obtain the actual exponent */
+#define IEEE754_MANTISSA_BITS	23 /* Mantissa width and implicit leading-1 bit position */
+#define IEEE754_EXP_SPECIAL	0xff /* reserved exponent value encoding infinity or NaN */
+
+/**
+ * xe_hwmon_temperature_decode - Decode an IEEE-754 temperature register value
+ * @reg_val: The raw register value to decode
+ * @temperature: Pointer to store the decoded temperature in millidegrees Celsius.
+ *
+ * IEEE-754 single-precision format:
+ *
+ *  31 30                         23 22                         0
+ * +--+-----------------------------+----------------------------+
+ * | S|          exponent           |          fraction          |
+ * +--+-----------------------------+----------------------------+
+ *
+ * value = (-1)^S * 1.fraction * 2^(exponent - 127)
+ *
+ * Return: 0 on success or an error if @reg_val is non-finite or cannot be
+ * represented in millidegrees Celsius.
+ */
+static int xe_hwmon_temperature_decode(u32 reg_val, long *temperature)
+{
+	u32 exponent = REG_FIELD_GET(IEEE754_EXP_MASK, reg_val);
+	u32 mantissa = REG_FIELD_GET(IEEE754_MANTISSA_MASK, reg_val);
+	s64 value;
+	int shift;
+
+	/* Exponent 0xff encodes infinity or NaN. */
+	if (exponent == IEEE754_EXP_SPECIAL)
+		return -EINVAL;
+
+	/* Subnormal values are smaller than one millidegree Celsius. */
+	if (!exponent) {
+		*temperature = 0;
+		return 0;
+	}
+
+	value = (s64)(mantissa | BIT(IEEE754_MANTISSA_BITS)) * MILLIDEGREE_PER_DEGREE;
+	shift = exponent - (IEEE754_EXP_BIAS + IEEE754_MANTISSA_BITS);
+	if (shift >= 0) {
+		if (shift >= BITS_PER_LONG || value > (LONG_MAX >> shift))
+			return -ERANGE;
+		value <<= shift;
+	} else if (shift > -64) {
+		value >>= -shift;
+	} else {
+		value = 0;
+	}
+
+	/* Ensure the magnitude fits in long, which is 32-bit on some arches. */
+	if (value > LONG_MAX)
+		return -ERANGE;
+
+	if (reg_val & IEEE754_SIGN)
+		value = -value;
+
+	*temperature = value;
+	return 0;
+}
+
 static int
 xe_hwmon_temp_read(struct xe_hwmon *hwmon, u32 attr, int channel, long *val)
 {
@@ -1254,26 +1318,27 @@ xe_hwmon_temp_read(struct xe_hwmon *hwmon, u32 attr, int channel, long *val)
 	switch (attr) {
 	case hwmon_temp_input:
 		switch (channel) {
-		case CHANNEL_PKG:
-		case CHANNEL_VRAM:
-			reg_val = xe_mmio_read32(mmio, xe_hwmon_get_reg(hwmon, REG_TEMP, channel));
-
-			/* HW register value is in degrees Celsius, convert to millidegrees. */
-			*val = REG_FIELD_GET(TEMP_MASK, reg_val) * MILLIDEGREE_PER_DEGREE;
-			return 0;
 		case CHANNEL_MCTRL:
 			return get_mc_temp(hwmon, val);
 		case CHANNEL_PCIE:
 			return get_pcie_temp(hwmon, val);
+		case CHANNEL_PKG:
+		case CHANNEL_VRAM:
 		case CHANNEL_VRAM_N...CHANNEL_VRAM_N_MAX:
 			reg_val = xe_mmio_read32(mmio, xe_hwmon_get_reg(hwmon, REG_TEMP, channel));
-			/*
-			 * This temperature format is 24 bit [31:8] signed integer and 8 bit
-			 * [7:0] fraction.
-			 */
-			*val = (s32)(REG_FIELD_GET(TEMP_MASK_VRAM_N, reg_val)) *
-				(REG_FIELD_GET(TEMP_SIGN_MASK, reg_val) ? -1 : 1) *
-				 MILLIDEGREE_PER_DEGREE;
+			if (hwmon->xe->info.platform >= XE_CRESCENTISLAND) {
+				return xe_hwmon_temperature_decode((u32)reg_val, val);
+			} else if (channel >= CHANNEL_VRAM_N) {
+				/*
+				 * This temperature format is 24 bit [31:8] signed integer and 8 bit
+				 * [7:0] fraction for platforms before CRI.
+				 */
+				*val = (s32)REG_FIELD_GET(TEMP_MASK_VRAM_N, reg_val) *
+					(REG_FIELD_GET(TEMP_SIGN_MASK, reg_val) ? -1 : 1) *
+					MILLIDEGREE_PER_DEGREE;
+			} else {
+				*val = REG_FIELD_GET(TEMP_MASK, reg_val) * MILLIDEGREE_PER_DEGREE;
+			}
 			return 0;
 		default:
 			return -EOPNOTSUPP;
-- 
2.25.1

[PATCH v9 12/14] drm/xe/hwmon: Update memory controller temperature offset for CRI

[Karthik Poosa]

On CRI the memory controller temperatures moved in the READ_THERMAL_DATA
output: they now occupy bytes 16..19 instead of starting at byte 2.

Read and average the CRI memory controller sensors from bytes 16..19,
keeping the existing byte 2..count-1 range for earlier platforms. Only
the group(s) covering the used bytes are fetched.

Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_hwmon.c | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index 8617b5e84b50..7fe3ba422cc8 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -109,6 +109,10 @@ enum sensor_attr_power {
 /* Index of memory controller in READ_THERMAL_DATA output */
 #define TEMP_INDEX_MCTRL	2
 
+/* On CRI the memory controller temperatures are READ_THERMAL_DATA bytes 16..19. */
+#define CRI_TEMP_INDEX_MCTRL	16
+#define CRI_TEMP_MCTRL_COUNT	4
+
 /* Mailbox sentinel reported for an unavailable temperature sensor */
 #define TEMP_MBX_INVALID	0xFF
 
@@ -969,10 +973,19 @@ static int mbx_temp_decode(u8 value)
 static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
 {
 	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
-	int ret, i, count = 0;
+	int ret, i, start, end, count = 0;
 	s32 average = 0;
 
-	for (i = 0; i < DIV_ROUND_UP(hwmon->temp.count, sizeof(u32)); i++) {
+	/* CRI relocated the memory controller temperatures to READ_THERMAL_DATA bytes 16..19. */
+	if (hwmon->xe->info.platform >= XE_CRESCENTISLAND) {
+		start = CRI_TEMP_INDEX_MCTRL;
+		end = CRI_TEMP_INDEX_MCTRL + CRI_TEMP_MCTRL_COUNT;
+	} else {
+		start = TEMP_INDEX_MCTRL;
+		end = hwmon->temp.count - 1;
+	}
+
+	for (i = start / sizeof(u32); i < DIV_ROUND_UP(end, sizeof(u32)); i++) {
 		ret = xe_pcode_read(root_tile, PCODE_MBOX(PCODE_THERMAL_INFO, READ_THERMAL_DATA, i),
 				    &hwmon->temp.dword[i], NULL);
 		if (ret)
@@ -981,7 +994,7 @@ static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
 			hwmon->temp.dword[i]);
 	}
 
-	for (i = TEMP_INDEX_MCTRL; i < hwmon->temp.count - 1; i++) {
+	for (i = start; i < end; i++) {
 		if (!mbx_temp_valid(hwmon, hwmon->temp.value[i]))
 			continue;
 		average += mbx_temp_decode(hwmon->temp.value[i]);
-- 
2.25.1

[PATCH v9 13/14] drm/xe/hwmon: add PCIe temperature support for CRI

[Karthik Poosa]

Add the PCIe temperature sensor offset in READ_THERMAL_DATA for CRI.

Refactor PCIe temperature handling to use platform-specific sensor
indices and derive the mailbox group and byte offset from the sensor
index, eliminating special-case decoding logic.

Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
---
 drivers/gpu/drm/xe/xe_hwmon.c     | 26 +++++++++++++++++++++-----
 drivers/gpu/drm/xe/xe_pcode_api.h |  2 --
 2 files changed, 21 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index 7fe3ba422cc8..1c67e510dba5 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -108,10 +108,13 @@ enum sensor_attr_power {
 
 /* Index of memory controller in READ_THERMAL_DATA output */
 #define TEMP_INDEX_MCTRL	2
+#define TEMP_INDEX_PCIE		10
+#define BMG_G21_TEMP_INDEX_PCIE	8
 
 /* On CRI the memory controller temperatures are READ_THERMAL_DATA bytes 16..19. */
 #define CRI_TEMP_INDEX_MCTRL	16
 #define CRI_TEMP_MCTRL_COUNT	4
+#define CRI_TEMP_INDEX_PCIE	20
 
 /* Mailbox sentinel reported for an unavailable temperature sensor */
 #define TEMP_MBX_INVALID	0xFF
@@ -1014,21 +1017,34 @@ static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
 	return 0;
 }
 
+static u8 xe_hwmon_pcie_temp_index(struct xe_hwmon *hwmon)
+{
+	if (hwmon->xe->info.platform == XE_CRESCENTISLAND)
+		return CRI_TEMP_INDEX_PCIE;
+
+	if (hwmon->xe->info.subplatform == XE_SUBPLATFORM_BATTLEMAGE_G21)
+		return BMG_G21_TEMP_INDEX_PCIE;
+
+	return TEMP_INDEX_PCIE;
+}
+
 static int get_pcie_temp(struct xe_hwmon *hwmon, long *val)
 {
 	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
 	u32 data = 0;
+	u32 group;
+	u32 byte;
+	u8 index = xe_hwmon_pcie_temp_index(hwmon);
 	int ret;
 
+	group = index / sizeof(data);
+	byte = index % sizeof(data);
 	ret = xe_pcode_read(root_tile, PCODE_MBOX(PCODE_THERMAL_INFO, READ_THERMAL_DATA,
-						  PCIE_SENSOR_GROUP_ID), &data, NULL);
+						  group), &data, NULL);
 	if (ret)
 		return ret;
 
-	/* Sensor offset is different for G21 */
-	if (hwmon->xe->info.subplatform != XE_SUBPLATFORM_BATTLEMAGE_G21)
-		data = REG_FIELD_GET(PCIE_SENSOR_MASK, data);
-
+	data >>= byte * BITS_PER_BYTE;
 	data = REG_FIELD_GET(TEMP_MASK, data);
 	if (!mbx_temp_valid(hwmon, data)) {
 		drm_dbg(&hwmon->xe->drm, "PCIe temperature not available\n");
diff --git a/drivers/gpu/drm/xe/xe_pcode_api.h b/drivers/gpu/drm/xe/xe_pcode_api.h
index 94575c476e3d..00c4fc7d0124 100644
--- a/drivers/gpu/drm/xe/xe_pcode_api.h
+++ b/drivers/gpu/drm/xe/xe_pcode_api.h
@@ -58,8 +58,6 @@
 #define     READ_THERMAL_LIMITS			0x0
 #define     READ_THERMAL_CONFIG			0x1
 #define     READ_THERMAL_DATA			0x2
-#define       PCIE_SENSOR_GROUP_ID		0x2
-#define       PCIE_SENSOR_MASK			REG_GENMASK(31, 16)
 
 #define   PCODE_LATE_BINDING			0x5C
 #define     GET_CAPABILITY_STATUS		0x0
-- 
2.25.1

[PATCH v9 14/14] drm/xe/hwmon: Simplify temperature channels config

[Karthik Poosa]

Replace the repeated temperature channels list with an indexed config
array. Use range designators for channels sharing the same attributes.

Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Assisted-by: LLM
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_hwmon.c | 104 ++++++----------------------------
 1 file changed, 17 insertions(+), 87 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index 1c67e510dba5..ea3d1be72181 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -803,94 +803,24 @@ static const struct attribute_group *hwmon_groups[] = {
 	NULL
 };
 
+static const u32 hwmon_temp_config[CHANNEL_MAX + 1] = {
+	[CHANNEL_CARD] = HWMON_T_LABEL,
+	[CHANNEL_PKG] = HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT |
+			 HWMON_T_LABEL | HWMON_T_MAX,
+	[CHANNEL_VRAM ... CHANNEL_PCIE] = HWMON_T_CRIT | HWMON_T_EMERGENCY |
+					 HWMON_T_INPUT | HWMON_T_LABEL,
+	[CHANNEL_VRAM_N ... CHANNEL_VRAM_N_MAX] = HWMON_T_CRIT | HWMON_T_EMERGENCY |
+							 HWMON_T_INPUT | HWMON_T_LABEL,
+	[CHANNEL_MAX] = 0, /* hwmon config terminator */
+};
+
+static const struct hwmon_channel_info hwmon_temp_info = {
+	.type = hwmon_temp,
+	.config = hwmon_temp_config,
+};
+
 static const struct hwmon_channel_info * const hwmon_info[] = {
-	HWMON_CHANNEL_INFO(temp,
-			   HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL |
-			   HWMON_T_MAX,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL),
+	&hwmon_temp_info,
 	HWMON_CHANNEL_INFO(power, HWMON_P_MAX | HWMON_P_RATED_MAX | HWMON_P_LABEL | HWMON_P_CRIT |
 			   HWMON_P_CAP,
 			   HWMON_P_MAX | HWMON_P_RATED_MAX | HWMON_P_LABEL | HWMON_P_CAP),
-- 
2.25.1

Re: [PATCH v9 01/14] drm/xe/hwmon: Handle pcode read failures of xe_hwmon_pcode_rmw_power_limit

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] drm/xe/hwmon: unchecked return value from xe_hwmon_pcode_rmw_power_limit()
- [Medium] hwmon: ignored pcode read errors fabricate valid sysfs responses
--

commit 6cc9575a02c32b9a8a28e257650ff7b17698865f
Author: Karthik Poosa <karthik.poosa@intel.com>

drm/xe/hwmon: Handle pcode read failures of xe_hwmon_pcode_rmw_power_limit

This commit adds a return on read failures inside
xe_hwmon_pcode_rmw_power_limit and updates callers to avoid updating
power limit settings with invalid data.

> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
> index 5edeac961ec33..9884e06f83e59 100644
> --- a/drivers/gpu/drm/xe/xe_hwmon.c
> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
> @@ -232,9 +232,11 @@ static int xe_hwmon_pcode_rmw_power_limit(const struct xe_hwmon *hwmon, u32 attr
>  						  READ_PSYSGPU_POWER_LIMIT :
>  						  READ_PACKAGE_POWER_LIMIT,
>  						  prepare_power_limit_param2(hwmon)), &val0, &val1);
> -	if (ret)
> -		drm_dbg(&hwmon->xe->drm, "read failed ch %d val0 0x%08x, val1 0x%08x, ret %d\n",
> +	if (ret) {
> +		drm_err(&hwmon->xe->drm, "read failed ch %d val0 0x%08x, val1 0x%08x, ret %d\n",
>  			channel, val0, val1, ret);
> +		return ret;
> +	}

[Severity: Medium]
Since this function now returns early on error, skipping the subsequent PCODE
writes, could this cause regressions in xe_hwmon_get_preregistration_info?

In xe_hwmon_get_preregistration_info, there are four calls to this function
that ignore the return value. If these initialization writes fail, the
function still sets hwmon->boot_power_limit_read = true.

Setting this flag alters the subcommand used for later reads, changing it from
READ_PL_FROM_FW to READ_PL_FROM_PCODE. Could this cause userspace to receive
incorrect power limit values if the initial writes were aborted?

[ ... ]
> @@ -394,7 +396,9 @@ static int xe_hwmon_power_max_write(struct xe_hwmon *hwmon, u32 attr, int channe
>  		if (hwmon->xe->info.has_mbx_power_limits) {
>  			drm_dbg(&hwmon->xe->drm, "disabling %s on channel %d\n",
>  				PWR_ATTR_TO_STR(attr), channel);
> -			xe_hwmon_pcode_rmw_power_limit(hwmon, attr, channel, PWR_LIM_EN, 0);
> +			ret = xe_hwmon_pcode_rmw_power_limit(hwmon, attr, channel, PWR_LIM_EN, 0);
> +			if (ret)
> +				goto unlock;
>  			xe_hwmon_pcode_read_power_limit(hwmon, attr, channel, &reg_val);

[Severity: Medium]
Is it intentional that the return value of xe_hwmon_pcode_read_power_limit is
discarded right after checking the write failure?

If this read fails due to a hardware timeout, it could leave reg_val
uninitialized or zeroed, bypassing the disable verification check that follows.

Additionally, could the ignored read errors in xe_hwmon_power_max_read
fabricate valid sysfs responses? If xe_hwmon_pcode_read_power_limit fails in
that function, it returns fake 0 readings instead of propagating the hardware
error, which might mislead userspace tools into believing the power limit is
disabled.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009120335.52973-1-karthik.poosa@intel.com?part=1

Re: [PATCH v9 03/14] drm/xe/hwmon: Fix memory controller thermal data handling

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] xe: endianness bug when unpacking thermal sensor values via union overlay
--

commit 99c258fb8e157f67678f926764db2d41f2794285
Author: Karthik Poosa <karthik.poosa@intel.com>

drm/xe/hwmon: Fix memory controller thermal data handling

This commit updates get_mc_temp() to read all required thermal groups and uses
an aligned u32 buffer for PCODE accesses to avoid unaligned memory accesses
and ensure correct MC temperature reporting.

> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
> index c63aa708ab6fc..33d0ca7d86e44 100644
> --- a/drivers/gpu/drm/xe/xe_hwmon.c
> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
> @@ -143,8 +143,12 @@ struct xe_hwmon_thermal_info {
>  	};
>  	/** @count: no of temperature sensors available for the platform */
>  	u8 count;
> -	/** @value: per-sensor raw mailbox temperature; bit7=sign, bits6:0=magnitude */
> -	u8 value[U8_MAX];
> +	union {
> +		/** @value: per-sensor raw mailbox temperature; bit7=sign, bits6:0=magnitude */
> +		u8 value[U8_MAX + 1];
> +		/** @dword: sensor values as dwords, u32-aligned for pcode reads */
> +		u32 dword[DIV_ROUND_UP(U8_MAX + 1, sizeof(u32))];
> +	};
>  	/** @vram_label: vram label names */
>  	char vram_label[MAX_VRAM_CHANNELS][MAX_LABEL_SIZE];
>  };

[Severity: Low]
Does this struct layout rely on a little-endian memory layout?

Overlaying a byte array over a dword array via a union structurally embeds an
endianness assumption. On big-endian architectures, the bytes of the 32-bit
hardware registers unpacked into the dword array would be reversed when
accessed through the value array.

[ ... ]
> @@ -831,16 +835,16 @@ static int mbx_temp_decode(u8 value)
>  static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
>  {
>  	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
> -	u32 *dword = (u32 *)hwmon->temp.value;
>  	s32 average = 0;
>  	int ret, i;
>  
> -	for (i = 0; i < DIV_ROUND_UP(TEMP_LIMIT_MAX, sizeof(u32)); i++) {
> +	for (i = 0; i < DIV_ROUND_UP(hwmon->temp.count, sizeof(u32)); i++) {
>  		ret = xe_pcode_read(root_tile, PCODE_MBOX(PCODE_THERMAL_INFO, READ_THERMAL_DATA, i),
> -				    (dword + i), NULL);
> +				    &hwmon->temp.dword[i], NULL);
>  		if (ret)
>  			return ret;
> -		drm_dbg(&hwmon->xe->drm, "thermal data for group %d val 0x%x\n", i, dword[i]);
> +		drm_dbg(&hwmon->xe->drm, "thermal data for group %d val 0x%x\n", i,
> +			hwmon->temp.dword[i]);
>  	}
>  
>  	for (i = TEMP_INDEX_MCTRL; i < hwmon->temp.count - 1; i++)
>  		average += mbx_temp_decode(hwmon->temp.value[i]);

[Severity: Low]
Does this regression decode the wrong byte from the 32-bit hardware register
on big-endian systems?

Since the value array aliases the dword array in xe_hwmon_thermal_info, this
loop will extract incorrect bytes on big-endian architectures and report the
wrong temperatures.

While Intel GPUs are rarely deployed on big-endian hosts, the xe driver's
Kconfig does not restrict compilation to little-endian or x86 architectures.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009120335.52973-1-karthik.poosa@intel.com?part=3

Re: [PATCH v9 07/14] drm/xe/hwmon: Consolidate temperature sensor availability checks

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] drm/xe/hwmon: live hardware read during probe permanently hides sysfs attributes on transient failure
- [Medium] drm/xe/hwmon: endianness bug when extracting thermal limits via union
--

commit bbb594b78c17c03bdb11a59f0ce797f39d14c3e9
Author: Karthik Poosa <karthik.poosa@intel.com>
Subject: drm/xe/hwmon: Consolidate temperature sensor availability checks

This commit replaces is_vram_ch_available() with a generalized
is_temp_available() function that validates multiple sensor types using new
helpers. It uses this new function during hwmon registration to ensure
attributes for absent sensors are not exposed.

> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
> index accccadbe3e67..62e341ef37e9b 100644
> --- a/drivers/gpu/drm/xe/xe_hwmon.c
> +++ b/drivers/gpu/drm/xe/xe_hwmon.c

[ ... ]

> @@ -1008,19 +1008,39 @@ static void xe_hwmon_get_voltage(struct xe_hwmon *hwmon, int channel, long *valu
>  	*value = DIV_ROUND_CLOSEST(REG_FIELD_GET(VOLTAGE_MASK, reg_val) * 2500, SF_VOLTAGE);
>  }
>  
> -static inline bool is_vram_ch_available(struct xe_hwmon *hwmon, int channel)
> +static bool is_temp_available(struct xe_hwmon *hwmon, int channel)
>  {
>  	struct xe_mmio *mmio = xe_root_tile_mmio(hwmon->xe);
> -	int vram_id = channel - CHANNEL_VRAM_N;
> -	struct xe_reg vram_reg;
> +	struct xe_reg reg;
> +	u32 reg_val;
>  
> -	vram_reg = xe_hwmon_get_reg(hwmon, REG_TEMP, channel);
> -	if (!xe_reg_is_valid(vram_reg) || !xe_mmio_read32(mmio, vram_reg))
> -		return false;
> +	switch (channel) {
> +	case CHANNEL_PKG:
> +	case CHANNEL_VRAM:
> +	case CHANNEL_VRAM_N...CHANNEL_VRAM_N_MAX:
> +		reg = xe_hwmon_get_reg(hwmon, REG_TEMP, channel);
> +		if (!xe_reg_is_valid(reg))
> +			return false;
> +
> +		reg_val = xe_mmio_read32(mmio, reg);
> +		if (!mmio_temp_valid(hwmon, reg_val)) {

[Severity: Medium]
Since this function is called during hwmon registration to determine attribute
visibility, does this live hardware read risk permanently hiding sysfs
attributes if the hardware is transiently busy or uninitialized?

If the sensor returns 0 (which mmio_temp_valid treats as invalid) during
driver probe, the attribute will be hidden for the entire boot cycle.

> +			drm_dbg(&hwmon->xe->drm,
> +				"channel %d temperature unavailable, val 0x%x\n", channel, reg_val);
> +			return false;
> +		}
> +
> +		if (channel >= CHANNEL_VRAM_N)
> +			sprintf(hwmon->temp.vram_label[channel - CHANNEL_VRAM_N],
> +				"vram_ch_%d", channel - CHANNEL_VRAM_N);
>  
> -	/* Create label only for available vram channel */
> -	sprintf(hwmon->temp.vram_label[vram_id], "vram_ch_%d", vram_id);
> -	return true;
> +		return true;
> +	case CHANNEL_MCTRL:
> +		return hwmon->temp.count && !get_mc_temp(hwmon, NULL);

[Severity: Medium]
Similar to the MMIO read above, could this PCODE mailbox read cause
attributes to be permanently hidden?

If the PCODE mailbox transiently times out during driver probe,
get_mc_temp() will return an error, causing the MCTRL attribute to be
permanently hidden for the duration of the boot cycle.

> +	case CHANNEL_PCIE:
> +		return hwmon->temp.count && !get_pcie_temp(hwmon, NULL);
> +	default:
> +		return false;
> +	}
>  }
>  
>  static umode_t
> @@ -1030,14 +1050,13 @@ xe_hwmon_temp_is_visible(struct xe_hwmon *hwmon, u32 attr, int channel)
>  	case hwmon_temp_emergency:
>  		switch (channel) {
>  		case CHANNEL_PKG:
> -			return hwmon->temp.limit[TEMP_LIMIT_PKG_SHUTDOWN] ? 0444 : 0;
> -		case CHANNEL_VRAM:
> -			return hwmon->temp.limit[TEMP_LIMIT_MEM_SHUTDOWN] ? 0444 : 0;
>  		case CHANNEL_MCTRL:
>  		case CHANNEL_PCIE:
> -			return hwmon->temp.count ? 0444 : 0;
> +			return (is_temp_available(hwmon, channel) &&
> +				hwmon->temp.limit[TEMP_LIMIT_PKG_SHUTDOWN]) ? 0444 : 0;

[Severity: Medium]
Does extracting thermal limits this way introduce an endianness bug?

While looking at how the limits are accessed here, the xe_hwmon_thermal_info
struct aliases u8 arrays with u32 arrays:

        union {
                u8 limit[TEMP_LIMIT_MAX];
                u32 data[DIV_ROUND_UP(TEMP_LIMIT_MAX, sizeof(u32))];
        };

If the driver reads 32-bit values from PCODE into the u32 arrays, extracting
individual 8-bit limits by indexing into the u8 arrays assumes a little-endian
memory layout. On big-endian architectures, index 0 will map to bits 24:31
instead of bits 0:7, potentially causing the driver to extract incorrect
thermal limits.

> +		case CHANNEL_VRAM:
>  		case CHANNEL_VRAM_N...CHANNEL_VRAM_N_MAX:
> -			return (is_vram_ch_available(hwmon, channel) &&
> +			return (is_temp_available(hwmon, channel) &&
>  				hwmon->temp.limit[TEMP_LIMIT_MEM_SHUTDOWN]) ? 0444 : 0;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009120335.52973-1-karthik.poosa@intel.com?part=7

✓ CI.KUnit: success for drm/xe/hwmon: Update hwmon thermal mailbox (rev6)

[Patchwork]

== Series Details ==

Series: drm/xe/hwmon: Update hwmon thermal mailbox (rev6)
URL   : https://patchwork.freedesktop.org/series/174898/
State : success

== Summary ==

+ trap cleanup EXIT
+ kunitconfigs=('/kernel/drivers/gpu/tests/.kunitconfig' '/kernel/drivers/gpu/drm/xe/.kunitconfig' '/kernel/drivers/gpu/drm/tests/.kunitconfig' '/kernel/drivers/gpu/drm/ttm/tests/.kunitconfig' '/kernel/drivers/dma-buf/.kunitconfig')
+ for kcfg in "${kunitconfigs[@]}"
+ [[ ! -f /kernel/drivers/gpu/tests/.kunitconfig ]]
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/tests/.kunitconfig
[12:15:04] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[12:15:08] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[12:15:28] Starting KUnit Kernel (1/1)...
[12:15:28] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[12:15:29] ================= gpu_buddy (14 subtests) ==================
[12:15:29] [PASSED] gpu_test_buddy_alloc_limit
[12:15:29] [PASSED] gpu_test_buddy_alloc_optimistic
[12:15:29] [PASSED] gpu_test_buddy_alloc_pessimistic
[12:15:29] [PASSED] gpu_test_buddy_alloc_pathological
[12:15:29] [PASSED] gpu_test_buddy_alloc_contiguous
[12:15:29] [PASSED] gpu_test_buddy_alloc_clear
[12:15:29] [PASSED] gpu_test_buddy_alloc_range
[12:15:29] [PASSED] gpu_test_buddy_alloc_range_bias
[12:15:30] [PASSED] gpu_test_buddy_fragmentation_performance
[12:15:30] [PASSED] gpu_test_buddy_dirty_tracker_performance
[12:15:30] [PASSED] gpu_test_buddy_alloc_exceeds_max_order
[12:15:30] [PASSED] gpu_test_buddy_offset_aligned_allocation
[12:15:30] [PASSED] gpu_test_buddy_subtree_offset_alignment_stress
[12:15:30] [PASSED] gpu_test_buddy_addr_to_block
[12:15:30] ==================== [PASSED] gpu_buddy ====================
[12:15:30] ============================================================
[12:15:30] Testing complete. Ran 14 tests: passed: 14
[12:15:30] Elapsed time: 26.648s total, 4.454s configuring, 20.327s building, 1.828s running

+ for kcfg in "${kunitconfigs[@]}"
+ [[ ! -f /kernel/drivers/gpu/drm/xe/.kunitconfig ]]
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig
[12:15:30] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[12:15:32] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[12:16:06] Starting KUnit Kernel (1/1)...
[12:16:06] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[12:16:07] ================== guc_buf (11 subtests) ===================
[12:16:07] [PASSED] test_smallest
[12:16:07] [PASSED] test_largest
[12:16:07] [PASSED] test_granular
[12:16:07] [PASSED] test_unique
[12:16:07] [PASSED] test_overlap
[12:16:07] [PASSED] test_reusable
[12:16:07] [PASSED] test_too_big
[12:16:07] [PASSED] test_flush
[12:16:07] [PASSED] test_lookup
[12:16:07] [PASSED] test_data
[12:16:07] [PASSED] test_class
[12:16:07] ===================== [PASSED] guc_buf =====================
[12:16:07] =================== guc_dbm (7 subtests) ===================
[12:16:07] [PASSED] test_empty
[12:16:07] [PASSED] test_default
[12:16:07] ======================== test_size  ========================
[12:16:07] [PASSED] 4
[12:16:07] [PASSED] 8
[12:16:07] [PASSED] 32
[12:16:07] [PASSED] 256
[12:16:07] ==================== [PASSED] test_size ====================
[12:16:07] ======================= test_reuse  ========================
[12:16:07] [PASSED] 4
[12:16:07] [PASSED] 8
[12:16:07] [PASSED] 32
[12:16:07] [PASSED] 256
[12:16:07] =================== [PASSED] test_reuse ====================
[12:16:07] =================== test_range_overlap  ====================
[12:16:07] [PASSED] 4
[12:16:07] [PASSED] 8
[12:16:07] [PASSED] 32
[12:16:07] [PASSED] 256
[12:16:07] =============== [PASSED] test_range_overlap ================
[12:16:07] =================== test_range_compact  ====================
[12:16:07] [PASSED] 4
[12:16:07] [PASSED] 8
[12:16:07] [PASSED] 32
[12:16:07] [PASSED] 256
[12:16:07] =============== [PASSED] test_range_compact ================
[12:16:07] ==================== test_range_spare  =====================
[12:16:07] [PASSED] 4
[12:16:07] [PASSED] 8
[12:16:07] [PASSED] 32
[12:16:07] [PASSED] 256
[12:16:07] ================ [PASSED] test_range_spare =================
[12:16:07] ===================== [PASSED] guc_dbm =====================
[12:16:07] =================== guc_idm (6 subtests) ===================
[12:16:07] [PASSED] bad_init
[12:16:07] [PASSED] no_init
[12:16:07] [PASSED] init_fini
[12:16:07] [PASSED] check_used
[12:16:07] [PASSED] check_quota
[12:16:07] [PASSED] check_all
[12:16:07] ===================== [PASSED] guc_idm =====================
[12:16:07] ============== guc_klv_helpers (13 subtests) ===============
[12:16:07] [PASSED] test_count
[12:16:07] [PASSED] test_encode_u32
[12:16:07] [PASSED] test_encode_u64
[12:16:07] [PASSED] test_encode_string
[12:16:07] [PASSED] test_encode_object_raw
[12:16:07] [PASSED] test_encode_object_klv
[12:16:07] [PASSED] test_encode_object_nested
[12:16:07] [PASSED] test_encode_object_basic
[12:16:07] ===================== test_decode_u16  =====================
[12:16:07] [PASSED] empty
[12:16:07] [PASSED] valid
[12:16:07] [PASSED] max
[12:16:07] [PASSED] big
[12:16:07] [PASSED] long
[12:16:07] ================= [PASSED] test_decode_u16 =================
[12:16:07] ===================== test_decode_u32  =====================
[12:16:07] [PASSED] empty
[12:16:07] [PASSED] valid
[12:16:07] [PASSED] max
[12:16:07] [PASSED] long
[12:16:07] ================= [PASSED] test_decode_u32 =================
[12:16:07] ===================== test_decode_u64  =====================
[12:16:07] [PASSED] empty
[12:16:07] [PASSED] short
[12:16:07] [PASSED] valid
[12:16:07] [PASSED] max
[12:16:07] [PASSED] long
[12:16:07] ================= [PASSED] test_decode_u64 =================
[12:16:07] ===================== test_decode_str  =====================
[12:16:07] [PASSED] empty
[12:16:07] [PASSED] one
[12:16:07] [PASSED] one_trash
[12:16:07] [PASSED] two
[12:16:07] [PASSED] two_trash
[12:16:07] [PASSED] three
[12:16:07] [PASSED] dword
[12:16:07] [PASSED] four
[12:16:07] [PASSED] five
[12:16:07] [PASSED] six
[12:16:07] [PASSED] seven
[12:16:07] [PASSED] qword
[12:16:07] ================= [PASSED] test_decode_str =================
[12:16:07] [PASSED] test_print
[12:16:07] ================= [PASSED] guc_klv_helpers =================
[12:16:07] =================== xe_log (4 subtests) ====================
[12:16:07] [PASSED] demo_cper
[12:16:07] [PASSED] demo_dmesg
[12:16:07] ======================= test_dmesg  ========================
[12:16:07] [PASSED] test_fatal
[12:16:07] [PASSED] test_fatal_tile
[12:16:07] [PASSED] test_fatal_gt
[12:16:07] [PASSED] test_fatal_comp
[12:16:07] [PASSED] test_fatal_comp_tile
[12:16:07] [PASSED] test_fatal_comp_gt
[12:16:07] [PASSED] test_fatal_all
[12:16:07] [PASSED] test_recoverable
[12:16:07] [PASSED] test_recoverable_tile
[12:16:07] [PASSED] test_recoverable_gt
[12:16:07] [PASSED] test_recoverable_comp
[12:16:07] [PASSED] test_recoverable_comp_tile
[12:16:07] [PASSED] test_recoverable_comp_gt
[12:16:07] [PASSED] test_recoverable_all
[12:16:07] [PASSED] test_info
[12:16:07] [PASSED] test_info_tile
[12:16:07] [PASSED] test_info_gt
[12:16:07] [PASSED] test_info_err
[12:16:07] [PASSED] test_info_comp
[12:16:07] [PASSED] test_info_comp_tile
[12:16:07] [PASSED] test_info_comp_gt
[12:16:07] [PASSED] test_info_all
[12:16:07] [PASSED] test_hw_fatal
[12:16:07] [PASSED] test_hw_recoverable
[12:16:07] [PASSED] test_hw_corrected
[12:16:07] [PASSED] test_hw_informational
[12:16:07] =================== [PASSED] test_dmesg ====================
[12:16:07] ====================== test_invalid  =======================
[12:16:07] [SKIPPED] no-component no-location no-warn (requires CONFIG_DRM_XE_DEBUG)
[12:16:07] [SKIPPED] reserved location (requires CONFIG_DRM_XE_DEBUG)
[12:16:07] [SKIPPED] unknown location (requires CONFIG_DRM_XE_DEBUG)
[12:16:07] [SKIPPED] nonzero-device-id location (requires CONFIG_DRM_XE_DEBUG)
[12:16:07] [SKIPPED] invalid-tile-id location (requires CONFIG_DRM_XE_DEBUG)
[12:16:07] [SKIPPED] invalid-gt-id location (requires CONFIG_DRM_XE_DEBUG)
[12:16:07] [SKIPPED] unknown component class (requires CONFIG_DRM_XE_DEBUG)
[12:16:07] [SKIPPED] unknown system component (requires CONFIG_DRM_XE_DEBUG)
[12:16:07] [SKIPPED] unknown hardware component (requires CONFIG_DRM_XE_DEBUG)
[12:16:07] [SKIPPED] unknown component and location (requires CONFIG_DRM_XE_DEBUG)
[12:16:07] ================== [SKIPPED] test_invalid ==================
[12:16:07] ===================== [PASSED] xe_log ======================
[12:16:07] ================== no_relay (3 subtests) ===================
[12:16:07] [PASSED] xe_drops_guc2pf_if_not_ready
[12:16:07] [PASSED] xe_drops_guc2vf_if_not_ready
[12:16:07] [PASSED] xe_rejects_send_if_not_ready
[12:16:07] ==================== [PASSED] no_relay =====================
[12:16:07] ================== pf_relay (14 subtests) ==================
[12:16:07] [PASSED] pf_rejects_guc2pf_too_short
[12:16:07] [PASSED] pf_rejects_guc2pf_too_long
[12:16:07] [PASSED] pf_rejects_guc2pf_no_payload
[12:16:07] [PASSED] pf_fails_no_payload
[12:16:07] [PASSED] pf_fails_bad_origin
[12:16:07] [PASSED] pf_fails_bad_type
[12:16:07] [PASSED] pf_txn_reports_error
[12:16:07] [PASSED] pf_txn_sends_pf2guc
[12:16:07] [PASSED] pf_sends_pf2guc
[12:16:07] [SKIPPED] pf_loopback_nop (requires CONFIG_DRM_XE_DEBUG_SRIOV)
[12:16:07] [SKIPPED] pf_loopback_echo (requires CONFIG_DRM_XE_DEBUG_SRIOV)
[12:16:07] [SKIPPED] pf_loopback_fail (requires CONFIG_DRM_XE_DEBUG_SRIOV)
[12:16:07] [SKIPPED] pf_loopback_busy (requires CONFIG_DRM_XE_DEBUG_SRIOV)
[12:16:07] [SKIPPED] pf_loopback_retry (requires CONFIG_DRM_XE_DEBUG_SRIOV)
[12:16:07] ==================== [PASSED] pf_relay =====================
[12:16:07] ================== vf_relay (3 subtests) ===================
[12:16:07] [PASSED] vf_rejects_guc2vf_too_short
[12:16:07] [PASSED] vf_rejects_guc2vf_too_long
[12:16:07] [PASSED] vf_rejects_guc2vf_no_payload
[12:16:07] ==================== [PASSED] vf_relay =====================
[12:16:07] ================ pf_gt_config (9 subtests) =================
[12:16:07] [PASSED] fair_contexts_1vf
[12:16:07] [PASSED] fair_doorbells_1vf
[12:16:07] [PASSED] fair_ggtt_1vf
[12:16:07] ====================== fair_vram_1vf  ======================
[12:16:07] [PASSED] 3.50 GiB
[12:16:07] [PASSED] 11.5 GiB
[12:16:07] [PASSED] 15.5 GiB
[12:16:07] [PASSED] 31.5 GiB
[12:16:07] [PASSED] 63.5 GiB
[12:16:07] [PASSED] 1.91 GiB
[12:16:07] ================== [PASSED] fair_vram_1vf ==================
[12:16:07] ================ fair_vram_1vf_admin_only  =================
[12:16:07] [PASSED] 3.50 GiB
[12:16:07] [PASSED] 11.5 GiB
[12:16:07] [PASSED] 15.5 GiB
[12:16:07] [PASSED] 31.5 GiB
[12:16:07] [PASSED] 63.5 GiB
[12:16:07] [PASSED] 1.91 GiB
[12:16:07] ============ [PASSED] fair_vram_1vf_admin_only =============
[12:16:07] ====================== fair_contexts  ======================
[12:16:07] [PASSED] 1 VF
[12:16:07] [PASSED] 2 VFs
[12:16:07] [PASSED] 3 VFs
[12:16:07] [PASSED] 4 VFs
[12:16:07] [PASSED] 5 VFs
[12:16:07] [PASSED] 6 VFs
[12:16:07] [PASSED] 7 VFs
[12:16:07] [PASSED] 8 VFs
[12:16:07] [PASSED] 9 VFs
[12:16:07] [PASSED] 10 VFs
[12:16:07] [PASSED] 11 VFs
[12:16:07] [PASSED] 12 VFs
[12:16:07] [PASSED] 13 VFs
[12:16:07] [PASSED] 14 VFs
[12:16:07] [PASSED] 15 VFs
[12:16:07] [PASSED] 16 VFs
[12:16:07] [PASSED] 17 VFs
[12:16:07] [PASSED] 18 VFs
[12:16:07] [PASSED] 19 VFs
[12:16:07] [PASSED] 20 VFs
[12:16:07] [PASSED] 21 VFs
[12:16:07] [PASSED] 22 VFs
[12:16:07] [PASSED] 23 VFs
[12:16:07] [PASSED] 24 VFs
[12:16:07] [PASSED] 25 VFs
[12:16:07] [PASSED] 26 VFs
[12:16:07] [PASSED] 27 VFs
[12:16:07] [PASSED] 28 VFs
[12:16:07] [PASSED] 29 VFs
[12:16:07] [PASSED] 30 VFs
[12:16:07] [PASSED] 31 VFs
[12:16:07] [PASSED] 32 VFs
[12:16:07] [PASSED] 33 VFs
[12:16:07] [PASSED] 34 VFs
[12:16:07] [PASSED] 35 VFs
[12:16:07] [PASSED] 36 VFs
[12:16:07] [PASSED] 37 VFs
[12:16:07] [PASSED] 38 VFs
[12:16:07] [PASSED] 39 VFs
[12:16:07] [PASSED] 40 VFs
[12:16:07] [PASSED] 41 VFs
[12:16:07] [PASSED] 42 VFs
[12:16:07] [PASSED] 43 VFs
[12:16:07] [PASSED] 44 VFs
[12:16:07] [PASSED] 45 VFs
[12:16:07] [PASSED] 46 VFs
[12:16:07] [PASSED] 47 VFs
[12:16:07] [PASSED] 48 VFs
[12:16:07] [PASSED] 49 VFs
[12:16:07] [PASSED] 50 VFs
[12:16:07] [PASSED] 51 VFs
[12:16:07] [PASSED] 52 VFs
[12:16:07] [PASSED] 53 VFs
[12:16:07] [PASSED] 54 VFs
[12:16:07] [PASSED] 55 VFs
[12:16:07] [PASSED] 56 VFs
[12:16:07] [PASSED] 57 VFs
[12:16:07] [PASSED] 58 VFs
[12:16:07] [PASSED] 59 VFs
[12:16:07] [PASSED] 60 VFs
[12:16:07] [PASSED] 61 VFs
[12:16:07] [PASSED] 62 VFs
[12:16:07] [PASSED] 63 VFs
[12:16:07] ================== [PASSED] fair_contexts ==================
[12:16:07] ===================== fair_doorbells  ======================
[12:16:07] [PASSED] 1 VF
[12:16:07] [PASSED] 2 VFs
[12:16:07] [PASSED] 3 VFs
[12:16:07] [PASSED] 4 VFs
[12:16:07] [PASSED] 5 VFs
[12:16:07] [PASSED] 6 VFs
[12:16:07] [PASSED] 7 VFs
[12:16:07] [PASSED] 8 VFs
[12:16:07] [PASSED] 9 VFs
[12:16:07] [PASSED] 10 VFs
[12:16:07] [PASSED] 11 VFs
[12:16:07] [PASSED] 12 VFs
[12:16:07] [PASSED] 13 VFs
[12:16:07] [PASSED] 14 VFs
[12:16:07] [PASSED] 15 VFs
[12:16:07] [PASSED] 16 VFs
[12:16:07] [PASSED] 17 VFs
[12:16:07] [PASSED] 18 VFs
[12:16:07] [PASSED] 19 VFs
[12:16:07] [PASSED] 20 VFs
[12:16:07] [PASSED] 21 VFs
[12:16:07] [PASSED] 22 VFs
[12:16:07] [PASSED] 23 VFs
[12:16:07] [PASSED] 24 VFs
[12:16:07] [PASSED] 25 VFs
[12:16:07] [PASSED] 26 VFs
[12:16:07] [PASSED] 27 VFs
[12:16:07] [PASSED] 28 VFs
[12:16:07] [PASSED] 29 VFs
[12:16:07] [PASSED] 30 VFs
[12:16:07] [PASSED] 31 VFs
[12:16:07] [PASSED] 32 VFs
[12:16:07] [PASSED] 33 VFs
[12:16:07] [PASSED] 34 VFs
[12:16:07] [PASSED] 35 VFs
[12:16:07] [PASSED] 36 VFs
[12:16:07] [PASSED] 37 VFs
[12:16:07] [PASSED] 38 VFs
[12:16:07] [PASSED] 39 VFs
[12:16:07] [PASSED] 40 VFs
[12:16:07] [PASSED] 41 VFs
[12:16:07] [PASSED] 42 VFs
[12:16:07] [PASSED] 43 VFs
[12:16:07] [PASSED] 44 VFs
[12:16:07] [PASSED] 45 VFs
[12:16:07] [PASSED] 46 VFs
[12:16:07] [PASSED] 47 VFs
[12:16:07] [PASSED] 48 VFs
[12:16:07] [PASSED] 49 VFs
[12:16:07] [PASSED] 50 VFs
[12:16:07] [PASSED] 51 VFs
[12:16:07] [PASSED] 52 VFs
[12:16:07] [PASSED] 53 VFs
[12:16:07] [PASSED] 54 VFs
[12:16:07] [PASSED] 55 VFs
[12:16:07] [PASSED] 56 VFs
[12:16:07] [PASSED] 57 VFs
[12:16:07] [PASSED] 58 VFs
[12:16:07] [PASSED] 59 VFs
[12:16:07] [PASSED] 60 VFs
[12:16:07] [PASSED] 61 VFs
[12:16:07] [PASSED] 62 VFs
[12:16:07] [PASSED] 63 VFs
[12:16:07] ================= [PASSED] fair_doorbells ==================
[12:16:07] ======================== fair_ggtt  ========================
[12:16:07] [PASSED] 1 VF
[12:16:07] [PASSED] 2 VFs
[12:16:07] [PASSED] 3 VFs
[12:16:07] [PASSED] 4 VFs
[12:16:07] [PASSED] 5 VFs
[12:16:07] [PASSED] 6 VFs
[12:16:07] [PASSED] 7 VFs
[12:16:07] [PASSED] 8 VFs
[12:16:07] [PASSED] 9 VFs
[12:16:07] [PASSED] 10 VFs
[12:16:07] [PASSED] 11 VFs
[12:16:07] [PASSED] 12 VFs
[12:16:07] [PASSED] 13 VFs
[12:16:07] [PASSED] 14 VFs
[12:16:07] [PASSED] 15 VFs
[12:16:07] [PASSED] 16 VFs
[12:16:07] [PASSED] 17 VFs
[12:16:07] [PASSED] 18 VFs
[12:16:07] [PASSED] 19 VFs
[12:16:07] [PASSED] 20 VFs
[12:16:07] [PASSED] 21 VFs
[12:16:07] [PASSED] 22 VFs
[12:16:07] [PASSED] 23 VFs
[12:16:07] [PASSED] 24 VFs
[12:16:07] [PASSED] 25 VFs
[12:16:07] [PASSED] 26 VFs
[12:16:07] [PASSED] 27 VFs
[12:16:07] [PASSED] 28 VFs
[12:16:07] [PASSED] 29 VFs
[12:16:07] [PASSED] 30 VFs
[12:16:07] [PASSED] 31 VFs
[12:16:07] [PASSED] 32 VFs
[12:16:07] [PASSED] 33 VFs
[12:16:07] [PASSED] 34 VFs
[12:16:07] [PASSED] 35 VFs
[12:16:07] [PASSED] 36 VFs
[12:16:07] [PASSED] 37 VFs
[12:16:07] [PASSED] 38 VFs
[12:16:07] [PASSED] 39 VFs
[12:16:07] [PASSED] 40 VFs
[12:16:07] [PASSED] 41 VFs
[12:16:07] [PASSED] 42 VFs
[12:16:07] [PASSED] 43 VFs
[12:16:07] [PASSED] 44 VFs
[12:16:07] [PASSED] 45 VFs
[12:16:07] [PASSED] 46 VFs
[12:16:07] [PASSED] 47 VFs
[12:16:07] [PASSED] 48 VFs
[12:16:07] [PASSED] 49 VFs
[12:16:07] [PASSED] 50 VFs
[12:16:07] [PASSED] 51 VFs
[12:16:07] [PASSED] 52 VFs
[12:16:07] [PASSED] 53 VFs
[12:16:07] [PASSED] 54 VFs
[12:16:07] [PASSED] 55 VFs
[12:16:07] [PASSED] 56 VFs
[12:16:07] [PASSED] 57 VFs
[12:16:07] [PASSED] 58 VFs
[12:16:07] [PASSED] 59 VFs
[12:16:07] [PASSED] 60 VFs
[12:16:07] [PASSED] 61 VFs
[12:16:07] [PASSED] 62 VFs
[12:16:07] [PASSED] 63 VFs
[12:16:07] ==================== [PASSED] fair_ggtt ====================
[12:16:07] ======================== fair_vram  ========================
[12:16:07] [PASSED] 1 VF
[12:16:07] [PASSED] 2 VFs
[12:16:07] [PASSED] 3 VFs
[12:16:07] [PASSED] 4 VFs
[12:16:07] [PASSED] 5 VFs
[12:16:07] [PASSED] 6 VFs
[12:16:07] [PASSED] 7 VFs
[12:16:07] [PASSED] 8 VFs
[12:16:07] [PASSED] 9 VFs
[12:16:07] [PASSED] 10 VFs
[12:16:07] [PASSED] 11 VFs
[12:16:07] [PASSED] 12 VFs
[12:16:07] [PASSED] 13 VFs
[12:16:07] [PASSED] 14 VFs
[12:16:07] [PASSED] 15 VFs
[12:16:07] [PASSED] 16 VFs
[12:16:07] [PASSED] 17 VFs
[12:16:07] [PASSED] 18 VFs
[12:16:07] [PASSED] 19 VFs
[12:16:07] [PASSED] 20 VFs
[12:16:07] [PASSED] 21 VFs
[12:16:07] [PASSED] 22 VFs
[12:16:07] [PASSED] 23 VFs
[12:16:07] [PASSED] 24 VFs
[12:16:07] [PASSED] 25 VFs
[12:16:07] [PASSED] 26 VFs
[12:16:07] [PASSED] 27 VFs
[12:16:07] [PASSED] 28 VFs
[12:16:07] [PASSED] 29 VFs
[12:16:07] [PASSED] 30 VFs
[12:16:07] [PASSED] 31 VFs
[12:16:07] [PASSED] 32 VFs
[12:16:07] [PASSED] 33 VFs
[12:16:07] [PASSED] 34 VFs
[12:16:07] [PASSED] 35 VFs
[12:16:07] [PASSED] 36 VFs
[12:16:07] [PASSED] 37 VFs
[12:16:07] [PASSED] 38 VFs
[12:16:07] [PASSED] 39 VFs
[12:16:07] [PASSED] 40 VFs
[12:16:07] [PASSED] 41 VFs
[12:16:07] [PASSED] 42 VFs
[12:16:07] [PASSED] 43 VFs
[12:16:07] [PASSED] 44 VFs
[12:16:07] [PASSED] 45 VFs
[12:16:07] [PASSED] 46 VFs
[12:16:07] [PASSED] 47 VFs
[12:16:07] [PASSED] 48 VFs
[12:16:07] [PASSED] 49 VFs
[12:16:07] [PASSED] 50 VFs
[12:16:07] [PASSED] 51 VFs
[12:16:07] [PASSED] 52 VFs
[12:16:07] [PASSED] 53 VFs
[12:16:07] [PASSED] 54 VFs
[12:16:07] [PASSED] 55 VFs
[12:16:07] [PASSED] 56 VFs
[12:16:07] [PASSED] 57 VFs
[12:16:07] [PASSED] 58 VFs
[12:16:07] [PASSED] 59 VFs
[12:16:07] [PASSED] 60 VFs
[12:16:07] [PASSED] 61 VFs
[12:16:07] [PASSED] 62 VFs
[12:16:07] [PASSED] 63 VFs
[12:16:07] ==================== [PASSED] fair_vram ====================
[12:16:07] ================== [PASSED] pf_gt_config ===================
[12:16:07] ===================== lmtt (1 subtest) =====================
[12:16:07] ======================== test_ops  =========================
[12:16:07] [PASSED] 2-level
[12:16:07] [PASSED] multi-level
[12:16:07] ==================== [PASSED] test_ops =====================
[12:16:07] ====================== [PASSED] lmtt =======================
[12:16:07] ================= sriov_packet (1 subtest) =================
[12:16:07] [PASSED] test_descriptor_init
[12:16:07] ================== [PASSED] sriov_packet ===================
[12:16:07] ================= pf_service (11 subtests) =================
[12:16:07] [PASSED] pf_negotiate_any
[12:16:07] [PASSED] pf_negotiate_base_match
[12:16:07] [PASSED] pf_negotiate_base_newer
[12:16:07] [PASSED] pf_negotiate_base_next
[12:16:07] [SKIPPED] pf_negotiate_base_older (no older minor)
[12:16:07] [PASSED] pf_negotiate_base_prev
[12:16:07] [PASSED] pf_negotiate_latest_match
[12:16:07] [PASSED] pf_negotiate_latest_newer
[12:16:07] [PASSED] pf_negotiate_latest_next
[12:16:07] [SKIPPED] pf_negotiate_latest_older (no older minor)
[12:16:07] [SKIPPED] pf_negotiate_latest_prev (no prev major)
[12:16:07] =================== [PASSED] pf_service ====================
[12:16:07] ================= xe_guc_g2g (2 subtests) ==================
[12:16:07] ============== xe_live_guc_g2g_kunit_default  ==============
[12:16:07] ========= [SKIPPED] xe_live_guc_g2g_kunit_default ==========
[12:16:07] ============== xe_live_guc_g2g_kunit_allmem  ===============
[12:16:07] ========== [SKIPPED] xe_live_guc_g2g_kunit_allmem ==========
[12:16:07] =================== [SKIPPED] xe_guc_g2g ===================
[12:16:07] =================== xe_mocs (2 subtests) ===================
[12:16:07] ================ xe_live_mocs_kernel_kunit  ================
[12:16:07] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============
[12:16:07] ================ xe_live_mocs_reset_kunit  =================
[12:16:07] ============ [SKIPPED] xe_live_mocs_reset_kunit ============
[12:16:07] ==================== [SKIPPED] xe_mocs =====================
[12:16:07] ================= xe_migrate (2 subtests) ==================
[12:16:07] ================= xe_migrate_sanity_kunit  =================
[12:16:07] ============ [SKIPPED] xe_migrate_sanity_kunit =============
[12:16:07] ================== xe_validate_ccs_kunit  ==================
[12:16:07] ============= [SKIPPED] xe_validate_ccs_kunit ==============
[12:16:07] =================== [SKIPPED] xe_migrate ===================
[12:16:07] ================== xe_dma_buf (1 subtest) ==================
[12:16:07] ==================== xe_dma_buf_kunit  =====================
[12:16:07] ================ [SKIPPED] xe_dma_buf_kunit ================
[12:16:07] =================== [SKIPPED] xe_dma_buf ===================
[12:16:07] ================= xe_bo_shrink (1 subtest) =================
[12:16:07] =================== xe_bo_shrink_kunit  ====================
[12:16:07] =============== [SKIPPED] xe_bo_shrink_kunit ===============
[12:16:07] ================== [SKIPPED] xe_bo_shrink ==================
[12:16:07] ==================== xe_bo (2 subtests) ====================
[12:16:07] ================== xe_ccs_migrate_kunit  ===================
[12:16:07] ============== [SKIPPED] xe_ccs_migrate_kunit ==============
[12:16:07] ==================== xe_bo_evict_kunit  ====================
[12:16:07] =============== [SKIPPED] xe_bo_evict_kunit ================
[12:16:07] ===================== [SKIPPED] xe_bo ======================
[12:16:07] =================== xe_any (9 subtests) ====================
[12:16:07] [PASSED] test_to_xe
[12:16:07] [PASSED] test_to_dev
[12:16:07] [PASSED] test_to_pdev
[12:16:07] [PASSED] test_to_drm
[12:16:07] [PASSED] test_if_pdev
[12:16:07] [PASSED] test_if_xe
[12:16:07] [PASSED] test_if_tile
[12:16:07] [PASSED] test_if_gt
[12:16:07] [PASSED] test_to_id
[12:16:07] ===================== [PASSED] xe_any ======================
[12:16:07] ==================== args (13 subtests) ====================
[12:16:07] [PASSED] count_args_test
[12:16:07] [PASSED] call_args_example
[12:16:07] [PASSED] call_args_test
[12:16:07] [PASSED] drop_first_arg_example
[12:16:07] [PASSED] drop_first_arg_test
[12:16:07] [PASSED] first_arg_example
[12:16:07] [PASSED] first_arg_test
[12:16:07] [PASSED] last_arg_example
[12:16:07] [PASSED] last_arg_test
[12:16:07] [PASSED] pick_arg_example
[12:16:07] [PASSED] if_args_example
[12:16:07] [PASSED] if_args_test
[12:16:07] [PASSED] sep_comma_example
[12:16:07] ====================== [PASSED] args =======================
[12:16:07] =================== xe_pci (3 subtests) ====================
[12:16:07] ==================== check_graphics_ip  ====================
[12:16:07] [PASSED] 12.00 Xe_LP
[12:16:07] [PASSED] 12.10 Xe_LP+
[12:16:07] [PASSED] 12.55 Xe_HPG
[12:16:07] [PASSED] 12.60 Xe_HPC
[12:16:07] [PASSED] 12.70 Xe_LPG
[12:16:07] [PASSED] 12.71 Xe_LPG
[12:16:07] [PASSED] 12.74 Xe_LPG+
[12:16:07] [PASSED] 20.01 Xe2_HPG
[12:16:07] [PASSED] 20.02 Xe2_HPG
[12:16:07] [PASSED] 20.04 Xe2_LPG
[12:16:07] [PASSED] 30.00 Xe3_LPG
[12:16:07] [PASSED] 30.01 Xe3_LPG
[12:16:07] [PASSED] 30.03 Xe3_LPG
[12:16:07] [PASSED] 30.04 Xe3_LPG
[12:16:07] [PASSED] 30.05 Xe3_LPG
[12:16:07] [PASSED] 35.10 Xe3p_LPG
[12:16:07] [PASSED] 35.11 Xe3p_XPC
[12:16:07] ================ [PASSED] check_graphics_ip ================
[12:16:07] ===================== check_media_ip  ======================
[12:16:07] [PASSED] 12.00 Xe_M
[12:16:07] [PASSED] 12.55 Xe_HPM
[12:16:07] [PASSED] 13.00 Xe_LPM+
[12:16:07] [PASSED] 13.01 Xe2_HPM
[12:16:07] [PASSED] 20.00 Xe2_LPM
[12:16:07] [PASSED] 30.00 Xe3_LPM
[12:16:07] [PASSED] 30.02 Xe3_LPM
[12:16:07] [PASSED] 35.00 Xe3p_LPM
[12:16:07] [PASSED] 35.03 Xe3p_HPM
[12:16:07] ================= [PASSED] check_media_ip ==================
[12:16:07] =================== check_platform_desc  ===================
[12:16:07] [PASSED] 0x9A60 (TIGERLAKE)
[12:16:07] [PASSED] 0x9A68 (TIGERLAKE)
[12:16:07] [PASSED] 0x9A70 (TIGERLAKE)
[12:16:07] [PASSED] 0x9A40 (TIGERLAKE)
[12:16:07] [PASSED] 0x9A49 (TIGERLAKE)
[12:16:07] [PASSED] 0x9A59 (TIGERLAKE)
[12:16:07] [PASSED] 0x9A78 (TIGERLAKE)
[12:16:07] [PASSED] 0x9AC0 (TIGERLAKE)
[12:16:07] [PASSED] 0x9AC9 (TIGERLAKE)
[12:16:07] [PASSED] 0x9AD9 (TIGERLAKE)
[12:16:07] [PASSED] 0x9AF8 (TIGERLAKE)
[12:16:07] [PASSED] 0x4C80 (ROCKETLAKE)
[12:16:07] [PASSED] 0x4C8A (ROCKETLAKE)
[12:16:07] [PASSED] 0x4C8B (ROCKETLAKE)
[12:16:07] [PASSED] 0x4C8C (ROCKETLAKE)
[12:16:07] [PASSED] 0x4C90 (ROCKETLAKE)
[12:16:07] [PASSED] 0x4C9A (ROCKETLAKE)
[12:16:07] [PASSED] 0x4680 (ALDERLAKE_S)
[12:16:07] [PASSED] 0x4682 (ALDERLAKE_S)
[12:16:07] [PASSED] 0x4688 (ALDERLAKE_S)
[12:16:07] [PASSED] 0x468A (ALDERLAKE_S)
[12:16:07] [PASSED] 0x468B (ALDERLAKE_S)
[12:16:07] [PASSED] 0x4690 (ALDERLAKE_S)
[12:16:07] [PASSED] 0x4692 (ALDERLAKE_S)
[12:16:07] [PASSED] 0x4693 (ALDERLAKE_S)
[12:16:07] [PASSED] 0x46A0 (ALDERLAKE_P)
[12:16:07] [PASSED] 0x46A1 (ALDERLAKE_P)
[12:16:07] [PASSED] 0x46A2 (ALDERLAKE_P)
[12:16:07] [PASSED] 0x46A3 (ALDERLAKE_P)
[12:16:07] [PASSED] 0x46A6 (ALDERLAKE_P)
[12:16:07] [PASSED] 0x46A8 (ALDERLAKE_P)
[12:16:07] [PASSED] 0x46AA (ALDERLAKE_P)
[12:16:07] [PASSED] 0x462A (ALDERLAKE_P)
[12:16:07] [PASSED] 0x4626 (ALDERLAKE_P)
[12:16:07] [PASSED] 0x4628 (ALDERLAKE_P)
[12:16:07] [PASSED] 0x46B0 (ALDERLAKE_P)
[12:16:07] [PASSED] 0x46B1 (ALDERLAKE_P)
[12:16:07] [PASSED] 0x46B2 (ALDERLAKE_P)
[12:16:07] [PASSED] 0x46B3 (ALDERLAKE_P)
[12:16:07] [PASSED] 0x46C0 (ALDERLAKE_P)
[12:16:07] [PASSED] 0x46C1 (ALDERLAKE_P)
[12:16:07] [PASSED] 0x46C2 (ALDERLAKE_P)
[12:16:07] [PASSED] 0x46C3 (ALDERLAKE_P)
[12:16:07] [PASSED] 0x46D0 (ALDERLAKE_N)
[12:16:07] [PASSED] 0x46D1 (ALDERLAKE_N)
[12:16:07] [PASSED] 0x46D2 (ALDERLAKE_N)
[12:16:07] [PASSED] 0x46D3 (ALDERLAKE_N)
[12:16:07] [PASSED] 0x46D4 (ALDERLAKE_N)
[12:16:07] [PASSED] 0xA721 (ALDERLAKE_P)
[12:16:07] [PASSED] 0xA7A1 (ALDERLAKE_P)
[12:16:07] [PASSED] 0xA7A9 (ALDERLAKE_P)
[12:16:07] [PASSED] 0xA7AC (ALDERLAKE_P)
[12:16:07] [PASSED] 0xA7AD (ALDERLAKE_P)
[12:16:07] [PASSED] 0xA720 (ALDERLAKE_P)
[12:16:07] [PASSED] 0xA7A0 (ALDERLAKE_P)
[12:16:07] [PASSED] 0xA7A8 (ALDERLAKE_P)
[12:16:07] [PASSED] 0xA7AA (ALDERLAKE_P)
[12:16:07] [PASSED] 0xA7AB (ALDERLAKE_P)
[12:16:07] [PASSED] 0xA780 (ALDERLAKE_S)
[12:16:07] [PASSED] 0xA781 (ALDERLAKE_S)
[12:16:07] [PASSED] 0xA782 (ALDERLAKE_S)
[12:16:07] [PASSED] 0xA783 (ALDERLAKE_S)
[12:16:07] [PASSED] 0xA788 (ALDERLAKE_S)
[12:16:07] [PASSED] 0xA789 (ALDERLAKE_S)
[12:16:07] [PASSED] 0xA78A (ALDERLAKE_S)
[12:16:07] [PASSED] 0xA78B (ALDERLAKE_S)
[12:16:07] [PASSED] 0x4905 (DG1)
[12:16:07] [PASSED] 0x4906 (DG1)
[12:16:07] [PASSED] 0x4907 (DG1)
[12:16:07] [PASSED] 0x4908 (DG1)
[12:16:07] [PASSED] 0x4909 (DG1)
[12:16:07] [PASSED] 0x56C0 (DG2)
[12:16:07] [PASSED] 0x56C2 (DG2)
[12:16:07] [PASSED] 0x56C1 (DG2)
[12:16:07] [PASSED] 0x7D51 (METEORLAKE)
[12:16:07] [PASSED] 0x7DD1 (METEORLAKE)
[12:16:07] [PASSED] 0x7D41 (METEORLAKE)
[12:16:07] [PASSED] 0x7D67 (METEORLAKE)
[12:16:07] [PASSED] 0xB640 (METEORLAKE)
[12:16:07] [PASSED] 0x56A0 (DG2)
[12:16:07] [PASSED] 0x56A1 (DG2)
[12:16:07] [PASSED] 0x56A2 (DG2)
[12:16:07] [PASSED] 0x56BE (DG2)
[12:16:07] [PASSED] 0x56BF (DG2)
[12:16:07] [PASSED] 0x5690 (DG2)
[12:16:07] [PASSED] 0x5691 (DG2)
[12:16:07] [PASSED] 0x5692 (DG2)
[12:16:07] [PASSED] 0x56A5 (DG2)
[12:16:07] [PASSED] 0x56A6 (DG2)
[12:16:07] [PASSED] 0x56B0 (DG2)
[12:16:07] [PASSED] 0x56B1 (DG2)
[12:16:07] [PASSED] 0x56BA (DG2)
[12:16:07] [PASSED] 0x56BB (DG2)
[12:16:07] [PASSED] 0x56BC (DG2)
[12:16:07] [PASSED] 0x56BD (DG2)
[12:16:07] [PASSED] 0x5693 (DG2)
[12:16:07] [PASSED] 0x5694 (DG2)
[12:16:07] [PASSED] 0x5695 (DG2)
[12:16:07] [PASSED] 0x56A3 (DG2)
[12:16:07] [PASSED] 0x56A4 (DG2)
[12:16:07] [PASSED] 0x56B2 (DG2)
[12:16:07] [PASSED] 0x56B3 (DG2)
[12:16:07] [PASSED] 0x5696 (DG2)
[12:16:07] [PASSED] 0x5697 (DG2)
[12:16:07] [PASSED] 0xB69 (PVC)
[12:16:07] [PASSED] 0xB6E (PVC)
[12:16:07] [PASSED] 0xBD4 (PVC)
[12:16:07] [PASSED] 0xBD5 (PVC)
[12:16:07] [PASSED] 0xBD6 (PVC)
[12:16:07] [PASSED] 0xBD7 (PVC)
[12:16:07] [PASSED] 0xBD8 (PVC)
[12:16:07] [PASSED] 0xBD9 (PVC)
[12:16:07] [PASSED] 0xBDA (PVC)
[12:16:07] [PASSED] 0xBDB (PVC)
[12:16:07] [PASSED] 0xBE0 (PVC)
[12:16:07] [PASSED] 0xBE1 (PVC)
[12:16:07] [PASSED] 0xBE5 (PVC)
[12:16:07] [PASSED] 0x7D40 (METEORLAKE)
[12:16:07] [PASSED] 0x7D45 (METEORLAKE)
[12:16:07] [PASSED] 0x7D55 (METEORLAKE)
[12:16:07] [PASSED] 0x7D60 (METEORLAKE)
[12:16:07] [PASSED] 0x7DD5 (METEORLAKE)
[12:16:07] [PASSED] 0x6420 (LUNARLAKE)
[12:16:07] [PASSED] 0x64A0 (LUNARLAKE)
[12:16:07] [PASSED] 0x64B0 (LUNARLAKE)
[12:16:07] [PASSED] 0xE202 (BATTLEMAGE)
[12:16:07] [PASSED] 0xE209 (BATTLEMAGE)
[12:16:07] [PASSED] 0xE20B (BATTLEMAGE)
[12:16:07] [PASSED] 0xE20C (BATTLEMAGE)
[12:16:07] [PASSED] 0xE20D (BATTLEMAGE)
[12:16:07] [PASSED] 0xE210 (BATTLEMAGE)
[12:16:07] [PASSED] 0xE211 (BATTLEMAGE)
[12:16:07] [PASSED] 0xE212 (BATTLEMAGE)
[12:16:07] [PASSED] 0xE216 (BATTLEMAGE)
[12:16:07] [PASSED] 0xE220 (BATTLEMAGE)
[12:16:07] [PASSED] 0xE221 (BATTLEMAGE)
[12:16:07] [PASSED] 0xE222 (BATTLEMAGE)
[12:16:07] [PASSED] 0xE223 (BATTLEMAGE)
[12:16:07] [PASSED] 0xB080 (PANTHERLAKE)
[12:16:07] [PASSED] 0xB081 (PANTHERLAKE)
[12:16:07] [PASSED] 0xB082 (PANTHERLAKE)
[12:16:07] [PASSED] 0xB083 (PANTHERLAKE)
[12:16:07] [PASSED] 0xB084 (PANTHERLAKE)
[12:16:07] [PASSED] 0xB085 (PANTHERLAKE)
[12:16:07] [PASSED] 0xB086 (PANTHERLAKE)
[12:16:07] [PASSED] 0xB087 (PANTHERLAKE)
[12:16:07] [PASSED] 0xB08F (PANTHERLAKE)
[12:16:07] [PASSED] 0xB090 (PANTHERLAKE)
[12:16:07] [PASSED] 0xB0A0 (PANTHERLAKE)
[12:16:07] [PASSED] 0xB0A1 (PANTHERLAKE)
[12:16:07] [PASSED] 0xB0B0 (PANTHERLAKE)
[12:16:07] [PASSED] 0xFD80 (PANTHERLAKE)
[12:16:07] [PASSED] 0xFD81 (PANTHERLAKE)
[12:16:07] [PASSED] 0xD740 (NOVALAKE_S)
[12:16:07] [PASSED] 0xD741 (NOVALAKE_S)
[12:16:07] [PASSED] 0xD742 (NOVALAKE_S)
[12:16:07] [PASSED] 0xD743 (NOVALAKE_S)
[12:16:07] [PASSED] 0xD745 (NOVALAKE_S)
[12:16:07] [PASSED] 0xD74A (NOVALAKE_S)
[12:16:07] [PASSED] 0xD74B (NOVALAKE_S)
[12:16:07] [PASSED] 0x674C (CRESCENTISLAND)
[12:16:07] [PASSED] 0x674D (CRESCENTISLAND)
[12:16:07] [PASSED] 0x674E (CRESCENTISLAND)
[12:16:07] [PASSED] 0x674F (CRESCENTISLAND)
[12:16:07] [PASSED] 0x6750 (CRESCENTISLAND)
[12:16:07] [PASSED] 0x6751 (CRESCENTISLAND)
[12:16:07] [PASSED] 0xD750 (NOVALAKE_P)
[12:16:07] [PASSED] 0xD751 (NOVALAKE_P)
[12:16:07] [PASSED] 0xD752 (NOVALAKE_P)
[12:16:07] [PASSED] 0xD753 (NOVALAKE_P)
[12:16:07] [PASSED] 0xD754 (NOVALAKE_P)
[12:16:07] [PASSED] 0xD755 (NOVALAKE_P)
[12:16:07] [PASSED] 0xD756 (NOVALAKE_P)
[12:16:07] [PASSED] 0xD757 (NOVALAKE_P)
[12:16:07] [PASSED] 0xD75F (NOVALAKE_P)
[12:16:07] =============== [PASSED] check_platform_desc ===============
[12:16:07] ===================== [PASSED] xe_pci ======================
[12:16:07] ============= xe_rtp_tables_test (5 subtests) ==============
[12:16:07] ================== xe_rtp_table_gt_test  ===================
[12:16:07] [PASSED] gt_was/14011060649
[12:16:07] [PASSED] gt_was/14011059788
[12:16:07] [PASSED] gt_was/14015795083
[12:16:07] [PASSED] gt_was/16021867713
[12:16:07] [PASSED] gt_was/14019449301
[12:16:07] [PASSED] gt_was/16028005424
[12:16:07] [PASSED] gt_was/14026578760
[12:16:07] [PASSED] gt_was/1409420604
[12:16:07] [PASSED] gt_was/1408615072
[12:16:07] [PASSED] gt_was/22010523718
[12:16:07] [PASSED] gt_was/14011006942
[12:16:07] [PASSED] gt_was/14014830051
[12:16:07] [PASSED] gt_was/18018781329
[12:16:07] [PASSED] gt_was/1509235366
[12:16:07] [PASSED] gt_was/18018781329
[12:16:07] [PASSED] gt_was/16016694945
[12:16:07] [PASSED] gt_was/14018575942
[12:16:07] [PASSED] gt_was/22016670082
[12:16:07] [PASSED] gt_was/22016670082
[12:16:07] [PASSED] gt_was/14017421178
[12:16:07] [PASSED] gt_was/16025250150
[12:16:07] [PASSED] gt_was/14021871409
[12:16:07] [PASSED] gt_was/16021865536
[12:16:07] [PASSED] gt_was/14021486841
[12:16:07] [PASSED] gt_was/14025160223
[12:16:07] [PASSED] gt_was/14026144927, 16029437861, 14026127056
[12:16:07] [PASSED] gt_was/14025635424
[12:16:07] [PASSED] gt_was/16028005424
[12:16:07] ============== [PASSED] xe_rtp_table_gt_test ===============
[12:16:07] ================== xe_rtp_table_gt_test  ===================
[12:16:07] [PASSED] gt_tunings/Tuning: Blend Fill Caching Optimization Disable
[12:16:07] [PASSED] gt_tunings/Tuning: 32B Access Enable
[12:16:07] [PASSED] gt_tunings/Tuning: L3 cache
[12:16:07] [PASSED] gt_tunings/Tuning: L3 cache - media
[12:16:07] [PASSED] gt_tunings/Tuning: Compression Overfetch
[12:16:07] [PASSED] gt_tunings/Tuning: Compression Overfetch - media
[12:16:07] [PASSED] gt_tunings/Tuning: Enable compressible partial write overfetch in L3
[12:16:07] [PASSED] gt_tunings/Tuning: Enable compressible partial write overfetch in L3 - media
[12:16:07] [PASSED] gt_tunings/Tuning: L2 Overfetch Compressible Only
[12:16:07] [PASSED] gt_tunings/Tuning: L2 Overfetch Compressible Only - media
[12:16:07] [PASSED] gt_tunings/Tuning: Stateless compression control
[12:16:07] [PASSED] gt_tunings/Tuning: Stateless compression control - media
[12:16:07] [PASSED] gt_tunings/Tuning: L3 RW flush all Cache
[12:16:07] [PASSED] gt_tunings/Tuning: L3 RW flush all cache - media
[12:16:07] [PASSED] gt_tunings/Tuning: Set STLB Bank Hash Mode to 4KB
[12:16:07] [PASSED] gt_tunings/Tuning: Force All Non-Compressible Memory Reads to be 256B Overfetches
[12:16:07] ============== [PASSED] xe_rtp_table_gt_test ===============
[12:16:07] ================== xe_rtp_table_oob_test  ==================
[12:16:07] [PASSED] oob_was/1607983814
[12:16:07] [PASSED] oob_was/16010904313
[12:16:07] [PASSED] oob_was/18022495364
[12:16:07] [PASSED] oob_was/22012773006
[12:16:07] [PASSED] oob_was/14014475959
[12:16:07] [PASSED] oob_was/22011391025
[12:16:07] [PASSED] oob_was/22012727170
[12:16:07] [PASSED] oob_was/22012727685
[12:16:07] [PASSED] oob_was/22016596838
[12:16:07] [PASSED] oob_was/18020744125
[12:16:07] [PASSED] oob_was/1409600907
[12:16:07] [PASSED] oob_was/22014953428
[12:16:07] [PASSED] oob_was/16017236439
[12:16:07] [PASSED] oob_was/14019821291
[12:16:07] [PASSED] oob_was/14015076503
[12:16:07] [PASSED] oob_was/22016122933
[12:16:07] [PASSED] oob_was/14018913170
[12:16:07] [PASSED] oob_was/14018094691
[12:16:07] [PASSED] oob_was/18024947630
[12:16:07] [PASSED] oob_was/16022287689
[12:16:07] [PASSED] oob_was/13011645652
[12:16:07] [PASSED] oob_was/14022293748
[12:16:07] [PASSED] oob_was/22019794406
[12:16:07] [PASSED] oob_was/22019338487
[12:16:07] [PASSED] oob_was/16023588340
[12:16:07] [PASSED] oob_was/14019789679
[12:16:07] [PASSED] oob_was/14022866841
[12:16:07] [PASSED] oob_was/16021333562
[12:16:07] [PASSED] oob_was/14016712196
[12:16:07] [PASSED] oob_was/14015568240
[12:16:07] [PASSED] oob_was/18013179988
[12:16:07] [PASSED] oob_was/1508761755
[12:16:07] [PASSED] oob_was/16023105232
[12:16:07] [PASSED] oob_was/16026508708
[12:16:07] [PASSED] oob_was/14020001231
[12:16:07] [PASSED] oob_was/16023683509
[12:16:07] [PASSED] oob_was/14025515070
[12:16:07] [PASSED] oob_was/15015404425_disable
[12:16:07] [PASSED] oob_was/16026007364
[12:16:07] [PASSED] oob_was/14020316580
[12:16:07] [PASSED] oob_was/14025883347
[12:16:07] [PASSED] oob_was/16029380221
[12:16:07] [PASSED] oob_was/22022079272
[12:16:07] [PASSED] oob_was/16029897822
[12:16:07] [PASSED] oob_was/14027054324
[12:16:07] [PASSED] oob_was/14025941587
[12:16:07] [PASSED] oob_was/16030224309
[12:16:07] ============== [PASSED] xe_rtp_table_oob_test ==============
[12:16:07] ================ xe_rtp_table_dev_oob_test  ================
[12:16:07] [PASSED] device_oob_was/22010954014
[12:16:07] [PASSED] device_oob_was/15015404425
[12:16:07] [PASSED] device_oob_was/22019338487_display
[12:16:07] [PASSED] device_oob_was/14022085890
[12:16:07] [PASSED] device_oob_was/14026539277
[12:16:07] [PASSED] device_oob_was/14026633728
[12:16:07] [PASSED] device_oob_was/14026746987
[12:16:07] [PASSED] device_oob_was/14026779378
[12:16:07] ============ [PASSED] xe_rtp_table_dev_oob_test ============
[12:16:07] ========== xe_rtp_table_missing_upper_bound_test  ==========
[12:16:07] [PASSED] register_whitelist/WaAllowPMDepthAndInvocationCountAccessFromUMD, 1408556865
[12:16:07] [PASSED] register_whitelist/1508744258, 14012131227, 1808121037
[12:16:07] [PASSED] register_whitelist/1806527549
[12:16:07] [PASSED] register_whitelist/allow_read_ctx_timestamp
[12:16:07] [PASSED] register_whitelist/allow_read_queue_timestamp
[12:16:07] [PASSED] register_whitelist/16014440446
[12:16:07] [PASSED] register_whitelist/16017236439
[12:16:07] [PASSED] register_whitelist/16020183090
[12:16:07] [PASSED] register_whitelist/14024997852
[12:16:07] [PASSED] register_whitelist/14024997852
[12:16:07] ====== [PASSED] xe_rtp_table_missing_upper_bound_test ======
[12:16:07] =============== [PASSED] xe_rtp_tables_test ================
[12:16:07] =================== xe_rtp (3 subtests) ====================
[12:16:07] =================== xe_rtp_rules_tests  ====================
[12:16:07] [PASSED] no
[12:16:07] [PASSED] yes
[12:16:07] [PASSED] no-and-no
[12:16:07] [PASSED] no-and-yes
[12:16:07] [PASSED] yes-and-no
[12:16:07] [PASSED] yes-and-yes
[12:16:07] [PASSED] no-or-no
[12:16:07] [PASSED] no-or-yes
[12:16:07] [PASSED] yes-or-no
[12:16:07] [PASSED] yes-or-yes
[12:16:07] [PASSED] no-yes-or-yes-no
[12:16:07] [PASSED] no-yes-or-yes-yes
[12:16:07] [PASSED] yes-yes-or-no-yes
[12:16:07] [PASSED] yes-yes-or-yes-yes
[12:16:07] [PASSED] no-no-or-yes-or-no
[12:16:07] [PASSED] or
[12:16:07] [PASSED] or-yes
[12:16:07] [PASSED] or-no
[12:16:07] [PASSED] yes-or
[12:16:07] [PASSED] no-or
[12:16:07] [PASSED] no-or-or-yes
[12:16:07] [PASSED] yes-or-or-no
[12:16:07] [PASSED] no-or-or-no
[12:16:07] [PASSED] missing-context-engine-class
[12:16:07] [PASSED] missing-context-engine-class-or-yes
[12:16:07] [PASSED] missing-context-engine-class-or-or-yes
[12:16:07] =============== [PASSED] xe_rtp_rules_tests ================
[12:16:07] =============== xe_rtp_process_to_sr_tests  ================
[12:16:07] [PASSED] coalesce-same-reg
[12:16:07] [PASSED] coalesce-same-reg-literal-and-func
[12:16:07] [PASSED] no-match-no-add
[12:16:07] [PASSED] two-regs-two-entries
[12:16:07] [PASSED] clr-one-set-other
[12:16:07] [PASSED] set-field
[12:16:07] [PASSED] conflict-duplicate
[12:16:07] [PASSED] conflict-not-disjoint
[12:16:07] [PASSED] conflict-not-disjoint-literal-and-func
[12:16:07] [PASSED] conflict-reg-type
[12:16:07] [PASSED] bad-mcr-reg-forced-to-regular
[12:16:07] [PASSED] bad-regular-reg-forced-to-mcr
[12:16:07] =========== [PASSED] xe_rtp_process_to_sr_tests ============
[12:16:07] ================== xe_rtp_process_tests  ===================
[12:16:07] [PASSED] active1
[12:16:07] [PASSED] active2
[12:16:07] [PASSED] active-inactive
[12:16:07] [PASSED] inactive-active
[12:16:07] [PASSED] inactive-active-inactive
[12:16:07] [PASSED] inactive-inactive-inactive
[12:16:07] ============== [PASSED] xe_rtp_process_tests ===============
[12:16:07] ===================== [PASSED] xe_rtp ======================
[12:16:07] ==================== xe_wa (1 subtest) =====================
[12:16:07] ======================== xe_wa_gt  =========================
[12:16:07] [PASSED] TIGERLAKE B0
[12:16:07] [PASSED] DG1 A0
[12:16:07] [PASSED] DG1 B0
[12:16:07] [PASSED] ALDERLAKE_S A0
[12:16:07] [PASSED] ALDERLAKE_S B0
[12:16:07] [PASSED] ALDERLAKE_S C0
[12:16:07] [PASSED] ALDERLAKE_S D0
[12:16:07] [PASSED] ALDERLAKE_P A0
[12:16:07] [PASSED] ALDERLAKE_P B0
[12:16:07] [PASSED] ALDERLAKE_P C0
[12:16:07] [PASSED] ALDERLAKE_S RPLS D0
[12:16:07] [PASSED] ALDERLAKE_P RPLU E0
[12:16:07] [PASSED] DG2 G10 C0
[12:16:07] [PASSED] DG2 G11 B1
[12:16:07] [PASSED] DG2 G12 A1
[12:16:07] [PASSED] METEORLAKE 12.70(Xe_LPG) A0 13.00(Xe_LPM+) A0
[12:16:07] [PASSED] METEORLAKE 12.71(Xe_LPG) A0 13.00(Xe_LPM+) A0
[12:16:07] [PASSED] METEORLAKE 12.74(Xe_LPG+) A0 13.00(Xe_LPM+) A0
[12:16:07] [PASSED] LUNARLAKE 20.04(Xe2_LPG) A0 20.00(Xe2_LPM) A0
[12:16:07] [PASSED] LUNARLAKE 20.04(Xe2_LPG) B0 20.00(Xe2_LPM) A0
[12:16:07] [PASSED] BATTLEMAGE 20.01(Xe2_HPG) A0 13.01(Xe2_HPM) A1
[12:16:07] [PASSED] PANTHERLAKE 30.00(Xe3_LPG) A0 30.00(Xe3_LPM) A0
[12:16:07] ==================== [PASSED] xe_wa_gt =====================
[12:16:07] ====================== [PASSED] xe_wa ======================
[12:16:07] ============================================================
[12:16:07] Testing complete. Ran 821 tests: passed: 793, skipped: 28
[12:16:07] Elapsed time: 36.679s total, 1.866s configuring, 34.047s building, 0.717s running

+ for kcfg in "${kunitconfigs[@]}"
+ [[ ! -f /kernel/drivers/gpu/drm/tests/.kunitconfig ]]
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig
[12:16:07] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[12:16:09] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[12:16:34] Starting KUnit Kernel (1/1)...
[12:16:34] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[12:16:34] ============ drm_test_pick_cmdline (2 subtests) ============
[12:16:34] [PASSED] drm_test_pick_cmdline_res_1920_1080_60
[12:16:34] =============== drm_test_pick_cmdline_named  ===============
[12:16:34] [PASSED] NTSC
[12:16:34] [PASSED] NTSC-J
[12:16:34] [PASSED] PAL
[12:16:34] [PASSED] PAL-M
[12:16:34] =========== [PASSED] drm_test_pick_cmdline_named ===========
[12:16:34] ============== [PASSED] drm_test_pick_cmdline ==============
[12:16:34] == drm_test_atomic_get_connector_for_encoder (1 subtest) ===
[12:16:34] [PASSED] drm_test_drm_atomic_get_connector_for_encoder
[12:16:34] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ====
[12:16:34] =========== drm_validate_clone_mode (2 subtests) ===========
[12:16:34] ============== drm_test_check_in_clone_mode  ===============
[12:16:34] [PASSED] in_clone_mode
[12:16:34] [PASSED] not_in_clone_mode
[12:16:34] ========== [PASSED] drm_test_check_in_clone_mode ===========
[12:16:34] =============== drm_test_check_valid_clones  ===============
[12:16:34] [PASSED] not_in_clone_mode
[12:16:34] [PASSED] valid_clone
[12:16:34] [PASSED] invalid_clone
[12:16:34] =========== [PASSED] drm_test_check_valid_clones ===========
[12:16:34] ============= [PASSED] drm_validate_clone_mode =============
[12:16:34] ============= drm_validate_modeset (1 subtest) =============
[12:16:34] [PASSED] drm_test_check_connector_changed_modeset
[12:16:34] ============== [PASSED] drm_validate_modeset ===============
[12:16:34] ====== drm_test_bridge_get_current_state (1 subtest) =======
[12:16:34] [PASSED] drm_test_drm_bridge_get_current_state_atomic
[12:16:34] ======== [PASSED] drm_test_bridge_get_current_state ========
[12:16:34] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ======
[12:16:34] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic
[12:16:34] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled
[12:16:34] [PASSED] drm_test_drm_bridge_helper_hdmi_output_bus_fmts
[12:16:34] ======== [PASSED] drm_test_bridge_helper_reset_crtc ========
[12:16:34] ============== drm_bridge_alloc (2 subtests) ===============
[12:16:34] [PASSED] drm_test_drm_bridge_alloc_basic
[12:16:34] [PASSED] drm_test_drm_bridge_alloc_get_put
[12:16:34] ================ [PASSED] drm_bridge_alloc =================
[12:16:34] ============= drm_bridge_bus_fmt (5 subtests) ==============
[12:16:34] [PASSED] drm_test_bridge_rgb_yuv_rgb
[12:16:34] [PASSED] drm_test_bridge_must_convert_to_yuv444
[12:16:34] [PASSED] drm_test_bridge_hdmi_auto_rgb
[12:16:34] [PASSED] drm_test_bridge_auto_first
[12:16:34] [PASSED] drm_test_bridge_rgb_yuv_no_path
[12:16:34] =============== [PASSED] drm_bridge_bus_fmt ================
[12:16:34] ============= drm_cmdline_parser (40 subtests) =============
[12:16:34] [PASSED] drm_test_cmdline_force_d_only
[12:16:34] [PASSED] drm_test_cmdline_force_D_only_dvi
[12:16:34] [PASSED] drm_test_cmdline_force_D_only_hdmi
[12:16:34] [PASSED] drm_test_cmdline_force_D_only_not_digital
[12:16:34] [PASSED] drm_test_cmdline_force_e_only
[12:16:34] [PASSED] drm_test_cmdline_res
[12:16:34] [PASSED] drm_test_cmdline_res_vesa
[12:16:34] [PASSED] drm_test_cmdline_res_vesa_rblank
[12:16:34] [PASSED] drm_test_cmdline_res_rblank
[12:16:34] [PASSED] drm_test_cmdline_res_bpp
[12:16:34] [PASSED] drm_test_cmdline_res_refresh
[12:16:34] [PASSED] drm_test_cmdline_res_bpp_refresh
[12:16:34] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced
[12:16:34] [PASSED] drm_test_cmdline_res_bpp_refresh_margins
[12:16:34] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off
[12:16:34] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on
[12:16:34] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog
[12:16:34] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital
[12:16:34] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on
[12:16:34] [PASSED] drm_test_cmdline_res_margins_force_on
[12:16:34] [PASSED] drm_test_cmdline_res_vesa_margins
[12:16:34] [PASSED] drm_test_cmdline_name
[12:16:34] [PASSED] drm_test_cmdline_name_bpp
[12:16:34] [PASSED] drm_test_cmdline_name_option
[12:16:34] [PASSED] drm_test_cmdline_name_bpp_option
[12:16:34] [PASSED] drm_test_cmdline_rotate_0
[12:16:34] [PASSED] drm_test_cmdline_rotate_90
[12:16:34] [PASSED] drm_test_cmdline_rotate_180
[12:16:34] [PASSED] drm_test_cmdline_rotate_270
[12:16:34] [PASSED] drm_test_cmdline_hmirror
[12:16:34] [PASSED] drm_test_cmdline_vmirror
[12:16:34] [PASSED] drm_test_cmdline_margin_options
[12:16:34] [PASSED] drm_test_cmdline_multiple_options
[12:16:34] [PASSED] drm_test_cmdline_bpp_extra_and_option
[12:16:34] [PASSED] drm_test_cmdline_extra_and_option
[12:16:34] [PASSED] drm_test_cmdline_freestanding_options
[12:16:34] [PASSED] drm_test_cmdline_freestanding_force_e_and_options
[12:16:34] [PASSED] drm_test_cmdline_panel_orientation
[12:16:34] ================ drm_test_cmdline_invalid  =================
[12:16:34] [PASSED] margin_only
[12:16:34] [PASSED] interlace_only
[12:16:34] [PASSED] res_missing_x
[12:16:34] [PASSED] res_missing_y
[12:16:34] [PASSED] res_bad_y
[12:16:34] [PASSED] res_missing_y_bpp
[12:16:34] [PASSED] res_bad_bpp
[12:16:34] [PASSED] res_bad_refresh
[12:16:34] [PASSED] res_bpp_refresh_force_on_off
[12:16:34] [PASSED] res_invalid_mode
[12:16:34] [PASSED] res_bpp_wrong_place_mode
[12:16:34] [PASSED] name_bpp_refresh
[12:16:34] [PASSED] name_refresh
[12:16:34] [PASSED] name_refresh_wrong_mode
[12:16:34] [PASSED] name_refresh_invalid_mode
[12:16:34] [PASSED] rotate_multiple
[12:16:34] [PASSED] rotate_invalid_val
[12:16:34] [PASSED] rotate_truncated
[12:16:34] [PASSED] invalid_option
[12:16:34] [PASSED] invalid_tv_option
[12:16:34] [PASSED] truncated_tv_option
[12:16:34] ============ [PASSED] drm_test_cmdline_invalid =============
[12:16:34] =============== drm_test_cmdline_tv_options  ===============
[12:16:34] [PASSED] NTSC
[12:16:34] [PASSED] NTSC_443
[12:16:34] [PASSED] NTSC_J
[12:16:34] [PASSED] PAL
[12:16:34] [PASSED] PAL_M
[12:16:34] [PASSED] PAL_N
[12:16:34] [PASSED] SECAM
[12:16:34] [PASSED] MONO_525
[12:16:34] [PASSED] MONO_625
[12:16:34] =========== [PASSED] drm_test_cmdline_tv_options ===========
[12:16:34] =============== [PASSED] drm_cmdline_parser ================
[12:16:34] ========== drmm_connector_hdmi_init (20 subtests) ==========
[12:16:34] [PASSED] drm_test_connector_hdmi_init_valid
[12:16:34] [PASSED] drm_test_connector_hdmi_init_bpc_8
[12:16:34] [PASSED] drm_test_connector_hdmi_init_bpc_10
[12:16:34] [PASSED] drm_test_connector_hdmi_init_bpc_12
[12:16:34] [PASSED] drm_test_connector_hdmi_init_bpc_invalid
[12:16:34] [PASSED] drm_test_connector_hdmi_init_bpc_null
[12:16:34] [PASSED] drm_test_connector_hdmi_init_formats_empty
[12:16:34] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb
[12:16:34] === drm_test_connector_hdmi_init_formats_yuv420_allowed  ===
[12:16:34] [PASSED] supported_formats=0x9 yuv420_allowed=1
[12:16:34] [PASSED] supported_formats=0x9 yuv420_allowed=0
[12:16:34] [PASSED] supported_formats=0x5 yuv420_allowed=1
[12:16:34] [PASSED] supported_formats=0x5 yuv420_allowed=0
[12:16:34] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[12:16:34] [PASSED] drm_test_connector_hdmi_init_null_ddc
[12:16:34] [PASSED] drm_test_connector_hdmi_init_null_product
[12:16:34] [PASSED] drm_test_connector_hdmi_init_null_vendor
[12:16:34] [PASSED] drm_test_connector_hdmi_init_product_length_exact
[12:16:34] [PASSED] drm_test_connector_hdmi_init_product_length_too_long
[12:16:34] [PASSED] drm_test_connector_hdmi_init_product_valid
[12:16:34] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact
[12:16:34] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long
[12:16:34] [PASSED] drm_test_connector_hdmi_init_vendor_valid
[12:16:34] ========= drm_test_connector_hdmi_init_type_valid  =========
[12:16:34] [PASSED] HDMI-A
[12:16:34] [PASSED] HDMI-B
[12:16:34] ===== [PASSED] drm_test_connector_hdmi_init_type_valid =====
[12:16:34] ======== drm_test_connector_hdmi_init_type_invalid  ========
[12:16:34] [PASSED] Unknown
[12:16:34] [PASSED] VGA
[12:16:34] [PASSED] DVI-I
[12:16:34] [PASSED] DVI-D
[12:16:34] [PASSED] DVI-A
[12:16:34] [PASSED] Composite
[12:16:34] [PASSED] SVIDEO
[12:16:34] [PASSED] LVDS
[12:16:34] [PASSED] Component
[12:16:34] [PASSED] DIN
[12:16:34] [PASSED] DP
[12:16:34] [PASSED] TV
[12:16:34] [PASSED] eDP
[12:16:34] [PASSED] Virtual
[12:16:34] [PASSED] DSI
[12:16:34] [PASSED] DPI
[12:16:34] [PASSED] Writeback
[12:16:34] [PASSED] SPI
[12:16:34] [PASSED] USB
[12:16:34] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ====
[12:16:34] ============ [PASSED] drmm_connector_hdmi_init =============
[12:16:34] ============= drmm_connector_init (3 subtests) =============
[12:16:34] [PASSED] drm_test_drmm_connector_init
[12:16:34] [PASSED] drm_test_drmm_connector_init_null_ddc
[12:16:34] ========= drm_test_drmm_connector_init_type_valid  =========
[12:16:34] [PASSED] Unknown
[12:16:34] [PASSED] VGA
[12:16:34] [PASSED] DVI-I
[12:16:34] [PASSED] DVI-D
[12:16:34] [PASSED] DVI-A
[12:16:34] [PASSED] Composite
[12:16:34] [PASSED] SVIDEO
[12:16:34] [PASSED] LVDS
[12:16:34] [PASSED] Component
[12:16:34] [PASSED] DIN
[12:16:34] [PASSED] DP
[12:16:34] [PASSED] HDMI-A
[12:16:34] [PASSED] HDMI-B
[12:16:34] [PASSED] TV
[12:16:34] [PASSED] eDP
[12:16:34] [PASSED] Virtual
[12:16:34] [PASSED] DSI
[12:16:34] [PASSED] DPI
[12:16:34] [PASSED] Writeback
[12:16:34] [PASSED] SPI
[12:16:34] [PASSED] USB
[12:16:34] ===== [PASSED] drm_test_drmm_connector_init_type_valid =====
[12:16:34] =============== [PASSED] drmm_connector_init ===============
[12:16:34] ========= drm_connector_dynamic_init (6 subtests) ==========
[12:16:34] [PASSED] drm_test_drm_connector_dynamic_init
[12:16:34] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc
[12:16:34] [PASSED] drm_test_drm_connector_dynamic_init_not_added
[12:16:34] [PASSED] drm_test_drm_connector_dynamic_init_properties
[12:16:34] ===== drm_test_drm_connector_dynamic_init_type_valid  ======
[12:16:34] [PASSED] Unknown
[12:16:34] [PASSED] VGA
[12:16:34] [PASSED] DVI-I
[12:16:34] [PASSED] DVI-D
[12:16:34] [PASSED] DVI-A
[12:16:34] [PASSED] Composite
[12:16:34] [PASSED] SVIDEO
[12:16:34] [PASSED] LVDS
[12:16:34] [PASSED] Component
[12:16:34] [PASSED] DIN
[12:16:34] [PASSED] DP
[12:16:34] [PASSED] HDMI-A
[12:16:34] [PASSED] HDMI-B
[12:16:34] [PASSED] TV
[12:16:34] [PASSED] eDP
[12:16:34] [PASSED] Virtual
[12:16:34] [PASSED] DSI
[12:16:34] [PASSED] DPI
[12:16:34] [PASSED] Writeback
[12:16:34] [PASSED] SPI
[12:16:34] [PASSED] USB
[12:16:34] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid ==
[12:16:34] ======== drm_test_drm_connector_dynamic_init_name  =========
[12:16:34] [PASSED] Unknown
[12:16:34] [PASSED] VGA
[12:16:34] [PASSED] DVI-I
[12:16:34] [PASSED] DVI-D
[12:16:34] [PASSED] DVI-A
[12:16:34] [PASSED] Composite
[12:16:34] [PASSED] SVIDEO
[12:16:34] [PASSED] LVDS
[12:16:34] [PASSED] Component
[12:16:34] [PASSED] DIN
[12:16:34] [PASSED] DP
[12:16:34] [PASSED] HDMI-A
[12:16:34] [PASSED] HDMI-B
[12:16:34] [PASSED] TV
[12:16:34] [PASSED] eDP
[12:16:34] [PASSED] Virtual
[12:16:34] [PASSED] DSI
[12:16:34] [PASSED] DPI
[12:16:34] [PASSED] Writeback
[12:16:34] [PASSED] SPI
[12:16:34] [PASSED] USB
[12:16:34] ==== [PASSED] drm_test_drm_connector_dynamic_init_name =====
[12:16:34] =========== [PASSED] drm_connector_dynamic_init ============
[12:16:34] ==== drm_connector_dynamic_register_early (4 subtests) =====
[12:16:34] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list
[12:16:34] [PASSED] drm_test_drm_connector_dynamic_register_early_defer
[12:16:34] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init
[12:16:34] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object
[12:16:34] ====== [PASSED] drm_connector_dynamic_register_early =======
[12:16:34] ======= drm_connector_dynamic_register (7 subtests) ========
[12:16:34] [PASSED] drm_test_drm_connector_dynamic_register_on_list
[12:16:34] [PASSED] drm_test_drm_connector_dynamic_register_no_defer
[12:16:34] [PASSED] drm_test_drm_connector_dynamic_register_no_init
[12:16:34] [PASSED] drm_test_drm_connector_dynamic_register_mode_object
[12:16:34] [PASSED] drm_test_drm_connector_dynamic_register_sysfs
[12:16:34] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name
[12:16:34] [PASSED] drm_test_drm_connector_dynamic_register_debugfs
[12:16:34] ========= [PASSED] drm_connector_dynamic_register ==========
[12:16:34] = drm_connector_attach_broadcast_rgb_property (2 subtests) =
[12:16:34] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property
[12:16:34] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector
[12:16:34] === [PASSED] drm_connector_attach_broadcast_rgb_property ===
[12:16:34] ========== drm_get_tv_mode_from_name (2 subtests) ==========
[12:16:34] ========== drm_test_get_tv_mode_from_name_valid  ===========
[12:16:34] [PASSED] NTSC
[12:16:34] [PASSED] NTSC-443
[12:16:34] [PASSED] NTSC-J
[12:16:34] [PASSED] PAL
[12:16:34] [PASSED] PAL-M
[12:16:34] [PASSED] PAL-N
[12:16:34] [PASSED] SECAM
[12:16:34] [PASSED] Mono
[12:16:34] ====== [PASSED] drm_test_get_tv_mode_from_name_valid =======
[12:16:34] [PASSED] drm_test_get_tv_mode_from_name_truncated
[12:16:34] ============ [PASSED] drm_get_tv_mode_from_name ============
[12:16:34] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) =
[12:16:34] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb
[12:16:34] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc
[12:16:34] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1
[12:16:34] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc
[12:16:34] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1
[12:16:34] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double
[12:16:34] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid  =
[12:16:34] [PASSED] VIC 96
[12:16:34] [PASSED] VIC 97
[12:16:34] [PASSED] VIC 101
[12:16:34] [PASSED] VIC 102
[12:16:34] [PASSED] VIC 106
[12:16:34] [PASSED] VIC 107
[12:16:34] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid ===
[12:16:34] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc
[12:16:34] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc
[12:16:34] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc
[12:16:34] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc
[12:16:34] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc
[12:16:34] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ====
[12:16:34] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) ==
[12:16:34] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name  ====
[12:16:34] [PASSED] Automatic
[12:16:34] [PASSED] Full
[12:16:34] [PASSED] Limited 16:235
[12:16:34] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name ===
[12:16:34] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid
[12:16:34] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ====
[12:16:34] == drm_hdmi_connector_get_output_format_name (2 subtests) ==
[12:16:34] === drm_test_drm_hdmi_connector_get_output_format_name  ====
[12:16:34] [PASSED] RGB
[12:16:34] [PASSED] YUV 4:2:0
[12:16:34] [PASSED] YUV 4:2:2
[12:16:34] [PASSED] YUV 4:4:4
[12:16:34] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name ===
[12:16:34] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid
[12:16:34] ==== [PASSED] drm_hdmi_connector_get_output_format_name ====
[12:16:34] ============= drm_damage_helper (21 subtests) ==============
[12:16:34] [PASSED] drm_test_damage_iter_no_damage
[12:16:34] [PASSED] drm_test_damage_iter_no_damage_fractional_src
[12:16:34] [PASSED] drm_test_damage_iter_no_damage_src_moved
[12:16:34] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved
[12:16:34] [PASSED] drm_test_damage_iter_no_damage_not_visible
[12:16:34] [PASSED] drm_test_damage_iter_no_damage_no_crtc
[12:16:34] [PASSED] drm_test_damage_iter_no_damage_no_fb
[12:16:34] [PASSED] drm_test_damage_iter_simple_damage
[12:16:34] [PASSED] drm_test_damage_iter_single_damage
[12:16:34] [PASSED] drm_test_damage_iter_single_damage_intersect_src
[12:16:34] [PASSED] drm_test_damage_iter_single_damage_outside_src
[12:16:34] [PASSED] drm_test_damage_iter_single_damage_fractional_src
[12:16:34] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src
[12:16:34] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src
[12:16:34] [PASSED] drm_test_damage_iter_single_damage_src_moved
[12:16:34] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved
[12:16:34] [PASSED] drm_test_damage_iter_damage
[12:16:34] [PASSED] drm_test_damage_iter_damage_one_intersect
[12:16:34] [PASSED] drm_test_damage_iter_damage_one_outside
[12:16:34] [PASSED] drm_test_damage_iter_damage_src_moved
[12:16:34] [PASSED] drm_test_damage_iter_damage_not_visible
[12:16:34] ================ [PASSED] drm_damage_helper ================
[12:16:34] ============== drm_dp_mst_helper (3 subtests) ==============
[12:16:34] ============== drm_test_dp_mst_calc_pbn_mode  ==============
[12:16:34] [PASSED] Clock 154000 BPP 30 DSC disabled
[12:16:34] [PASSED] Clock 234000 BPP 30 DSC disabled
[12:16:34] [PASSED] Clock 297000 BPP 24 DSC disabled
[12:16:34] [PASSED] Clock 332880 BPP 24 DSC enabled
[12:16:34] [PASSED] Clock 324540 BPP 24 DSC enabled
[12:16:34] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ==========
[12:16:34] ============== drm_test_dp_mst_calc_pbn_div  ===============
[12:16:34] [PASSED] Link rate 2000000 lane count 4
[12:16:34] [PASSED] Link rate 2000000 lane count 2
[12:16:34] [PASSED] Link rate 2000000 lane count 1
[12:16:34] [PASSED] Link rate 1350000 lane count 4
[12:16:34] [PASSED] Link rate 1350000 lane count 2
[12:16:34] [PASSED] Link rate 1350000 lane count 1
[12:16:34] [PASSED] Link rate 1000000 lane count 4
[12:16:34] [PASSED] Link rate 1000000 lane count 2
[12:16:34] [PASSED] Link rate 1000000 lane count 1
[12:16:34] [PASSED] Link rate 810000 lane count 4
[12:16:34] [PASSED] Link rate 810000 lane count 2
[12:16:34] [PASSED] Link rate 810000 lane count 1
[12:16:34] [PASSED] Link rate 540000 lane count 4
[12:16:34] [PASSED] Link rate 540000 lane count 2
[12:16:34] [PASSED] Link rate 540000 lane count 1
[12:16:34] [PASSED] Link rate 270000 lane count 4
[12:16:34] [PASSED] Link rate 270000 lane count 2
[12:16:34] [PASSED] Link rate 270000 lane count 1
[12:16:34] [PASSED] Link rate 162000 lane count 4
[12:16:34] [PASSED] Link rate 162000 lane count 2
[12:16:34] [PASSED] Link rate 162000 lane count 1
[12:16:34] ========== [PASSED] drm_test_dp_mst_calc_pbn_div ===========
[12:16:34] ========= drm_test_dp_mst_sideband_msg_req_decode  =========
[12:16:34] [PASSED] DP_ENUM_PATH_RESOURCES with port number
[12:16:34] [PASSED] DP_POWER_UP_PHY with port number
[12:16:34] [PASSED] DP_POWER_DOWN_PHY with port number
[12:16:34] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks
[12:16:34] [PASSED] DP_ALLOCATE_PAYLOAD with port number
[12:16:34] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI
[12:16:34] [PASSED] DP_ALLOCATE_PAYLOAD with PBN
[12:16:34] [PASSED] DP_QUERY_PAYLOAD with port number
[12:16:34] [PASSED] DP_QUERY_PAYLOAD with VCPI
[12:16:34] [PASSED] DP_REMOTE_DPCD_READ with port number
[12:16:34] [PASSED] DP_REMOTE_DPCD_READ with DPCD address
[12:16:34] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes
[12:16:34] [PASSED] DP_REMOTE_DPCD_WRITE with port number
[12:16:34] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address
[12:16:34] [PASSED] DP_REMOTE_DPCD_WRITE with data array
[12:16:34] [PASSED] DP_REMOTE_I2C_READ with port number
[12:16:34] [PASSED] DP_REMOTE_I2C_READ with I2C device ID
[12:16:34] [PASSED] DP_REMOTE_I2C_READ with transactions array
[12:16:34] [PASSED] DP_REMOTE_I2C_WRITE with port number
[12:16:34] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID
[12:16:34] [PASSED] DP_REMOTE_I2C_WRITE with data array
[12:16:34] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID
[12:16:34] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID
[12:16:34] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event
[12:16:34] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event
[12:16:34] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior
[12:16:34] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior
[12:16:34] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode =====
[12:16:34] ================ [PASSED] drm_dp_mst_helper ================
[12:16:34] ================== drm_exec (7 subtests) ===================
[12:16:34] [PASSED] sanitycheck
[12:16:34] [PASSED] test_lock
[12:16:34] [PASSED] test_lock_unlock
[12:16:34] [PASSED] test_duplicates
[12:16:34] [PASSED] test_prepare
[12:16:34] [PASSED] test_prepare_array
[12:16:34] [PASSED] test_multiple_loops
[12:16:34] ==================== [PASSED] drm_exec =====================
[12:16:34] =========== drm_format_helper_test (17 subtests) ===========
[12:16:34] ============== drm_test_fb_xrgb8888_to_gray8  ==============
[12:16:34] [PASSED] single_pixel_source_buffer
[12:16:34] [PASSED] single_pixel_clip_rectangle
[12:16:34] [PASSED] well_known_colors
[12:16:34] [PASSED] destination_pitch
[12:16:34] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ==========
[12:16:34] ============= drm_test_fb_xrgb8888_to_rgb332  ==============
[12:16:34] [PASSED] single_pixel_source_buffer
[12:16:34] [PASSED] single_pixel_clip_rectangle
[12:16:34] [PASSED] well_known_colors
[12:16:34] [PASSED] destination_pitch
[12:16:34] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ==========
[12:16:34] ============= drm_test_fb_xrgb8888_to_rgb565  ==============
[12:16:34] [PASSED] single_pixel_source_buffer
[12:16:34] [PASSED] single_pixel_clip_rectangle
[12:16:34] [PASSED] well_known_colors
[12:16:34] [PASSED] destination_pitch
[12:16:34] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ==========
[12:16:34] ============ drm_test_fb_xrgb8888_to_xrgb1555  =============
[12:16:34] [PASSED] single_pixel_source_buffer
[12:16:34] [PASSED] single_pixel_clip_rectangle
[12:16:34] [PASSED] well_known_colors
[12:16:34] [PASSED] destination_pitch
[12:16:34] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 =========
[12:16:34] ============ drm_test_fb_xrgb8888_to_argb1555  =============
[12:16:34] [PASSED] single_pixel_source_buffer
[12:16:34] [PASSED] single_pixel_clip_rectangle
[12:16:34] [PASSED] well_known_colors
[12:16:34] [PASSED] destination_pitch
[12:16:34] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 =========
[12:16:34] ============ drm_test_fb_xrgb8888_to_rgba5551  =============
[12:16:34] [PASSED] single_pixel_source_buffer
[12:16:34] [PASSED] single_pixel_clip_rectangle
[12:16:34] [PASSED] well_known_colors
[12:16:34] [PASSED] destination_pitch
[12:16:34] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 =========
[12:16:34] ============= drm_test_fb_xrgb8888_to_rgb888  ==============
[12:16:34] [PASSED] single_pixel_source_buffer
[12:16:34] [PASSED] single_pixel_clip_rectangle
[12:16:34] [PASSED] well_known_colors
[12:16:34] [PASSED] destination_pitch
[12:16:34] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ==========
[12:16:34] ============= drm_test_fb_xrgb8888_to_bgr888  ==============
[12:16:34] [PASSED] single_pixel_source_buffer
[12:16:34] [PASSED] single_pixel_clip_rectangle
[12:16:34] [PASSED] well_known_colors
[12:16:34] [PASSED] destination_pitch
[12:16:34] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ==========
[12:16:34] ============ drm_test_fb_xrgb8888_to_argb8888  =============
[12:16:34] [PASSED] single_pixel_source_buffer
[12:16:34] [PASSED] single_pixel_clip_rectangle
[12:16:34] [PASSED] well_known_colors
[12:16:34] [PASSED] destination_pitch
[12:16:34] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 =========
[12:16:34] =========== drm_test_fb_xrgb8888_to_xrgb2101010  ===========
[12:16:34] [PASSED] single_pixel_source_buffer
[12:16:34] [PASSED] single_pixel_clip_rectangle
[12:16:34] [PASSED] well_known_colors
[12:16:34] [PASSED] destination_pitch
[12:16:34] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 =======
[12:16:34] =========== drm_test_fb_xrgb8888_to_argb2101010  ===========
[12:16:34] [PASSED] single_pixel_source_buffer
[12:16:34] [PASSED] single_pixel_clip_rectangle
[12:16:34] [PASSED] well_known_colors
[12:16:34] [PASSED] destination_pitch
[12:16:34] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 =======
[12:16:34] ============== drm_test_fb_xrgb8888_to_mono  ===============
[12:16:34] [PASSED] single_pixel_source_buffer
[12:16:34] [PASSED] single_pixel_clip_rectangle
[12:16:34] [PASSED] well_known_colors
[12:16:34] [PASSED] destination_pitch
[12:16:34] ========== [PASSED] drm_test_fb_xrgb8888_to_mono ===========
[12:16:34] ==================== drm_test_fb_swab  =====================
[12:16:34] [PASSED] single_pixel_source_buffer
[12:16:34] [PASSED] single_pixel_clip_rectangle
[12:16:34] [PASSED] well_known_colors
[12:16:34] [PASSED] destination_pitch
[12:16:34] ================ [PASSED] drm_test_fb_swab =================
[12:16:34] ============ drm_test_fb_xrgb8888_to_xbgr8888  =============
[12:16:34] [PASSED] single_pixel_source_buffer
[12:16:34] [PASSED] single_pixel_clip_rectangle
[12:16:34] [PASSED] well_known_colors
[12:16:34] [PASSED] destination_pitch
[12:16:34] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 =========
[12:16:34] ============ drm_test_fb_xrgb8888_to_abgr8888  =============
[12:16:34] [PASSED] single_pixel_source_buffer
[12:16:34] [PASSED] single_pixel_clip_rectangle
[12:16:34] [PASSED] well_known_colors
[12:16:34] [PASSED] destination_pitch
[12:16:34] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 =========
[12:16:34] ================= drm_test_fb_clip_offset  =================
[12:16:34] [PASSED] pass through
[12:16:34] [PASSED] horizontal offset
[12:16:34] [PASSED] vertical offset
[12:16:34] [PASSED] horizontal and vertical offset
[12:16:34] [PASSED] horizontal offset (custom pitch)
[12:16:34] [PASSED] vertical offset (custom pitch)
[12:16:34] [PASSED] horizontal and vertical offset (custom pitch)
[12:16:34] ============= [PASSED] drm_test_fb_clip_offset =============
[12:16:34] =================== drm_test_fb_memcpy  ====================
[12:16:34] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258)
[12:16:34] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258)
[12:16:34] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559)
[12:16:34] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258)
[12:16:34] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258)
[12:16:34] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559)
[12:16:34] [PASSED] well_known_colors: XB24 little-endian (0x34324258)
[12:16:34] [PASSED] well_known_colors: XRA8 little-endian (0x38415258)
[12:16:34] [PASSED] well_known_colors: YU24 little-endian (0x34325559)
[12:16:34] [PASSED] destination_pitch: XB24 little-endian (0x34324258)
[12:16:34] [PASSED] destination_pitch: XRA8 little-endian (0x38415258)
[12:16:34] [PASSED] destination_pitch: YU24 little-endian (0x34325559)
[12:16:34] =============== [PASSED] drm_test_fb_memcpy ================
[12:16:34] ============= [PASSED] drm_format_helper_test ==============
[12:16:34] ================= drm_format (18 subtests) =================
[12:16:34] [PASSED] drm_test_format_block_width_invalid
[12:16:34] [PASSED] drm_test_format_block_width_one_plane
[12:16:34] [PASSED] drm_test_format_block_width_two_plane
[12:16:34] [PASSED] drm_test_format_block_width_three_plane
[12:16:34] [PASSED] drm_test_format_block_width_tiled
[12:16:34] [PASSED] drm_test_format_block_height_invalid
[12:16:34] [PASSED] drm_test_format_block_height_one_plane
[12:16:34] [PASSED] drm_test_format_block_height_two_plane
[12:16:34] [PASSED] drm_test_format_block_height_three_plane
[12:16:34] [PASSED] drm_test_format_block_height_tiled
[12:16:34] [PASSED] drm_test_format_min_pitch_invalid
[12:16:34] [PASSED] drm_test_format_min_pitch_one_plane_8bpp
[12:16:34] [PASSED] drm_test_format_min_pitch_one_plane_16bpp
[12:16:34] [PASSED] drm_test_format_min_pitch_one_plane_24bpp
[12:16:34] [PASSED] drm_test_format_min_pitch_one_plane_32bpp
[12:16:34] [PASSED] drm_test_format_min_pitch_two_plane
[12:16:34] [PASSED] drm_test_format_min_pitch_three_plane_8bpp
[12:16:34] [PASSED] drm_test_format_min_pitch_tiled
[12:16:34] =================== [PASSED] drm_format ====================
[12:16:34] ============== drm_framebuffer (10 subtests) ===============
[12:16:34] ========== drm_test_framebuffer_check_src_coords  ==========
[12:16:34] [PASSED] Success: source fits into fb
[12:16:34] [PASSED] Fail: overflowing fb with x-axis coordinate
[12:16:34] [PASSED] Fail: overflowing fb with y-axis coordinate
[12:16:34] [PASSED] Fail: overflowing fb with source width
[12:16:34] [PASSED] Fail: overflowing fb with source height
[12:16:34] ====== [PASSED] drm_test_framebuffer_check_src_coords ======
[12:16:34] [PASSED] drm_test_framebuffer_cleanup
[12:16:34] =============== drm_test_framebuffer_create  ===============
[12:16:34] [PASSED] ABGR8888 normal sizes
[12:16:34] [PASSED] ABGR8888 max sizes
[12:16:34] [PASSED] ABGR8888 pitch greater than min required
[12:16:34] [PASSED] ABGR8888 pitch less than min required
[12:16:34] [PASSED] ABGR8888 Invalid width
[12:16:34] [PASSED] ABGR8888 Invalid buffer handle
[12:16:34] [PASSED] No pixel format
[12:16:34] [PASSED] ABGR8888 Width 0
[12:16:34] [PASSED] ABGR8888 Height 0
[12:16:34] [PASSED] ABGR8888 Out of bound height * pitch combination
[12:16:34] [PASSED] ABGR8888 Large buffer offset
[12:16:34] [PASSED] ABGR8888 Buffer offset for inexistent plane
[12:16:34] [PASSED] ABGR8888 Invalid flag
[12:16:34] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers
[12:16:34] [PASSED] ABGR8888 Valid buffer modifier
[12:16:34] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE)
[12:16:34] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS
[12:16:34] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS
[12:16:34] [PASSED] NV12 Normal sizes
[12:16:34] [PASSED] NV12 Max sizes
[12:16:34] [PASSED] NV12 Invalid pitch
[12:16:34] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag
[12:16:34] [PASSED] NV12 different  modifier per-plane
[12:16:34] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE
[12:16:34] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS
[12:16:34] [PASSED] NV12 Modifier for inexistent plane
[12:16:34] [PASSED] NV12 Handle for inexistent plane
[12:16:34] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS
[12:16:34] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier
[12:16:34] [PASSED] YVU420 Normal sizes
[12:16:34] [PASSED] YVU420 Max sizes
[12:16:34] [PASSED] YVU420 Invalid pitch
[12:16:34] [PASSED] YVU420 Different pitches
[12:16:34] [PASSED] YVU420 Different buffer offsets/pitches
[12:16:34] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS
[12:16:34] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS
[12:16:34] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS
[12:16:34] [PASSED] YVU420 Valid modifier
[12:16:34] [PASSED] YVU420 Different modifiers per plane
[12:16:34] [PASSED] YVU420 Modifier for inexistent plane
[12:16:34] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR)
[12:16:34] [PASSED] X0L2 Normal sizes
[12:16:34] [PASSED] X0L2 Max sizes
[12:16:34] [PASSED] X0L2 Invalid pitch
[12:16:34] [PASSED] X0L2 Pitch greater than minimum required
[12:16:34] [PASSED] X0L2 Handle for inexistent plane
[12:16:34] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set
[12:16:34] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set
[12:16:34] [PASSED] X0L2 Valid modifier
[12:16:34] [PASSED] X0L2 Modifier for inexistent plane
[12:16:34] =========== [PASSED] drm_test_framebuffer_create ===========
[12:16:34] [PASSED] drm_test_framebuffer_free
[12:16:34] [PASSED] drm_test_framebuffer_init
[12:16:34] [PASSED] drm_test_framebuffer_init_bad_format
[12:16:34] [PASSED] drm_test_framebuffer_init_dev_mismatch
[12:16:34] [PASSED] drm_test_framebuffer_lookup
[12:16:34] [PASSED] drm_test_framebuffer_lookup_inexistent
[12:16:34] [PASSED] drm_test_framebuffer_modifiers_not_supported
[12:16:34] ================= [PASSED] drm_framebuffer =================
[12:16:34] ================ drm_gem_shmem (8 subtests) ================
[12:16:34] [PASSED] drm_gem_shmem_test_obj_create
[12:16:34] [PASSED] drm_gem_shmem_test_obj_create_private
[12:16:34] [PASSED] drm_gem_shmem_test_pin_pages
[12:16:34] [PASSED] drm_gem_shmem_test_vmap
[12:16:34] [PASSED] drm_gem_shmem_test_get_sg_table
[12:16:34] [PASSED] drm_gem_shmem_test_get_pages_sgt
[12:16:34] [PASSED] drm_gem_shmem_test_madvise
[12:16:34] [PASSED] drm_gem_shmem_test_purge
[12:16:34] ================== [PASSED] drm_gem_shmem ==================
[12:16:34] === drm_atomic_helper_connector_hdmi_check (29 subtests) ===
[12:16:34] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode
[12:16:34] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1
[12:16:34] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode
[12:16:34] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1
[12:16:34] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode
[12:16:34] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1
[12:16:34] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420  =======
[12:16:34] [PASSED] Automatic
[12:16:34] [PASSED] Full
[12:16:34] [PASSED] Limited 16:235
[12:16:34] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 ===
[12:16:34] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed
[12:16:34] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed
[12:16:34] [PASSED] drm_test_check_disable_connector
[12:16:34] [PASSED] drm_test_check_hdmi_funcs_reject_rate
[12:16:34] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb
[12:16:34] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420
[12:16:34] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422
[12:16:34] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420
[12:16:34] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420
[12:16:34] [PASSED] drm_test_check_output_bpc_crtc_mode_changed
[12:16:34] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed
[12:16:34] [PASSED] drm_test_check_output_bpc_dvi
[12:16:34] [PASSED] drm_test_check_output_bpc_format_vic_1
[12:16:34] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only
[12:16:34] [PASSED] drm_test_check_output_bpc_format_display_rgb_only
[12:16:34] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only
[12:16:34] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only
[12:16:34] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc
[12:16:34] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc
[12:16:34] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc
[12:16:34] ============ drm_test_check_hdmi_color_format  =============
[12:16:34] [PASSED] AUTO -> RGB
[12:16:34] [PASSED] YCBCR422 -> YUV422
[12:16:34] [PASSED] YCBCR420 -> YUV420
[12:16:34] [PASSED] YCBCR444 -> YUV444
[12:16:34] [PASSED] RGB -> RGB
[12:16:34] ======== [PASSED] drm_test_check_hdmi_color_format =========
[12:16:34] ======== drm_test_check_hdmi_color_format_420_only  ========
[12:16:34] [PASSED] RGB should fail
[12:16:34] [PASSED] YUV444 should fail
[12:16:34] [PASSED] YUV422 should fail
[12:16:34] [PASSED] YUV420 should work
[12:16:34] ==== [PASSED] drm_test_check_hdmi_color_format_420_only ====
[12:16:34] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ======
[12:16:34] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ====
[12:16:34] [PASSED] drm_test_check_broadcast_rgb_value
[12:16:34] [PASSED] drm_test_check_bpc_8_value
[12:16:34] [PASSED] drm_test_check_bpc_10_value
[12:16:34] [PASSED] drm_test_check_bpc_12_value
[12:16:34] [PASSED] drm_test_check_format_value
[12:16:34] [PASSED] drm_test_check_tmds_char_value
[12:16:34] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ======
[12:16:34] = drm_atomic_helper_connector_hdmi_mode_valid (7 subtests) =
[12:16:34] [PASSED] drm_test_check_mode_valid
[12:16:34] [PASSED] drm_test_check_mode_valid_reject
[12:16:34] [PASSED] drm_test_check_mode_valid_reject_rate
[12:16:34] [PASSED] drm_test_check_mode_valid_reject_max_clock
[12:16:34] [PASSED] drm_test_check_mode_valid_yuv420_only_max_clock
[12:16:34] [PASSED] drm_test_check_mode_valid_reject_yuv420_only_connector
[12:16:34] [PASSED] drm_test_check_mode_valid_accept_yuv420_also_connector_rgb
[12:16:34] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid ===
[12:16:34] = drm_atomic_helper_connector_hdmi_infoframes (5 subtests) =
[12:16:34] [PASSED] drm_test_check_infoframes
[12:16:34] [PASSED] drm_test_check_reject_avi_infoframe
[12:16:34] [PASSED] drm_test_check_reject_hdr_infoframe_bpc_8
[12:16:34] [PASSED] drm_test_check_reject_hdr_infoframe_bpc_10
[12:16:34] [PASSED] drm_test_check_reject_audio_infoframe
[12:16:34] === [PASSED] drm_atomic_helper_connector_hdmi_infoframes ===
[12:16:34] ================= drm_managed (2 subtests) =================
[12:16:34] [PASSED] drm_test_managed_release_action
[12:16:34] [PASSED] drm_test_managed_run_action
[12:16:34] =================== [PASSED] drm_managed ===================
[12:16:34] =================== drm_mm (6 subtests) ====================
[12:16:34] [PASSED] drm_test_mm_init
[12:16:34] [PASSED] drm_test_mm_debug
[12:16:34] [PASSED] drm_test_mm_align32
[12:16:34] [PASSED] drm_test_mm_align64
[12:16:34] [PASSED] drm_test_mm_lowest
[12:16:34] [PASSED] drm_test_mm_highest
[12:16:34] ===================== [PASSED] drm_mm ======================
[12:16:34] ============= drm_modes_analog_tv (5 subtests) =============
[12:16:34] [PASSED] drm_test_modes_analog_tv_mono_576i
[12:16:34] [PASSED] drm_test_modes_analog_tv_ntsc_480i
[12:16:34] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined
[12:16:34] [PASSED] drm_test_modes_analog_tv_pal_576i
[12:16:34] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined
[12:16:34] =============== [PASSED] drm_modes_analog_tv ===============
[12:16:34] ============== drm_panic_helper (3 subtests) ===============
[12:16:34] ============= drm_test_panic_screen_user_map  ==============
[12:16:34] [PASSED] Panic screen user, mode: 1024 x 768 	XR24 little-endian (0x34325258)
[12:16:34] [PASSED] Panic screen user, mode: 494 x 494 	XR24 little-endian (0x34325258)
[12:16:34] [PASSED] Panic screen user, mode: 1920 x 1080 	XR24 little-endian (0x34325258)
[12:16:34] [PASSED] Panic screen user, mode: 1024 x 768 	RG16 little-endian (0x36314752)
[12:16:34] [PASSED] Panic screen user, mode: 1024 x 768 	RG24 little-endian (0x34324752)
[12:16:34] [PASSED] Panic screen kmsg, mode: 1024 x 768 	XR24 little-endian (0x34325258)
[12:16:34] [PASSED] Panic screen kmsg, mode: 494 x 494 	XR24 little-endian (0x34325258)
[12:16:34] [PASSED] Panic screen kmsg, mode: 1920 x 1080 	XR24 little-endian (0x34325258)
[12:16:34] [PASSED] Panic screen kmsg, mode: 1024 x 768 	RG16 little-endian (0x36314752)
[12:16:34] [PASSED] Panic screen kmsg, mode: 1024 x 768 	RG24 little-endian (0x34324752)
[12:16:34] ========= [PASSED] drm_test_panic_screen_user_map ==========
[12:16:34] ============= drm_test_panic_screen_user_page  =============
[12:16:34] [PASSED] Panic screen user, mode: 1024 x 768 	XR24 little-endian (0x34325258)
[12:16:34] [PASSED] Panic screen user, mode: 494 x 494 	XR24 little-endian (0x34325258)
[12:16:34] [PASSED] Panic screen user, mode: 1920 x 1080 	XR24 little-endian (0x34325258)
[12:16:34] [PASSED] Panic screen user, mode: 1024 x 768 	RG16 little-endian (0x36314752)
[12:16:34] [PASSED] Panic screen user, mode: 1024 x 768 	RG24 little-endian (0x34324752)
[12:16:34] [PASSED] Panic screen kmsg, mode: 1024 x 768 	XR24 little-endian (0x34325258)
[12:16:34] [PASSED] Panic screen kmsg, mode: 494 x 494 	XR24 little-endian (0x34325258)
[12:16:34] [PASSED] Panic screen kmsg, mode: 1920 x 1080 	XR24 little-endian (0x34325258)
[12:16:34] [PASSED] Panic screen kmsg, mode: 1024 x 768 	RG16 little-endian (0x36314752)
[12:16:34] [PASSED] Panic screen kmsg, mode: 1024 x 768 	RG24 little-endian (0x34324752)
[12:16:34] ========= [PASSED] drm_test_panic_screen_user_page =========
[12:16:34] ========== drm_test_panic_screen_user_set_pixel  ===========
[12:16:34] [PASSED] Panic screen user, mode: 1024 x 768 	XR24 little-endian (0x34325258)
[12:16:34] [PASSED] Panic screen user, mode: 494 x 494 	XR24 little-endian (0x34325258)
[12:16:34] [PASSED] Panic screen user, mode: 1920 x 1080 	XR24 little-endian (0x34325258)
[12:16:34] [PASSED] Panic screen user, mode: 1024 x 768 	RG16 little-endian (0x36314752)
[12:16:34] [PASSED] Panic screen user, mode: 1024 x 768 	RG24 little-endian (0x34324752)
[12:16:34] [PASSED] Panic screen kmsg, mode: 1024 x 768 	XR24 little-endian (0x34325258)
[12:16:35] [PASSED] Panic screen kmsg, mode: 494 x 494 	XR24 little-endian (0x34325258)
[12:16:35] [PASSED] Panic screen kmsg, mode: 1920 x 1080 	XR24 little-endian (0x34325258)
[12:16:35] [PASSED] Panic screen kmsg, mode: 1024 x 768 	RG16 little-endian (0x36314752)
[12:16:35] [PASSED] Panic screen kmsg, mode: 1024 x 768 	RG24 little-endian (0x34324752)
[12:16:35] ====== [PASSED] drm_test_panic_screen_user_set_pixel =======
[12:16:35] ================ [PASSED] drm_panic_helper =================
[12:16:35] ============== drm_plane_helper (2 subtests) ===============
[12:16:35] =============== drm_test_check_plane_state  ================
[12:16:35] [PASSED] clipping_simple
[12:16:35] [PASSED] clipping_rotate_reflect
[12:16:35] [PASSED] positioning_simple
[12:16:35] [PASSED] upscaling
[12:16:35] [PASSED] downscaling
[12:16:35] [PASSED] rounding1
[12:16:35] [PASSED] rounding2
[12:16:35] [PASSED] rounding3
[12:16:35] [PASSED] rounding4
[12:16:35] =========== [PASSED] drm_test_check_plane_state ============
[12:16:35] =========== drm_test_check_invalid_plane_state  ============
[12:16:35] [PASSED] positioning_invalid
[12:16:35] [PASSED] upscaling_invalid
[12:16:35] [PASSED] downscaling_invalid
[12:16:35] ======= [PASSED] drm_test_check_invalid_plane_state ========
[12:16:35] ================ [PASSED] drm_plane_helper =================
[12:16:35] ====== drm_connector_helper_tv_get_modes (1 subtest) =======
[12:16:35] ====== drm_test_connector_helper_tv_get_modes_check  =======
[12:16:35] [PASSED] None
[12:16:35] [PASSED] PAL
[12:16:35] [PASSED] NTSC
[12:16:35] [PASSED] Both, NTSC Default
[12:16:35] [PASSED] Both, PAL Default
[12:16:35] [PASSED] Both, NTSC Default, with PAL on command-line
[12:16:35] [PASSED] Both, PAL Default, with NTSC on command-line
[12:16:35] == [PASSED] drm_test_connector_helper_tv_get_modes_check ===
[12:16:35] ======== [PASSED] drm_connector_helper_tv_get_modes ========
[12:16:35] ================== drm_rect (9 subtests) ===================
[12:16:35] [PASSED] drm_test_rect_clip_scaled_div_by_zero
[12:16:35] [PASSED] drm_test_rect_clip_scaled_not_clipped
[12:16:35] [PASSED] drm_test_rect_clip_scaled_clipped
[12:16:35] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned
[12:16:35] ================= drm_test_rect_intersect  =================
[12:16:35] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0
[12:16:35] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1
[12:16:35] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0
[12:16:35] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1
[12:16:35] [PASSED] right x left: 2x1+0+0 x 3x1+1+0
[12:16:35] [PASSED] left x right: 3x1+1+0 x 2x1+0+0
[12:16:35] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1
[12:16:35] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0
[12:16:35] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1
[12:16:35] [PASSED] touching side: 1x1+0+0 x 1x1+1+0
[12:16:35] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0
[12:16:35] [PASSED] inside another: 2x2+0+0 x 1x1+1+1
[12:16:35] [PASSED] far away: 1x1+0+0 x 1x1+3+6
[12:16:35] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10
[12:16:35] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10
[12:16:35] ============= [PASSED] drm_test_rect_intersect =============
[12:16:35] ================ drm_test_rect_calc_hscale  ================
[12:16:35] [PASSED] normal use
[12:16:35] [PASSED] out of max range
[12:16:35] [PASSED] out of min range
[12:16:35] [PASSED] zero dst
[12:16:35] [PASSED] negative src
[12:16:35] [PASSED] negative dst
[12:16:35] ============ [PASSED] drm_test_rect_calc_hscale ============
[12:16:35] ================ drm_test_rect_calc_vscale  ================
[12:16:35] [PASSED] normal use
[12:16:35] [PASSED] out of max range
[12:16:35] [PASSED] out of min range
[12:16:35] [PASSED] zero dst
[12:16:35] [PASSED] negative src
[12:16:35] [PASSED] negative dst
[12:16:35] ============ [PASSED] drm_test_rect_calc_vscale ============
[12:16:35] ================== drm_test_rect_rotate  ===================
[12:16:35] [PASSED] reflect-x
[12:16:35] [PASSED] reflect-y
[12:16:35] [PASSED] rotate-0
[12:16:35] [PASSED] rotate-90
[12:16:35] [PASSED] rotate-180
[12:16:35] [PASSED] rotate-270
[12:16:35] ============== [PASSED] drm_test_rect_rotate ===============
[12:16:35] ================ drm_test_rect_rotate_inv  =================
[12:16:35] [PASSED] reflect-x
[12:16:35] [PASSED] reflect-y
[12:16:35] [PASSED] rotate-0
[12:16:35] [PASSED] rotate-90
[12:16:35] [PASSED] rotate-180
[12:16:35] [PASSED] rotate-270
[12:16:35] ============ [PASSED] drm_test_rect_rotate_inv =============
[12:16:35] ==================== [PASSED] drm_rect =====================
[12:16:35] ============ drm_sysfb_modeset_test (1 subtest) ============
[12:16:35] ============ drm_test_sysfb_build_fourcc_list  =============
[12:16:35] [PASSED] no native formats
[12:16:35] [PASSED] XRGB8888 as native format
[12:16:35] [PASSED] remove duplicates
[12:16:35] [PASSED] convert alpha formats
[12:16:35] [PASSED] random formats
[12:16:35] ======== [PASSED] drm_test_sysfb_build_fourcc_list =========
[12:16:35] ============= [PASSED] drm_sysfb_modeset_test ==============
[12:16:35] ================== drm_fixp (2 subtests) ===================
[12:16:35] [PASSED] drm_test_int2fixp
[12:16:35] [PASSED] drm_test_sm2fixp
[12:16:35] ==================== [PASSED] drm_fixp =====================
[12:16:35] ============================================================
[12:16:35] Testing complete. Ran 667 tests: passed: 667
[12:16:35] Elapsed time: 27.267s total, 1.842s configuring, 25.009s building, 0.413s running

+ for kcfg in "${kunitconfigs[@]}"
+ [[ ! -f /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig ]]
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig
[12:16:35] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[12:16:37] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[12:16:47] Starting KUnit Kernel (1/1)...
[12:16:47] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[12:16:47] ================= ttm_device (5 subtests) ==================
[12:16:47] [PASSED] ttm_device_init_basic
[12:16:47] [PASSED] ttm_device_init_multiple
[12:16:47] [PASSED] ttm_device_fini_basic
[12:16:47] [PASSED] ttm_device_init_no_vma_man
[12:16:47] ================== ttm_device_init_pools  ==================
[12:16:47] [PASSED] No DMA allocations, no DMA32 required
[12:16:47] [PASSED] DMA allocations, DMA32 required
[12:16:47] [PASSED] No DMA allocations, DMA32 required
[12:16:47] [PASSED] DMA allocations, no DMA32 required
[12:16:47] ============== [PASSED] ttm_device_init_pools ==============
[12:16:47] =================== [PASSED] ttm_device ====================
[12:16:47] ================== ttm_pool (8 subtests) ===================
[12:16:47] ================== ttm_pool_alloc_basic  ===================
[12:16:47] [PASSED] One page
[12:16:47] [PASSED] More than one page
[12:16:47] [PASSED] Above the allocation limit
[12:16:47] [PASSED] One page, with coherent DMA mappings enabled
[12:16:47] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[12:16:47] ============== [PASSED] ttm_pool_alloc_basic ===============
[12:16:47] ============== ttm_pool_alloc_basic_dma_addr  ==============
[12:16:47] [PASSED] One page
[12:16:47] [PASSED] More than one page
[12:16:47] [PASSED] Above the allocation limit
[12:16:47] [PASSED] One page, with coherent DMA mappings enabled
[12:16:47] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[12:16:47] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ==========
[12:16:47] [PASSED] ttm_pool_alloc_order_caching_match
[12:16:47] [PASSED] ttm_pool_alloc_caching_mismatch
[12:16:47] [PASSED] ttm_pool_alloc_order_mismatch
[12:16:47] [PASSED] ttm_pool_free_dma_alloc
[12:16:47] [PASSED] ttm_pool_free_no_dma_alloc
[12:16:47] [PASSED] ttm_pool_fini_basic
[12:16:47] ==================== [PASSED] ttm_pool =====================
[12:16:47] ================ ttm_resource (8 subtests) =================
[12:16:47] ================= ttm_resource_init_basic  =================
[12:16:47] [PASSED] Init resource in TTM_PL_SYSTEM
[12:16:47] [PASSED] Init resource in TTM_PL_VRAM
[12:16:47] [PASSED] Init resource in a private placement
[12:16:47] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags
[12:16:47] ============= [PASSED] ttm_resource_init_basic =============
[12:16:47] [PASSED] ttm_resource_init_pinned
[12:16:47] [PASSED] ttm_resource_fini_basic
[12:16:47] [PASSED] ttm_resource_manager_init_basic
[12:16:47] [PASSED] ttm_resource_manager_usage_basic
[12:16:47] [PASSED] ttm_resource_manager_set_used_basic
[12:16:47] [PASSED] ttm_sys_man_alloc_basic
[12:16:47] [PASSED] ttm_sys_man_free_basic
[12:16:47] ================== [PASSED] ttm_resource ===================
[12:16:47] =================== ttm_tt (15 subtests) ===================
[12:16:47] ==================== ttm_tt_init_basic  ====================
[12:16:47] [PASSED] Page-aligned size
[12:16:47] [PASSED] Extra pages requested
[12:16:47] ================ [PASSED] ttm_tt_init_basic ================
[12:16:47] [PASSED] ttm_tt_init_misaligned
[12:16:47] [PASSED] ttm_tt_fini_basic
[12:16:47] [PASSED] ttm_tt_fini_sg
[12:16:47] [PASSED] ttm_tt_fini_shmem
[12:16:47] [PASSED] ttm_tt_create_basic
[12:16:47] [PASSED] ttm_tt_create_invalid_bo_type
[12:16:47] [PASSED] ttm_tt_create_ttm_exists
[12:16:47] [PASSED] ttm_tt_create_failed
[12:16:47] [PASSED] ttm_tt_destroy_basic
[12:16:47] [PASSED] ttm_tt_populate_null_ttm
[12:16:47] [PASSED] ttm_tt_populate_populated_ttm
[12:16:47] [PASSED] ttm_tt_unpopulate_basic
[12:16:47] [PASSED] ttm_tt_unpopulate_empty_ttm
[12:16:47] [PASSED] ttm_tt_swapin_basic
[12:16:47] ===================== [PASSED] ttm_tt ======================
[12:16:47] =================== ttm_bo (14 subtests) ===================
[12:16:47] =========== ttm_bo_reserve_optimistic_no_ticket  ===========
[12:16:47] [PASSED] Cannot be interrupted and sleeps
[12:16:47] [PASSED] Cannot be interrupted, locks straight away
[12:16:47] [PASSED] Can be interrupted, sleeps
[12:16:47] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket =======
[12:16:47] [PASSED] ttm_bo_reserve_locked_no_sleep
[12:16:47] [PASSED] ttm_bo_reserve_no_wait_ticket
[12:16:47] [PASSED] ttm_bo_reserve_double_resv
[12:16:47] [PASSED] ttm_bo_reserve_interrupted
[12:16:47] [PASSED] ttm_bo_reserve_deadlock
[12:16:47] [PASSED] ttm_bo_unreserve_basic
[12:16:47] [PASSED] ttm_bo_unreserve_pinned
[12:16:47] [PASSED] ttm_bo_unreserve_bulk
[12:16:47] [PASSED] ttm_bo_fini_basic
[12:16:47] [PASSED] ttm_bo_fini_shared_resv
[12:16:47] [PASSED] ttm_bo_pin_basic
[12:16:47] [PASSED] ttm_bo_pin_unpin_resource
[12:16:47] [PASSED] ttm_bo_multiple_pin_one_unpin
[12:16:47] ===================== [PASSED] ttm_bo ======================
[12:16:47] ============== ttm_bo_validate (22 subtests) ===============
[12:16:47] ============== ttm_bo_init_reserved_sys_man  ===============
[12:16:47] [PASSED] Buffer object for userspace
[12:16:47] [PASSED] Kernel buffer object
[12:16:47] [PASSED] Shared buffer object
[12:16:47] ========== [PASSED] ttm_bo_init_reserved_sys_man ===========
[12:16:47] ============== ttm_bo_init_reserved_mock_man  ==============
[12:16:47] [PASSED] Buffer object for userspace
[12:16:47] [PASSED] Kernel buffer object
[12:16:47] [PASSED] Shared buffer object
[12:16:47] ========== [PASSED] ttm_bo_init_reserved_mock_man ==========
[12:16:47] [PASSED] ttm_bo_init_reserved_resv
[12:16:47] ================== ttm_bo_validate_basic  ==================
[12:16:47] [PASSED] Buffer object for userspace
[12:16:47] [PASSED] Kernel buffer object
[12:16:47] [PASSED] Shared buffer object
[12:16:47] ============== [PASSED] ttm_bo_validate_basic ==============
[12:16:47] [PASSED] ttm_bo_validate_invalid_placement
[12:16:47] ============= ttm_bo_validate_same_placement  ==============
[12:16:47] [PASSED] System manager
[12:16:47] [PASSED] VRAM manager
[12:16:47] ========= [PASSED] ttm_bo_validate_same_placement ==========
[12:16:47] [PASSED] ttm_bo_validate_failed_alloc
[12:16:47] [PASSED] ttm_bo_validate_pinned
[12:16:47] [PASSED] ttm_bo_validate_busy_placement
[12:16:47] ================ ttm_bo_validate_multihop  =================
[12:16:47] [PASSED] Buffer object for userspace
[12:16:47] [PASSED] Kernel buffer object
[12:16:47] [PASSED] Shared buffer object
[12:16:47] ============ [PASSED] ttm_bo_validate_multihop =============
[12:16:47] ========== ttm_bo_validate_no_placement_signaled  ==========
[12:16:47] [PASSED] Buffer object in system domain, no page vector
[12:16:47] [PASSED] Buffer object in system domain with an existing page vector
[12:16:47] ====== [PASSED] ttm_bo_validate_no_placement_signaled ======
[12:16:47] ======== ttm_bo_validate_no_placement_not_signaled  ========
[12:16:47] [PASSED] Buffer object for userspace
[12:16:47] [PASSED] Kernel buffer object
[12:16:47] [PASSED] Shared buffer object
[12:16:47] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ====
[12:16:47] [PASSED] ttm_bo_validate_move_fence_signaled
[12:16:47] ========= ttm_bo_validate_move_fence_not_signaled  =========
[12:16:47] [PASSED] Waits for GPU
[12:16:47] [PASSED] Tries to lock straight away
[12:16:47] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled =====
[12:16:47] [PASSED] ttm_bo_validate_swapout
[12:16:47] [PASSED] ttm_bo_validate_happy_evict
[12:16:47] [PASSED] ttm_bo_validate_all_pinned_evict
[12:16:47] [PASSED] ttm_bo_validate_allowed_only_evict
[12:16:47] [PASSED] ttm_bo_validate_deleted_evict
[12:16:47] [PASSED] ttm_bo_validate_busy_domain_evict
[12:16:47] [PASSED] ttm_bo_validate_evict_gutting
[12:16:47] [PASSED] ttm_bo_validate_recrusive_evict
[12:16:47] ================= [PASSED] ttm_bo_validate =================
[12:16:47] ============================================================
[12:16:47] Testing complete. Ran 102 tests: passed: 102
[12:16:47] Elapsed time: 12.131s total, 1.881s configuring, 10.036s building, 0.185s running

+ for kcfg in "${kunitconfigs[@]}"
+ [[ ! -f /kernel/drivers/dma-buf/.kunitconfig ]]
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/dma-buf/.kunitconfig
[12:16:47] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[12:16:49] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[12:16:58] Starting KUnit Kernel (1/1)...
[12:16:58] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[12:16:58] =============== dma-buf-fence (12 subtests) ================
[12:16:58] [PASSED] test_sanitycheck
[12:16:58] [PASSED] test_signaling
[12:16:58] [PASSED] test_add_callback
[12:16:58] [PASSED] test_late_add_callback
[12:16:58] [PASSED] test_rm_callback
[12:16:58] [PASSED] test_late_rm_callback
[12:16:58] [PASSED] test_status
[12:16:58] [PASSED] test_error
[12:16:58] [PASSED] test_wait
[12:16:58] [PASSED] test_wait_timeout
[12:16:58] [PASSED] test_stub
[12:16:58] [SKIPPED] test_race_signal_callback (requires at least 2 CPUs)
[12:16:58] ================== [PASSED] dma-buf-fence ==================
[12:16:58] ============ dma-buf-fence-chain (11 subtests) =============
[12:16:58] [PASSED] test_sanitycheck
[12:16:58] [PASSED] test_find_seqno
[12:16:58] [PASSED] test_find_signaled
[12:16:58] [PASSED] test_find_out_of_order
[12:17:03] [PASSED] test_find_gap
[12:17:03] [PASSED] test_find_race
[12:17:03] [PASSED] test_signal_forward
[12:17:03] [PASSED] test_signal_backward
[12:17:03] [PASSED] test_wait_forward
[12:17:03] [PASSED] test_wait_backward
[12:17:03] [PASSED] test_wait_random
[12:17:03] =============== [PASSED] dma-buf-fence-chain ===============
[12:17:03] ============ dma-buf-fence-unwrap (10 subtests) ============
[12:17:03] [PASSED] test_sanitycheck
[12:17:03] [PASSED] test_unwrap_array
[12:17:03] [PASSED] test_unwrap_chain
[12:17:03] [PASSED] test_unwrap_chain_array
[12:17:03] [PASSED] test_unwrap_merge
[12:17:03] [PASSED] test_unwrap_merge_duplicate
[12:17:03] [PASSED] test_unwrap_merge_seqno
[12:17:03] [PASSED] test_unwrap_merge_order
[12:17:03] [PASSED] test_unwrap_merge_complex
[12:17:03] [PASSED] test_unwrap_merge_complex_seqno
[12:17:03] ============== [PASSED] dma-buf-fence-unwrap ===============
[12:17:03] ================ dma-buf-resv (5 subtests) =================
[12:17:03] [PASSED] test_sanitycheck
[12:17:03] ===================== test_signaling  ======================
[12:17:03] [PASSED] kernel
[12:17:03] [PASSED] write
[12:17:03] [PASSED] read
[12:17:03] [PASSED] bookkeep
[12:17:03] ================= [PASSED] test_signaling ==================
[12:17:03] ====================== test_for_each  ======================
[12:17:03] [PASSED] kernel
[12:17:03] [PASSED] write
[12:17:03] [PASSED] read
[12:17:03] [PASSED] bookkeep
[12:17:03] ================== [PASSED] test_for_each ==================
[12:17:03] ================= test_for_each_unlocked  ==================
[12:17:03] [PASSED] kernel
[12:17:03] [PASSED] write
[12:17:03] [PASSED] read
[12:17:03] [PASSED] bookkeep
[12:17:03] ============= [PASSED] test_for_each_unlocked ==============
[12:17:03] ===================== test_get_fences  =====================
[12:17:03] [PASSED] kernel
[12:17:03] [PASSED] write
[12:17:03] [PASSED] read
[12:17:03] [PASSED] bookkeep
[12:17:03] ================= [PASSED] test_get_fences =================
[12:17:03] ================== [PASSED] dma-buf-resv ===================
[12:17:03] ============================================================
[12:17:03] Testing complete. Ran 50 tests: passed: 49, skipped: 1
[12:17:03] Elapsed time: 16.005s total, 1.854s configuring, 8.829s building, 5.273s running

+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel

Re: [PATCH v9 10/14] drm/xe/hwmon: Add platform-aware VRAM thermal channel support

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] hwmon: DRM driver implements hwmon directly instead of as auxiliary device
--

commit 55ff84e7912b9e195885552d6a750a68cc2c19d9
Author: Karthik Poosa <karthik.poosa@intel.com>

drm/xe/hwmon: Add platform-aware VRAM thermal channel support

On CRI, this derives the number of available VRAM temperature channels from
the CRI_MSU_VRAM_ENABLE register. It increases the maximum supported VRAM
channel count to 80 and uses the derived count to control VRAM sensor
enumeration, channel access, and VRAM label allocation.

> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
> index bafa175f84578..9d83d9d2286ed 100644
> --- a/drivers/gpu/drm/xe/xe_hwmon.c
> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
[ ... ]
> @@ -1683,7 +1809,9 @@ int xe_hwmon_register(struct xe_device *xe)
>  	hwmon->xe = xe;
>  	xe->hwmon = hwmon;
>  
> -	xe_hwmon_get_preregistration_info(hwmon);
> +	ret = xe_hwmon_get_preregistration_info(hwmon);
> +	if (ret)
> +		goto err_null_hwmon;
>  
>  	drm_dbg(&xe->drm, "Register xe hwmon interface\n");
>  
> @@ -1693,10 +1821,14 @@ int xe_hwmon_register(struct xe_device *xe)
>  								hwmon_groups);

[Severity: Low]
The hwmon subsystem guidelines state that if a chip's main functionality
is not hardware monitoring (such as a DRM controller), its hardware
monitoring functionality should be implemented as an auxiliary device
driver residing in drivers/hwmon/.

Does registering the hardware monitoring device directly from within the 
drivers/gpu/drm/ subsystem bypass these structural layering rules?

>  	if (IS_ERR(hwmon->hwmon_dev)) {
>  		drm_err(&xe->drm, "Failed to register xe hwmon (%pe)\n", hwmon->hwmon_dev);
> -		xe->hwmon = NULL;
> -		return PTR_ERR(hwmon->hwmon_dev);
> +		ret = PTR_ERR(hwmon->hwmon_dev);
> +		goto err_null_hwmon;
>  	}
>  
>  	return 0;
> +
> +err_null_hwmon:
> +	xe->hwmon = NULL;
> +	return ret;
>  }
>  MODULE_IMPORT_NS("INTEL_PMT_TELEMETRY");

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009120335.52973-1-karthik.poosa@intel.com?part=10

✓ Xe.CI.BAT: success for drm/xe/hwmon: Update hwmon thermal mailbox (rev6)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 872 bytes --]

== Series Details ==

Series: drm/xe/hwmon: Update hwmon thermal mailbox (rev6)
URL   : https://patchwork.freedesktop.org/series/174898/
State : success

== Summary ==

CI Bug Log - changes from xe-5915-3bd4f625aafdf70814dbf075de96e224355c9f1e_BAT -> xe-pw-174898v6_BAT
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Participating hosts (14 -> 14)
------------------------------

  No changes in participating hosts


Changes
-------

  No changes found


Build changes
-------------

  * Linux: xe-5915-3bd4f625aafdf70814dbf075de96e224355c9f1e -> xe-pw-174898v6

  IGT_9138: 9138
  xe-5915-3bd4f625aafdf70814dbf075de96e224355c9f1e: 3bd4f625aafdf70814dbf075de96e224355c9f1e
  xe-pw-174898v6: 174898v6

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-174898v6/index.html

[-- Attachment #2: Type: text/html, Size: 1420 bytes --]

Re: [PATCH v9 01/14] drm/xe/hwmon: Handle pcode read failures of xe_hwmon_pcode_rmw_power_limit

[Poosa, Karthik]

On 09-10-2026 17:44, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> - [Medium] drm/xe/hwmon: unchecked return value from xe_hwmon_pcode_rmw_power_limit()
> - [Medium] hwmon: ignored pcode read errors fabricate valid sysfs responses
> --
>
> commit 6cc9575a02c32b9a8a28e257650ff7b17698865f
> Author: Karthik Poosa <karthik.poosa@intel.com>
>
> drm/xe/hwmon: Handle pcode read failures of xe_hwmon_pcode_rmw_power_limit
>
> This commit adds a return on read failures inside
> xe_hwmon_pcode_rmw_power_limit and updates callers to avoid updating
> power limit settings with invalid data.
>
>> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
>> index 5edeac961ec33..9884e06f83e59 100644
>> --- a/drivers/gpu/drm/xe/xe_hwmon.c
>> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
>> @@ -232,9 +232,11 @@ static int xe_hwmon_pcode_rmw_power_limit(const struct xe_hwmon *hwmon, u32 attr
>>   						  READ_PSYSGPU_POWER_LIMIT :
>>   						  READ_PACKAGE_POWER_LIMIT,
>>   						  prepare_power_limit_param2(hwmon)), &val0, &val1);
>> -	if (ret)
>> -		drm_dbg(&hwmon->xe->drm, "read failed ch %d val0 0x%08x, val1 0x%08x, ret %d\n",
>> +	if (ret) {
>> +		drm_err(&hwmon->xe->drm, "read failed ch %d val0 0x%08x, val1 0x%08x, ret %d\n",
>>   			channel, val0, val1, ret);
>> +		return ret;
>> +	}
> [Severity: Medium]
> Since this function now returns early on error, skipping the subsequent PCODE
> writes, could this cause regressions in xe_hwmon_get_preregistration_info?
>
> In xe_hwmon_get_preregistration_info, there are four calls to this function
> that ignore the return value. If these initialization writes fail, the
> function still sets hwmon->boot_power_limit_read = true.
>
> Setting this flag alters the subcommand used for later reads, changing it from
> READ_PL_FROM_FW to READ_PL_FROM_PCODE. Could this cause userspace to receive
> incorrect power limit values if the initial writes were aborted?
>
> [ ... ]

No, This won't cause a regression.

boot_power_limit_read is set only after all four READ_PL_FROM_FW reads 
succeed. Later PCODE failures don't change the cached pl1_on_boot and 
pl2_on_boot values.

If the RMW read fails, nothing is written. If the write fails, PCODE 
doesn't apply it. Either way, PCODE keeps the firmware defaults.
>> @@ -394,7 +396,9 @@ static int xe_hwmon_power_max_write(struct xe_hwmon *hwmon, u32 attr, int channe
>>   		if (hwmon->xe->info.has_mbx_power_limits) {
>>   			drm_dbg(&hwmon->xe->drm, "disabling %s on channel %d\n",
>>   				PWR_ATTR_TO_STR(attr), channel);
>> -			xe_hwmon_pcode_rmw_power_limit(hwmon, attr, channel, PWR_LIM_EN, 0);
>> +			ret = xe_hwmon_pcode_rmw_power_limit(hwmon, attr, channel, PWR_LIM_EN, 0);
>> +			if (ret)
>> +				goto unlock;
>>   			xe_hwmon_pcode_read_power_limit(hwmon, attr, channel, &reg_val);
> .
> [Severity: Medium]
> Is it intentional that the return value of xe_hwmon_pcode_read_power_limit is
> discarded right after checking the write failure?
>
> If this read fails due to a hardware timeout, it could leave reg_val
> uninitialized or zeroed, bypassing the disable verification check that follows.
>
> Additionally, could the ignored read errors in xe_hwmon_power_max_read
> fabricate valid sysfs responses? If xe_hwmon_pcode_read_power_limit fails in
> that function, it returns fake 0 readings instead of propagating the hardware
> error, which might mislead userspace tools into believing the power limit is
> disabled.
Valid points, but they're unrelated to this patch. this shall be handled 
in separate patch series.

Re: [PATCH v9 07/14] drm/xe/hwmon: Consolidate temperature sensor availability checks

[Poosa, Karthik]

On 09-10-2026 17:46, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> - [Medium] drm/xe/hwmon: live hardware read during probe permanently hides sysfs attributes on transient failure
> - [Medium] drm/xe/hwmon: endianness bug when extracting thermal limits via union
> --
>
> commit bbb594b78c17c03bdb11a59f0ce797f39d14c3e9
> Author: Karthik Poosa <karthik.poosa@intel.com>
> Subject: drm/xe/hwmon: Consolidate temperature sensor availability checks
>
> This commit replaces is_vram_ch_available() with a generalized
> is_temp_available() function that validates multiple sensor types using new
> helpers. It uses this new function during hwmon registration to ensure
> attributes for absent sensors are not exposed.
>
>> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
>> index accccadbe3e67..62e341ef37e9b 100644
>> --- a/drivers/gpu/drm/xe/xe_hwmon.c
>> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
> [ ... ]
>
>> @@ -1008,19 +1008,39 @@ static void xe_hwmon_get_voltage(struct xe_hwmon *hwmon, int channel, long *valu
>>   	*value = DIV_ROUND_CLOSEST(REG_FIELD_GET(VOLTAGE_MASK, reg_val) * 2500, SF_VOLTAGE);
>>   }
>>   
>> -static inline bool is_vram_ch_available(struct xe_hwmon *hwmon, int channel)
>> +static bool is_temp_available(struct xe_hwmon *hwmon, int channel)
>>   {
>>   	struct xe_mmio *mmio = xe_root_tile_mmio(hwmon->xe);
>> -	int vram_id = channel - CHANNEL_VRAM_N;
>> -	struct xe_reg vram_reg;
>> +	struct xe_reg reg;
>> +	u32 reg_val;
>>   
>> -	vram_reg = xe_hwmon_get_reg(hwmon, REG_TEMP, channel);
>> -	if (!xe_reg_is_valid(vram_reg) || !xe_mmio_read32(mmio, vram_reg))
>> -		return false;
>> +	switch (channel) {
>> +	case CHANNEL_PKG:
>> +	case CHANNEL_VRAM:
>> +	case CHANNEL_VRAM_N...CHANNEL_VRAM_N_MAX:
>> +		reg = xe_hwmon_get_reg(hwmon, REG_TEMP, channel);
>> +		if (!xe_reg_is_valid(reg))
>> +			return false;
>> +
>> +		reg_val = xe_mmio_read32(mmio, reg);
>> +		if (!mmio_temp_valid(hwmon, reg_val)) {
> [Severity: Medium]
> Since this function is called during hwmon registration to determine attribute
> visibility, does this live hardware read risk permanently hiding sysfs
> attributes if the hardware is transiently busy or uninitialized?
>
> If the sensor returns 0 (which mmio_temp_valid treats as invalid) during
> driver probe, the attribute will be hidden for the entire boot cycle.
device is expected to be ready by this time, so this is not an issue.
>
>> +			drm_dbg(&hwmon->xe->drm,
>> +				"channel %d temperature unavailable, val 0x%x\n", channel, reg_val);
>> +			return false;
>> +		}
>> +
>> +		if (channel >= CHANNEL_VRAM_N)
>> +			sprintf(hwmon->temp.vram_label[channel - CHANNEL_VRAM_N],
>> +				"vram_ch_%d", channel - CHANNEL_VRAM_N);
>>   
>> -	/* Create label only for available vram channel */
>> -	sprintf(hwmon->temp.vram_label[vram_id], "vram_ch_%d", vram_id);
>> -	return true;
>> +		return true;
>> +	case CHANNEL_MCTRL:
>> +		return hwmon->temp.count && !get_mc_temp(hwmon, NULL);
> [Severity: Medium]
> Similar to the MMIO read above, could this PCODE mailbox read cause
> attributes to be permanently hidden?
>
> If the PCODE mailbox transiently times out during driver probe,
> get_mc_temp() will return an error, causing the MCTRL attribute to be
> permanently hidden for the duration of the boot cycle.

pcode mailbox reads use a default timeout of 10 ms, and the mailbox is 
expected to complete within that time.

If it doesn't, that's an issue to debug, not a transient condition to 
retry. So we treat it as a failure and keep the attribute hidden.

>
>> +	case CHANNEL_PCIE:
>> +		return hwmon->temp.count && !get_pcie_temp(hwmon, NULL);
>> +	default:
>> +		return false;
>> +	}
>>   }
>>   
>>   static umode_t
>> @@ -1030,14 +1050,13 @@ xe_hwmon_temp_is_visible(struct xe_hwmon *hwmon, u32 attr, int channel)
>>   	case hwmon_temp_emergency:
>>   		switch (channel) {
>>   		case CHANNEL_PKG:
>> -			return hwmon->temp.limit[TEMP_LIMIT_PKG_SHUTDOWN] ? 0444 : 0;
>> -		case CHANNEL_VRAM:
>> -			return hwmon->temp.limit[TEMP_LIMIT_MEM_SHUTDOWN] ? 0444 : 0;
>>   		case CHANNEL_MCTRL:
>>   		case CHANNEL_PCIE:
>> -			return hwmon->temp.count ? 0444 : 0;
>> +			return (is_temp_available(hwmon, channel) &&
>> +				hwmon->temp.limit[TEMP_LIMIT_PKG_SHUTDOWN]) ? 0444 : 0;
> [Severity: Medium]
> Does extracting thermal limits this way introduce an endianness bug?
>
> While looking at how the limits are accessed here, the xe_hwmon_thermal_info
> struct aliases u8 arrays with u32 arrays:
>
>          union {
>                  u8 limit[TEMP_LIMIT_MAX];
>                  u32 data[DIV_ROUND_UP(TEMP_LIMIT_MAX, sizeof(u32))];
>          };
>
> If the driver reads 32-bit values from PCODE into the u32 arrays, extracting
> individual 8-bit limits by indexing into the u8 arrays assumes a little-endian
> memory layout. On big-endian architectures, index 0 will map to bits 24:31
> instead of bits 0:7, potentially causing the driver to extract incorrect
> thermal limits.
>
>> +		case CHANNEL_VRAM:
>>   		case CHANNEL_VRAM_N...CHANNEL_VRAM_N_MAX:
>> -			return (is_vram_ch_available(hwmon, channel) &&
>> +			return (is_temp_available(hwmon, channel) &&
>>   				hwmon->temp.limit[TEMP_LIMIT_MEM_SHUTDOWN]) ? 0444 : 0;

Re: [PATCH v9 10/14] drm/xe/hwmon: Add platform-aware VRAM thermal channel support

[Poosa, Karthik]

On 09-10-2026 17:48, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] hwmon: DRM driver implements hwmon directly instead of as auxiliary device
> --
>
> commit 55ff84e7912b9e195885552d6a750a68cc2c19d9
> Author: Karthik Poosa <karthik.poosa@intel.com>
>
> drm/xe/hwmon: Add platform-aware VRAM thermal channel support
>
> On CRI, this derives the number of available VRAM temperature channels from
> the CRI_MSU_VRAM_ENABLE register. It increases the maximum supported VRAM
> channel count to 80 and uses the derived count to control VRAM sensor
> enumeration, channel access, and VRAM label allocation.
>
>> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
>> index bafa175f84578..9d83d9d2286ed 100644
>> --- a/drivers/gpu/drm/xe/xe_hwmon.c
>> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
> [ ... ]
>> @@ -1683,7 +1809,9 @@ int xe_hwmon_register(struct xe_device *xe)
>>   	hwmon->xe = xe;
>>   	xe->hwmon = hwmon;
>>   
>> -	xe_hwmon_get_preregistration_info(hwmon);
>> +	ret = xe_hwmon_get_preregistration_info(hwmon);
>> +	if (ret)
>> +		goto err_null_hwmon;
>>   
>>   	drm_dbg(&xe->drm, "Register xe hwmon interface\n");
>>   
>> @@ -1693,10 +1821,14 @@ int xe_hwmon_register(struct xe_device *xe)
>>   								hwmon_groups);
> [Severity: Low]
> The hwmon subsystem guidelines state that if a chip's main functionality
> is not hardware monitoring (such as a DRM controller), its hardware
> monitoring functionality should be implemented as an auxiliary device
> driver residing in drivers/hwmon/.
>
> Does registering the hardware monitoring device directly from within the
> drivers/gpu/drm/ subsystem bypass these structural layering rules?
The hwmon documentation expresses a preference for separating monitoring 
functionality from devices whose primary purpose is not hardware 
monitoring. However, direct hwmon registration from DRM drivers is 
already common practice in the kernel (e.g. amdgpu, nouveau, xe), so the 
proposed approach would be consistent with existing GPU driver 
implementations."

>
>>   	if (IS_ERR(hwmon->hwmon_dev)) {
>>   		drm_err(&xe->drm, "Failed to register xe hwmon (%pe)\n", hwmon->hwmon_dev);
>> -		xe->hwmon = NULL;
>> -		return PTR_ERR(hwmon->hwmon_dev);
>> +		ret = PTR_ERR(hwmon->hwmon_dev);
>> +		goto err_null_hwmon;
>>   	}
>>   
>>   	return 0;
>> +
>> +err_null_hwmon:
>> +	xe->hwmon = NULL;
>> +	return ret;
>>   }
>>   MODULE_IMPORT_NS("INTEL_PMT_TELEMETRY");

Re: [PATCH v9 01/14] drm/xe/hwmon: Handle pcode read failures of xe_hwmon_pcode_rmw_power_limit

[Poosa, Karthik]

On 10-10-2026 10:44, Poosa, Karthik wrote:
>
> On 09-10-2026 17:44, sashiko-bot@kernel.org wrote:
>> Thank you for your contribution! Sashiko AI review found 2 potential 
>> issue(s) to consider:
>> - [Medium] drm/xe/hwmon: unchecked return value from 
>> xe_hwmon_pcode_rmw_power_limit()
>> - [Medium] hwmon: ignored pcode read errors fabricate valid sysfs 
>> responses
>> -- 
>>
>> commit 6cc9575a02c32b9a8a28e257650ff7b17698865f
>> Author: Karthik Poosa <karthik.poosa@intel.com>
>>
>> drm/xe/hwmon: Handle pcode read failures of 
>> xe_hwmon_pcode_rmw_power_limit
>>
>> This commit adds a return on read failures inside
>> xe_hwmon_pcode_rmw_power_limit and updates callers to avoid updating
>> power limit settings with invalid data.
>>
>>> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c 
>>> b/drivers/gpu/drm/xe/xe_hwmon.c
>>> index 5edeac961ec33..9884e06f83e59 100644
>>> --- a/drivers/gpu/drm/xe/xe_hwmon.c
>>> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
>>> @@ -232,9 +232,11 @@ static int xe_hwmon_pcode_rmw_power_limit(const 
>>> struct xe_hwmon *hwmon, u32 attr
>>>                             READ_PSYSGPU_POWER_LIMIT :
>>>                             READ_PACKAGE_POWER_LIMIT,
>>> prepare_power_limit_param2(hwmon)), &val0, &val1);
>>> -    if (ret)
>>> -        drm_dbg(&hwmon->xe->drm, "read failed ch %d val0 0x%08x, 
>>> val1 0x%08x, ret %d\n",
>>> +    if (ret) {
>>> +        drm_err(&hwmon->xe->drm, "read failed ch %d val0 0x%08x, 
>>> val1 0x%08x, ret %d\n",
>>>               channel, val0, val1, ret);
>>> +        return ret;
>>> +    }
>> [Severity: Medium]
>> Since this function now returns early on error, skipping the 
>> subsequent PCODE
>> writes, could this cause regressions in 
>> xe_hwmon_get_preregistration_info?
>>
>> In xe_hwmon_get_preregistration_info, there are four calls to this 
>> function
>> that ignore the return value. If these initialization writes fail, the
>> function still sets hwmon->boot_power_limit_read = true.
>>
>> Setting this flag alters the subcommand used for later reads, 
>> changing it from
>> READ_PL_FROM_FW to READ_PL_FROM_PCODE. Could this cause userspace to 
>> receive
>> incorrect power limit values if the initial writes were aborted?
>>
>> [ ... ]
>
> No, This won't cause a regression.
>
> boot_power_limit_read is set only after all four READ_PL_FROM_FW reads 
> succeed. Later PCODE failures don't change the cached pl1_on_boot and 
> pl2_on_boot values.
>
> If the RMW read fails, nothing is written. If the write fails, PCODE 
> doesn't apply it. Either way, PCODE keeps the firmware defaults.
>>> @@ -394,7 +396,9 @@ static int xe_hwmon_power_max_write(struct 
>>> xe_hwmon *hwmon, u32 attr, int channe
>>>           if (hwmon->xe->info.has_mbx_power_limits) {
>>>               drm_dbg(&hwmon->xe->drm, "disabling %s on channel %d\n",
>>>                   PWR_ATTR_TO_STR(attr), channel);
>>> -            xe_hwmon_pcode_rmw_power_limit(hwmon, attr, channel, 
>>> PWR_LIM_EN, 0);
>>> +            ret = xe_hwmon_pcode_rmw_power_limit(hwmon, attr, 
>>> channel, PWR_LIM_EN, 0);
>>> +            if (ret)
>>> +                goto unlock;
>>>               xe_hwmon_pcode_read_power_limit(hwmon, attr, channel, 
>>> &reg_val);
>> .
>> [Severity: Medium]
>> Is it intentional that the return value of 
>> xe_hwmon_pcode_read_power_limit is
>> discarded right after checking the write failure?
>>
>> If this read fails due to a hardware timeout, it could leave reg_val
>> uninitialized or zeroed, bypassing the disable verification check 
>> that follows.
>>
>> Additionally, could the ignored read errors in xe_hwmon_power_max_read
>> fabricate valid sysfs responses? If xe_hwmon_pcode_read_power_limit 
>> fails in
>> that function, it returns fake 0 readings instead of propagating the 
>> hardware
>> error, which might mislead userspace tools into believing the power 
>> limit is
>> disabled.
> Valid points, but they're unrelated to this patch. this shall be 
> handled in separate patch series.
Raised this patch for this 
https://patchwork.freedesktop.org/patch/759383/?series=175943&rev=1

Re: [PATCH v9 07/14] drm/xe/hwmon: Consolidate temperature sensor availability checks

[Poosa, Karthik]

On 10-10-2026 10:49, Poosa, Karthik wrote:
>
> On 09-10-2026 17:46, sashiko-bot@kernel.org wrote:
>> Thank you for your contribution! Sashiko AI review found 2 potential 
>> issue(s) to consider:
>> - [Medium] drm/xe/hwmon: live hardware read during probe permanently 
>> hides sysfs attributes on transient failure
>> - [Medium] drm/xe/hwmon: endianness bug when extracting thermal 
>> limits via union
>> -- 
>>
>> commit bbb594b78c17c03bdb11a59f0ce797f39d14c3e9
>> Author: Karthik Poosa <karthik.poosa@intel.com>
>> Subject: drm/xe/hwmon: Consolidate temperature sensor availability 
>> checks
>>
>> This commit replaces is_vram_ch_available() with a generalized
>> is_temp_available() function that validates multiple sensor types 
>> using new
>> helpers. It uses this new function during hwmon registration to ensure
>> attributes for absent sensors are not exposed.
>>
>>> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c 
>>> b/drivers/gpu/drm/xe/xe_hwmon.c
>>> index accccadbe3e67..62e341ef37e9b 100644
>>> --- a/drivers/gpu/drm/xe/xe_hwmon.c
>>> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
>> [ ... ]
>>
>>> @@ -1008,19 +1008,39 @@ static void xe_hwmon_get_voltage(struct 
>>> xe_hwmon *hwmon, int channel, long *valu
>>>       *value = DIV_ROUND_CLOSEST(REG_FIELD_GET(VOLTAGE_MASK, 
>>> reg_val) * 2500, SF_VOLTAGE);
>>>   }
>>>   -static inline bool is_vram_ch_available(struct xe_hwmon *hwmon, 
>>> int channel)
>>> +static bool is_temp_available(struct xe_hwmon *hwmon, int channel)
>>>   {
>>>       struct xe_mmio *mmio = xe_root_tile_mmio(hwmon->xe);
>>> -    int vram_id = channel - CHANNEL_VRAM_N;
>>> -    struct xe_reg vram_reg;
>>> +    struct xe_reg reg;
>>> +    u32 reg_val;
>>>   -    vram_reg = xe_hwmon_get_reg(hwmon, REG_TEMP, channel);
>>> -    if (!xe_reg_is_valid(vram_reg) || !xe_mmio_read32(mmio, vram_reg))
>>> -        return false;
>>> +    switch (channel) {
>>> +    case CHANNEL_PKG:
>>> +    case CHANNEL_VRAM:
>>> +    case CHANNEL_VRAM_N...CHANNEL_VRAM_N_MAX:
>>> +        reg = xe_hwmon_get_reg(hwmon, REG_TEMP, channel);
>>> +        if (!xe_reg_is_valid(reg))
>>> +            return false;
>>> +
>>> +        reg_val = xe_mmio_read32(mmio, reg);
>>> +        if (!mmio_temp_valid(hwmon, reg_val)) {
>> [Severity: Medium]
>> Since this function is called during hwmon registration to determine 
>> attribute
>> visibility, does this live hardware read risk permanently hiding sysfs
>> attributes if the hardware is transiently busy or uninitialized?
>>
>> If the sensor returns 0 (which mmio_temp_valid treats as invalid) during
>> driver probe, the attribute will be hidden for the entire boot cycle.
> device is expected to be ready by this time, so this is not an issue.
>>
>>> + drm_dbg(&hwmon->xe->drm,
>>> +                "channel %d temperature unavailable, val 0x%x\n", 
>>> channel, reg_val);
>>> +            return false;
>>> +        }
>>> +
>>> +        if (channel >= CHANNEL_VRAM_N)
>>> +            sprintf(hwmon->temp.vram_label[channel - CHANNEL_VRAM_N],
>>> +                "vram_ch_%d", channel - CHANNEL_VRAM_N);
>>>   -    /* Create label only for available vram channel */
>>> -    sprintf(hwmon->temp.vram_label[vram_id], "vram_ch_%d", vram_id);
>>> -    return true;
>>> +        return true;
>>> +    case CHANNEL_MCTRL:
>>> +        return hwmon->temp.count && !get_mc_temp(hwmon, NULL);
>> [Severity: Medium]
>> Similar to the MMIO read above, could this PCODE mailbox read cause
>> attributes to be permanently hidden?
>>
>> If the PCODE mailbox transiently times out during driver probe,
>> get_mc_temp() will return an error, causing the MCTRL attribute to be
>> permanently hidden for the duration of the boot cycle.
>
> pcode mailbox reads use a default timeout of 10 ms, and the mailbox is 
> expected to complete within that time.
>
> If it doesn't, that's an issue to debug, not a transient condition to 
> retry. So we treat it as a failure and keep the attribute hidden.
>
>>
>>> +    case CHANNEL_PCIE:
>>> +        return hwmon->temp.count && !get_pcie_temp(hwmon, NULL);
>>> +    default:
>>> +        return false;
>>> +    }
>>>   }
>>>     static umode_t
>>> @@ -1030,14 +1050,13 @@ xe_hwmon_temp_is_visible(struct xe_hwmon 
>>> *hwmon, u32 attr, int channel)
>>>       case hwmon_temp_emergency:
>>>           switch (channel) {
>>>           case CHANNEL_PKG:
>>> -            return hwmon->temp.limit[TEMP_LIMIT_PKG_SHUTDOWN] ? 
>>> 0444 : 0;
>>> -        case CHANNEL_VRAM:
>>> -            return hwmon->temp.limit[TEMP_LIMIT_MEM_SHUTDOWN] ? 
>>> 0444 : 0;
>>>           case CHANNEL_MCTRL:
>>>           case CHANNEL_PCIE:
>>> -            return hwmon->temp.count ? 0444 : 0;
>>> +            return (is_temp_available(hwmon, channel) &&
>>> + hwmon->temp.limit[TEMP_LIMIT_PKG_SHUTDOWN]) ? 0444 : 0;
>> [Severity: Medium]
>> Does extracting thermal limits this way introduce an endianness bug?
>>
>> While looking at how the limits are accessed here, the 
>> xe_hwmon_thermal_info
>> struct aliases u8 arrays with u32 arrays:
>>
>>          union {
>>                  u8 limit[TEMP_LIMIT_MAX];
>>                  u32 data[DIV_ROUND_UP(TEMP_LIMIT_MAX, sizeof(u32))];
>>          };
>>
>> If the driver reads 32-bit values from PCODE into the u32 arrays, 
>> extracting
>> individual 8-bit limits by indexing into the u8 arrays assumes a 
>> little-endian
>> memory layout. On big-endian architectures, index 0 will map to bits 
>> 24:31
>> instead of bits 0:7, potentially causing the driver to extract incorrect
>> thermal limits.
>>
>>> +        case CHANNEL_VRAM:
>>>           case CHANNEL_VRAM_N...CHANNEL_VRAM_N_MAX:
>>> -            return (is_vram_ch_available(hwmon, channel) &&
>>> +            return (is_temp_available(hwmon, channel) &&
>>> hwmon->temp.limit[TEMP_LIMIT_MEM_SHUTDOWN]) ? 0444 : 0;
This is fixed in next revision 
https://lore.kernel.org/intel-xe/20261012130401.443473-4-karthik.poosa@intel.com/T/#u 
. The thermal limit words are now stored in a __le32 array with 
cpu_to_le32(), so limit[] reads the correct bytes on big-endian hosts as 
well."