Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 00/29] DP-HDMI PCON DSC fixes
@ 2026-11-20 14:07 Ankit Nautiyal
  2026-11-20 14:07 ` [PATCH 01/29] drm/i915/hdmi: Split the intel_hdmi_dsc_get_bpp() Ankit Nautiyal
                   ` (31 more replies)
  0 siblings, 32 replies; 42+ messages in thread
From: Ankit Nautiyal @ 2026-11-20 14:07 UTC (permalink / raw)
  To: intel-gfx, intel-xe; +Cc: alexander.kaplan, Ankit Nautiyal

The PCON mode_valid path currently does not fully account for the bandwidth
limitations of the PCON <-> HDMI link. The DSC capability between the
PCON and the HDMI sink also needs to be taken into account, which currently
isn't. Furthermore, the compressed bpp chosen needs to fit the
FRL configuration, which is also missing.

This series:
 - reworks the HDMI DSC helpers so they can be reused across the
   mode_valid, compute_config and FRL bandwidth check paths
 - fixes the FRL/TMDS downstream bandwidth checks, and allows
   PCON DSC modes through the FRL check
 - Clamps the programmed DSC bpp to the FRL link bandwidth.
 - Adds the PCON DSC operations (decode, decode and re-encode and
   pass-through), and uses the FRL rate of the stream on the HDMI link.

This series is sent as a whole to have all the solution in one place.
It will be split in 3 series and merged in this order:
 1. Groundwork (patches 1-9): FRL/TMDS downstream bandwidth checks and
    the HDMI DSC helpers. A couple of patches are still to be reviewed,
    so these will be separated out for CI testing and merged first.
 2. PCON DSC operations (patches 10-21): PCON DSC state, decode and
    decode and re-encode operations and the FRL rate of the stream.
 3. DSC pass-through (patches 22-29): pass-through of a DSC 1.2a stream,
    within the limits of the HDMI sink.

Rev2:
 - Rebase and address comments from Suraj.
 - Drop drm/i915/dp: Use FRL pair check for the DFP dotclock limit as no
   longer required.

Rev3:
 - Address Comments from Sashiko.
 - Account for FRL encoding overhead during bw calculation.
 - Pass pixel clock instead of using mode->crtc_clock to make it work
   with mode-valid case.
 - Clamp the target bpp only when it equals the pipe bpp to avoid
   missing the case when dsc min_bpp and max_bpp are same.

Rev4:
 - Add the PCON DSC operations as per DP Spec: decode,
   decode and re-encode, and pass-through for a DSC 1.2a stream.
 - Add the PCON DSC state to crtc_state, compute the operation and the
   PCON DSC encoder parameters in compute_config, and only program them
   at enable. Disable the PCON DSC encoder unless it is needed.
 - Enable DSC pass-through in the PCON, and limit the slice count and
   the compressed bpp of the DP stream to what the HDMI sink supports.
 - Store the FRL rate in crtc_state, use the regular or the DSC max FRL
   rate depending on the stream on the HDMI link, and retrain the FRL
   link from the link check work.
 - Use link bpp instead of pipe bpp in the target_bpp clamp patch and
   reuse intel_dp_output_format_link_bpp_x16(). (Suraj)

Ankit Nautiyal (29):
  drm/i915/hdmi: Split the intel_hdmi_dsc_get_bpp()
  drm/i915/dp: Fix FRL BW check for HDMI2.1 DFP
  drm/i915/dp: Add a wrapper to check frl/tmds downstream constraints
  drm/i915/dp: Use the common downstream bw check in compute_bpc
  drm/i915/hdmi: Expose DSC min/max bpp helpers
  drm/i915/hdmi: Add helper to check if DSC chunksize fits the sink
    limits
  drm/i915/hdmi: Pass pixel clock to DSC slice helper
  drm/i915/dp: Account for FRL 16b/18b encoding overhead
  drm/i915/hdmi: Clamp the target_bpp only when it equals the link bpp
  drm/i915/dp: Add PCON DSC state to crtc_state
  drm/dp: Add a helper to disable the PCON DSC encoder
  drm/i915/dp: Compute the PCON DSC operation
  drm/i915/dp: Disable the PCON DSC encoder unless it is needed
  drm/i915/dp: Clamp PCON DSC bpp to the FRL link bandwidth
  drm/i915/dp: Add a helper for the DSC stream version
  drm/i915/dp: Add a helper for the FRL payload bandwidth
  drm/i915/dp: Compute the PCON DSC encoder parameters
  drm/i915/dp: Retrain the PCON FRL link from the link check work
  drm/i915/dp: Store the PCON FRL rate in the crtc state
  drm/i915/dp: Use the FRL rate of the stream on the HDMI link
  drm/i915/dp: Allow PCON DSC modes through the FRL bw check
  drm/i915/dp: Enable DSC pass-through in the PCON
  drm/i915/dp: Limit the DP link bpp for DSC pass-through to the FRL
    bandwidth
  drm/i915/dp: Select DSC pass-through in the PCON for DSC 1.2a streams
  drm/i915/dp: Allow limiting the DSC slice count for the downstream
    device
  drm/i915/dp: Check the HDMI sink slice limits for DSC pass-through
  drm/i915/dp: Pick the DSC slice count for pass-through within the HDMI
    limits
  drm/i915/dp: Limit the compressed bpp for pass-through to the HDMI
    sink
  drm/i915/dp: Accept DSC 1.2a pass-through modes in the PCON mode check

 drivers/gpu/drm/display/drm_dp_helper.c       |  23 +
 drivers/gpu/drm/i915/display/g4x_dp.c         |   2 +-
 .../drm/i915/display/intel_crtc_state_dump.c  |  17 +
 drivers/gpu/drm/i915/display/intel_ddi.c      |   4 +-
 .../drm/i915/display/intel_display_types.h    |  31 +
 drivers/gpu/drm/i915/display/intel_dp.c       | 668 ++++++++++++++----
 drivers/gpu/drm/i915/display/intel_dp.h       |  13 +-
 .../drm/i915/display/intel_dp_link_training.c |   5 +-
 drivers/gpu/drm/i915/display/intel_hdmi.c     | 138 +++-
 drivers/gpu/drm/i915/display/intel_hdmi.h     |   8 +-
 include/drm/display/drm_dp_helper.h           |   1 +
 11 files changed, 731 insertions(+), 179 deletions(-)

-- 
2.50.1


^ permalink raw reply	[flat|nested] 42+ messages in thread

end of thread, other threads:[~2026-11-20 15:24 UTC | newest]

Thread overview: 42+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 14:07 [PATCH 00/29] DP-HDMI PCON DSC fixes Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 01/29] drm/i915/hdmi: Split the intel_hdmi_dsc_get_bpp() Ankit Nautiyal
2026-11-20 14:32   ` sashiko-bot
2026-11-20 14:07 ` [PATCH 02/29] drm/i915/dp: Fix FRL BW check for HDMI2.1 DFP Ankit Nautiyal
2026-11-20 14:34   ` sashiko-bot
2026-11-20 14:07 ` [PATCH 03/29] drm/i915/dp: Add a wrapper to check frl/tmds downstream constraints Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 04/29] drm/i915/dp: Use the common downstream bw check in compute_bpc Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 05/29] drm/i915/hdmi: Expose DSC min/max bpp helpers Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 06/29] drm/i915/hdmi: Add helper to check if DSC chunksize fits the sink limits Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 07/29] drm/i915/hdmi: Pass pixel clock to DSC slice helper Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 08/29] drm/i915/dp: Account for FRL 16b/18b encoding overhead Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 09/29] drm/i915/hdmi: Clamp the target_bpp only when it equals the link bpp Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 10/29] drm/i915/dp: Add PCON DSC state to crtc_state Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 11/29] drm/dp: Add a helper to disable the PCON DSC encoder Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 12/29] drm/i915/dp: Compute the PCON DSC operation Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 13/29] drm/i915/dp: Disable the PCON DSC encoder unless it is needed Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 14/29] drm/i915/dp: Clamp PCON DSC bpp to the FRL link bandwidth Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 15/29] drm/i915/dp: Add a helper for the DSC stream version Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 16/29] drm/i915/dp: Add a helper for the FRL payload bandwidth Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 17/29] drm/i915/dp: Compute the PCON DSC encoder parameters Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 18/29] drm/i915/dp: Retrain the PCON FRL link from the link check work Ankit Nautiyal
2026-11-20 14:46   ` sashiko-bot
2026-11-20 14:07 ` [PATCH 19/29] drm/i915/dp: Store the PCON FRL rate in the crtc state Ankit Nautiyal
2026-11-20 14:39   ` sashiko-bot
2026-11-20 14:07 ` [PATCH 20/29] drm/i915/dp: Use the FRL rate of the stream on the HDMI link Ankit Nautiyal
2026-11-20 14:43   ` sashiko-bot
2026-11-20 14:07 ` [PATCH 21/29] drm/i915/dp: Allow PCON DSC modes through the FRL bw check Ankit Nautiyal
2026-11-20 14:48   ` sashiko-bot
2026-11-20 14:07 ` [PATCH 22/29] drm/i915/dp: Enable DSC pass-through in the PCON Ankit Nautiyal
2026-11-20 14:38   ` sashiko-bot
2026-11-20 14:07 ` [PATCH 23/29] drm/i915/dp: Limit the DP link bpp for DSC pass-through to the FRL bandwidth Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 24/29] drm/i915/dp: Select DSC pass-through in the PCON for DSC 1.2a streams Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 25/29] drm/i915/dp: Allow limiting the DSC slice count for the downstream device Ankit Nautiyal
2026-11-20 14:41   ` sashiko-bot
2026-11-20 14:07 ` [PATCH 26/29] drm/i915/dp: Check the HDMI sink slice limits for DSC pass-through Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 27/29] drm/i915/dp: Pick the DSC slice count for pass-through within the HDMI limits Ankit Nautiyal
2026-11-20 14:48   ` sashiko-bot
2026-11-20 14:07 ` [PATCH 28/29] drm/i915/dp: Limit the compressed bpp for pass-through to the HDMI sink Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 29/29] drm/i915/dp: Accept DSC 1.2a pass-through modes in the PCON mode check Ankit Nautiyal
2026-11-20 14:33 ` ✗ CI.checkpatch: warning for DP-HDMI PCON DSC fixes (rev4) Patchwork
2026-11-20 14:35 ` ✓ CI.KUnit: success " Patchwork
2026-11-20 15:24 ` ✓ Xe.CI.BAT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox