[PATCH 1/2] auto-t: remove scanning wait from testConnectAutoconnect

[PATCH 1/2] auto-t: remove scanning wait from testConnectAutoconnect

[James Prestwood]

[-- Attachment #1: Type: text/plain, Size: 1035 bytes --]

In certain cases the test was reaching this point once already finished
with a scan. This caused the wait for 'scanning' to time out. At this point
in the test we don't need to wait for scanning and only need to wait for
scanning to finish. If scanning is already finished before validation we
can simply validate at that time.
---
 autotests/testConnectAutoconnect/validation.py | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/autotests/testConnectAutoconnect/validation.py b/autotests/testConnectAutoconnect/validation.py
index 43cbaf02..b1e3accc 100644
--- a/autotests/testConnectAutoconnect/validation.py
+++ b/autotests/testConnectAutoconnect/validation.py
@@ -54,9 +54,6 @@ class TestConnectAutoConnect(unittest.TestCase):
         self.assertIsNotNone(devices)
         device = devices[0]
 
-        condition = 'obj.scanning'
-        wd.wait_for_object_condition(device, condition)
-
         condition = 'not obj.scanning'
         wd.wait_for_object_condition(device, condition)
 
-- 
2.21.1

[PATCH 2/2] auto-t: remove scanning wait from testHiddenNetworks

[James Prestwood]

[-- Attachment #1: Type: text/plain, Size: 815 bytes --]

Same deal as with testKnownNetworks, the wait for scanning to stop
has been removed since scanning may not be running at this point.
---
 autotests/testHiddenNetworks/validation.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/autotests/testHiddenNetworks/validation.py b/autotests/testHiddenNetworks/validation.py
index 9c433623..551f12c7 100644
--- a/autotests/testHiddenNetworks/validation.py
+++ b/autotests/testHiddenNetworks/validation.py
@@ -50,8 +50,6 @@ class TestConnectAutoConnect(unittest.TestCase):
         device = devices[0]
 
         if autoconnect:
-            condition = 'obj.scanning'
-            wd.wait_for_object_condition(device, condition)
             condition = 'not obj.scanning'
             wd.wait_for_object_condition(device, condition)
 
-- 
2.21.1

Re: [PATCH 1/2] auto-t: remove scanning wait from testConnectAutoconnect

[Kourt, Tim A]

[-- Attachment #1: Type: text/plain, Size: 1538 bytes --]

Hi James,

On 5/6/2020 8:58 AM, James Prestwood wrote:
> In certain cases the test was reaching this point once already finished
> with a scan. This caused the wait for 'scanning' to time out. At this point
> in the test we don't need to wait for scanning and only need to wait for
> scanning to finish. If scanning is already finished before validation we
> can simply validate at that time.
> ---
>   autotests/testConnectAutoconnect/validation.py | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/autotests/testConnectAutoconnect/validation.py b/autotests/testConnectAutoconnect/validation.py
> index 43cbaf02..b1e3accc 100644
> --- a/autotests/testConnectAutoconnect/validation.py
> +++ b/autotests/testConnectAutoconnect/validation.py
> @@ -54,9 +54,6 @@ class TestConnectAutoConnect(unittest.TestCase):
>           self.assertIsNotNone(devices)
>           device = devices[0]
>   
> -        condition = 'obj.scanning'
> -        wd.wait_for_object_condition(device, condition)
> -
What if the scan has never started yet? Since iwd is started from 
Python, it looks suspicious that it goes through the scan before it hits 
the conditional wait a few lines down the script. Perhaps changing to 
wd.list_devices(1) API has introduced this issue. Would it help to 
increase the conditional wait time out so it goes into the second round 
of scans for these certain cases?

>           condition = 'not obj.scanning'
>           wd.wait_for_object_condition(device, condition)
>   
Best,
Tim

Re: [PATCH 1/2] auto-t: remove scanning wait from testConnectAutoconnect

[James Prestwood]

[-- Attachment #1: Type: text/plain, Size: 2017 bytes --]

Hi Tim,

On Wed, May 6, 2020 at 9:46 AM Kourt, Tim A <tim.a.kourt@linux.intel.com> wrote:
>
> Hi James,
>
> On 5/6/2020 8:58 AM, James Prestwood wrote:
> > In certain cases the test was reaching this point once already finished
> > with a scan. This caused the wait for 'scanning' to time out. At this point
> > in the test we don't need to wait for scanning and only need to wait for
> > scanning to finish. If scanning is already finished before validation we
> > can simply validate at that time.
> > ---
> >   autotests/testConnectAutoconnect/validation.py | 3 ---
> >   1 file changed, 3 deletions(-)
> >
> > diff --git a/autotests/testConnectAutoconnect/validation.py b/autotests/testConnectAutoconnect/validation.py
> > index 43cbaf02..b1e3accc 100644
> > --- a/autotests/testConnectAutoconnect/validation.py
> > +++ b/autotests/testConnectAutoconnect/validation.py
> > @@ -54,9 +54,6 @@ class TestConnectAutoConnect(unittest.TestCase):
> >           self.assertIsNotNone(devices)
> >           device = devices[0]
> >
> > -        condition = 'obj.scanning'
> > -        wd.wait_for_object_condition(device, condition)
> > -
> What if the scan has never started yet? Since iwd is started from
> Python, it looks suspicious that it goes through the scan before it hits
> the conditional wait a few lines down the script. Perhaps changing to
> wd.list_devices(1) API has introduced this issue. Would it help to
> increase the conditional wait time out so it goes into the second round
> of scans for these certain cases?

I can try increasing the timeout, but I think relying on periodic
scans for this autotest isn't the best way to go about it. I will try
explicitly scanning via dbus, otherwise you are just hoping that a
periodic scan was started. This timing will vary slightly between
systems which is why I think I am hitting this.

>
> >           condition = 'not obj.scanning'
> >           wd.wait_for_object_condition(device, condition)
> >
> Best,
> Tim

Re: [PATCH 1/2] auto-t: remove scanning wait from testConnectAutoconnect

[Kourt, Tim A]

[-- Attachment #1: Type: text/plain, Size: 1023 bytes --]

Hi James,

>>> -        condition = 'obj.scanning'
>>> -        wd.wait_for_object_condition(device, condition)
>>> -
>> What if the scan has never started yet? Since iwd is started from
>> Python, it looks suspicious that it goes through the scan before it hits
>> the conditional wait a few lines down the script. Perhaps changing to
>> wd.list_devices(1) API has introduced this issue. Would it help to
>> increase the conditional wait time out so it goes into the second round
>> of scans for these certain cases?
> I can try increasing the timeout, but I think relying on periodic
> scans for this autotest isn't the best way to go about it. I will try
> explicitly scanning via dbus, otherwise you are just hoping that a
> periodic scan was started. This timing will vary slightly between
> systems which is why I think I am hitting this.
The purpose of this autotest and of the one with the hidden networks is 
to exercise auto-connection without an explicit call from Dbus 
(different code paths).